[webkit-dev] no URL validation checking in KURLGoogle?
Hi, It seems that KURLGoogle is not validating url, it simply marks url as valid. I tested an invalid url http://a a/ in Chrome, it tried to open it and failed. In FireFox for this kind of url it will pop out a dialog saying The URL is not valid and cannot be loaded. Should url be validated in KURLGoogle too? Or any concerns not adding it? Thanks, Deqing ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] vertical text
Thanks for the answer, Dave. That makes perfect sense. Why is it that the graphics context is rotated but the advances supplied to Font::DrawGlyphs in the GlyphBuffer aren't? Cary On Thu, Nov 10, 2011 at 5:22 PM, David Hyatt hy...@apple.com wrote: On Nov 10, 2011, at 4:07 PM, Cary Clark wrote: TL;DR: Why is the graphics context rotated when drawing vertical text? I assume you're referring to the rotation done by InlineTextBox. The basic reason for the rotation was that it was a minimal change to the code and allowed a bunch of other drawing functions to remain unchanged. You could certainly eliminate the rotation, but you'd then have to patch all of the InlineTextBox drawing functions (underlines, selection, spell check markers, etc.) to be able to operate horizontally or vertically. dave (hy...@apple.com) ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Source/ThirdParty/ChangeLog? Really???
Bad form! X0,000 announcements have historically always been in WebCore/ChangeLog. A sad and unfortunate break in tradition just to avoid resolving the conflict to land. :( But seriously WebKit, congrats! ~Brady ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Source/ThirdParty/ChangeLog? Really???
Hi All, I didn't break the tradition, 7 was the culprit revision: http://trac.webkit.org/changeset/10 - trunk/Source/ThirdParty/ChangeLog http://trac.webkit.org/changeset/9 - absolutely wrong patch http://trac.webkit.org/changeset/8 - absolutely wrong patch http://trac.webkit.org/changeset/7 - trunk/ChangeLog http://trac.webkit.org/changeset/6 - trunk/WebCore/ChangeLog http://trac.webkit.org/changeset/5 - trunk/WebCore/ChangeLog http://trac.webkit.org/changeset/4 - trunk/WebCore/ChangeLog http://trac.webkit.org/changeset/3 - trunk/WebCore/ChangeLog http://trac.webkit.org/changeset/2 - trunk/WebCore/ChangeLog http://trac.webkit.org/changeset/1 - absolutely wrong patch Now we shouldn't be sad, but let's celebrate this great number! ;) Brady Eidson írta: Bad form! X0,000 announcements have historically always been in WebCore/ChangeLog. A sad and unfortunate break in tradition just to avoid resolving the conflict to land. :( But seriously WebKit, congrats! ~Brady ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] no URL validation checking in KURLGoogle?
On Fri, Nov 11, 2011 at 12:29 AM, Huang, Deqing deqing.hu...@intel.com wrote: Hi, It seems that KURLGoogle is not validating url, it simply marks url as valid. I tested an invalid url http://a a/ in Chrome, it tried to open it and failed. In FireFox for this kind of url it will pop out a dialog saying The URL is not valid and cannot be loaded. Should url be validated in KURLGoogle too? Or any concerns not adding it? This mailing list is not the correct place for this. If you think you have a bug, you should file one. I question why you think the problem is KURLGoogle and why you think it is not validating the URL. If you step through the code for this URL, you will find that this is not the case. Brett ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
