Re: [webkit-dev] Subpixel Layout Update
> I meant it would let us update the PNGs once instead of twice. Ah, that's a good point. We're "only" touching about 500 pixel tests so it wouldn't be too bad if we had to do it twice. Might be nice to avoid though. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Subpixel Layout Update
On Fri, Feb 10, 2012 at 6:22 PM, Levi Weintraub wrote: > On Fri, Feb 10, 2012 at 6:14 PM, Adam Barth wrote: >> >> On Fri, Feb 10, 2012 at 6:09 PM, Levi Weintraub wrote: >> > On Fri, Feb 10, 2012 at 6:03 PM, Adam Barth wrote: >> >> >> >> On Fri, Feb 10, 2012 at 5:49 PM, Levi Weintraub >> >> wrote: >> >> > WebKittens, >> >> > >> >> > We're planning to wrap up our conversion of the RenderTree to >> >> > subpixel >> >> > units >> >> > next week. We've created a the following wiki page to help explain >> >> > the >> >> > changes we are making: https://trac.webkit.org/wiki/LayoutUnit If you >> >> > work >> >> > on the rendering code, please take a look and talk to Emil and me if >> >> > you >> >> > have any questions. >> >> > >> >> > This will effect a large number of layout test expectations as well >> >> > as >> >> > some >> >> > platform interfaces. If you are working on or maintaining a port >> >> > other >> >> > than >> >> > Apple, Qt, and Chromium, please touch bases with us. >> >> >> >> We've been talking about turning on mock scroll bars for Chromium. >> >> Would it make sense to do that at the same time to minimize the number >> >> of baseline updates? >> > >> > It would allow us to make only one WebKit sheriff's life miserable >> > instead >> > of two, but the changes don't really relate in any other meaningful way. >> >> I meant it would let us update the PNGs once instead of twice. >> > Of course. We're only looking at something on the order of 500-600 layout > test expectation updates, which I believe is quite a bit smaller than the > mock scrollbar update, but we're totally interested in saving this effort. > Who should we talk to about aligning these changes? Oh, if it's only 500-600, then it's probably not worthwhile. Adam >> >> > On Fri, Oct 28, 2011 at 1:43 PM, Levi Weintraub >> >> > wrote: >> >> >> >> >> >> WebKittens, >> >> >> >> >> >> As you may know, Emil and I have been diligently working on getting >> >> >> subpixel layout up and running in WebKit. After much testing, we >> >> >> settled on a fixed point implementation instead of floats; we're >> >> >> happy >> >> >> to discuss how we arrived at this decision. We're currently in a >> >> >> state >> >> >> where we pass most of the layout tests and many (but not all) of the >> >> >> remaining failures are due to rounding differences that are >> >> >> desirable. >> >> >> >> >> >> As such, we've moved our efforts to a public branch on the >> >> >> WebKit.org >> >> >> svn server, and would love early feedback and advice. Our branch >> >> >> currently runs the following ports: Mac, Qt, Chromium-Linux, and >> >> >> Chromium-Mac. Any advice or help bringing up other platforms would >> >> >> be >> >> >> greatly appreciated. >> >> >> >> >> >> You can check our work out here: >> >> >> http://svn.webkit.org/repository/webkit/branches/subpixellayout >> >> >> (currently branched from r98654 and we'll continue to track head by >> >> >> a >> >> >> day or two) >> >> >> >> >> >> Thanks, >> >> >> Emil and Levi >> >> > >> >> > >> >> > >> >> > ___ >> >> > webkit-dev mailing list >> >> > webkit-dev@lists.webkit.org >> >> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> > >> > >> > > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Subpixel Layout Update
On Fri, Feb 10, 2012 at 6:14 PM, Adam Barth wrote: > On Fri, Feb 10, 2012 at 6:09 PM, Levi Weintraub wrote: > > On Fri, Feb 10, 2012 at 6:03 PM, Adam Barth wrote: > >> > >> On Fri, Feb 10, 2012 at 5:49 PM, Levi Weintraub > wrote: > >> > WebKittens, > >> > > >> > We're planning to wrap up our conversion of the RenderTree to subpixel > >> > units > >> > next week. We've created a the following wiki page to help explain the > >> > changes we are making: https://trac.webkit.org/wiki/LayoutUnit If you > >> > work > >> > on the rendering code, please take a look and talk to Emil and me if > you > >> > have any questions. > >> > > >> > This will effect a large number of layout test expectations as well as > >> > some > >> > platform interfaces. If you are working on or maintaining a port other > >> > than > >> > Apple, Qt, and Chromium, please touch bases with us. > >> > >> We've been talking about turning on mock scroll bars for Chromium. > >> Would it make sense to do that at the same time to minimize the number > >> of baseline updates? > > > > It would allow us to make only one WebKit sheriff's life miserable > instead > > of two, but the changes don't really relate in any other meaningful way. > > I meant it would let us update the PNGs once instead of twice. > > Of course. We're only looking at something on the order of 500-600 layout test expectation updates, which I believe is quite a bit smaller than the mock scrollbar update, but we're totally interested in saving this effort. Who should we talk to about aligning these changes? > Adam > > > >> > On Fri, Oct 28, 2011 at 1:43 PM, Levi Weintraub > >> > wrote: > >> >> > >> >> WebKittens, > >> >> > >> >> As you may know, Emil and I have been diligently working on getting > >> >> subpixel layout up and running in WebKit. After much testing, we > >> >> settled on a fixed point implementation instead of floats; we're > happy > >> >> to discuss how we arrived at this decision. We're currently in a > state > >> >> where we pass most of the layout tests and many (but not all) of the > >> >> remaining failures are due to rounding differences that are > desirable. > >> >> > >> >> As such, we've moved our efforts to a public branch on the WebKit.org > >> >> svn server, and would love early feedback and advice. Our branch > >> >> currently runs the following ports: Mac, Qt, Chromium-Linux, and > >> >> Chromium-Mac. Any advice or help bringing up other platforms would be > >> >> greatly appreciated. > >> >> > >> >> You can check our work out here: > >> >> http://svn.webkit.org/repository/webkit/branches/subpixellayout > >> >> (currently branched from r98654 and we'll continue to track head by a > >> >> day or two) > >> >> > >> >> Thanks, > >> >> Emil and Levi > >> > > >> > > >> > > >> > ___ > >> > webkit-dev mailing list > >> > webkit-dev@lists.webkit.org > >> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >> > > > > > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Subpixel Layout Update
On Fri, Feb 10, 2012 at 6:09 PM, Levi Weintraub wrote: > On Fri, Feb 10, 2012 at 6:03 PM, Adam Barth wrote: >> >> On Fri, Feb 10, 2012 at 5:49 PM, Levi Weintraub wrote: >> > WebKittens, >> > >> > We're planning to wrap up our conversion of the RenderTree to subpixel >> > units >> > next week. We've created a the following wiki page to help explain the >> > changes we are making: https://trac.webkit.org/wiki/LayoutUnit If you >> > work >> > on the rendering code, please take a look and talk to Emil and me if you >> > have any questions. >> > >> > This will effect a large number of layout test expectations as well as >> > some >> > platform interfaces. If you are working on or maintaining a port other >> > than >> > Apple, Qt, and Chromium, please touch bases with us. >> >> We've been talking about turning on mock scroll bars for Chromium. >> Would it make sense to do that at the same time to minimize the number >> of baseline updates? > > It would allow us to make only one WebKit sheriff's life miserable instead > of two, but the changes don't really relate in any other meaningful way. I meant it would let us update the PNGs once instead of twice. Adam >> > On Fri, Oct 28, 2011 at 1:43 PM, Levi Weintraub >> > wrote: >> >> >> >> WebKittens, >> >> >> >> As you may know, Emil and I have been diligently working on getting >> >> subpixel layout up and running in WebKit. After much testing, we >> >> settled on a fixed point implementation instead of floats; we're happy >> >> to discuss how we arrived at this decision. We're currently in a state >> >> where we pass most of the layout tests and many (but not all) of the >> >> remaining failures are due to rounding differences that are desirable. >> >> >> >> As such, we've moved our efforts to a public branch on the WebKit.org >> >> svn server, and would love early feedback and advice. Our branch >> >> currently runs the following ports: Mac, Qt, Chromium-Linux, and >> >> Chromium-Mac. Any advice or help bringing up other platforms would be >> >> greatly appreciated. >> >> >> >> You can check our work out here: >> >> http://svn.webkit.org/repository/webkit/branches/subpixellayout >> >> (currently branched from r98654 and we'll continue to track head by a >> >> day or two) >> >> >> >> Thanks, >> >> Emil and Levi >> > >> > >> > >> > ___ >> > webkit-dev mailing list >> > webkit-dev@lists.webkit.org >> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Subpixel Layout Update
On Fri, Feb 10, 2012 at 6:03 PM, Adam Barth wrote: > On Fri, Feb 10, 2012 at 5:49 PM, Levi Weintraub wrote: > > WebKittens, > > > > We're planning to wrap up our conversion of the RenderTree to subpixel > units > > next week. We've created a the following wiki page to help explain the > > changes we are making: https://trac.webkit.org/wiki/LayoutUnit If you > work > > on the rendering code, please take a look and talk to Emil and me if you > > have any questions. > > > > This will effect a large number of layout test expectations as well as > some > > platform interfaces. If you are working on or maintaining a port other > than > > Apple, Qt, and Chromium, please touch bases with us. > > We've been talking about turning on mock scroll bars for Chromium. > Would it make sense to do that at the same time to minimize the number > of baseline updates? > It would allow us to make only one WebKit sheriff's life miserable instead of two, but the changes don't really relate in any other meaningful way. > > Adam > > > > On Fri, Oct 28, 2011 at 1:43 PM, Levi Weintraub > wrote: > >> > >> WebKittens, > >> > >> As you may know, Emil and I have been diligently working on getting > >> subpixel layout up and running in WebKit. After much testing, we > >> settled on a fixed point implementation instead of floats; we're happy > >> to discuss how we arrived at this decision. We're currently in a state > >> where we pass most of the layout tests and many (but not all) of the > >> remaining failures are due to rounding differences that are desirable. > >> > >> As such, we've moved our efforts to a public branch on the WebKit.org > >> svn server, and would love early feedback and advice. Our branch > >> currently runs the following ports: Mac, Qt, Chromium-Linux, and > >> Chromium-Mac. Any advice or help bringing up other platforms would be > >> greatly appreciated. > >> > >> You can check our work out here: > >> http://svn.webkit.org/repository/webkit/branches/subpixellayout > >> (currently branched from r98654 and we'll continue to track head by a > >> day or two) > >> > >> Thanks, > >> Emil and Levi > > > > > > > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Subpixel Layout Update
On Fri, Feb 10, 2012 at 5:49 PM, Levi Weintraub wrote: > WebKittens, > > We're planning to wrap up our conversion of the RenderTree to subpixel units > next week. We've created a the following wiki page to help explain the > changes we are making: https://trac.webkit.org/wiki/LayoutUnit If you work > on the rendering code, please take a look and talk to Emil and me if you > have any questions. > > This will effect a large number of layout test expectations as well as some > platform interfaces. If you are working on or maintaining a port other than > Apple, Qt, and Chromium, please touch bases with us. We've been talking about turning on mock scroll bars for Chromium. Would it make sense to do that at the same time to minimize the number of baseline updates? Adam > On Fri, Oct 28, 2011 at 1:43 PM, Levi Weintraub wrote: >> >> WebKittens, >> >> As you may know, Emil and I have been diligently working on getting >> subpixel layout up and running in WebKit. After much testing, we >> settled on a fixed point implementation instead of floats; we're happy >> to discuss how we arrived at this decision. We're currently in a state >> where we pass most of the layout tests and many (but not all) of the >> remaining failures are due to rounding differences that are desirable. >> >> As such, we've moved our efforts to a public branch on the WebKit.org >> svn server, and would love early feedback and advice. Our branch >> currently runs the following ports: Mac, Qt, Chromium-Linux, and >> Chromium-Mac. Any advice or help bringing up other platforms would be >> greatly appreciated. >> >> You can check our work out here: >> http://svn.webkit.org/repository/webkit/branches/subpixellayout >> (currently branched from r98654 and we'll continue to track head by a >> day or two) >> >> Thanks, >> Emil and Levi > > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Subpixel Layout Update
WebKittens, We're planning to wrap up our conversion of the RenderTree to subpixel units next week. We've created a the following wiki page to help explain the changes we are making: https://trac.webkit.org/wiki/LayoutUnit If you work on the rendering code, please take a look and talk to Emil and me if you have any questions. This will effect a large number of layout test expectations as well as some platform interfaces. If you are working on or maintaining a port other than Apple, Qt, and Chromium, please touch bases with us. Thanks! -Emil and Levi On Fri, Oct 28, 2011 at 1:43 PM, Levi Weintraub wrote: > WebKittens, > > As you may know, Emil and I have been diligently working on getting > subpixel layout up and running in WebKit. After much testing, we > settled on a fixed point implementation instead of floats; we're happy > to discuss how we arrived at this decision. We're currently in a state > where we pass most of the layout tests and many (but not all) of the > remaining failures are due to rounding differences that are desirable. > > As such, we've moved our efforts to a public branch on the WebKit.org > svn server, and would love early feedback and advice. Our branch > currently runs the following ports: Mac, Qt, Chromium-Linux, and > Chromium-Mac. Any advice or help bringing up other platforms would be > greatly appreciated. > > You can check our work out here: > http://svn.webkit.org/repository/webkit/branches/subpixellayout > (currently branched from r98654 and we'll continue to track head by a > day or two) > > Thanks, > Emil and Levi > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] test_expectations.txt for non-chromium ports
I think at one point Adam indicated he wanted to use them for the Apple Win port, but he is still using the Skipped files since the Win port is still using ORWT on the bots. That said, I understand why you're asking this (I think), but I would prefer that we not have to support both options indefinitely into the future. I would like to merge whatever features we need from both approaches into one solution if possible (of course, we can do that after forcing ports to use only one or the other for now). The last time this was discussed at any length, people seemed to want expectations to cascade, but I never got any clear feedback on what the semantics of the cascade would be, and how that might interact with different modifiers in the test_expectations file. Since that time, I've come to believe that even the way Chromium uses expectations files is just making things harder for developers and maintainers, and so I would like to change how Chromium does things as well ... this is a long-winded way of saying most things are on the table for discussion. For example, we might want to use only Skipped files for tests that are always planned to be skipped, and test_expectations for things that are supposed to be temporary workarounds to keep the tree green until bugs can be filed and new baselines generated. Or, we might want to do something else ... -- Dirk On Fri, Feb 10, 2012 at 1:07 PM, Ojan Vafai wrote: > Do any non-chromium ports want to use test_expectations.txt instead of or in > addition to Skipped files? I think we should only allow one or the other per > port. Having both for all ports keeps causing confusion. > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] When should we turn on new features?
Hi all, In general, the decision of whether a given feature is enabled or not is made by each port. However, at last year's W3C TPAC, there were complaints from other participants about WebKit shipping half-baked implementations and breaking feature-detection. As an example, when WebKit enabled new types for form controls, we didn't initially have useful UIs. This resulted in breaking websites that relied on feature-detection to decide whether to use new types or fallback to JS-based fallback UI. Now those websites need to rely on navigator string. (I don't intend to name-call anyone or blame this instance in particular). So when is a Web-facing feature implemented in WebKit good enough to be enabled by any port? Should there be some set of criteria to be met? - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] test_expectations.txt for non-chromium ports
Do any non-chromium ports want to use test_expectations.txt instead of or in addition to Skipped files? I think we should only allow one or the other per port. Having both for all ports keeps causing confusion. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] GTK 64-bit Debug slave is offline
The buildslave is back and kicking. Thanks! Philippe On Fri, 2012-02-10 at 07:45 -0800, William Siegrist wrote: > The master has been restarted. > > -Bill > > > On Feb 10, 2012, at 3:37 AM, Philippe Normand wrote: > > > Hi! > > > > We can't start the 64-bit GTK Debug slave anymore, the error we get is: > > > > 2012-02-10 03:27:55-0800 [Broker,client] > > ReconnectingPBClientFactory.failedToGetPerspective > > 2012-02-10 03:27:55-0800 [Broker,client] Unhandled Error > > Traceback from remote host -- Traceback unavailable > > > > It seems that means we get an authentication error. Can the buildmaster > > admin please check this on their side? > > > > Thanks! > > Philippe > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > signature.asc Description: This is a digitally signed message part ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] JavaScriptCore Debugger - Non-Browser Implementation
Hi again, Does anyone have any insight here? Is this the correct place to ask? Thx, Matt On Tue, Feb 7, 2012 at 10:18 PM, Matt Veenstra wrote: > Hello, > > I am looking for a tool to help debug JavaScript code for > JavaScriptCore when NOT using a browser? I did a bit of research and > did not find anything that seems to attach and debug at a code level > and ignore the DOM. > > Is there something simple I missed? Drosera seemed to exist in the past. > > Is this the proper list for this question? > > Thanks, > Matt Veenstra > tribalmedia ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] GTK 64-bit Debug slave is offline
The master has been restarted. -Bill On Feb 10, 2012, at 3:37 AM, Philippe Normand wrote: > Hi! > > We can't start the 64-bit GTK Debug slave anymore, the error we get is: > > 2012-02-10 03:27:55-0800 [Broker,client] > ReconnectingPBClientFactory.failedToGetPerspective > 2012-02-10 03:27:55-0800 [Broker,client] Unhandled Error > Traceback from remote host -- Traceback unavailable > > It seems that means we get an authentication error. Can the buildmaster > admin please check this on their side? > > Thanks! > Philippe > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] GTK 64-bit Debug slave is offline
We had the same issue on Chromium Mac Release (Tests) bot last week. The problem is that the master thinks the bot is connected so the slave is unable to connect. - Ryosuke On Fri, Feb 10, 2012 at 3:37 AM, Philippe Normand wrote: > Hi! > > We can't start the 64-bit GTK Debug slave anymore, the error we get is: > > 2012-02-10 03:27:55-0800 [Broker,client] > ReconnectingPBClientFactory.failedToGetPerspective > 2012-02-10 03:27:55-0800 [Broker,client] Unhandled Error >Traceback from remote host -- Traceback unavailable > > It seems that means we get an authentication error. Can the buildmaster > admin please check this on their side? > > Thanks! > Philippe > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] GTK 64-bit Debug slave is offline
Hi! We can't start the 64-bit GTK Debug slave anymore, the error we get is: 2012-02-10 03:27:55-0800 [Broker,client] ReconnectingPBClientFactory.failedToGetPerspective 2012-02-10 03:27:55-0800 [Broker,client] Unhandled Error Traceback from remote host -- Traceback unavailable It seems that means we get an authentication error. Can the buildmaster admin please check this on their side? Thanks! Philippe signature.asc Description: This is a digitally signed message part ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
