Re: [webkit-dev] Blob will support ArrayBufferView instead of ArrayBuffer for Constructor Parameters
Hi, I haven't been closely following the thread on public-webapps, but looks like ArrayBuffer is back again: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob It was certainly not there in spec 20120712: http://www.w3.org/TR/2012/WD-FileAPI-20120712/#dfn-Blob But added back when it's updated to take sequence http://www.w3.org/TR/2012/WD-FileAPI-20121025/#dfn-Blob Currently it still works on WebKit but we show a deprecation warning on console. Should we remove the warning? On Tue, Jun 5, 2012 at 9:17 PM, Yin, Li li@intel.com wrote: Okay, I updated the patch, currently, it supports both of ArrayBuffer and ArrayBufferView. And I have filed a new bug about removing support of ArrayBuffer. https://bugs.webkit.org/show_bug.cgi?id=88389 Thanks for your good comments. -- Li Yin -Original Message- From: Kenneth Russell [mailto:k...@google.com] Sent: Wednesday, June 06, 2012 5:21 AM To: Takashi Toyoshima Cc: Yin, Li; webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Blob will support ArrayBufferView instead of ArrayBuffer for Constructor Parameters I think that WebKit should continue to support the old constructor for a brief period of time, but warn about its use. I've commented on the patch indicating this. Li Yin, if you implement this, please file a follow-on bug about removing support for the old constructor. The new bug should depend on the old, and it would be nice if you would own the follow-on bug. -Ken On Tue, Jun 5, 2012 at 7:33 AM, Takashi Toyoshima toyos...@google.com wrote: Hi, The same change will happen in XHR and WebSocket. I suggest to keep on holding ArrayBuffer interface in the WebSocket API spec at the thread https://www.w3.org/Bugs/Public/show_bug.cgi?id=17263 From the discussion, IE seems to continue supporting ArrayBuffer at least for WebSocket. So, I think WebKit also should continue to support it in addition to ArrayBufferView. Thanks, On Tue, Jun 5, 2012 at 9:32 PM, Yin, Li li@intel.com wrote: Hi, From FileAPI Spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob Blob should support ArrayBufferView instead of ArrayBuffer for Constructor Parameters. There is a bug in WebKit to track this issue. https://bugs.webkit.org/show_bug.cgi?id=88294 I have submitted patch to do that already. Any comments are appreciated. Thanks, Li Yin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Takashi Toyoshima Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Blob will support ArrayBufferView instead of ArrayBuffer for Constructor Parameters
+1 on removing the warning. On Wed, Mar 20, 2013 at 10:24 AM, Kinuko Yasuda kin...@chromium.org wrote: Hi, I haven't been closely following the thread on public-webapps, but looks like ArrayBuffer is back again: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob It was certainly not there in spec 20120712: http://www.w3.org/TR/2012/WD-FileAPI-20120712/#dfn-Blob But added back when it's updated to take sequence http://www.w3.org/TR/2012/WD-FileAPI-20121025/#dfn-Blob Currently it still works on WebKit but we show a deprecation warning on console. Should we remove the warning? On Tue, Jun 5, 2012 at 9:17 PM, Yin, Li li@intel.com wrote: Okay, I updated the patch, currently, it supports both of ArrayBuffer and ArrayBufferView. And I have filed a new bug about removing support of ArrayBuffer. https://bugs.webkit.org/show_bug.cgi?id=88389 Thanks for your good comments. -- Li Yin -Original Message- From: Kenneth Russell [mailto:k...@google.com] Sent: Wednesday, June 06, 2012 5:21 AM To: Takashi Toyoshima Cc: Yin, Li; webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Blob will support ArrayBufferView instead of ArrayBuffer for Constructor Parameters I think that WebKit should continue to support the old constructor for a brief period of time, but warn about its use. I've commented on the patch indicating this. Li Yin, if you implement this, please file a follow-on bug about removing support for the old constructor. The new bug should depend on the old, and it would be nice if you would own the follow-on bug. -Ken On Tue, Jun 5, 2012 at 7:33 AM, Takashi Toyoshima toyos...@google.com wrote: Hi, The same change will happen in XHR and WebSocket. I suggest to keep on holding ArrayBuffer interface in the WebSocket API spec at the thread https://www.w3.org/Bugs/Public/show_bug.cgi?id=17263 From the discussion, IE seems to continue supporting ArrayBuffer at least for WebSocket. So, I think WebKit also should continue to support it in addition to ArrayBufferView. Thanks, On Tue, Jun 5, 2012 at 9:32 PM, Yin, Li li@intel.com wrote: Hi, From FileAPI Spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob Blob should support ArrayBufferView instead of ArrayBuffer for Constructor Parameters. There is a bug in WebKit to track this issue. https://bugs.webkit.org/show_bug.cgi?id=88294 I have submitted patch to do that already. Any comments are appreciated. Thanks, Li Yin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Takashi Toyoshima Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Please don't leave entries for rebaseline in TestExpectation files
Please don't add lines to TestExpectations saying that they just need rebaselines and then leave. That would reduce the test coverage we have, and effectively disables the test. If you're adding those entires, please be sure to remove them ASAP. Better yet, don't add them unless you have to rebaseline hundreds of tests. It's not acceptable to leave those entries in TestExpectations for days. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Blob will support ArrayBufferView instead of ArrayBuffer for Constructor Parameters
Agree; remove the warning. -Ken On Wed, Mar 20, 2013 at 10:33 AM, Takashi Toyoshima toyos...@chromium.org wrote: +1 on removing the warning. On Wed, Mar 20, 2013 at 10:24 AM, Kinuko Yasuda kin...@chromium.org wrote: Hi, I haven't been closely following the thread on public-webapps, but looks like ArrayBuffer is back again: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob It was certainly not there in spec 20120712: http://www.w3.org/TR/2012/WD-FileAPI-20120712/#dfn-Blob But added back when it's updated to take sequence http://www.w3.org/TR/2012/WD-FileAPI-20121025/#dfn-Blob Currently it still works on WebKit but we show a deprecation warning on console. Should we remove the warning? On Tue, Jun 5, 2012 at 9:17 PM, Yin, Li li@intel.com wrote: Okay, I updated the patch, currently, it supports both of ArrayBuffer and ArrayBufferView. And I have filed a new bug about removing support of ArrayBuffer. https://bugs.webkit.org/show_bug.cgi?id=88389 Thanks for your good comments. -- Li Yin -Original Message- From: Kenneth Russell [mailto:k...@google.com] Sent: Wednesday, June 06, 2012 5:21 AM To: Takashi Toyoshima Cc: Yin, Li; webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Blob will support ArrayBufferView instead of ArrayBuffer for Constructor Parameters I think that WebKit should continue to support the old constructor for a brief period of time, but warn about its use. I've commented on the patch indicating this. Li Yin, if you implement this, please file a follow-on bug about removing support for the old constructor. The new bug should depend on the old, and it would be nice if you would own the follow-on bug. -Ken On Tue, Jun 5, 2012 at 7:33 AM, Takashi Toyoshima toyos...@google.com wrote: Hi, The same change will happen in XHR and WebSocket. I suggest to keep on holding ArrayBuffer interface in the WebSocket API spec at the thread https://www.w3.org/Bugs/Public/show_bug.cgi?id=17263 From the discussion, IE seems to continue supporting ArrayBuffer at least for WebSocket. So, I think WebKit also should continue to support it in addition to ArrayBufferView. Thanks, On Tue, Jun 5, 2012 at 9:32 PM, Yin, Li li@intel.com wrote: Hi, From FileAPI Spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob Blob should support ArrayBufferView instead of ArrayBuffer for Constructor Parameters. There is a bug in WebKit to track this issue. https://bugs.webkit.org/show_bug.cgi?id=88294 I have submitted patch to do that already. Any comments are appreciated. Thanks, Li Yin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Takashi Toyoshima Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Blob will support ArrayBufferView instead of ArrayBuffer for Constructor Parameters
Agree. I will remove it. -Original Message- From: Kenneth Russell [mailto:k...@google.com] Sent: Thursday, March 21, 2013 7:37 AM To: Takashi Toyoshima Cc: Kinuko Yasuda; Yin, Li; webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Blob will support ArrayBufferView instead of ArrayBuffer for Constructor Parameters Agree; remove the warning. -Ken On Wed, Mar 20, 2013 at 10:33 AM, Takashi Toyoshima toyos...@chromium.org wrote: +1 on removing the warning. On Wed, Mar 20, 2013 at 10:24 AM, Kinuko Yasuda kin...@chromium.org wrote: Hi, I haven't been closely following the thread on public-webapps, but looks like ArrayBuffer is back again: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob It was certainly not there in spec 20120712: http://www.w3.org/TR/2012/WD-FileAPI-20120712/#dfn-Blob But added back when it's updated to take sequence http://www.w3.org/TR/2012/WD-FileAPI-20121025/#dfn-Blob Currently it still works on WebKit but we show a deprecation warning on console. Should we remove the warning? On Tue, Jun 5, 2012 at 9:17 PM, Yin, Li li@intel.com wrote: Okay, I updated the patch, currently, it supports both of ArrayBuffer and ArrayBufferView. And I have filed a new bug about removing support of ArrayBuffer. https://bugs.webkit.org/show_bug.cgi?id=88389 Thanks for your good comments. -- Li Yin -Original Message- From: Kenneth Russell [mailto:k...@google.com] Sent: Wednesday, June 06, 2012 5:21 AM To: Takashi Toyoshima Cc: Yin, Li; webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Blob will support ArrayBufferView instead of ArrayBuffer for Constructor Parameters I think that WebKit should continue to support the old constructor for a brief period of time, but warn about its use. I've commented on the patch indicating this. Li Yin, if you implement this, please file a follow-on bug about removing support for the old constructor. The new bug should depend on the old, and it would be nice if you would own the follow-on bug. -Ken On Tue, Jun 5, 2012 at 7:33 AM, Takashi Toyoshima toyos...@google.com wrote: Hi, The same change will happen in XHR and WebSocket. I suggest to keep on holding ArrayBuffer interface in the WebSocket API spec at the thread https://www.w3.org/Bugs/Public/show_bug.cgi?id=17263 From the discussion, IE seems to continue supporting ArrayBuffer at least for WebSocket. So, I think WebKit also should continue to support it in addition to ArrayBufferView. Thanks, On Tue, Jun 5, 2012 at 9:32 PM, Yin, Li li@intel.com wrote: Hi, From FileAPI Spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob Blob should support ArrayBufferView instead of ArrayBuffer for Constructor Parameters. There is a bug in WebKit to track this issue. https://bugs.webkit.org/show_bug.cgi?id=88294 I have submitted patch to do that already. Any comments are appreciated. Thanks, Li Yin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Takashi Toyoshima Software Engineer, Google ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files
e.g. just in this afternoon, I was able to remove ~30 entries from platform/mac/TestExpectations. http://trac.webkit.org/changeset?new=146417%40trunk%2FLayoutTests%2Fplatform%2Fmac%2FTestExpectationsold=146296%40trunk%2FLayoutTests%2Fplatform%2Fmac%2FTestExpectations I bet there are a lot more entries in other platform/port's TestExpectations files. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files
Hi, It looks EFL port has ~ 60 test cases which say to do rebaseline in TestExpectations file. I will remove them soon. Gyuyoung. On Thu, Mar 21, 2013 at 9:24 AM, Ryosuke Niwa rn...@webkit.org wrote: e.g. just in this afternoon, I was able to remove ~30 entries from platform/mac/TestExpectations. http://trac.webkit.org/changeset?new=146417%40trunk%2FLayoutTests%2Fplatform%2Fmac%2FTestExpectationsold=146296%40trunk%2FLayoutTests%2Fplatform%2Fmac%2FTestExpectations I bet there are a lot more entries in other platform/port's TestExpectations files. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files
I remove test cases which need to do rebaseline on EFL TestExpectations file. http://trac.webkit.org/changeset/146432 The removed test cases are going to be done rebaseline. Gyuyoung. On Thu, Mar 21, 2013 at 9:59 AM, Gyuyoung Kim gyuyoung@webkit.orgwrote: Hi, It looks EFL port has ~ 60 test cases which say to do rebaseline in TestExpectations file. I will remove them soon. Gyuyoung. On Thu, Mar 21, 2013 at 9:24 AM, Ryosuke Niwa rn...@webkit.org wrote: e.g. just in this afternoon, I was able to remove ~30 entries from platform/mac/TestExpectations. http://trac.webkit.org/changeset?new=146417%40trunk%2FLayoutTests%2Fplatform%2Fmac%2FTestExpectationsold=146296%40trunk%2FLayoutTests%2Fplatform%2Fmac%2FTestExpectations I bet there are a lot more entries in other platform/port's TestExpectations files. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] APNG support
Hi What is WebKit opinion of APNG support? I recently wrote the fully functional implementation, it's not that big (the format is simple), just extends PNGImageDecoder.cpp functionality a little bit. On platforms where it's not wanted or not needed, it could be easy to deactivate the code with a single #define What do you think? I posted the patch here: https://bugs.webkit.org/show_bug.cgi?id=17022 Cheers, Max. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
