Re: [webkit-dev] Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?
Hi, On 31/07/13 22:40, Ryosuke Niwa wrote: Can't we encounter the same bug if we you multiplied the same height by 64 even if the sub pixel layout is not turned off? Or is there some parser and other component that prevents such an overflow to happen? For the specific case of max-height, if subpixel_layout is not enabled, I think the LayoutUnit class will use the REPORT_OVERFLOW macro to spot the issue during the CSS parsing stage; the LayoutUnit will call MathExtras::clampTo on the initial CSS value. Precisely, SATURATED_ARITHMETIC_LAYOUT, which requires SUBPIXEL_LAYOUT support, is intended to protect the arithmetic operations, since the initial values are already under control. But, targeting your specific question, it would b possible to define a maxh-height CSS Property value which does not overflow, hence multiplying by 64 during the layout phase will spot the same bug, so the answer to your specific question is: yes, the same bug will appear in some cases even if subpixel_layout is not enabled. Perhaps that's a interesting scenario to study, so I'll prepare some test to verify whether I manage to reproduce the issue without subpixel_layout support. Regards, -- Javi ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Windows Build Broken?
Hi ,I couldn't fix the problem with vs2005.Now I am trying to build with vs2010 and it fails too.here is the pasebin link : http://pastebin.com/W0YyGXZGKindly guide. regards RSadhu Date: Tue, 23 Jul 2013 07:21:23 +0530 Subject: Re: [webkit-dev] Windows Build Broken? From: mital.d.v...@gmail.com To: rakeshsa...@hotmail.com CC: webkit-dev@lists.webkit.org Sorry Its not exactly the same error. but Its similar error which is present in build-webkit I am trying to build using Visual Studio 2010 Express using commandline cygwin tools Thanks, Mital Vora. On Tue, Jul 23, 2013 at 7:17 AM, Mital Vora mital.d.v...@gmail.com wrote: Hi, For the WinCairo Build as well these are the exact errors coming in the buildbot Building results into: /cygdrive/c/Projects/BuildSlave/win-cairo-release/build/WebKitBuild WEBKIT_OUTPUTDIR is set to: C:\Projects\BuildSlave\win-cairo-release\build\WebKitBuild WEBKIT_LIBRARIES is set to: Use of uninitialized value in print at /cygdrive/c/Projects/BuildSlave/win-cairo-release/build/Tools/Scripts/webkitdirs.pm line 1644. http://build.webkit.org/builders/WinCairo%20Release/builds/28414/steps/compile-webkit/logs/stdio Windows and WinCairo Build from commandline seems broken.. can anybody help fixing this. Regards, Mital Vora. On Sun, Jul 21, 2013 at 9:07 PM, Rakesh Sadhu rakeshsa...@hotmail.com wrote: Hi ,I updated my webkit source code and tried to build it on windows machine , and it fails to compile, with following error Tools/Scripts/build-webkit --debug Installing WebKitSupportLibrary...The WebKitSupportLibrary has been sucessfully installed in /home/rsadhu/trunk/WebKitLibraries/win* Cannot find '/cygdrive/c/Program Files (x86)/Microsoft Visual Studio 10.0/Common7/IDE/VCExpress.exe'Please execute the file 'vcvars32.bat' from'C:\Program Files (x86)\Microsoft Visual Studio 8\VC\bin\' to setup the necessary environment variables.*Died at /home/rsadhu/trunk/Tools/Scripts/webkitdirs.pm line 1627. Any Pointers on this? ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?
Hi, On 31/07/13 22:35, Benjamin Poulain wrote: It looks to me like it is a good idea on the long term to have saturated arithmetic enabled when you have subpixel layout. I believe only GTK and EFL enable subpixel layout at the moment(?). You can probably lead the way and mature the feature and others will follow. I've been in conctact already with the GTK+ port maintainers and they seem willing to enable SATURATED_ARITHMETIC_LAYOUT by default in the future. I think besides the two ports you mentioned the Qt port enables subpixel_layout as well, so I'll try to get feedback from the port maintainers. Regards, -- Javi ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Do we need subpixel layout (Was: Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?)
Hi, On 01/08/13 00:26, Balazs Kelemen wrote: I think first we should clarify some more basic questions about subpixel layout. 1. Is it actually mantained? 2. Do any port really need it? Please correct me if these questions are too obvious or have been resolved before. Note that I am not a fan of subpixel layout, neither an enemy of it - in fact I do not know or care much about it. But from what I know it seems like this is a feature that makes an essential difference on the engine and I don't understand how can we allow such huge divergence across WebKit ports. Isn't it a maintenance burden? Doesn't it result in that test results across ports will diverge a lot more? This is an important topic, since as far as I know, most of the ports enable subpixel_layout by default. It would be good to know their future plans on this regard. IIMHO, just considering the theory, it looks like a nice feature to have. Regarding whether is maintained or not, I see recent commits to the LayoutUnit for adding subpixel support on some APIs. Anyway, as I said before, I think the idea behind the SATURATED_ARITHMETIC_LAYOUT flag to protect the LayoutUnit class against arithmetic overflows looks like something we want anyway. Regards, ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Do we need subpixel layout (Was: Should SATURATED_ARITHMETIC_LAYOUT be forced when enabling SUBPIXEL_LAYOUT ?)
As someone who worked on both subpixel layout and saturated layout arithmetic I would strongly suggest that subpixel layout isn't used without saturated arithmetic as the reduced range of supported values with subpixel layout enabled makes numeric overflows rather common. Combining the two makes sense to me but isn't my decision to make. If you have any further questions or concerns about either I'd be happy to help answer them as best I can. Regards, Emil ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Windows Build Broken?
Please review your build log. The problem is the following: fatal error C1083: Cannot open include file: 'd3dx9.h': No such file or directory” You do not have the DirectX SDK installed, as documented in Step 4 of http://www.webkit.org/building/tools.html. -Brent On Aug 1, 2013, at 1:46 AM, Rakesh Sadhu rakeshsa...@hotmail.com wrote: Hi , I couldn't fix the problem with vs2005. Now I am trying to build with vs2010 and it fails too. here is the pasebin link : http://pastebin.com/W0YyGXZG Kindly guide. regards RSadhu Date: Tue, 23 Jul 2013 07:21:23 +0530 Subject: Re: [webkit-dev] Windows Build Broken? From: mital.d.v...@gmail.com To: rakeshsa...@hotmail.com CC: webkit-dev@lists.webkit.org Sorry Its not exactly the same error. but Its similar error which is present in build-webkit I am trying to build using Visual Studio 2010 Express using commandline cygwin tools Thanks, Mital Vora. On Tue, Jul 23, 2013 at 7:17 AM, Mital Vora mital.d.v...@gmail.com wrote: Hi, For the WinCairo Build as well these are the exact errors coming in the buildbot Building results into: /cygdrive/c/Projects/BuildSlave/win-cairo-release/build/WebKitBuild WEBKIT_OUTPUTDIR is set to: C:\Projects\BuildSlave\win-cairo-release\build\WebKitBuild WEBKIT_LIBRARIES is set to: Use of uninitialized value in print at /cygdrive/c/Projects/BuildSlave/win-cairo-release/build/Tools/Scripts/webkitdirs.pm line 1644. http://build.webkit.org/builders/WinCairo%20Release/builds/28414/steps/compile-webkit/logs/stdio Windows and WinCairo Build from commandline seems broken.. can anybody help fixing this. Regards, Mital Vora. On Sun, Jul 21, 2013 at 9:07 PM, Rakesh Sadhu rakeshsa...@hotmail.com wrote: Hi , I updated my webkit source code and tried to build it on windows machine , and it fails to compile, with following error Tools/Scripts/build-webkit --debug Installing WebKitSupportLibrary... The WebKitSupportLibrary has been sucessfully installed in /home/rsadhu/trunk/WebKitLibraries/win * Cannot find '/cygdrive/c/Program Files (x86)/Microsoft Visual Studio 10.0/Common7/IDE/VCExpress.exe' Please execute the file 'vcvars32.bat' from 'C:\Program Files (x86)\Microsoft Visual Studio 8\VC\bin\' to setup the necessary environment variables. * Died at /home/rsadhu/trunk/Tools/Scripts/webkitdirs.pm line 1627. Any Pointers on this? ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
