[webkit-dev] Removing CUSTOM_PROTOCOLS compile guard?

[Pascal Jacquemart]

Hi,

I was wondering if we could remove the CUSTOM_PROTOCOLS compile guard?

I believe this is the default code path for all ports now since we moved EFL to 
use it last week
https://bugs.webkit.org/show_bug.cgi?id=128177

At least, it is mandatory for GTK and EFL builds, I don't know much about other 
ports
I checked with EWS Bot that it won't break the build 
https://bugs.webkit.org/show_bug.cgi?id=128169 (first patch)

Also CUSTOM_PROTOCOLS can be confusing against another real feature called 
CUSTOM_SCHEME_HANDLER

Do you agree?

Pascal
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] [webkit-qt] Qt 5.2.1 / 5.3.2 with JIT_ENABLED=0: Assert / Crash in LLIntData.cpp; Windows 7 x64

[Allan Sandfeld Jensen]

Hi again Andre

I am learning towards the assert being right. It appears sub-classes will be 
placed on 64bit aligned address on Win x64. This breaks some assumptions on 
how arrays are layed out. I will have to check where we make use if the 
assumptions asserted here, and see how bad it is. 

Note, we normally don't enable LLInt on Windows64. By disabling JIT though you 
have forced it to use the fallback CLoop LLInt, so that might be why we 
haven't run into it before. 

`Allan

> ___
> webkit-qt mailing list
> webkit...@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-qt

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Removing CUSTOM_PROTOCOLS compile guard?

[Darin Adler]

> On Oct 14, 2014, at 3:25 AM, Pascal Jacquemart  
> wrote:
> 
> At least, it is mandatory for GTK and EFL builds, I don't know much about 
> other ports

What file turns this on for GTK builds? I see it set in cmake/OptionsEfl.cmake 
for the EFL port, and in WebKit2/WebKit2Prefix.h for the Mac and iOS ports.

— Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Removing CUSTOM_PROTOCOLS compile guard?

[Martin Robinson]

On Tue, Oct 14, 2014 at 9:29 AM, Darin Adler  wrote:
> What file turns this on for GTK builds? I see it set in 
> cmake/OptionsEfl.cmake for the EFL port, and in WebKit2/WebKit2Prefix.h for 
> the Mac and iOS ports.

Like the Mac and iOS ports, this is enabled via
Source/WebKit2/WebKit2Prefix.h for WebKitGTK+.

--Martin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev