Re: [webkit-dev] Terminology for giving up ownership: take, release, move
> On Sep 6, 2016, at 8:20 PM, Darin Adler wrote: > >> On Sep 6, 2016, at 6:43 PM, Maciej Stachowiak wrote: >> >> RefPtr does also have regular release() though. I'm not sure if this is for >> a practical reason or just no one has fixed it yet. > > It’s still around until we finish getting rid of PassRefPtr, that’s all. > >> A wacky solution, based on your suggestion for releaseImpl, would be to have >> a nonNull method which asserts the pointer is not null and then returns a >> self reference, so you'd do move(ref.nonNull()). > > I don’t think we can do that. I don’t know how to change a RefPtr into a > Ref& in C++ even though we know the underlying object layout is identical. I didn't notice that detail. In that case I'll just say that this non-central example shouldn't be a major consideration for naming data structure remove-and-get combo operations. [It might be possible to make a way to convert a RefPtr<> to a Ref<> without refcount thrash that is closer to typical C++ conventions but I think suggestions along these lines are beyond my level of C++ knowledge. As a wild guess, perhaps a syntax like Ref x = notNull(move(refPtr)) could be made to work.] Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Importing W3C tests
Hi, I improved a bit W3C test importer lately. First, I'd like to remind people importing tests (great) without the importer (copy/paste a directory e.g.) to update LayoutTests/imported/w3c/resources/ImportExpectations. That allows me to refresh those tests when doing a full resync more quickly. Otherwise, I need to know why some tests were needlessly removed when doing a full resync, Note that, as part of the full resync, I am removing tests that are removed in WPT repository. I also made two improvements to W3C test importer. Resource files in WPT repository are not always in 'resources' folder. Test importer is generating a list of resource files in LayoutTests/imported/w3c/resources/resource-files.json All listed files there will be skipped. If you import tests without the importer, it might be better to update that file than adding Skip TestExpectations. Slow tests in WPT repository are identified with a meta element. Test importer is generating a list of slow tests in LayoutTests/tests-options.json If you import tests without the importer, it might be better to update that file than adding Slow TestExpectations. If you encounter any issue there, please let me know. Thanks y ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Terminology for giving up ownership: take, release, move
> On Sep 7, 2016, at 1:57 AM, Maciej Stachowiak wrote: > > perhaps a syntax like Ref x = notNull(move(refPtr)) could be made to work It definitely can. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
