Re: [webkit-dev] Can the WebKit logo be used for WebKit ports? (like WebKitGTK)

[Maciej Stachowiak]

> On Oct 9, 2019, at 5:43 AM, Carlos Alberto Lopez Perez  
> wrote:
> 
> On 03/10/2019 00:43, Ryosuke Niwa wrote:
>> I don't know the rules regarding the logo use but it might be a bit
>> misleading to use WebKit logo without any qualification for GTK+ port on
>> wpt.fyi.
>> 
>> I'd imagine people who visiting wpt.fyi may not realize how different GTK+
>> and Apple's WebKit ports are in terms of set of features being enabled, and
>> which sets of tests pass in each port.
>> 
>> So at minimum, we may want to add some kind of indication that it's GTK+
>> port; or that it's distinct from Apple's WebKit ports if you were to use
>> WebKit's logo somehow.
> 
> I agree that its important to not confuse users and make clearer that
> the results are for the WebKitGTK port.
> 
> On one hand the name would be WebKitGTK and the platform Linux, and on
> the other hand it would have on the smaller icon at the left a Tux (the
> classic Linux penguin).
> 
> See this example of how it would look (without logo still):
> 
> https://wpt.fyi/results/?run_id=334360001_id=336100010_id=322590004_id=332480002_id=332480003
> 
> 
> However, I agree that still can be confusing if we use the WebKit logo
> as is. So, let's discard doing that.
> 
> But, I wonder if it would be OK to use a variation of the WebKit logo
> with some clearly visible modifications like different colors.
> 
> For example: https://cloud.igalia.com/index.php/s/y4xrKBYBY8t643D
> (Its the WebKit logo but with the GTK colors)
> 
> 
> Would be using this variation of the logo OK?

In terms of legalities:

The WebKit logo (as well as the term WebKit) is trademarked by Apple, but there 
are acceptable use guidelines in the Terms of Use: 
https://webkit.org/terms-of-use/ . I am not a lawyer and cannot give legal 
advice, but my interpretation is that it’s OK to use the WebKit logo in 
association with WebKitGTK. As far as alterations, I think a WebKit logo with a 
GTK+ logo next to it (or Linux logo, whatever), or badging it in the corner, 
would be more in line with the guidelines than a recolor. i.e. putting another 
logo/mark next to the WebKit logo seems more appropriate than directly altering 
the logo.




> 
> 
> Thanks
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] JSC EWS being too optimistic

[Caio Lima]

Hi Aakash.

Thank you very much for this fix!

BR,
Caio.

Em qua, 9 de out de 2019 às 12:35, Aakash Jain  escreveu:
>
> Hi Caio,
>
> Thanks for reporting this issue.
>
> Jonathan fixed the bug you reported 
> (https://bugs.webkit.org/show_bug.cgi?id=202419). It was a regression from a 
> recent change.
>
> I verified the fix using the same patch you tested with earlier. jsc EWS is 
> now (correctly) failing on that patch 
> (https://bugs.webkit.org/show_bug.cgi?id=202140). Please let me know if you 
> notice any issue.
>
> Thanks
> Aakash
>
> On Oct 3, 2019, at 10:14 AM, Caio Lima  wrote:
>
> Hi all.
>
> I've noticed that JSC bots (jsc, jsc-armv7, jsc-mips, jsc-386) are
> marking every patch as success, even if there is a build failure (see
> https://bug-202140-attachments.webkit.org/attachment.cgi?id=379917 for
> https://bugs.webkit.org/show_bug.cgi?id=202140). Is it already in
> someone's radar?If not, could anybody take a look on this? I tried to
> investigate, but I'm lacking knowledge of EWS code base. This already
> caused some noise into JSC patches that broke ARMv7 and MIPS ports. I
> opened this bug to report it
> https://bugs.webkit.org/show_bug.cgi?id=202419.
>
> Thanks in advance,
> Caio Lima.
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] JSC EWS being too optimistic

[Aakash Jain]

Hi Caio,

Thanks for reporting this issue.

Jonathan fixed the bug you reported 
(https://bugs.webkit.org/show_bug.cgi?id=202419 
). It was a regression from a 
recent change.

I verified the fix using the same patch you tested with earlier. jsc EWS is now 
(correctly) failing on that patch 
(https://bugs.webkit.org/show_bug.cgi?id=202140 
). Please let me know if you 
notice any issue.

Thanks
Aakash

> On Oct 3, 2019, at 10:14 AM, Caio Lima  wrote:
> 
> Hi all.
> 
> I've noticed that JSC bots (jsc, jsc-armv7, jsc-mips, jsc-386) are
> marking every patch as success, even if there is a build failure (see
> https://bug-202140-attachments.webkit.org/attachment.cgi?id=379917 for
> https://bugs.webkit.org/show_bug.cgi?id=202140). Is it already in
> someone's radar?If not, could anybody take a look on this? I tried to
> investigate, but I'm lacking knowledge of EWS code base. This already
> caused some noise into JSC patches that broke ARMv7 and MIPS ports. I
> opened this bug to report it
> https://bugs.webkit.org/show_bug.cgi?id=202419.
> 
> Thanks in advance,
> Caio Lima.
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Moving to Python 3

[Philippe Normand]

Hi folks,

Now that Catalina is released, can we move on to some of the proposed
changes discussed in this thread?

Philippe

On Fri, 2019-07-12 at 12:18 -0700, Jonathan Bedard wrote:
> Hello WebKit developers,
> 
> Now that the Catalina developer seeds are available, it is official
> that the new Mac developer tools come with Python 3. As a result, we
> need to continue the ongoing discussion about migrating our Python
> 2.7 scripts to Python 3.
> 
> I propose that, over the next 9 months, we do the following:
> 
> 1. Make any no-cost Python 3 compatibility changes, in particular
> - print foo -> print(foo)
> - import .foo -> import webkitpy.foo
> 2. Convert any scripts not used in automation to Python 3 ASAP
> (scripts like bisect-builds, block-spammers, compare-results)
> 3. Make most Python 3 compatibility changes which sacrifice
> efficiency, subject to a case-by-case audit. These would be things
> like:
> - dict.iteritems() -> dict.items()
> - dict.items() -> list(dict.items())
> 4. Install Python 3 on macOS Sierra and Mojave bots
> 5. Convert peripheral automation scripts to Python 3 1-by-1 (scripts
> like clean-webkit, merge-results-json, webkit-patch)
> 6. Convert testing scripts and webkitpy to Python 3 in a single
> change
> 
> The trouble I foresee us encountering with any scheme which attempts
> a conversion which retains both Python 2.7 and Python 3 compatibility
> is code like this:
> 
> for expectation_string, expectation_enum in
> test_expectations.TestExpectations.EXPECTATIONS.iteritems():
> ...
> 
> In this code, the EXPECTATIONS dictionary is thousands of elements
> long. In Python 2.7, iteritems() gives us an iterator instead of
> creating a new list, like items() would. In Python 3, iteritems()
> doesn’t exist, but items() does, and now gives us an iterator instead
> of creating a new list. The trouble here is that, in this case,
> creating a new list will be very expensive, expensive enough that we
> might manage to impact the testing run. There isn’t really an elegant
> way around this problem if we want to support both Python 2.7 and
> Python 3, other than defining different code paths for each language.
> 
> There are other small gotchas as well. For example, ‘%’ is no longer
> a protected character, which can actually change the behavior of
> regexes. That’s why I think it’s better to just try and directly
> convert things instead of attempting to be compatible with both
> Python 2.7 and Python 3.
> 
> Jonathan
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Can the WebKit logo be used for WebKit ports? (like WebKitGTK)

[Carlos Alberto Lopez Perez]

On 03/10/2019 00:43, Ryosuke Niwa wrote:
> I don't know the rules regarding the logo use but it might be a bit
> misleading to use WebKit logo without any qualification for GTK+ port on
> wpt.fyi.
> 
> I'd imagine people who visiting wpt.fyi may not realize how different GTK+
> and Apple's WebKit ports are in terms of set of features being enabled, and
> which sets of tests pass in each port.
> 
> So at minimum, we may want to add some kind of indication that it's GTK+
> port; or that it's distinct from Apple's WebKit ports if you were to use
> WebKit's logo somehow.

I agree that its important to not confuse users and make clearer that
the results are for the WebKitGTK port.

On one hand the name would be WebKitGTK and the platform Linux, and on
the other hand it would have on the smaller icon at the left a Tux (the
classic Linux penguin).

See this example of how it would look (without logo still):

https://wpt.fyi/results/?run_id=334360001_id=336100010_id=322590004_id=332480002_id=332480003


However, I agree that still can be confusing if we use the WebKit logo
as is. So, let's discard doing that.

But, I wonder if it would be OK to use a variation of the WebKit logo
with some clearly visible modifications like different colors.

For example: https://cloud.igalia.com/index.php/s/y4xrKBYBY8t643D
(Its the WebKit logo but with the GTK colors)


Would be using this variation of the logo OK?


Thanks



signature.asc
Description: OpenPGP digital signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev