Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-02 Thread Ryosuke Niwa 
On Sat, Nov 2, 2019 at 8:25 PM Ryosuke Niwa  wrote:

>
> On Sat, Nov 2, 2019 at 7:54 PM Chris Dumez  wrote:
>
>>
>>
>> On Nov 2, 2019, at 7:38 PM, Ryosuke Niwa  wrote:
>>
>> 
>>
>> On Sat, Nov 2, 2019 at 1:23 AM Antti Koivisto  wrote:
>>
>>>
>>> On Sat, Nov 2, 2019 at 1:38 AM Ryosuke Niwa  wrote:
>>>
 On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro 
 wrote:

> On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa 
> wrote:
> > Namely, some people write a lambda as:
> > auto x = [] () { }
> >
> > with a space between [] and () while others would write it as:
> >
> > auto x = []() { }
>
> : I omit the () when there are no parameters, as in these examples.
>

 I guess that's another thing we should decide. Should we, or should we
 not have () when there are no arguments.

>>>
>>> I think this is easily settled by voting via exiting practice. We have
>>> 1287 instances of [&] { and 107 instances of [&]() { and &] () { across the
>>> whole WebKit.
>>>
>>
>> That’s good to know. Why don’t we go with the status quo then.
>>
>> In this case, we do put a space between ] or ) and {, right?
>>
>>
>> How is this the conclusion from Antti’s comment?
>>
>> Based on the discussion so far, it thought no space had a slight lead.
>>
>
> I think you’re conflating this discussion with the other email thread
> about a space between [] and ().
>
> Here, I’m talking about placing a space after [] before { as in:
> [] { }
>
> As opposed to:
> []{ }
>
> We never use the latter style whether it’s other control flow statements
> like if, while, or for, or for function definitions.
>
> - R. Niwa
>
> --
> - R. Niwa
>
-- 
- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-02 Thread Chris Dumez 


> On Nov 2, 2019, at 7:38 PM, Ryosuke Niwa  wrote:
> 
> 
> 
>> On Sat, Nov 2, 2019 at 1:23 AM Antti Koivisto  wrote:
>> 
>>> On Sat, Nov 2, 2019 at 1:38 AM Ryosuke Niwa  wrote:
 On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro  
 wrote:
>>> 
 On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa  wrote:
 > Namely, some people write a lambda as:
 > auto x = [] () { }
 > 
 > with a space between [] and () while others would write it as:
 > 
 > auto x = []() { }
 
 : I omit the () when there are no parameters, as in these examples.
>>> 
>>> I guess that's another thing we should decide. Should we, or should we not 
>>> have () when there are no arguments.
>> 
>> I think this is easily settled by voting via exiting practice. We have 1287 
>> instances of [&] { and 107 instances of [&]() { and &] () { across the whole 
>> WebKit.
> 
> That’s good to know. Why don’t we go with the status quo then.
> 
> In this case, we do put a space between ] or ) and {, right?

How is this the conclusion from Antti’s comment?

Based on the discussion so far, it thought no space had a slight lead.

> 
> I guess this is also consistent with the way people write objective C blocks: 
> https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/WorkingwithBlocks/WorkingwithBlocks.html
> 
> For JavaScript, this rule probably doesn’t apply because arrow function and 
> regular anonymous function both require ().
> 
> - R. Niwa
> 
> -- 
> - R. Niwa
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-02 Thread Ryosuke Niwa 
On Sat, Nov 2, 2019 at 1:23 AM Antti Koivisto  wrote:

>
> On Sat, Nov 2, 2019 at 1:38 AM Ryosuke Niwa  wrote:
>
>> On Fri, Nov 1, 2019 at 11:53 AM Michael Catanzaro 
>> wrote:
>>
>>> On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa  wrote:
>>> > Namely, some people write a lambda as:
>>> > auto x = [] () { }
>>> >
>>> > with a space between [] and () while others would write it as:
>>> >
>>> > auto x = []() { }
>>>
>>> : I omit the () when there are no parameters, as in these examples.
>>>
>>
>> I guess that's another thing we should decide. Should we, or should we
>> not have () when there are no arguments.
>>
>
> I think this is easily settled by voting via exiting practice. We have
> 1287 instances of [&] { and 107 instances of [&]() { and &] () { across the
> whole WebKit.
>

That’s good to know. Why don’t we go with the status quo then.

In this case, we do put a space between ] or ) and {, right?

I guess this is also consistent with the way people write objective C
blocks:
https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/WorkingwithBlocks/WorkingwithBlocks.html

For JavaScript, this rule probably doesn’t apply because arrow function and
regular anonymous function both require ().

- R. Niwa

-- 
- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Wincairo build broken

2019-11-02 Thread Aakash Jain 
Hello,

Wincairo build seems to be broken.

I filed: https://bugs.webkit.org/show_bug.cgi?id=203791 
 [wincairo] 'deref': is not a 
member of 'WebCore::ServiceWorkerContainer::jobResolvedWithRegistration::___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-02 Thread Caitlin Potter 
Not that anybody asked me, but I also prefer to not include a space between 
captures and parameter, for similar reasons.

If I’m not mistaken, v8/chromium tends to omit the space as well. If that’s 
still true and WebKit adopted that style, context switching between both 
codebases would be marginally easier for me.

> On Nov 2, 2019, at 4:19 AM, Antti Koivisto  wrote:
> 
> 
>> On Fri, Nov 1, 2019 at 10:50 PM Yusuke Suzuki  wrote:
>> 
>> > On Nov 1, 2019, at 11:53, Michael Catanzaro  wrote:
>> > 
>> > On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa  wrote:
>> >> Namely, some people write a lambda as:
>> >> auto x = [] () { }
>> >> with a space between [] and () while others would write it as:
>> >> auto x = []() { }
>> > 
>> > : I omit the () when there are no parameters, as in these examples.
>> > 
>> > No preference on spacing.
>> 
>> I like having a space here, because this rule is simpler to me.
>> If we always have a space between them, this is clear that the above case is 
>> written in `[] { }` instead of `[]{ }`.
> 
> I prefer not having the redundant space in [](). It also makes logical sense 
> to me to keep the lambda signature together. I started using lambdas with 
> space there, dropped it later, and suffered no adverse consequences.
> 
> As for existing practice, WebCore favors spaceless ]( about 2:1 but across 
> the entire WebKit it is closer to 1:1.
> 
> We always put space before { } block, I don't think that is really in 
> question here, or creating any inconsistencies.
> 
> 
>antti
>  
>> 
>> -Yusuke
>> 
>> > 
>> > 
>> > ___
>> > webkit-dev mailing list
>> > webkit-dev@lists.webkit.org
>> > https://lists.webkit.org/mailman/listinfo/webkit-dev
>> 
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-02 Thread Alexey Proskuryakov 
My preference is still e-mailing the patch author directly (possibly, also 
having an option to opt in for anyone). Bugzilla comments will always be 
irrelevant for most people CC'ed on the bug, and they are almost always 
undesirable to keep within the discussion flow.

- Alexey

> 1 нояб. 2019 г., в 18:28, Aakash Jain  написал(а):
> 
> Sounds good. I prefer the single comment when the first failure occur. That 
> way notification would be sent as soon as the first failure happens.
> 
> I'll implement that (assuming it's acceptable to everyone).
> 
> Thanks
> Aakash
> 
>> On Nov 1, 2019, at 8:35 PM, Maciej Stachowiak  wrote:
>> 
>> 
>> How about only a single comment when the first failure occurs? (Or else when 
>> all bots pass, if there is never a failure.)
>> 
>> This should help the author, the reviewer, and anyone else cc’d, without 
>> being too spammy.
>> 
>>> On Nov 1, 2019, at 5:20 PM, Aakash Jain  wrote:
>>> 
>>> Hi Ryosuke,
>>> 
>>> Many people didn't like the noise by the EWS comments, and we removed the 
>>> comments as per previous discussion in: 
>>> https://lists.webkit.org/pipermail/webkit-dev/2019-June/030683.html.
>>> 
>>> I agree with your point that having some kind of notification might be 
>>> useful.
>>> 
>>> I proposed some ideas in 
>>> https://lists.webkit.org/pipermail/webkit-dev/2019-September/030798.html, 
>>> but didn't get much feedback. If we can all agree on a solution, I can look 
>>> into implementing it.
>>> 
>>> Thanks
>>> Aakash
>>> 
 On Oct 30, 2019, at 1:03 AM, Ryosuke Niwa  wrote:
 
 These enhancements are great. There is one feature of the old EWS that I 
 really miss, which is that I used to get emails when some EWS failed. With 
 new EWS, I have to keep checking back the bugzilla to see if any of them 
 have failed periodically.
 
 Can we add a feature to opt into such an email notification? Maybe a flag 
 on a patch or JSON configuration file somewhere.
 
 - R. Niwa
 
 On Tue, Oct 29, 2019 at 4:05 PM Aakash Jain  wrote:
 Hi Everyone,
 
 I am happy to announce another EWS feature.
 
 From now on, in case of build failure, EWS will parse the errors and 
 display them in a separate 'errors' log. You wouldn't have to search 
 through thousands of lines of logs to find the error message.
 
 For example, in https://ews-build.webkit.org/#/builders/16/builds/6054, in 
 step #7 WebKit failed to compile. Complete logs (stdio) are 38,000+ lines, 
 and the error is not at the end of the logs. Normally, it requires some 
 searching through the logs to find the relevant errors. But now, there is 
 another 'errors' log, which contains just the relevant 11 lines 
 (containing error and few related lines to provide additional context).
 
 Hopefully this would save some time and efforts previously spent on 
 searching through the large logs.
 
 Note that this information is not displayed in status-bubble tool-tip, 
 since this might be lot of text to display in the tooltip. My further plan 
 is to make this information more readily available, by adding it to a 
 custom designed page which will open on clicking the status bubble 
 https://webkit.org/b/197522
 
 Please let me know if you notice any issues or have any feedback.
 
 Thanks
 Aakash
 
 Reference: https://webkit.org/b/203418
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev
 -- 
 - R. Niwa
>>> 
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>> 
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-02 Thread Antti Koivisto 
On Fri, Nov 1, 2019 at 10:50 PM Yusuke Suzuki  wrote:

>
> > On Nov 1, 2019, at 11:53, Michael Catanzaro 
> wrote:
> >
> > On Fri, Nov 1, 2019 at 11:19 am, Ryosuke Niwa  wrote:
> >> Namely, some people write a lambda as:
> >> auto x = [] () { }
> >> with a space between [] and () while others would write it as:
> >> auto x = []() { }
> >
> > : I omit the () when there are no parameters, as in these examples.
> >
> > No preference on spacing.
>
> I like having a space here, because this rule is simpler to me.
> If we always have a space between them, this is clear that the above case
> is written in `[] { }` instead of `[]{ }`.
>

I prefer not having the redundant space in [](). It also makes logical
sense to me to keep the lambda signature together. I started using lambdas
with space there, dropped it later, and suffered no adverse consequences.

As for existing practice, WebCore favors spaceless ]( about 2:1 but across
the entire WebKit it is closer to 1:1.

We always put space before { } block, I don't think that is really in
question here, or creating any inconsistencies.


   antti


>
> -Yusuke
>
> >
> >
> > ___
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org
> > https://lists.webkit.org/mailman/listinfo/webkit-dev
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev