Re: [webkit-dev] webkit-patch land behavior change

2022-04-27 Thread Manuel Rego Casasnovas via webkit-dev


On 26/04/2022 21:58, Jonathan Bedard via webkit-dev wrote:
> As we move closer to transitioning away from Subversion, I’ve change 
> ‘webkit-patch land’ to use commit-queue instead of directly committing a 
> local change from a contributor’s machine 
> (https://github.com/WebKit/WebKit/pull/392). ‘git-webkit land-unsafe’ will 
> allow contributors to directly land to Subversion for the time being, 
> although after we transition to GitHub, will also use commit-queue and prefix 
> “fast-cq” to uploaded patches to bypass building and testing.

If I remember correctly when you're accepted as committer you have to do
a first manual commit adding you to the contributors.json file; and I
guess people are using "webkit-patch land" for that (see example [1]).

Would the new contributors be able to land that first commit with the
commit-queue behavior?

Cheers,
  Rego

[1] https://bugs.webkit.org/show_bug.cgi?id=237634
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] New EWS queue: Stress Test EWS

2021-04-28 Thread Manuel Rego Casasnovas via webkit-dev
Hi,

The stress test EWS has some issue when dealing with testharness.js tests.

Every now and then it thinks it's a different type of test and it dumps
the layout tree, and it fails as the actual result has nothing to do
with a layout tree dump.

Actually it dumps an empty layout tree:
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600
   RenderBlock {HTML} at (0,0) size 800x600
 RenderBody {BODY} at (8,8) size 784x584

Last example I've seen:
https://ews-build.webkit.org/#/builders/62/builds/1903

I guess there might be some timing issue or something like that, as it
looks like it doesn't even load the test properly before comparing the
results.

Cheers,
  Rego
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev