Re: [webkit-dev] Fwd: [GTK]Scroll deficiency

2009-06-02 Thread Xiong
Hi,
I am happy to hear that you solve the issue.

I am also sorry to say i can not search the bug
report, and never submit the patch with my sloth.

-Xiong

2009/6/2 Srinivas Rao M Hamse msrini...@gmail.com

 Hi Xiong,

 My platform is WebKiton gtk+directfb. I am noticing that the issue is still
 present in the current Webkit nightly R-44111 build. I saw your sugested
 patch :

   In function ChromeClient::scroll()

 //   gdk_window_move_region(window, moveRegion, delta.width(),
 delta.height());
 //   gdk_region_offset(moveRegion, delta.width(), delta.height());
   gdk_window_move_region(window, moveRegion, moveRect.width,
 moveRect.height);
   gdk_region_offset(moveRegion, moveRect.width, moveRect.height);

 After applying it, I am not finding the scroll deficiency issue.
 I wish to know if this fix is working, why is it not landed yet. What is
 the plan for this bug.
 What is the bug number for Gtk+Directfb platform.

 Thanks and regards,
 Srinivas Rao.M http://msrinirao.blogspot.com





 On Wed, Apr 22, 2009 at 8:04 AM, Xiong browse...@gmail.com wrote:



 -- Forwarded message --
 From: Xiong browse...@gmail.com
 Date: Wed, Apr 22, 2009 at 9:42 AM
 Subject: Re: [webkit-dev] [GTK]Scroll deficiency
 To: Frank Thomsen f...@trifork.com
 Cc: Brent Fulgham bfulg...@gmail.com


 Hi Frank

 I am working on gtk+directfb and Brent working on Window+cairo, and
 you ?

 As you see, Brent and i have two separate bugs, because the
 workarounds he described
 do not help me.

 For now, i have resolved the problem in my platform.

 The reason why the screen display confusion is that GDK do not refresh
 the
 overlapping region when scrolling.

 So, change the codes as following:

 In function ChromeClient::scroll()

 //   gdk_window_move_region(window, moveRegion, delta.width(),
 delta.height());
 //   gdk_region_offset(moveRegion, delta.width(), delta.height());
   gdk_window_move_region(window, moveRegion, moveRect.width,
 moveRect.height);
   gdk_region_offset(moveRegion, moveRect.width, moveRect.height);

 After do that, the problem was gone, at least in my
 platform(Gtk+directfb).

 Good luck.

 -xiong

 2009/4/17 Frank Thomsen f...@trifork.com

 Hi guys

 Yesterday I wrote that I had solved the problem - at least on my machine.
 Well, I was wrong. Apparently the redraw-problem only exists in
 release-mode.
 Could you please tell me what you have done to circumvent this problem?
 You have talked about both commenting out code and doing something with the
 ... background..? Whatever it is I cannot find it in the mailing list, so I
 would really appreciate if you could enlighten me. And do you know if this
 has been reported as a bug? Can't seem to find that either...

 Thanks in advance!
 Frank

 -Original Message-
 From: webkit-dev-boun...@lists.webkit.org [mailto:
 webkit-dev-boun...@lists.webkit.org] On Behalf Of Brent Fulgham
 Sent: 31. marts 2009 01:04
 To: xiong
 Cc: webkit-dev@lists.webkit.org
 Subject: Re: [webkit-dev] [GTK]Scroll deficiency

 Hi Xiong,

 Thanks for trying these suggestions.

 On Sun, Mar 29, 2009 at 8:24 PM, xiong browse...@gmail.com wrote:
  Brent,
 
  In my platform, all the hack as you metioned are valueless.
 
  Bad news to me.
 
  Now, i only have a clue on cario for the scroll problem.

 I think we may have two separate (but perhaps related) bugs, because
 the workarounds I described do not help your problem.  Furthermore,
 the change you suggested (comment out the if (contentChanged) test
 in ChromeClient::repaint ()) does not resolve my problem, while it
 does fix yours.

 Thanks,

 -Brent
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev




 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev




 --
 Srinivas Rao M  Hamse


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Fwd: [GTK]Scroll deficiency

2009-06-02 Thread Holger Freyther
On Tuesday 02 June 2009 09:41:38 Srinivas Rao M Hamse wrote:

 I wish to know if this fix is working, why is it not landed yet. What is
 the plan for this bug.
 What is the bug number for Gtk+Directfb platform.

Please see http://webkit.org/coding/contributing.html and 
http://webkit.org/quality/reporting.html. From what I know no bug report has 
been filed, and no patch has been posted for review.

If you experience an issue, please file a bug report, if you have a patch, 
please see the contributing guidelines and post a patch, I'm happy to review 
it then.

z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev