Re: [webkit-dev] Abandoned Tests
On Jan 22, 2015, at 14:02, Benjamin Poulain benja...@webkit.org wrote: On 1/21/15 8:48 PM, Brent Fulgham wrote: I’ve been reviewing the various Windows layout tests, and have run across a few tests that seem to be leftovers from the Chromium project. I think all ports currently skip these tests: 1. fast/dom/title-directionality-removeChild.html 2. fast/dom/title-directionality.html They come from http://trac.webkit.org/changeset/84199 That's very much useless. The test was for chromium public API. Let's remove! 3. fast/events/drag-image-filename.html Looks useful. Probably worth fixing if possible. 4. fast/autoresize That's from https://bugs.webkit.org/show_bug.cgi?id=73631 Let's remove. [from the right address so may be it will go to the list] No, I think we should fix these (or reimplement them). We use the FrameView autosizing code! And testing it would be awesome. 5. fast/overflow/scrollbar-restored-and-then-locked.html Useless too. If no one is using these tests, or plans to, I would like to remove them and the disconnected bits of code in DRT/WKTR that were originally meant to drive this code. If I don’t hear anything by this time next week, I’ll remove the code. Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Abandoned Tests
Oh! Sorry. All of these tests fail. They fail because none of the ports actually implement the features they test: 1. fast/dom/title-directionalty and fast/dom/title-directionality-removeChild.html: These test that title supports a ‘dir’ property. We don’t, so they all fail. 2. fast/events/drag-image-filename.html: These expect DRT/WKTR to support ‘dumpFilenameBeingDragged’, which might be a useful debugging method. 3. fast/autoresize: These expect the system to support something called “enableAutoResizeMode(x, y, width, height)”. I’m not sure exactly what it’s supposed to do. 4. fast/overflow/scrollbar-restored-and-then-locked.html These expect DRT/WKTR to support “setScrollbarPolicy”, which seems to allow you to force a scrollbar (horizontal or vertical) to be on or off. Perhaps this would be a useful thing to have for testing. Thanks, -Brent On Jan 22, 2015, at 6:41 AM, Myles C. Maxfield mmaxfi...@apple.com wrote: That's what I mean. What happens when we actually run them? On Jan 21, 2015, at 9:29 PM, Brent Fulgham bfulg...@apple.com wrote: Hi Myles, These tests don’t fail — they are all skipped on mac, win, gtk, and efl. -Brent On Jan 21, 2015, at 9:24 PM, Myles C. Maxfield mmaxfi...@apple.com wrote: On which platforms do they fail? —Myles On Jan 21, 2015, at 8:48 PM, Brent Fulgham bfulg...@apple.com wrote: I’ve been reviewing the various Windows layout tests, and have run across a few tests that seem to be leftovers from the Chromium project. I think all ports currently skip these tests: 1. fast/dom/title-directionality-removeChild.html 2. fast/dom/title-directionality.html 3. fast/events/drag-image-filename.html 4. fast/autoresize 5. fast/overflow/scrollbar-restored-and-then-locked.html If no one is using these tests, or plans to, I would like to remove them and the disconnected bits of code in DRT/WKTR that were originally meant to drive this code. If I don’t hear anything by this time next week, I’ll remove the code. Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Abandoned Tests
On which platforms do they fail? —Myles On Jan 21, 2015, at 8:48 PM, Brent Fulgham bfulg...@apple.com wrote: I’ve been reviewing the various Windows layout tests, and have run across a few tests that seem to be leftovers from the Chromium project. I think all ports currently skip these tests: 1. fast/dom/title-directionality-removeChild.html 2. fast/dom/title-directionality.html 3. fast/events/drag-image-filename.html 4. fast/autoresize 5. fast/overflow/scrollbar-restored-and-then-locked.html If no one is using these tests, or plans to, I would like to remove them and the disconnected bits of code in DRT/WKTR that were originally meant to drive this code. If I don’t hear anything by this time next week, I’ll remove the code. Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Abandoned Tests
I’ve been reviewing the various Windows layout tests, and have run across a few tests that seem to be leftovers from the Chromium project. I think all ports currently skip these tests: 1. fast/dom/title-directionality-removeChild.html 2. fast/dom/title-directionality.html 3. fast/events/drag-image-filename.html 4. fast/autoresize 5. fast/overflow/scrollbar-restored-and-then-locked.html If no one is using these tests, or plans to, I would like to remove them and the disconnected bits of code in DRT/WKTR that were originally meant to drive this code. If I don’t hear anything by this time next week, I’ll remove the code. Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Abandoned Tests
Hi Myles, These tests don’t fail — they are all skipped on mac, win, gtk, and efl. -Brent On Jan 21, 2015, at 9:24 PM, Myles C. Maxfield mmaxfi...@apple.com wrote: On which platforms do they fail? —Myles On Jan 21, 2015, at 8:48 PM, Brent Fulgham bfulg...@apple.com wrote: I’ve been reviewing the various Windows layout tests, and have run across a few tests that seem to be leftovers from the Chromium project. I think all ports currently skip these tests: 1. fast/dom/title-directionality-removeChild.html 2. fast/dom/title-directionality.html 3. fast/events/drag-image-filename.html 4. fast/autoresize 5. fast/overflow/scrollbar-restored-and-then-locked.html If no one is using these tests, or plans to, I would like to remove them and the disconnected bits of code in DRT/WKTR that were originally meant to drive this code. If I don’t hear anything by this time next week, I’ll remove the code. Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
