[webkit-dev] Adding "__FILE__" and "__LINE__" to CRASH() macro

2013-04-12 Thread Arunprasad Rajkumar 
(Hope this is the proper mailing list to ask, Sorry in-case of not)

Hello Folks,

In embedded platforms(mostly debugger is missing) it very difficult(for us)
to debug the issues without proper prints in CRASH macro. Though it has
"WTFReportBacktrace();" due to some constraints we are not getting proper
call stack information(debug build with -g is costlier for us) .

So we are thinking to extend the functionality of WTFInvokeCrashHook by
passing __FILE__ & __LINE__ and printing it. Any suggestion?

If you all agreed then I will create bug and submit a patch.

Thanks & BR

-- 
*Arunprasad Rajkumar*
http://in.linkedin.com/in/ararunprasad
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Adding "__FILE__" and "__LINE__" to CRASH() macro

2013-04-12 Thread Darin Adler 
Is this for debug builds or for production builds?

If it is for debug builds, then adding file and line seems fine; we should do 
it in a way that shares code with assertion macros.

If it is for production builds, then how do you debug other crashes?

-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Adding "__FILE__" and "__LINE__" to CRASH() macro

2013-04-12 Thread Arunprasad Rajkumar 
Hi Darin,

>>Is this for debug builds or for production builds?
It is for production build.

>>If it is for debug builds, then adding file and line seems fine; we
should do it in a way that shares code with assertion macros.
So in-case of calling CRASH from ASSERT then it shouldn't print __FILE__
and __LINE__ right(because ASSERT prints all these)?

>>If it is for production builds, then how do you debug other crashes?
printf :(



On 12 April 2013 20:17, Darin Adler  wrote:

> Is this for debug builds or for production builds?
>
> If it is for debug builds, then adding file and line seems fine; we should
> do it in a way that shares code with assertion macros.
>
> If it is for production builds, then how do you debug other crashes?
>
> -- Darin
>



-- 
*Arunprasad Rajkumar*
http://in.linkedin.com/in/ararunprasad
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Adding "__FILE__" and "__LINE__" to CRASH() macro

2013-04-16 Thread Arunprasad Rajkumar 
Hi Darin,

Any other concerns? May I file a bug & provide the patch?

BR


On 15 April 2013 16:41, Arunprasad Rajkumar  wrote:

>
>
> Forwarded conversation
> Subject: Adding "__FILE__" and "__LINE__" to CRASH() macro
> 
>
> From: *Arunprasad Rajkumar* 
> Date: 12 April 2013 15:29
> To: "webkit-dev@lists.webkit.org" 
> Cc: arunpras...@nds.com
>
>
> (Hope this is the proper mailing list to ask, Sorry in-case of not)
>
> Hello Folks,
>
> In embedded platforms(mostly debugger is missing) it very difficult(for
> us) to debug the issues without proper prints in CRASH macro. Though it has
> "WTFReportBacktrace();" due to some constraints we are not getting proper
> call stack information(debug build with -g is costlier for us) .
>
> So we are thinking to extend the functionality of WTFInvokeCrashHook by
> passing __FILE__ & __LINE__ and printing it. Any suggestion?
>
> If you all agreed then I will create bug and submit a patch.
>
> Thanks & BR
>
> --
> *Arunprasad Rajkumar*
> http://in.linkedin.com/in/ararunprasad
>
> --
> From: *Darin Adler* 
> Date: 12 April 2013 20:17
> To: Arunprasad Rajkumar , arunpras...@nds.com
> Cc: WebKit Development 
>
>
> Is this for debug builds or for production builds?
>
> If it is for debug builds, then adding file and line seems fine; we should
> do it in a way that shares code with assertion macros.
>
> If it is for production builds, then how do you debug other crashes?
>
> -- Darin
>
> --
> From: *Arunprasad Rajkumar* 
> Date: 13 April 2013 11:36
> To: Darin Adler 
> Cc: arunpras...@nds.com, WebKit Development 
>
>
> Hi Darin,
>
> >>Is this for debug builds or for production builds?
>  It is for production build.
>
>
> >>If it is for debug builds, then adding file and line seems fine; we
> should do it in a way that shares code with assertion macros.
>  So in-case of calling CRASH from ASSERT then it shouldn't print __FILE__
> and __LINE__ right(because ASSERT prints all these)?
>
> >>If it is for production builds, then how do you debug other crashes?
> printf :(
>
> --
> *Arunprasad Rajkumar*
> http://in.linkedin.com/in/ararunprasad
>
>
>
>
> --
> *Arunprasad Rajkumar*
> http://in.linkedin.com/in/ararunprasad
>



-- 
*Arunprasad Rajkumar*
http://in.linkedin.com/in/ararunprasad
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Adding "__FILE__" and "__LINE__" to CRASH() macro

2013-04-16 Thread Balazs Kelemen 

On 04/16/2013 10:27 AM, Arunprasad Rajkumar wrote:

Hi Darin,

Any other concerns? May I file a bug & provide the patch?

BR


For me this change doesn't seems to be too big or controversial, so I 
would say let's go for it ;)





On 15 April 2013 16:41, Arunprasad Rajkumar > wrote:




Forwarded conversation
Subject: *Adding "__FILE__" and "__LINE__" to CRASH() macro*


From: *Arunprasad Rajkumar* mailto:ararunpra...@gmail.com>>
Date: 12 April 2013 15:29
To: "webkit-dev@lists.webkit.org
" mailto:webkit-dev@lists.webkit.org>>
Cc: arunpras...@nds.com 


(Hope this is the proper mailing list to ask, Sorry in-case of not)

Hello Folks,

In embedded platforms(mostly debugger is missing) it very
difficult(for us) to debug the issues without proper prints in
CRASH macro. Though it has "WTFReportBacktrace();" due to some
constraints we are not getting proper call stack
information(debug build with -g is costlier for us) .

So we are thinking to extend the functionality
of WTFInvokeCrashHook by passing __FILE__ & __LINE__ and printing
it. Any suggestion?

If you all agreed then I will create bug and submit a patch.

Thanks & BR

-- 
*Arunprasad Rajkumar*

http://in.linkedin.com/in/ararunprasad

--
From: *Darin Adler* mailto:da...@apple.com>>
Date: 12 April 2013 20:17
To: Arunprasad Rajkumar mailto:ararunpra...@gmail.com>>, arunpras...@nds.com

Cc: WebKit Development mailto:webkit-dev@lists.webkit.org>>


Is this for debug builds or for production builds?

If it is for debug builds, then adding file and line seems fine;
we should do it in a way that shares code with assertion macros.

If it is for production builds, then how do you debug other crashes?

-- Darin

--
From: *Arunprasad Rajkumar* mailto:ararunpra...@gmail.com>>
Date: 13 April 2013 11:36
To: Darin Adler mailto:da...@apple.com>>
Cc: arunpras...@nds.com , WebKit
Development mailto:webkit-dev@lists.webkit.org>>


Hi Darin,

>>Is this for debug builds or for production builds?
It is for production build.


>>If it is for debug builds, then adding file and line seems fine; we
should do it in a way that shares code with assertion macros.
So in-case of calling CRASH from ASSERT then it shouldn't print
__FILE__ and __LINE__ right(because ASSERT prints all these)?

>>If it is for production builds, then how do you debug other crashes?
printf :(

-- 
*Arunprasad Rajkumar*

http://in.linkedin.com/in/ararunprasad




-- 
*Arunprasad Rajkumar*

http://in.linkedin.com/in/ararunprasad




--
*Arunprasad Rajkumar*
http://in.linkedin.com/in/ararunprasad


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Adding "__FILE__" and "__LINE__" to CRASH() macro

2013-04-16 Thread Arunprasad Rajkumar 
Hi Balazs,

>>For me this change doesn't seems to be too big or controversial, so I
would say let's go for it ;)

Thank u, I will submit a patch soon :)

BR


On 16 April 2013 14:31, Balazs Kelemen  wrote:

>  On 04/16/2013 10:27 AM, Arunprasad Rajkumar wrote:
>
> Hi Darin,
>
>  Any other concerns? May I file a bug & provide the patch?
>
>  BR
>
>
> For me this change doesn't seems to be too big or controversial, so I
> would say let's go for it ;)
>
>
>
> On 15 April 2013 16:41, Arunprasad Rajkumar wrote:
>
>>
>>
>> Forwarded conversation
>> Subject: Adding "__FILE__" and "__LINE__" to CRASH() macro
>> 
>>
>> From: *Arunprasad Rajkumar* 
>> Date: 12 April 2013 15:29
>> To: "webkit-dev@lists.webkit.org" 
>> Cc: arunpras...@nds.com
>>
>>
>>   (Hope this is the proper mailing list to ask, Sorry in-case of not)
>>
>>  Hello Folks,
>>
>>  In embedded platforms(mostly debugger is missing) it very difficult(for
>> us) to debug the issues without proper prints in CRASH macro. Though it has
>> "WTFReportBacktrace();" due to some constraints we are not getting proper
>> call stack information(debug build with -g is costlier for us) .
>>
>>  So we are thinking to extend the functionality of WTFInvokeCrashHook by
>> passing __FILE__ & __LINE__ and printing it. Any suggestion?
>>
>>  If you all agreed then I will create bug and submit a patch.
>>
>>   Thanks & BR
>>
>>  --
>> *Arunprasad Rajkumar*
>> http://in.linkedin.com/in/ararunprasad
>>
>> --
>> From: *Darin Adler* 
>> Date: 12 April 2013 20:17
>> To: Arunprasad Rajkumar , arunpras...@nds.com
>> Cc: WebKit Development 
>>
>>
>> Is this for debug builds or for production builds?
>>
>> If it is for debug builds, then adding file and line seems fine; we
>> should do it in a way that shares code with assertion macros.
>>
>> If it is for production builds, then how do you debug other crashes?
>>
>> -- Darin
>>
>>  --
>> From: *Arunprasad Rajkumar* 
>> Date: 13 April 2013 11:36
>> To: Darin Adler 
>> Cc: arunpras...@nds.com, WebKit Development 
>>
>>
>>  Hi Darin,
>>
>>  >>Is this for debug builds or for production builds?
>>  It is for production build.
>>
>>
>> >>If it is for debug builds, then adding file and line seems fine; we
>> should do it in a way that shares code with assertion macros.
>>  So in-case of calling CRASH from ASSERT then it shouldn't print __FILE__
>> and __LINE__ right(because ASSERT prints all these)?
>>
>> >>If it is for production builds, then how do you debug other crashes?
>>  printf :(
>>
>>--
>> *Arunprasad Rajkumar*
>> http://in.linkedin.com/in/ararunprasad
>>
>>
>>
>>
>>  --
>> *Arunprasad Rajkumar*
>> http://in.linkedin.com/in/ararunprasad
>>
>
>
>
>  --
> *Arunprasad Rajkumar*
> http://in.linkedin.com/in/ararunprasad
>
>
> ___
> webkit-dev mailing 
> listwebkit-dev@lists.webkit.orghttps://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>


-- 
*Arunprasad Rajkumar*
http://in.linkedin.com/in/ararunprasad
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev