Re: [webkit-dev] Does anyone know why http/tests/appcache/fallback.html is failing?

2009-06-03 Thread Adam Barth
I'm sorry.  This was my fault.  I landed this patch, but I didn't
think the patch caused the test failure because I mistaken believed
the patch only added a new test.  I didn't realize the patch modified
a PHP file shared with this test.  In the future, I'll be more apt to
revert patches to try to fix redness.

Apologies,
Adam


2009/6/2 David Levin :
> Based on this: http://build.webkit.org/waterfall?last_time=1243932987
> It looks like http://trac.webkit.org/changeset/44350 caused the test to fail.
>
> On Tue, Jun 2, 2009 at 10:39 PM, Darin Adler  wrote:
>>
>> This test is failing on all the Mac buildbots.
>>
>> --- layout-test-results/http/tests/appcache/fallback-expected.txt       
>> 2009-06-02 20:27:35.0 -0700
>> +++ layout-test-results/http/tests/appcache/fallback-actual.txt 2009-06-02 
>> 20:27:35.0 -0700
>> @@ -2,5 +2,6 @@
>>
>>  Should say SUCCESS:
>>
>> -SUCCESS
>> +FAIL: Loading an URL from fallback namespace when network is disabled 
>> returned unexpected response
>> +FAILURE
>>
>> Does anyone know why? Can we roll out the change that caused this to start 
>> failing? Or fix it?
>>
>>    -- Darin
>>
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Does anyone know why http/tests/appcache/fallback.html is failing?

2009-06-02 Thread David Levin
Based on this: http://build.webkit.org/waterfall?last_time=1243932987
It looks like http://trac.webkit.org/changeset/44350 caused the test to
fail.


On Tue, Jun 2, 2009 at 10:39 PM, Darin Adler  wrote:

> This test is failing on all the Mac buildbots.
>
> --- layout-test-results/http/tests/appcache/fallback-expected.txt
> 2009-06-02 20:27:35.0 -0700
> +++ layout-test-results/http/tests/appcache/fallback-actual.txt 2009-06-02
> 20:27:35.0 -0700
> @@ -2,5 +2,6 @@
>
>  Should say SUCCESS:
>
> -SUCCESS
> +FAIL: Loading an URL from fallback namespace when network is disabled
> returned unexpected response
> +FAILURE
>
> Does anyone know why? Can we roll out the change that caused this to start
> failing? Or fix it?
>
>-- Darin
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Does anyone know why http/tests/appcache/fallback.html is failing?

2009-06-02 Thread Darin Adler

This test is failing on all the Mac buildbots.

--- layout-test-results/http/tests/appcache/fallback-expected.txt	 
2009-06-02 20:27:35.0 -0700
+++ layout-test-results/http/tests/appcache/fallback-actual.txt	 
2009-06-02 20:27:35.0 -0700

@@ -2,5 +2,6 @@

 Should say SUCCESS:

-SUCCESS
+FAIL: Loading an URL from fallback namespace when network is disabled  
returned unexpected response

+FAILURE

Does anyone know why? Can we roll out the change that caused this to  
start failing? Or fix it?


-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev