Re: [webkit-dev] Modern image formats for WebKit

[ChangSeok Oh]

> I am discussing the code in 1). It seems to me that an image decoder itself 
> should come from an external library, rather than be compiled directly from 
> WebKit sources.
Exactly.

> Assuming that we are linking with external decoding libraries, I do not have 
> any strong opinion as to which image decoding libraries that we build 
> scaffolding in order to link with.
O.K Thanks for making clear. =)

ChangSeok

> On Mar 22, 2015, at 12:46 AM, Myles C. Maxfield  wrote:
> 
> Sorry, I think we are misunderstanding each other. Let me try to be more 
> explicit:
> 
> There are two conceptual pieces that are required to support image formats:
> 1) the image decoder itself
> 2) scaffolding around the API of a decoder to correctly hook it up to the 
> rest of WebKit.
> 
> First of all, the code in 2) is required no matter what.
> 
> I am discussing the code in 1). It seems to me that an image decoder itself 
> should come from an external library, rather than be compiled directly from 
> WebKit sources.
> 
> Assuming that we are linking with external decoding libraries, I do not have 
> any strong opinion as to which image decoding libraries that we build 
> scaffolding in order to link with.
> 
> -Myles
> 
> On Mar 20, 2015, at 6:16 PM, ChangSeok Oh  > wrote:
> 
>>> So this is a really a question for people working on other active ports 
>>> like the EFL and GTK ones. Are there other libraries that you could use for 
>>> image decoding, or do you still want to keep and maintain a WebKit copy of 
>>> these image decoders?
>> 
>> Maybe the latter one. I’m not sure what you meant other libraries here if 
>> they are not libwebp nor libjxr. 
>> I found webp has been supported by gtk & elf ports already. At least 
>> WebPImageDecoder.cpp is a build target for those ports. JXR support would be 
>> a same shape with webp support, i. e adding a glue layer 
>> JPEGXRImageDecoder.cpp/h and linking libjxr.so.  
>> 
>> ChangSeok
>> 
>>> On Mar 21, 2015, at 6:39 AM, Darin Adler >> > wrote:
>>> 
>>> We should consider whether to keep the image format decoders in the WebKit 
>>> tree or not.
>>> 
>>> Dave Hyatt originally created this when we first were planning the Apple 
>>> Windows port of WebKit, but in the end we chose to not use them for the 
>>> Windows port. They aren’t used in the Windows port nor in the Mac or iOS 
>>> ports; for all of those we use a separate image decoding library.
>>> 
>>> So this is a really a question for people working on other active ports 
>>> like the EFL and GTK ones. Are there other libraries that you could use for 
>>> image decoding, or do you still want to keep and maintain a WebKit copy of 
>>> these image decoders?
>>> 
>>> — Darin
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org 
>>> https://lists.webkit.org/mailman/listinfo/webkit-dev 
>>> 
>> 
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org 
>> https://lists.webkit.org/mailman/listinfo/webkit-dev 
>> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Modern image formats for WebKit

[Myles C. Maxfield]

Sorry, I think we are misunderstanding each other. Let me try to be more 
explicit:

There are two conceptual pieces that are required to support image formats:
1) the image decoder itself
2) scaffolding around the API of a decoder to correctly hook it up to the rest 
of WebKit.

First of all, the code in 2) is required no matter what.

I am discussing the code in 1). It seems to me that an image decoder itself 
should come from an external library, rather than be compiled directly from 
WebKit sources.

Assuming that we are linking with external decoding libraries, I do not have 
any strong opinion as to which image decoding libraries that we build 
scaffolding in order to link with.

-Myles

> On Mar 20, 2015, at 6:16 PM, ChangSeok Oh  wrote:
> 
>> So this is a really a question for people working on other active ports like 
>> the EFL and GTK ones. Are there other libraries that you could use for image 
>> decoding, or do you still want to keep and maintain a WebKit copy of these 
>> image decoders?
> 
> Maybe the latter one. I’m not sure what you meant other libraries here if 
> they are not libwebp nor libjxr. 
> I found webp has been supported by gtk & elf ports already. At least 
> WebPImageDecoder.cpp is a build target for those ports. JXR support would be 
> a same shape with webp support, i. e adding a glue layer 
> JPEGXRImageDecoder.cpp/h and linking libjxr.so.  
> 
> ChangSeok
> 
>> On Mar 21, 2015, at 6:39 AM, Darin Adler  wrote:
>> 
>> We should consider whether to keep the image format decoders in the WebKit 
>> tree or not.
>> 
>> Dave Hyatt originally created this when we first were planning the Apple 
>> Windows port of WebKit, but in the end we chose to not use them for the 
>> Windows port. They aren’t used in the Windows port nor in the Mac or iOS 
>> ports; for all of those we use a separate image decoding library.
>> 
>> So this is a really a question for people working on other active ports like 
>> the EFL and GTK ones. Are there other libraries that you could use for image 
>> decoding, or do you still want to keep and maintain a WebKit copy of these 
>> image decoders?
>> 
>> — Darin
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Modern image formats for WebKit

[ChangSeok Oh]

> So this is a really a question for people working on other active ports like 
> the EFL and GTK ones. Are there other libraries that you could use for image 
> decoding, or do you still want to keep and maintain a WebKit copy of these 
> image decoders?

Maybe the latter one. I’m not sure what you meant other libraries here if they 
are not libwebp nor libjxr. 
I found webp has been supported by gtk & elf ports already. At least 
WebPImageDecoder.cpp is a build target for those ports. JXR support would be a 
same shape with webp support, i. e adding a glue layer JPEGXRImageDecoder.cpp/h 
and linking libjxr.so.  

ChangSeok

> On Mar 21, 2015, at 6:39 AM, Darin Adler  wrote:
> 
> We should consider whether to keep the image format decoders in the WebKit 
> tree or not.
> 
> Dave Hyatt originally created this when we first were planning the Apple 
> Windows port of WebKit, but in the end we chose to not use them for the 
> Windows port. They aren’t used in the Windows port nor in the Mac or iOS 
> ports; for all of those we use a separate image decoding library.
> 
> So this is a really a question for people working on other active ports like 
> the EFL and GTK ones. Are there other libraries that you could use for image 
> decoding, or do you still want to keep and maintain a WebKit copy of these 
> image decoders?
> 
> — Darin
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Modern image formats for WebKit

[Brent Fulgham]

> On Mar 20, 2015, at 2:39 PM, Darin Adler  wrote:
> 
> Dave Hyatt originally created this when we first were planning the Apple 
> Windows port of WebKit, but in the end we chose to not use them for the 
> Windows port. They aren’t used in the Windows port nor in the Mac or iOS 
> ports; for all of those we use a separate image decoding library.
> 
> So this is a really a question for people working on other active ports like 
> the EFL and GTK ones. Are there other libraries that you could use for image 
> decoding, or do you still want to keep and maintain a WebKit copy of these 
> image decoders?

The WinCairo and GTK ports definitely use these image decoders. I think the EFL 
port does as well, but I’m not sure.

-Brent
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Modern image formats for WebKit

[Darin Adler]

We should consider whether to keep the image format decoders in the WebKit tree 
or not.

Dave Hyatt originally created this when we first were planning the Apple 
Windows port of WebKit, but in the end we chose to not use them for the Windows 
port. They aren’t used in the Windows port nor in the Mac or iOS ports; for all 
of those we use a separate image decoding library.

So this is a really a question for people working on other active ports like 
the EFL and GTK ones. Are there other libraries that you could use for image 
decoding, or do you still want to keep and maintain a WebKit copy of these 
image decoders?

— Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Modern image formats for WebKit

[ChangSeok Oh]

> Are there no existing libraries that can be conditionally linked with for 
> supporting these formats? In the long term, it seems like bad design to have 
> WebKit have its own custom decoders.

Yes. there are of course. libwebp, libjxr are available on linux based systems 
and also seem available on mac and Windows. [1]
Both are BSD license so that there is no license issue to port them for any 
platforms if necessary.
I’m not telling about inventing new wheels for them, but adding a kind of a 
glue layer in webkit as png, gif and png supports do. ;) (e.g PNGImageDecoder.* 
JPEGImageDecoder.*)

[1] https://developers.google.com/speed/webp/download 

 https://jxrlib.codeplex.com/releases/view/107208 

 https://packages.debian.org/wheezy/webp 

 https://packages.debian.org/sid/utils/libjxr-tools 



ChangSeok

> On Mar 20, 2015, at 2:21 PM, Myles C. Maxfield  wrote:
> 
> Are there no existing libraries that can be conditionally linked with for 
> supporting these formats? In the long term, it seems like bad design to have 
> WebKit have its own custom decoders.
> 
> If that isn't an option, it seems fine to me provided that the decoders' 
> sources are all close together (for some definition of close) and not 
> peppered throughout WebKit.
> 
>> On Mar 19, 2015, at 9:38 PM, ChangSeok Oh  wrote:
>> 
>> Hi WebKittens.
>> 
>> I just saw apng support landed on webkit main stream. [1] (even it works for 
>> gtk port only now)
>> So I suddenly wonder if webkit community is getting interested in bringing 
>> other modern image formats like webp or jpeg-xr into webkit.
>> If so, I can lend my hands for it.
>> 
>> For webp support, as you know, we can reuse blink's codebase. [2]
>> For jpeg-xr supprot, I have a rough sketch for it [3] (it might be outdated 
>> or not fit tot of webkit though, bringing it to webkit is just a piece of 
>> cake. ;))
>> 
>> My intention is not to argue which format is better, just to ask community's 
>> thoughts, preferences  or like that.
>> 
>> [1] https://bugs.webkit.org/show_bug.cgi?id=17022
>> [2] 
>> https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp&q=webpima&sq=package:chromium&l=1
>> [3] 
>> http://cgit.collabora.com/git/user/kevino/Blink.git/commit/?h=jxr-support&id=2ac58312a5aae502aacc1c55c0bfdff767ab82a2
>> 
>> BR.
>> 
>> -- 
>> ChangSeok
>> 
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Modern image formats for WebKit

[Myles C. Maxfield]

Are there no existing libraries that can be conditionally linked with for 
supporting these formats? In the long term, it seems like bad design to have 
WebKit have its own custom decoders.

If that isn't an option, it seems fine to me provided that the decoders' 
sources are all close together (for some definition of close) and not peppered 
throughout WebKit.

> On Mar 19, 2015, at 9:38 PM, ChangSeok Oh  wrote:
> 
> Hi WebKittens.
> 
> I just saw apng support landed on webkit main stream. [1] (even it works for 
> gtk port only now)
> So I suddenly wonder if webkit community is getting interested in bringing 
> other modern image formats like webp or jpeg-xr into webkit.
> If so, I can lend my hands for it.
> 
> For webp support, as you know, we can reuse blink's codebase. [2]
> For jpeg-xr supprot, I have a rough sketch for it [3] (it might be outdated 
> or not fit tot of webkit though, bringing it to webkit is just a piece of 
> cake. ;))
> 
> My intention is not to argue which format is better, just to ask community's 
> thoughts, preferences  or like that.
> 
> [1] https://bugs.webkit.org/show_bug.cgi?id=17022
> [2] 
> https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp&q=webpima&sq=package:chromium&l=1
> [3] 
> http://cgit.collabora.com/git/user/kevino/Blink.git/commit/?h=jxr-support&id=2ac58312a5aae502aacc1c55c0bfdff767ab82a2
> 
> BR.
> 
> -- 
> ChangSeok
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Modern image formats for WebKit

[ChangSeok Oh]

Hi WebKittens.

I just saw apng support landed on webkit main stream. [1] (even it works 
for gtk port only now)
So I suddenly wonder if webkit community is getting interested in 
bringing other modern image formats like webp or jpeg-xr into webkit.

If so, I can lend my hands for it.

For webp support, as you know, we can reuse blink's codebase. [2]
For jpeg-xr supprot, I have a rough sketch for it [3] (it might be 
outdated or not fit tot of webkit though, bringing it to webkit is just 
a piece of cake. ;))


My intention is not to argue which format is better, just to ask 
community's thoughts, preferences  or like that.


[1] https://bugs.webkit.org/show_bug.cgi?id=17022
[2] 
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp&q=webpima&sq=package:chromium&l=1
[3] 
http://cgit.collabora.com/git/user/kevino/Blink.git/commit/?h=jxr-support&id=2ac58312a5aae502aacc1c55c0bfdff767ab82a2


BR.

--
ChangSeok

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev