Re: [webkit-dev] PSA: Distinguishing between failed release assertions and other crashes

2016-02-10 Thread Mark Lam
FYI, the change has landed in r196397: .

> On Feb 10, 2016, at 3:01 PM, Mark Lam  wrote:
> 
> As I shared in a previous email, I’ll be changing the implementation of 
> WTFCrash() for non-debug OS(DARWIN) builds to use an inlined asm statement 
> that issues a breakpoint instruction.  See 
> https://bugs.webkit.org/show_bug.cgi?id=153996 for details and discussion.  I 
> will be landing this patch shortly.
> 
> After this patch lands, for release builds, failed assertions will manifest 
> as a EXC_BREAKPOINT (SIGTRAP).  Failed assertions should be your only source 
> of EXC_BREAKPOINT crashes.
> For debug builds, failed assertions will continue to manifest as 
> EXC_BAD_ACCESS (SIGSEGV) on access of invalid address 0xbbadbeef.
> 
> Again, this change will only apply to OS(DARWIN) builds.  I’m leaving it up 
> to the linux folks to decide if they also want to adopt this behavior on 
> linux.
> 
> Thanks.
> 
> Mark
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] PSA: Distinguishing between failed release assertions and other crashes

2016-02-10 Thread Mark Lam
As I shared in a previous email, I’ll be changing the implementation of 
WTFCrash() for non-debug OS(DARWIN) builds to use an inlined asm statement that 
issues a breakpoint instruction.  See 
https://bugs.webkit.org/show_bug.cgi?id=153996 for details and discussion.  I 
will be landing this patch shortly.

After this patch lands, for release builds, failed assertions will manifest as 
a EXC_BREAKPOINT (SIGTRAP).  Failed assertions should be your only source of 
EXC_BREAKPOINT crashes.
For debug builds, failed assertions will continue to manifest as EXC_BAD_ACCESS 
(SIGSEGV) on access of invalid address 0xbbadbeef.

Again, this change will only apply to OS(DARWIN) builds.  I’m leaving it up to 
the linux folks to decide if they also want to adopt this behavior on linux.

Thanks.

Mark
  
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev