Re: [webkit-dev] Reflecting pixel delta distance in ImageDiff
Food for thought... Skia's skdiff tool generates two diff images for each image pair: - 1. every pixel which is different at all between images 1 2 shows up as white - 2. every pixel shows the color difference between images 1 2 (much more subtle) For an example of what this looks like, see http://skia.googlecode.com/svn/trunk/tools/tests/skdiff/test1/output-expected/index.html On Fri, Jun 15, 2012 at 7:24 PM, Tony Payne tpa...@chromium.org wrote: I would like to change chromium's ImageDiff to reflect the magnitude of pixel changes. Currently, if the pixel has any difference, the entire pixel is marked as 100% red. I'd like to change it so that miniscule difference are 20% red and large differences are 100% red. Looking at the code for CG, gtk and Win versions of ImageDiff, I think they already do something similar. Is this correct? Would anyone be opposed to such a change? See the attached image for an example of how this could assist in debugging regressions. It would certainly be enormously useful in my color management efforts. Thanks, Tony The CL in question is https://bugs.webkit.org/show_bug.cgi?id=89253 ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Reflecting pixel delta distance in ImageDiff
I would like to change chromium's ImageDiff to reflect the magnitude of pixel changes. Currently, if the pixel has any difference, the entire pixel is marked as 100% red. I'd like to change it so that miniscule difference are 20% red and large differences are 100% red. Looking at the code for CG, gtk and Win versions of ImageDiff, I think they already do something similar. Is this correct? Would anyone be opposed to such a change? See the attached image for an example of how this could assist in debugging regressions. It would certainly be enormously useful in my color management efforts. Thanks, Tony The CL in question is https://bugs.webkit.org/show_bug.cgi?id=89253 attachment: embed-attributes-style-diff.png___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Reflecting pixel delta distance in ImageDiff
On Fri, Jun 15, 2012 at 4:24 PM, Tony Payne tpa...@chromium.org wrote: I would like to change chromium's ImageDiff to reflect the magnitude of pixel changes. Currently, if the pixel has any difference, the entire pixel is marked as 100% red. I'd like to change it so that miniscule difference are 20% red and large differences are 100% red. Looking at the code for CG, gtk and Win versions of ImageDiff, I think they already do something similar. Is this correct? Would anyone be opposed to such a change? See the attached image for an example of how this could assist in debugging regressions. It would certainly be enormously useful in my color management efforts. People with Protanomaly like myself won't be too happy about it. I'm already having a really hard time finding the red pixels on diffs without zooming. - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Reflecting pixel delta distance in ImageDiff
On Fri, Jun 15, 2012 at 4:27 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Jun 15, 2012 at 4:24 PM, Tony Payne tpa...@chromium.org wrote: I would like to change chromium's ImageDiff to reflect the magnitude of pixel changes. Currently, if the pixel has any difference, the entire pixel is marked as 100% red. I'd like to change it so that miniscule difference are 20% red and large differences are 100% red. Looking at the code for CG, gtk and Win versions of ImageDiff, I think they already do something similar. Is this correct? Would anyone be opposed to such a change? See the attached image for an example of how this could assist in debugging regressions. It would certainly be enormously useful in my color management efforts. People with Protanomaly like myself won't be too happy about it. I'm already having a really hard time finding the red pixels on diffs without zooming. Fair enough, but that doesn't address the basic premise of distinguishing small deltas from large deltas. I'm sure we can find a UI that will work that achieves the desired goal ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Reflecting pixel delta distance in ImageDiff
On Fri, Jun 15, 2012 at 8:24 PM, Tony Payne tpa...@chromium.org wrote: Looking at the code for CG, gtk and Win versions of ImageDiff, I think they already do something similar. Is this correct? The GTK and Efl produces a grayscale image, where the pixel goes from black (no difference) to white, gradually, proportional to the euclidean distance between both pixel colors inside a RGB cube (sort of, as alpha channel is also considered). -- Leandro ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Reflecting pixel delta distance in ImageDiff
On Fri, Jun 15, 2012 at 8:27 PM, Ryosuke Niwa rn...@webkit.org wrote: People with Protanomaly like myself won't be too happy about it. I'm already having a really hard time finding the red pixels on diffs without zooming. Perhaps generating a list of rectangles where there are differences would help produce some interactive result with some marching ants bounding boxes that when clicked, zooms in to show the details? Leandro ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
