[webkit-dev] WebKitTools/Script/generate-coverage-data

2010-08-23 Thread Eric Seidel
Has anyone looked at our coverage-generating scripts in a while?

Seems to die trying to build libANGLE these days, but I believe the
scripts have been dead for much longer.

I'm interested in finding (and removing) dead code from WebCore.
There is a whole bunch more dead code now that the
LegacyHTMLDocumentParser has been removed.  I'd like to rip it out.  I
was hoping gcov / generate-coverage-data would help me do that.

-eric
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] WebKitTools/Script/generate-coverage-data

2010-08-23 Thread Holger Freyther
On 08/24/2010 01:38 AM, Eric Seidel wrote:
> Has anyone looked at our coverage-generating scripts in a while?

Sorry, I didn't. You are trying to use them on OSX? I think I can find some
time at the end of the week to make them work again. Can you wait that long?
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] WebKitTools/Script/generate-coverage-data

2010-08-24 Thread Eric Seidel
Ha.  That's not long to wait.  I'd be happy to use them on OS X if
they worked again.

At some point we had a coverage bot. Perhaps if they were restored to
working condition we could work with wms to set one up again.  I'm
expect we can find a linux machine somewhere to run it on.

-eric

On Mon, Aug 23, 2010 at 9:46 PM, Holger Freyther  wrote:
> On 08/24/2010 01:38 AM, Eric Seidel wrote:
>> Has anyone looked at our coverage-generating scripts in a while?
>
> Sorry, I didn't. You are trying to use them on OSX? I think I can find some
> time at the end of the week to make them work again. Can you wait that long?
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] WebKitTools/Script/generate-coverage-data

2010-08-26 Thread Holger Freyther
On 08/24/2010 12:46 PM, Holger Freyther wrote:
> On 08/24/2010 01:38 AM, Eric Seidel wrote:
>> Has anyone looked at our coverage-generating scripts in a while?
> 
> Sorry, I didn't. You are trying to use them on OSX? I think I can find some
> time at the end of the week to make them work again. Can you wait that long?

Hi,
the only change is to exclude the coverage option for ANGLE as libtool does
not like these parameters. I have tested the scripts and they work, I will
need to test the whole generate-coverage script tomorrow and will open a bug
report...

http://paste.lisp.org/display/113900
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] WebKitTools/Script/generate-coverage-data

2010-08-29 Thread Holger Freyther
On 08/26/2010 11:56 PM, Holger Freyther wrote:

> Hi,
> the only change is to exclude the coverage option for ANGLE as libtool does
> not like these parameters. I have tested the scripts and they work, I will
> need to test the whole generate-coverage script tomorrow and will open a bug
> report...

Darin was nice enough to review and I have landed it, please try it and tell
me if you have any problems with the script.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev