Re: [webkit-dev] test scripts
On Wed, Dec 30, 2009 at 2:33 PM, Sam Weinig sam.wei...@gmail.com wrote: I would prefer we stick with the run prefix. I am also not sure why we would have separate testing scripts based by language. Thanks, Sam. The language-specific scripts are more an artifact of the fact that the Perl test harness is written in Perl and the Python test harness is written in Python. They can be viewed as intermediate implementation steps. With the exception of a script for testing interpreted code (as Adam suggested in an earlier e-mail), I do agree with you that contributors shouldn't have to call or know about the language-specific scripts. I submitted a patch to that effect here: https://bugs.webkit.org/show_bug.cgi?id=33045 From an implementation perspective though, I do think they can provide a useful layer of encapsulation when calling from other code. As I mentioned in an earlier e-mail, over time we can move the language-specific scripts to a sub-folder so they won't be as visible to the end user. If the number of these scripts got out of hand, we could always add a run-all-tests scripts which ran them all. I think the intention is not to expose at the top level a separate script for every component, but to provide only higher-level commands. But yes, an all script is good. As for your preference regarding the run prefix, I elaborated on my reasons in the comments to the bug report. If you want, we can continue the discussion there. Thanks a lot, --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] test scripts
I would prefer we stick with the run prefix. I am also not sure why we would have separate testing scripts based by language. I think it would make a lot more sense to base the scripts on what they were testing as is currently done (run-webkit-tests tests webkit, run-javascriptcore-tests tests javascriptcore), so a script to bugzilla tool would be called run-bugzillatool-tests. If the number of these scripts got out of hand, we could always add a run-all-tests scripts which ran them all. -Sam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] test scripts
On Tue, Dec 29, 2009 at 11:07 AM, Adam Barth aba...@webkit.org wrote: I'd prefer to have as few test commands as possible. Ideally, I should just be able to run the grand unified test suite and know that my patch is ok to commit. There's some advantages to breaking out the JSC tests from the WebCore tests so we can avoid building WebCore when testing JSC. Similarly, there's an advantage to breaking out the tests of interpreted code from compiled code to avoid unnecessary compilation. However, I don't see the advantage of dividing the Perl tests from the Python tests. I agree with exposing higher-level test commands and having a single script that tests both the Perl and Python code (e.g. test-webkit-scripts). For encapsulation purposes and to let the Perl tests be called more easily from other languages, it may still be useful to have a single script that runs all the Perl unit tests (and similarly for Python). If we wanted to, we could perhaps move those language-specific scripts to a sub-folder so the end user won't see them. --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] test scripts
Last night on IRC there was a brief discussion of the test scripts: how they should be divided in the future and what they should be called. These scripts are in WebKitTools/Scripts. I believe we currently have at least (correct me if I'm wrong)-- run-webkit-tests run-javascriptcore-tests run-webkit-unittests (tests Python scripts) I also have a patch to add a script to test some Perl functionality. Maciej mentioned that he thinks it's useful for scripts to begin with an action word (i.e. a verb). However, we currently have many scripts (not just testing scripts) that begin with the generic word run. Going forward, how would people feel about giving new test scripts names that begin with the word test? For example-- test-webkit-perl test-webkit-python etc. Separate from this question, I think it would be great if one of those participating last night (or anyone else) could share their vision of how they think our tests should be divided up in the mid to long-term. This can include new tests that we haven't written yet, but hope to. Thanks, --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] test scripts
My 2¢: I like the name test-webkit-python. Or unittest-python, or unittest-webkit-python. On Mon, Dec 28, 2009 at 9:14 PM, Chris Jerdonek chris.jerdo...@gmail.com wrote: Last night on IRC there was a brief discussion of the test scripts: how they should be divided in the future and what they should be called. These scripts are in WebKitTools/Scripts. I believe we currently have at least (correct me if I'm wrong)-- run-webkit-tests run-javascriptcore-tests run-webkit-unittests (tests Python scripts) I also have a patch to add a script to test some Perl functionality. Maciej mentioned that he thinks it's useful for scripts to begin with an action word (i.e. a verb). However, we currently have many scripts (not just testing scripts) that begin with the generic word run. Going forward, how would people feel about giving new test scripts names that begin with the word test? For example-- test-webkit-perl test-webkit-python etc. Separate from this question, I think it would be great if one of those participating last night (or anyone else) could share their vision of how they think our tests should be divided up in the mid to long-term. This can include new tests that we haven't written yet, but hope to. Thanks, --Chris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
