Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?
I build debug with !ENABLE_SVG on my laptop to mitigate some of the pain of building on the road. Not saying I couldn't live without it, it'd just be a life of ~doubled compile times. :-) -Kling On Fri, Sep 9, 2011 at 11:42 PM, Eric Seidel wrote: > I am interested in removing the ENABLE_SVG define, and all associated > sub-defines > > ENABLE_SVG_ANIMATION > ENABLE_SVG_AS_IMAGE > ENABLE_SVG_FONTS > ENABLE_SVG_FOREIGN_OBJECT > ENABLE_SVG_USE > > SVG is part of HTML5, and all major ports compile and ship with SVG > enabled (and have for years). > > Please let me know if you are compiling with ENABLE_SVG disabled. > > -eric > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?
I know webOS ships (or doesn't these days?) sans-SVG. On Fri, Sep 9, 2011 at 2:42 PM, Eric Seidel wrote: > I am interested in removing the ENABLE_SVG define, and all associated > sub-defines > > ENABLE_SVG_ANIMATION > ENABLE_SVG_AS_IMAGE > ENABLE_SVG_FONTS > ENABLE_SVG_FOREIGN_OBJECT > ENABLE_SVG_USE > > SVG is part of HTML5, and all major ports compile and ship with SVG > enabled (and have for years). > > Please let me know if you are compiling with ENABLE_SVG disabled. > > -eric > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?
We could at least remove the subsets of SVG. Some developers build without SVG for compile time reasons. Dirk Am 09.09.2011 um 23:45 schrieb Levi Weintraub: > I know webOS ships (or doesn't these days?) sans-SVG. > > On Fri, Sep 9, 2011 at 2:42 PM, Eric Seidel wrote: >> I am interested in removing the ENABLE_SVG define, and all associated >> sub-defines >> >> ENABLE_SVG_ANIMATION >> ENABLE_SVG_AS_IMAGE >> ENABLE_SVG_FONTS >> ENABLE_SVG_FOREIGN_OBJECT >> ENABLE_SVG_USE >> >> SVG is part of HTML5, and all major ports compile and ship with SVG >> enabled (and have for years). >> >> Please let me know if you are compiling with ENABLE_SVG disabled. >> >> -eric >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?
That seems like a very reasonable solution to me. On Fri, Sep 9, 2011 at 2:51 PM, Dirk Schulze wrote: > We could at least remove the subsets of SVG. Some developers build without > SVG for compile time reasons. > > Dirk > > Am 09.09.2011 um 23:45 schrieb Levi Weintraub: > >> I know webOS ships (or doesn't these days?) sans-SVG. >> >> On Fri, Sep 9, 2011 at 2:42 PM, Eric Seidel wrote: >>> I am interested in removing the ENABLE_SVG define, and all associated >>> sub-defines >>> >>> ENABLE_SVG_ANIMATION >>> ENABLE_SVG_AS_IMAGE >>> ENABLE_SVG_FONTS >>> ENABLE_SVG_FOREIGN_OBJECT >>> ENABLE_SVG_USE >>> >>> SVG is part of HTML5, and all major ports compile and ship with SVG >>> enabled (and have for years). >>> >>> Please let me know if you are compiling with ENABLE_SVG disabled. >>> >>> -eric >>> ___ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?
Hi Eric, chromium's mac tryservers (which are similar to webkit's EWS) all build with svg disabled. Nico On Fri, Sep 9, 2011 at 2:42 PM, Eric Seidel wrote: > I am interested in removing the ENABLE_SVG define, and all associated > sub-defines > > ENABLE_SVG_ANIMATION > ENABLE_SVG_AS_IMAGE > ENABLE_SVG_FONTS > ENABLE_SVG_FOREIGN_OBJECT > ENABLE_SVG_USE > > SVG is part of HTML5, and all major ports compile and ship with SVG > enabled (and have for years). > > Please let me know if you are compiling with ENABLE_SVG disabled. > > -eric > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?
When doing ports to various embedded systems we often disable SVG to reduce the size of the resulting library. It would be nice to retain the top level ENABLE_SVG define for this purpose. Thanks, Dan On 09/09/2011 05:42 PM, Eric Seidel wrote: I am interested in removing the ENABLE_SVG define, and all associated sub-defines ENABLE_SVG_ANIMATION ENABLE_SVG_AS_IMAGE ENABLE_SVG_FONTS ENABLE_SVG_FOREIGN_OBJECT ENABLE_SVG_USE SVG is part of HTML5, and all major ports compile and ship with SVG enabled (and have for years). Please let me know if you are compiling with ENABLE_SVG disabled. -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?
Same here. We disable SVG for code size reasons as well. It would be nice to continue to have the top level define for that purpose. Thanks! -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Dan Minor Sent: Monday, September 12, 2011 7:07 AM To: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Do you compile with ENABLE_SVG diabled? When doing ports to various embedded systems we often disable SVG to reduce the size of the resulting library. It would be nice to retain the top level ENABLE_SVG define for this purpose. Thanks, Dan On 09/09/2011 05:42 PM, Eric Seidel wrote: > I am interested in removing the ENABLE_SVG define, and all associated > sub-defines > > ENABLE_SVG_ANIMATION > ENABLE_SVG_AS_IMAGE > ENABLE_SVG_FONTS > ENABLE_SVG_FOREIGN_OBJECT > ENABLE_SVG_USE > > SVG is part of HTML5, and all major ports compile and ship with SVG > enabled (and have for years). > > Please let me know if you are compiling with ENABLE_SVG disabled. > > -eric > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?
Hearing no objections to removing any of the sub-defines, I will post a patch to do so shortly. I'll leave the ENABLE_SVG define for now. -eric On Tue, Sep 13, 2011 at 11:12 AM, Baldeva, Arpit wrote: > Same here. We disable SVG for code size reasons as well. It would be nice to > continue to have the top level define for that purpose. > > Thanks! > > -Original Message- > From: webkit-dev-boun...@lists.webkit.org > [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Dan Minor > Sent: Monday, September 12, 2011 7:07 AM > To: webkit-dev@lists.webkit.org > Subject: Re: [webkit-dev] Do you compile with ENABLE_SVG diabled? > > When doing ports to various embedded systems we often disable SVG to reduce > the size of the resulting library. It would be nice to retain the top level > ENABLE_SVG define for this purpose. > > Thanks, > > Dan > > On 09/09/2011 05:42 PM, Eric Seidel wrote: >> I am interested in removing the ENABLE_SVG define, and all associated >> sub-defines >> >> ENABLE_SVG_ANIMATION >> ENABLE_SVG_AS_IMAGE >> ENABLE_SVG_FONTS >> ENABLE_SVG_FOREIGN_OBJECT >> ENABLE_SVG_USE >> >> SVG is part of HTML5, and all major ports compile and ship with SVG >> enabled (and have for years). >> >> Please let me know if you are compiling with ENABLE_SVG disabled. >> >> -eric >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?
Folks can track the general task of feature removal at: https://bugs.webkit.org/show_bug.cgi?id=68012 I will link all the "Remove ENABLE_*" bugs to that one. -eric On Tue, Sep 13, 2011 at 11:20 AM, Eric Seidel wrote: > Hearing no objections to removing any of the sub-defines, I will post > a patch to do so shortly. > > I'll leave the ENABLE_SVG define for now. > > -eric > > On Tue, Sep 13, 2011 at 11:12 AM, Baldeva, Arpit wrote: >> Same here. We disable SVG for code size reasons as well. It would be nice to >> continue to have the top level define for that purpose. >> >> Thanks! >> >> -Original Message- >> From: webkit-dev-boun...@lists.webkit.org >> [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Dan Minor >> Sent: Monday, September 12, 2011 7:07 AM >> To: webkit-dev@lists.webkit.org >> Subject: Re: [webkit-dev] Do you compile with ENABLE_SVG diabled? >> >> When doing ports to various embedded systems we often disable SVG to reduce >> the size of the resulting library. It would be nice to retain the top level >> ENABLE_SVG define for this purpose. >> >> Thanks, >> >> Dan >> >> On 09/09/2011 05:42 PM, Eric Seidel wrote: >>> I am interested in removing the ENABLE_SVG define, and all associated >>> sub-defines >>> >>> ENABLE_SVG_ANIMATION >>> ENABLE_SVG_AS_IMAGE >>> ENABLE_SVG_FONTS >>> ENABLE_SVG_FOREIGN_OBJECT >>> ENABLE_SVG_USE >>> >>> SVG is part of HTML5, and all major ports compile and ship with SVG >>> enabled (and have for years). >>> >>> Please let me know if you are compiling with ENABLE_SVG disabled. >>> >>> -eric >>> ___ >>> webkit-dev mailing list >>> webkit-dev@lists.webkit.org >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >>> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?
On Tue, Sep 13, 2011 at 11:27 AM, Eric Seidel wrote: > Folks can track the general task of feature removal at: > https://bugs.webkit.org/show_bug.cgi?id=68012 Nice this is helpful, thanks. > > > I will link all the "Remove ENABLE_*" bugs to that one. > > -eric > > On Tue, Sep 13, 2011 at 11:20 AM, Eric Seidel wrote: > > Hearing no objections to removing any of the sub-defines, I will post > > a patch to do so shortly. > > > > I'll leave the ENABLE_SVG define for now. > > > > -eric > > > > On Tue, Sep 13, 2011 at 11:12 AM, Baldeva, Arpit > wrote: > >> Same here. We disable SVG for code size reasons as well. It would be > nice to continue to have the top level define for that purpose. > >> > >> Thanks! > >> > >> -Original Message- > >> From: webkit-dev-boun...@lists.webkit.org [mailto: > webkit-dev-boun...@lists.webkit.org] On Behalf Of Dan Minor > >> Sent: Monday, September 12, 2011 7:07 AM > >> To: webkit-dev@lists.webkit.org > >> Subject: Re: [webkit-dev] Do you compile with ENABLE_SVG diabled? > >> > >> When doing ports to various embedded systems we often disable SVG to > reduce the size of the resulting library. It would be nice to retain the > top level ENABLE_SVG define for this purpose. > >> > >> Thanks, > >> > >> Dan > >> > >> On 09/09/2011 05:42 PM, Eric Seidel wrote: > >>> I am interested in removing the ENABLE_SVG define, and all associated > >>> sub-defines > >>> > >>> ENABLE_SVG_ANIMATION > >>> ENABLE_SVG_AS_IMAGE > >>> ENABLE_SVG_FONTS > >>> ENABLE_SVG_FOREIGN_OBJECT > >>> ENABLE_SVG_USE > >>> > >>> SVG is part of HTML5, and all major ports compile and ship with SVG > >>> enabled (and have for years). > >>> > >>> Please let me know if you are compiling with ENABLE_SVG disabled. > >>> > >>> -eric > >>> ___ > >>> webkit-dev mailing list > >>> webkit-dev@lists.webkit.org > >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >>> > >> ___ > >> webkit-dev mailing list > >> webkit-dev@lists.webkit.org > >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >> > >> ___ > >> webkit-dev mailing list > >> webkit-dev@lists.webkit.org > >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >> > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > -- *Sencha* Jarred Nicholls, Senior Software Architect @jarrednicholls <http://twitter.com/jarrednicholls> ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?
I've removed ENABLE_SVG_FOREIGN_OBJECT in http://trac.webkit.org/changeset/95040 I'm going to let that one bake for a few hours before I land the rest of the ENABLE_SVG_* removal patches. Thank you everyone for your feedback. -eric On Tue, Sep 13, 2011 at 11:28 AM, Jarred Nicholls wrote: > On Tue, Sep 13, 2011 at 11:27 AM, Eric Seidel wrote: >> >> Folks can track the general task of feature removal at: >> https://bugs.webkit.org/show_bug.cgi?id=68012 > > Nice this is helpful, thanks. > >> >> I will link all the "Remove ENABLE_*" bugs to that one. >> >> -eric >> >> On Tue, Sep 13, 2011 at 11:20 AM, Eric Seidel wrote: >> > Hearing no objections to removing any of the sub-defines, I will post >> > a patch to do so shortly. >> > >> > I'll leave the ENABLE_SVG define for now. >> > >> > -eric >> > >> > On Tue, Sep 13, 2011 at 11:12 AM, Baldeva, Arpit >> > wrote: >> >> Same here. We disable SVG for code size reasons as well. It would be >> >> nice to continue to have the top level define for that purpose. >> >> >> >> Thanks! >> >> >> >> -Original Message----- >> >> From: webkit-dev-boun...@lists.webkit.org >> >> [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Dan Minor >> >> Sent: Monday, September 12, 2011 7:07 AM >> >> To: webkit-dev@lists.webkit.org >> >> Subject: Re: [webkit-dev] Do you compile with ENABLE_SVG diabled? >> >> >> >> When doing ports to various embedded systems we often disable SVG to >> >> reduce the size of the resulting library. It would be nice to retain the >> >> top level ENABLE_SVG define for this purpose. >> >> >> >> Thanks, >> >> >> >> Dan >> >> >> >> On 09/09/2011 05:42 PM, Eric Seidel wrote: >> >>> I am interested in removing the ENABLE_SVG define, and all associated >> >>> sub-defines >> >>> >> >>> ENABLE_SVG_ANIMATION >> >>> ENABLE_SVG_AS_IMAGE >> >>> ENABLE_SVG_FONTS >> >>> ENABLE_SVG_FOREIGN_OBJECT >> >>> ENABLE_SVG_USE >> >>> >> >>> SVG is part of HTML5, and all major ports compile and ship with SVG >> >>> enabled (and have for years). >> >>> >> >>> Please let me know if you are compiling with ENABLE_SVG disabled. >> >>> >> >>> -eric >> >>> ___ >> >>> webkit-dev mailing list >> >>> webkit-dev@lists.webkit.org >> >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >>> >> >> ___ >> >> webkit-dev mailing list >> >> webkit-dev@lists.webkit.org >> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> >> >> ___ >> >> webkit-dev mailing list >> >> webkit-dev@lists.webkit.org >> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev >> >> >> > >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > > > -- > > Sencha > Jarred Nicholls, Senior Software Architect > @jarrednicholls > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Do you compile with ENABLE_SVG diabled?
EFL build bot has built WebKit EFL with SVG features successfully. I think EFL guys won't oppose this removal. - gyuyoung > -Original Message- > From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- > boun...@lists.webkit.org] On Behalf Of Eric Seidel > Sent: Wednesday, September 14, 2011 5:20 AM > To: Jarred Nicholls > Cc: webkit-dev@lists.webkit.org > Subject: Re: [webkit-dev] Do you compile with ENABLE_SVG diabled? > > I've removed ENABLE_SVG_FOREIGN_OBJECT in > http://trac.webkit.org/changeset/95040 > > I'm going to let that one bake for a few hours before I land the rest > of the ENABLE_SVG_* removal patches. > > Thank you everyone for your feedback. > > -eric > > On Tue, Sep 13, 2011 at 11:28 AM, Jarred Nicholls > wrote: > > On Tue, Sep 13, 2011 at 11:27 AM, Eric Seidel wrote: > >> > >> Folks can track the general task of feature removal at: > >> https://bugs.webkit.org/show_bug.cgi?id=68012 > > > > Nice this is helpful, thanks. > > > >> > >> I will link all the "Remove ENABLE_*" bugs to that one. > >> > >> -eric > >> > >> On Tue, Sep 13, 2011 at 11:20 AM, Eric Seidel wrote: > >> > Hearing no objections to removing any of the sub-defines, I will post > >> > a patch to do so shortly. > >> > > >> > I'll leave the ENABLE_SVG define for now. > >> > > >> > -eric > >> > > >> > On Tue, Sep 13, 2011 at 11:12 AM, Baldeva, Arpit > >> > wrote: > >> >> Same here. We disable SVG for code size reasons as well. It would be > >> >> nice to continue to have the top level define for that purpose. > >> >> > >> >> Thanks! > >> >> > >> >> -Original Message- > >> >> From: webkit-dev-boun...@lists.webkit.org > >> >> [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Dan Minor > >> >> Sent: Monday, September 12, 2011 7:07 AM > >> >> To: webkit-dev@lists.webkit.org > >> >> Subject: Re: [webkit-dev] Do you compile with ENABLE_SVG diabled? > >> >> > >> >> When doing ports to various embedded systems we often disable SVG to > >> >> reduce the size of the resulting library. It would be nice to > retain the > >> >> top level ENABLE_SVG define for this purpose. > >> >> > >> >> Thanks, > >> >> > >> >> Dan > >> >> > >> >> On 09/09/2011 05:42 PM, Eric Seidel wrote: > >> >>> I am interested in removing the ENABLE_SVG define, and all > associated > >> >>> sub-defines > >> >>> > >> >>> ENABLE_SVG_ANIMATION > >> >>> ENABLE_SVG_AS_IMAGE > >> >>> ENABLE_SVG_FONTS > >> >>> ENABLE_SVG_FOREIGN_OBJECT > >> >>> ENABLE_SVG_USE > >> >>> > >> >>> SVG is part of HTML5, and all major ports compile and ship with SVG > >> >>> enabled (and have for years). > >> >>> > >> >>> Please let me know if you are compiling with ENABLE_SVG disabled. > >> >>> > >> >>> -eric > >> >>> ___ > >> >>> webkit-dev mailing list > >> >>> webkit-dev@lists.webkit.org > >> >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >> >>> > >> >> ___ > >> >> webkit-dev mailing list > >> >> webkit-dev@lists.webkit.org > >> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >> >> > >> >> ___ > >> >> webkit-dev mailing list > >> >> webkit-dev@lists.webkit.org > >> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >> >> > >> > > >> ___ > >> webkit-dev mailing list > >> webkit-dev@lists.webkit.org > >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > > > > > > > -- > > > > Sencha > > Jarred Nicholls, Senior Software Architect > > @jarrednicholls > > > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
