Re: [webkit-dev] git-webkit pr now supports --no-ews / --ews flags

2023-01-27 Thread Aakash Jain via webkit-dev
As of 259501@main, we now have both, GitHub label "skip-ews" and git-webkit pr 
support for --skip-ews flag.

Thanks
Aakash

> On Jan 26, 2023, at 3:58 PM, Geoffrey Garen  wrote:
> 
> This is great!
> 
> As it is said in "Ghost Dog: The Way of the Samurai", it is bad when one 
> thing becomes two. Can we pick one name for this feature? Either —no-ews 
> (git-webkit) and no-ews (GitHub) or —skip-ews (git-webkit) and skip-ews 
> (GitHub)?
> 
> Thanks,
> Geoff
> 
>> On Jan 26, 2023, at 11:36 AM, Aakash Jain via webkit-dev 
>>  wrote:
>> 
>> Hi Everyone,
>> 
>> git-webkit pr now supports --no-ews / --ews flags (as of 259115@main). This 
>> is similar to --no-ews flag we had in webkit-patch.  You can also manually 
>> add skip-ews label on any PR when you don't need EWS to run anymore on it. 
>> --no-ews flag will also automatically add the skip-ews label on the 
>> corresponding GitHub PR.
>> 
>> Please feel free to use skip-ews GitHub label or --no-ews flag in git-webkit 
>> pr, when you don't need to run EWS for any reason (e.g.: PR failed a 
>> critical EWS indicating need for new iteration, and you don't need to run 
>> rest of the EWSes on that commit).
>> 
>> If you notice any issues, please let me know or file bugs (and assign to me).
>> 
>> 
>> Thanks
>> Aakash
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] git-webkit pr now supports --no-ews / --ews flags

2023-01-26 Thread Geoffrey Garen via webkit-dev
This is great!

As it is said in "Ghost Dog: The Way of the Samurai", it is bad when one thing 
becomes two. Can we pick one name for this feature? Either —no-ews (git-webkit) 
and no-ews (GitHub) or —skip-ews (git-webkit) and skip-ews (GitHub)?

Thanks,
Geoff

> On Jan 26, 2023, at 11:36 AM, Aakash Jain via webkit-dev 
>  wrote:
> 
> Hi Everyone,
> 
> git-webkit pr now supports --no-ews / --ews flags (as of 259115@main). This 
> is similar to --no-ews flag we had in webkit-patch.  You can also manually 
> add skip-ews label on any PR when you don't need EWS to run anymore on it. 
> --no-ews flag will also automatically add the skip-ews label on the 
> corresponding GitHub PR.
> 
> Please feel free to use skip-ews GitHub label or --no-ews flag in git-webkit 
> pr, when you don't need to run EWS for any reason (e.g.: PR failed a critical 
> EWS indicating need for new iteration, and you don't need to run rest of the 
> EWSes on that commit).
> 
> If you notice any issues, please let me know or file bugs (and assign to me).
> 
> 
> Thanks
> Aakash
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev