[weld-issues] [JBoss JIRA] (WELD-2330) Improving DeferredEventNotification logging in case of failure
Title: Message Title Matej Novotny created an issue Weld / WELD-2330 Improving DeferredEventNotification logging in case of failure Issue Type: Enhancement Affects Versions: 3.0.0.CR1 Assignee: Unassigned Created: 07/Feb/17 3:27 AM Priority: Major Reporter: Matej Novotny In Weld JTA module, namely in DeferredEventNotification, we log a simple one liner ERROR if anything goes awry and the whole stacktrace is then logged with DEBUG level. Therefore, unless you have DEBUG level logging, you cannot really tell what happened. We should improve this - e.g. log cause message? Add Comment
[weld-issues] [JBoss JIRA] (WELD-2330) Improving DeferredEventNotification logging in case of failure
Title: Message Title Martin Kouba updated an issue Weld / WELD-2330 Improving DeferredEventNotification logging in case of failure Change By: Martin Kouba Fix Version/s: 3.0.0.CR2 Fix Version/s: 2.4.3.Final Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2330) Improving DeferredEventNotification logging in case of failure
Title: Message Title
Matej Novotny updated an issue
Weld / WELD-2330
Improving DeferredEventNotification logging in case of failure
Change By:
Matej Novotny
Stackoverflow ID:
http://stackoverflow.com/questions/42028856
In Weld JTA module, namely in [{{DeferredEventNotification}}|https://github.com/weld/core/blob/master/modules/jta/src/main/java/org/jboss/weld/module/jta/DeferredEventNotification.java#L86], we log a simple one liner ERROR if anything goes awry and the whole stacktrace is then logged with DEBUG level.Therefore, unless you have DEBUG level logging, you cannot really tell what happened.We should improve this - e.g. log cause message?
Add Comment
This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d)
___
weld-issues mailing list
weld-issues@lis
[weld-issues] [JBoss JIRA] (WELD-2330) Improving DeferredEventNotification logging in case of failure
Title: Message Title Martin Kouba commented on WELD-2330 Re: Improving DeferredEventNotification logging in case of failure Yes, I believe we should add at least the observer method and the message of the cause (if available). Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2330) Improving DeferredEventNotification logging in case of failure
Title: Message Title Matej Novotny assigned an issue to Matej Novotny Weld / WELD-2330 Improving DeferredEventNotification logging in case of failure Change By: Matej Novotny Assignee: Matej Novotny Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2330) Improving DeferredEventNotification logging in case of failure
Title: Message Title Matej Novotny updated an issue Weld / WELD-2330 Improving DeferredEventNotification logging in case of failure Change By: Matej Novotny Git Pull Request: https://github.com/weld/core/pull/1587 Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2330) Improving DeferredEventNotification logging in case of failure
Title: Message Title Issue was automatically transitioned when Matej Novotny created pull request #1587 in GitHub Weld / WELD-2330 Improving DeferredEventNotification logging in case of failure Change By: Matej Novotny Status: Open Pull Request Sent Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2330) Improving DeferredEventNotification logging in case of failure
Title: Message Title Matej Novotny updated an issue Weld / WELD-2330 Improving DeferredEventNotification logging in case of failure Change By: Matej Novotny Git Pull Request: https://github.com/weld/core/pull/1587 , https://github.com/weld/core/pull/1588 Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2331) Misleading error message when Extension observer method is (wrongly) static
Title: Message Title Laird Nelson created an issue Weld / WELD-2331 Misleading error message when Extension observer method is (wrongly) static Issue Type: Bug Affects Versions: 3.0.0.Beta1 Assignee: Unassigned Components: Extensions Created: 07/Feb/17 6:19 PM Priority: Minor Reporter: Laird Nelson The root cause of this bug is definitely pilot error, but read on. If you have a lifecycle event method in an Extension, and you inadvertently make it static, then the error message you get is this: org.jboss.weld.exceptions.IllegalStateException: WELD-000143: Container lifecycle event method invoked outside of extension observer method invocation. It was not at all immediately apparent that the only problem I had was that the method was static. It would be very helpful if this condition could be probed a bit and a better error message delivered.
[weld-issues] [JBoss JIRA] (WELD-2331) Misleading error message when Extension observer method is (wrongly) static
Title: Message Title Martin Kouba commented on WELD-2331 Re: Misleading error message when Extension observer method is (wrongly) static Hm, this might require a CDI spec clarification. I don't think it is currently forbidden to use static observer methods on extensions. However, I think it's reasonable not to allow static observers. Also there are some spec requirements which would complicate the implementation for static observer methods - i.e. if a container lifecycle event method is called outside of the observer method invocation an IllegalStateException must be thrown. Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
