[weld-issues] [JBoss JIRA] (WELD-2543) Upgrade wildfly-arquillian from 2.1.0.Final to 2.1.1.Final

2018-11-14 Thread Matej Novotny (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matej Novotny updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2543  
 
 
  Upgrade wildfly-arquillian from 2.1.0.Final to 2.1.1.Final   
 

  
 
 
 
 

 
Change By: 
 Matej Novotny  
 
 
Fix Version/s: 
 3.1.0.Final  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2542) CDI 2 Support with Embedded Setup

2018-11-14 Thread Matej Novotny (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matej Novotny edited a comment on  WELD-2542  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: CDI 2 Support with Embedded Setup   
 

  
 
 
 
 

 
 bq. WeldServletLifecycle Is this class intended to provide a "CDI 2" setup? If you are asking whether this starts Weld, then yes,bq. This method JavaDoc signature is off. The method either throws an error, or returns true.It can return [{{false}} as well|https://github.com/weld/core/blob/d8a8cb64f3a9751dcac07c8d9eda0dd3a0e682b8/environments/servlet/core/src/main/java/org/jboss/weld/environment/servlet/WeldServletLifecycle.java#L164]But you are right that the exception thrown if registration with JSP didn't work isn't documented.bq. ... even though this file is optional accroding to the specs.Note that CDI specification deals with Java EE setup and from 2.0 with SE.Servlet support is not covered and what Weld offers is beyond CDI specification as is said in Weld docs, 18.3. Servlet containers.Anyway, you will need to have {{beans.xml}} present in case of servlet  -  and this should probably be documented in our docs as well. -  EDIT: Actually this is already documented in the end of the aforementioned chapter.  It says: ??In general, an implicit bean archive does not have to contain a beans.xml descriptor. However, such a bean archive is not supported by Weld Servlet, i.e. it’s excluded from discovery.?? bq. When configuring an embedded setup the docs states that "resteasy.injector.factory" isn't needed with v3 container...This isn't Weld doc and we haven't authored or tested that I am afraid.You may want to report this with resteasy guys.bq. The only thing that made Weld to properly work, is to use this gradle source set setup:This part I don't understand. How does this remedy the {{beans.xml}} trouble you had?bq. Looking at AbstractDiscoveryStrategy.java#L119-L139 it appears that as long as there were no beans.xml found (since WebAppBeanArchiveScanner is used), line 138 will never get called.This discovery isn't servlet specific, it is used in EE and SE as well hence not all parts of code and necessarily relevant for servlet environment.bq. P.S there is a repo I setup illustrating my implementation of the stack mentioned here. Thanks, I will glance at it later.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 

[weld-issues] [JBoss JIRA] (WELD-2542) CDI 2 Support with Embedded Setup

2018-11-14 Thread Matej Novotny (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matej Novotny commented on  WELD-2542  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: CDI 2 Support with Embedded Setup   
 

  
 
 
 
 

 
 

WeldServletLifecycle Is this class intended to provide a "CDI 2" setup? 
 If you are asking whether this starts Weld, then yes, 

This method JavaDoc signature is off. The method either throws an error, or returns true.
 It can return false as well But you are right that the exception thrown if registration with JSP didn't work isn't documented. 

... even though this file is optional accroding to the specs.
 Note that CDI specification deals with Java EE setup and from 2.0 with SE. Servlet support is not covered and what Weld offers is beyond CDI specification as is said in Weld docs, 18.3. Servlet containers. Anyway, you will need to have beans.xml present in case of servlet and this should probably be documented in our docs as well. 

When configuring an embedded setup the docs states that "resteasy.injector.factory" isn't needed with v3 container...
 This isn't Weld doc and we haven't authored or tested that I am afraid. You may want to report this with resteasy guys. 

The only thing that made Weld to properly work, is to use this gradle source set setup:
 This part I don't understand. How does this remedy the beans.xml trouble you had? 

Looking at AbstractDiscoveryStrategy.java#L119-L139 it appears that as long as there were no beans.xml found (since WebAppBeanArchiveScanner is used), line 138 will never get called.
 This discovery isn't servlet specific, it is used in EE and SE as well hence not all parts of code and necessarily relevant for servlet environment. 

P.S there is a repo I setup illustrating my implementation of the stack mentioned here. 
 Thanks, I will glance at it later.  
 

  
 
 
 
 

 
 
 

 
 
 

[weld-issues] [JBoss JIRA] (WELD-2541) Should @AroundInvoke apply to mdb methods called by container?

2018-11-14 Thread Matej Novotny (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matej Novotny commented on  WELD-2541  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Should @AroundInvoke apply to mdb methods called by container?   
 

  
 
 
 
 

 
 Hi Xiao Ou Sun, this is, as far as I can tell, not required by specification and was previously not possible due to the way Weld was handling it. Specification only mandates interception of listener methods during message delivery (see here). As part of WELD-2404, we decided to enable this behaviour - so it's not a defect but a feature   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2422) Revisit Weld SPI so that integrators are not required to depend on Weld internals

2018-11-14 Thread Matej Novotny (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matej Novotny updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2422  
 
 
  Revisit Weld SPI so that integrators are not required to depend on Weld internals   
 

  
 
 
 
 

 
Change By: 
 Matej Novotny  
 
 
Fix Version/s: 
 3.1.0.Final  
 
 
Fix Version/s: 
 3.1.x  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2422) Revisit Weld SPI so that integrators are not required to depend on Weld internals

2018-11-14 Thread Matej Novotny (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matej Novotny assigned an issue to Matej Novotny  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2422  
 
 
  Revisit Weld SPI so that integrators are not required to depend on Weld internals   
 

  
 
 
 
 

 
Change By: 
 Matej Novotny  
 
 
Assignee: 
 Matej Novotny  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues