[weld-issues] [JBoss JIRA] (CDITCK-579) CustomBeanImplementationTest relies on unspecified usage of InjectionPoint

2017-05-31 Thread Tomas Remes (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tomas Remes resolved as Done  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 I disabled the test  
 

  
 
 
 
 

 
 CDI TCK /  CDITCK-579  
 
 
  CustomBeanImplementationTest relies on unspecified usage of InjectionPoint   
 

  
 
 
 
 

 
Change By: 
 Tomas Remes  
 
 
Status: 
 Open Resolved  
 
 
Resolution: 
 Done  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (CDITCK-579) CustomBeanImplementationTest relies on unspecified usage of InjectionPoint

2017-05-30 Thread Matej Novotny (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matej Novotny commented on  CDITCK-579  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: CustomBeanImplementationTest relies on unspecified usage of InjectionPoint   
 

  
 
 
 
 

 
 If that's the case, then getMember should get invoked if, for instance, the test first creates an instance of the Foo bean (to enforce injection) and invokes some dummy method on it (in case there is lazy init, not sure how this works in OWB). But I think Tomas tried this and it still didn't work for OWB.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (CDITCK-579) CustomBeanImplementationTest relies on unspecified usage of InjectionPoint

2017-05-30 Thread Mark Struberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mark Struberg commented on  CDITCK-579  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: CustomBeanImplementationTest relies on unspecified usage of InjectionPoint   
 

  
 
 
 
 

 
 Uff, about 30 different usages.  E.g in the InjectionPointProducer, DecoratorInjectionFactory etc But the main use case is probably the InjectionTargetImpl.  
 
 
 
 
 for (InjectionPoint injectionPoint : getInjectionPoints())  
 
 
 {  
 
 
 if (injectionPoint.getMember().getDeclaringClass().equals(type))
  
 
 
 
  This happens in various situations, while injecting fields, members, parameters, etc.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d)  
 
 

 
   
 

  
 

  
 

   


[weld-issues] [JBoss JIRA] (CDITCK-579) CustomBeanImplementationTest relies on unspecified usage of InjectionPoint

2017-05-30 Thread Tomas Remes (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tomas Remes commented on  CDITCK-579  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: CustomBeanImplementationTest relies on unspecified usage of InjectionPoint   
 

  
 
 
 
 

 
 OK so the above suggested approach is not the way to go. I was experimenting with the test little bit and I am not sure it could be tested when it's not clearly defined.  Mark Struberg Just out of curiosity - when OWB call InjectionPoint.getMember() method?   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (CDITCK-579) CustomBeanImplementationTest relies on unspecified usage of InjectionPoint

2017-05-29 Thread Tomas Remes (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tomas Remes commented on  CDITCK-579  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: CustomBeanImplementationTest relies on unspecified usage of InjectionPoint   
 

  
 
 
 
 

 
 Agree again. I would suggest to get Foo reference in the test and obtain its attributes to make sure the CustomInjectionPoint is used.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (CDITCK-579) CustomBeanImplementationTest relies on unspecified usage of InjectionPoint

2017-05-27 Thread Mark Struberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mark Struberg created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 CDI TCK /  CDITCK-579  
 
 
  CustomBeanImplementationTest relies on unspecified usage of InjectionPoint   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 2.0.0.Final  
 
 
Assignee: 
 Tomas Remes  
 
 
Components: 
 Tests  
 
 
Created: 
 27/May/17 12:19 PM  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Mark Struberg  
 

  
 
 
 
 

 
 Not sure why, but CustomBeanImplementationTest#testInjectionPointGetMemberIsUsedToDetermineTheClassThatDeclaresAnInjectionPoint seems to presume that InjectionPoint#getMember() gets triggered during bootstrap. But that is simply not the case in OWB. It's also nowhere defined that this should be.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment