[weld-issues] [JBoss JIRA] (WELD-2338) Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any
Title: Message Title Matej Novotny updated an issue Weld / WELD-2338 Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any Change By: Matej Novotny Git Pull Request: https://github.com/weld/core/pull/1597 , https://github.com/weld/core/pull/1598 Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2338) Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any
Title: Message Title Issue was automatically transitioned when Matej Novotny created pull request #1597 in GitHub Weld / WELD-2338 Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any Change By: Matej Novotny Status: Open Pull Request Sent Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2338) Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any
Title: Message Title Matej Novotny assigned an issue to Matej Novotny Weld / WELD-2338 Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any Change By: Matej Novotny Assignee: Matej Novotny Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2338) Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any
Title: Message Title
Martin Kouba updated an issue
Weld / WELD-2338
Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any
Change By:
Martin Kouba
Right now, the following observers are forbidden cannot be declared *on an extension* :{code:java}void first(@Observes Object foo, Bar bar) {}void second(@Observes @Foo Object foo, Bar bar) {}{code}whereas this one is allowed:{code:java}void third(@Observes Foo foo, Bar bar) {}{code}Note that the *first* observer would be notified even for container lifecycle events and so it's considered a _container lifecycle event observer_. However, the *second* observer is incorrectly considered a _container lifecycle event observer_ too.{{Observers.isContainerLifecycleObserverMethod()}} should return false for an observer with observed type {{java.lang.Object}} and a qualifier other than {{@Any}}.Note that all the above observers are defined as non-portable in the spec. The problem is that extensions can communicate using events and so the required beans may be not discovered/available yet. However, I think Weld should be consistent here. If *third* is allowed, the *second* should be allowed too.
Add Comment
This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d)
[weld-issues] [JBoss JIRA] (WELD-2338) Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any
Title: Message Title Martin Kouba commented on WELD-2338 Re: Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any Ok, so there is no need to add @Default to the issue summary Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2338) Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any
Title: Message Title Antoine Sabot-Durand commented on WELD-2338 Re: Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any agree Martin Kouba Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2338) Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any
Title: Message Title Matej Novotny commented on WELD-2338 Re: Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any Martin Kouba Yes, the only way to notify such observer is to actually fire an event specifically with @Default qualifier. Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2338) Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any
Title: Message Title Martin Kouba commented on WELD-2338 Re: Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any Hm, container lifecycle events are fired with @javax.enterprise.inject.Any and observer is matched if it has no event qualifiers or a subset of the event qualifiers. So if you define void observe(@Observes @Default Object foo, Bar bar) it shouldn't be matched. Do you agree? Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2338) Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any
Title: Message Title Antoine Sabot-Durand commented on WELD-2338 Re: Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any +1, but shouldn't the title be "... qualifier different than @Any or @Default" ? Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2338) Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any
Title: Message Title Martin Kouba updated an issue Weld / WELD-2338 Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any Change By: Martin Kouba Forum Reference: http://lists.jboss.org/pipermail/cdi-dev/2017-February/009604.html Add Comment This message was sent by Atlassian JIRA (v7.2.3#72005-sha1:73be91d) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2338) Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any
Title: Message Title
Martin Kouba created an issue
Weld / WELD-2338
Revise the check of valid injection points for an extension observer method with observed type java.lang.Object and a qualifier other than @Any
Issue Type:
Bug
Assignee:
Unassigned
Created:
17/Feb/17 6:53 AM
Priority:
Major
Reporter:
Martin Kouba
Right now, the following observers are forbidden:
void first(@Observes Object foo, Bar bar) {
}
void second(@Observes @Foo Object foo, Bar bar) {
}
whereas this one is allowed:
void third(@Observes Foo foo, Bar bar) {
