[weld-issues] [JBoss JIRA] (WELD-2474) Weld is still using CDI 2.0 literal implementations in several places

2018-03-20 Thread Martin Kouba (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Kouba created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2474  
 
 
  Weld is still using CDI 2.0 literal implementations in several places   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 3.0.3.Final  
 
 
Assignee: 
 Matej Novotny  
 
 
Created: 
 20/Mar/18 11:48 AM  
 
 
Fix Versions: 
 3.0.4.Final  
 
 
Priority: 
  Critical  
 
 
Reporter: 
 Martin Kouba  
 

  
 
 
 
 

 
 There are some places where it does not matter (e.g. BeanAttributesConfiguratorImpl#removeDefaultQualifierIfNeeded) but others (.e.g. org.jboss.weld.util.Observers#isContainerLifecycleObserverMethod()) may result in NoClassDefFoundError. I think we should be consistent and only use Weld literals for now.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 

[weld-issues] [JBoss JIRA] (WELD-2474) Weld is still using CDI 2.0 literal implementations in several places

2018-03-20 Thread Martin Kouba (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Kouba updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2474  
 
 
  Weld is still using CDI 2.0 literal implementations in several places   
 

  
 
 
 
 

 
Change By: 
 Martin Kouba  
 
 
Priority: 
 Critical Major  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2474) Weld is still using CDI 2.0 literal implementations in several places

2018-03-21 Thread Martin Kouba (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Kouba commented on  WELD-2474  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Weld is still using CDI 2.0 literal implementations in several places   
 

  
 
 
 
 

 
 This particular check is only performed if an extension declares an observer method like @Observes Object event.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2474) Weld is still using CDI 2.0 literal implementations in several places

2018-03-21 Thread Matej Novotny (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matej Novotny commented on  WELD-2474  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Weld is still using CDI 2.0 literal implementations in several places   
 

  
 
 
 
 

 
 Back there I recall I was {{grep}}ing through the code and I left some of these in place for I thought them harmless (they were in tests for the most part). But I wonder how come all the tests pass with org.jboss.weld.util.Observers#isContainerLifecycleObserverMethod()) using CDI literals? This should be used in every OM check, right?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2474) Weld is still using CDI 2.0 literal implementations in several places

2018-03-22 Thread Matej Novotny (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matej Novotny updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2474  
 
 
  Weld is still using CDI 2.0 literal implementations in several places   
 

  
 
 
 
 

 
Change By: 
 Matej Novotny  
 
 
Git Pull Request: 
 https://github.com/weld/core/pull/1806  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2474) Weld is still using CDI 2.0 literal implementations in several places

2018-03-22 Thread Martin Kouba (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Kouba resolved as Done  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2474  
 
 
  Weld is still using CDI 2.0 literal implementations in several places   
 

  
 
 
 
 

 
Change By: 
 Martin Kouba  
 
 
Status: 
 Open Resolved  
 
 
Resolution: 
 Done  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues