[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title Vsevolod Golovanov created an issue Weld / WELD-2512 cid not appended to action URLs if there is already a parameter with a name ending with "cid" Issue Type: Bug Affects Versions: 2.3.5.Final Assignee: Unassigned Components: Web Tier integration (JSF, JSP, EL and Servlet) Created: 22/Jun/18 4:15 PM Environment: Wildlfly 10 Priority: Major Reporter: Vsevolod Golovanov FacesUrlTransformer looks for "cid=" in the action URL without checking word boundary. PrimeFaces' Dialog Framework has its own context propagation, so it adds a "pfdlgcid=..." parameter. FacesUrlTransformer sees "pfdlgcid=" and thinks that it doesn't need to do anything, thus breaking CDI conversation propagation. Add Comment
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title Vsevolod Golovanov updated an issue Weld / WELD-2512 cid not appended to action URLs if there is already a parameter with a name ending with "cid" Change By: Vsevolod Golovanov FacesUrlTransformer looks for "cid=" in the action URL without checking word boundary.PrimeFaces' Dialog Framework has its own context propagation, so to that end it adds a "pfdlgcid=..." parameter.FacesUrlTransformer sees "pfdlgcid=" and thinks that it doesn't need to do anything, thus breaking CDI conversation propagation. Add Comment This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title Vsevolod Golovanov commented on WELD-2512 Re: cid not appended to action URLs if there is already a parameter with a name ending with "cid" Workaround: reposition PrimeFaces' DialogViewHandler to be above ConversationAwareViewHandler in the view handler chain. You need to have ordering defined in faces-config.xml, otherwise the view handler order could be different each boot. (This could be complicated because wildfly-jsf-injection doesn't have name defined.) Add Comment This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title
Vsevolod Golovanov edited a comment on WELD-2512
Re: cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Workaround: reposition PrimeFaces' DialogViewHandler to be above ConversationAwareViewHandler in the view handler chain.You need to have ordering defined in faces-config.xml, otherwise the view handler order could be different each boot. (This could be complicated because wildfly-jsf-injection doesn't have {{name}} defined - WFLY-10628 .)
Add Comment
This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849)
___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title Martin Kouba updated an issue Weld / WELD-2512 cid not appended to action URLs if there is already a parameter with a name ending with "cid" Change By: Martin Kouba Fix Version/s: 3.0.5.Final Add Comment This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title Matej Novotny commented on WELD-2512 Re: cid not appended to action URLs if there is already a parameter with a name ending with "cid" Thanks for report. How do you imagine we should fix this? We cannot know what will the parameter look like hence we assume the basic one is present. Looking for any parameter which end with "cid" is just too risky as you introduce false positives. Add Comment This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title Martin Kouba commented on WELD-2512 Re: cid not appended to action URLs if there is already a parameter with a name ending with "cid" I believe that the issue is that FacesUrlTransformer is looking for cid= and thus primefaces' pfdlgcid is also matched. So the FacesUrlTransformer should probably look for ?cid= and &cid= instead. The truth is that those delimiters are probably not standardized, i.e. a web server may allow different query string param delimiters, but it should work in most cases. Add Comment This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title Matej Novotny commented on WELD-2512 Re: cid not appended to action URLs if there is already a parameter with a name ending with "cid" Oh right, I see. Guess I was reading it too quickly. Add Comment This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title Matej Novotny updated an issue Weld / WELD-2512 cid not appended to action URLs if there is already a parameter with a name ending with "cid" Change By: Matej Novotny Git Pull Request: https://github.com/weld/core/pull/1847 Add Comment This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title Matej Novotny assigned an issue to Matej Novotny Weld / WELD-2512 cid not appended to action URLs if there is already a parameter with a name ending with "cid" Change By: Matej Novotny Assignee: Matej Novotny Add Comment This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title Vsevolod Golovanov commented on WELD-2512 Re: cid not appended to action URLs if there is already a parameter with a name ending with "cid" Also there is a less commongly used third delimiter - semicolon. It's equivalent to ampersand. https://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 Add Comment This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title
Vsevolod Golovanov edited a comment on WELD-2512
Re: cid not appended to action URLs if there is already a parameter with a name ending with "cid"
You've hardcoded "cid" in the PR. Weld allows configuring this parameter name, that's why there is a ` {{ cidParameterName ` }} argument passed around.
Add Comment
This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849)
___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title Vsevolod Golovanov commented on WELD-2512 Re: cid not appended to action URLs if there is already a parameter with a name ending with "cid" You've hardcoded "cid" in the PR. Weld allows configuring this parameter name, that's why there is a `cidParameterName` argument passed around. Add Comment This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title Martin Kouba commented on WELD-2512 Re: cid not appended to action URLs if there is already a parameter with a name ending with "cid" Vsevolod Golovanov These are good points! In any case, don't hesitate to add comments directly to the PR... Add Comment This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title Matej Novotny commented on WELD-2512 Re: cid not appended to action URLs if there is already a parameter with a name ending with "cid" Vsevolod Golovanov thanks! Should be corrected now. Add Comment This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2512) cid not appended to action URLs if there is already a parameter with a name ending with "cid"
Title: Message Title Martin Kouba resolved as Done Weld / WELD-2512 cid not appended to action URLs if there is already a parameter with a name ending with "cid" Change By: Martin Kouba Status: Open Resolved Resolution: Done Add Comment This message was sent by Atlassian JIRA (v7.5.0#75005-sha1:fd8c849) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
