[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title Matej Novotny updated WELD-2556 Weld / WELD-2556 Draft new SPI for defining classes that will delegate to integrator implementations Change By: Matej Novotny Status: Pull Request Sent Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title Issue was automatically transitioned when Matej Novotny created pull request #83 in GitHub Weld / WELD-2556 Draft new SPI for defining classes that will delegate to integrator implementations Change By: Matej Novotny Status: Open Pull Request Sent Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title Matej Novotny updated an issue Weld / WELD-2556 Draft new SPI for defining classes that will delegate to integrator implementations Change By: Matej Novotny Git Pull Request: https://github.com/weld/api/pull/83, https://github.com/weld/core/pull/1888 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title Matej Novotny updated an issue Weld / WELD-2556 Draft new SPI for defining classes that will delegate to integrator implementations Change By: Matej Novotny Labels: jdk12 Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title
Matej Novotny updated an issue
Weld / WELD-2556
Draft new SPI for defining classes that will delegate to integrator implementations
Change By:
Matej Novotny
We need to introduce new SPI that integrators implement and that will allow us to delegate class creation to them as opposed to current state where we just ask for proper {{ClassLoader}}.Current approach requires us to crack open CL's {{defineClass()}} methods which won't really work on JDK 12. Integrators can provide their own privileged CLs which won't have these problems.The idea is to introduce a new interface {{WeldClassDefiner}} (name is just a suggestion) which would have several methods with same signature as seen on CL. Namely we need two variations of {{defineClass()}} plus {{loadClass()}}. With that in place, {{ProxyServives}} could have a {{getClassDefiner()}} method returning the implementation. This approach will likely be requires on JDK 12.On WFLY side, the implementation will leverage [ {{ClassDefiner}} |https://github.com/jboss-modules/jboss-modules/blob/1.x/src/main/java/org/jboss/modules/ClassDefiner.java] which is part of jboss-modules.
Add Comment
This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505)
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title Matej Novotny updated an issue Weld / WELD-2556 Draft new SPI for defining classes that will delegate to integrator implementations Change By: Matej Novotny Fix Version/s: 3.1.0.Final Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title Matej Novotny assigned an issue to Matej Novotny Weld / WELD-2556 Draft new SPI for defining classes that will delegate to integrator implementations Change By: Matej Novotny Assignee: Matej Novotny Add Comment This message was sent by Atlassian Jira (v7.12.1#712002-sha1:609a505) ___ weld-issues mailing list weld-issues@lists.jboss.org https://lists.jboss.org/mailman/listinfo/weld-issues
[weld-issues] [JBoss JIRA] (WELD-2556) Draft new SPI for defining classes that will delegate to integrator implementations
Title: Message Title Matej Novotny created an issue Weld / WELD-2556 Draft new SPI for defining classes that will delegate to integrator implementations Issue Type: Enhancement Affects Versions: 3.1.0.Beta1 Assignee: Unassigned Components: Proxies Created: 09/Jan/19 9:44 AM Priority: Major Reporter: Matej Novotny We need to introduce new SPI that integrators implement and that will allow us to delegate class creation to them as opposed to current state where we just ask for proper ClassLoader. Current approach requires us to crack open CL's defineClass() methods which won't really work on JDK 12. Integrators can provide their own privileged CLs which won't have these problems. The idea is to introduce a new interface WeldClassDefiner (name is just a suggestion) which would have several methods with same signature as seen on CL. Namely we need two variations of defineClass() plus loadClass(). With that in place, ProxyServives could have a getClassDefiner() method returning the implementation. This approach will likely be requires on JDK 12. On WFLY side, the implementation will leverage ClassDefiner which is part of jboss-modules.
