[weld-issues] [JBoss JIRA] (WELD-2631) Cleanup leftover HttpSessionDestructionContext when starting new session context

2020-08-03 Thread Jira
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matěj Novotný updated  WELD-2631  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2631  
 
 
  Cleanup leftover HttpSessionDestructionContext when starting new session context   
 

  
 
 
 
 

 
Change By: 
 Matěj Novotný  
 
 
Status: 
 Pull Request Sent Resolved  
 
 
Resolution: 
 Done  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.8#713008-sha1:1606a5c)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2631) Cleanup leftover HttpSessionDestructionContext when starting new session context

2020-08-03 Thread Jira
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matěj Novotný commented on  WELD-2631  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Cleanup leftover HttpSessionDestructionContext when starting new session context   
 

  
 
 
 
 

 
 PRs were merged, this will land in WFLY whenever it updates to Weld 3.1.5+.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.8#713008-sha1:1606a5c)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2631) Cleanup leftover HttpSessionDestructionContext when starting new session context

2020-07-22 Thread Jira
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matěj Novotný updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2631  
 
 
  Cleanup leftover HttpSessionDestructionContext when starting new session context   
 

  
 
 
 
 

 
Change By: 
 Matěj Novotný  
 
 
Git Pull Request: 
 https://github.com/weld/core/pull/2005 , https://github.com/weld/core/pull/2006  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.8#713008-sha1:1606a5c)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2631) Cleanup leftover HttpSessionDestructionContext when starting new session context

2020-07-22 Thread Jira
Title: Message Title


 
 
 
 

 
 
 

 
   
 Issue was automatically transitioned when Matěj Novotný created pull request #2005 in GitHub  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2631  
 
 
  Cleanup leftover HttpSessionDestructionContext when starting new session context   
 

  
 
 
 
 

 
Change By: 
 Matěj Novotný  
 
 
Status: 
 Open Pull Request Sent  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.8#713008-sha1:1606a5c)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2631) Cleanup leftover HttpSessionDestructionContext when starting new session context

2020-07-22 Thread Jira
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matěj Novotný updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2631  
 
 
  Cleanup leftover HttpSessionDestructionContext when starting new session context   
 

  
 
 
 
 

 
Change By: 
 Matěj Novotný  
 
 
Git Pull Request: 
 https://github.com/weld/core/pull/2005  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.8#713008-sha1:1606a5c)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2631) Cleanup leftover HttpSessionDestructionContext when starting new session context

2020-07-22 Thread Jira
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matěj Novotný created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2631  
 
 
  Cleanup leftover HttpSessionDestructionContext when starting new session context   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 4.0.0.Alpha3, 3.1.4.Final  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 Scopes & Contexts  
 
 
Created: 
 22/Jul/20 6:31 AM  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Matěj Novotný  
 

  
 
 
 
 

 
 Related to WFLY-12815.   In a scenario where session timeouts (meaning we use HttpSessionDestructionContext) and there are lifecycle listeners for session destruction that throw an exception, your listener won't get called and the context will stay active on that thread. This means that any subsequent usage of this thread for session will blow up with multiple active contexts for given scope.   What we can do is to check, on session context activation, for any leftover destruction context and clear that up plus do some logging. In theory this should be safe as I cannot imagine a situation where a leftover active destruction context would be intentional. It won't be perfect solution, but it is more robust than what we have now.   An automated test is probably not viable as we would need to "corrupt" all thread in WFLY to be able to reliably achieve the faulty state. Hence I will put together a PR, test that against our TS, then WFLY TS and ask the original reported to verify as well.  
 

  
 
 
 
 

 
 
  

[weld-issues] [JBoss JIRA] (WELD-2631) Cleanup leftover HttpSessionDestructionContext when starting new session context

2020-07-22 Thread Jira
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matěj Novotný assigned an issue to Matěj Novotný  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2631  
 
 
  Cleanup leftover HttpSessionDestructionContext when starting new session context   
 

  
 
 
 
 

 
Change By: 
 Matěj Novotný  
 
 
Assignee: 
 Matěj Novotný  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.8#713008-sha1:1606a5c)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues

[weld-issues] [JBoss JIRA] (WELD-2631) Cleanup leftover HttpSessionDestructionContext when starting new session context

2020-07-22 Thread Jira
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matěj Novotný updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Weld /  WELD-2631  
 
 
  Cleanup leftover HttpSessionDestructionContext when starting new session context   
 

  
 
 
 
 

 
Change By: 
 Matěj Novotný  
 
 
Fix Version/s: 
 3.1.5.Final  
 
 
Fix Version/s: 
 4.0.0.Alpha4  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.8#713008-sha1:1606a5c)  
 
 

 
   
 

  
 

  
 

   

___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues