[weld-issues] [JBoss JIRA] Commented: (WELD-919) Conversation propagation token that negates the cid parameter

2011-06-09 Thread Nicklas Karlsson (JIRA)

[ 
https://issues.jboss.org/browse/WELD-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12607403#comment-12607403
 ] 

Nicklas Karlsson commented on WELD-919:
---

Of course, this could be expanded in Seam2-style to name the parameter 
conversationPropagation and have values of none and end to differ between 
just abandoning the conversation and ending it. 

 Conversation propagation token that negates the cid parameter
 ---

 Key: WELD-919
 URL: https://issues.jboss.org/browse/WELD-919
 Project: Weld
  Issue Type: Feature Request
  Components: Conversations
Affects Versions: 1.1.1.Final
Reporter: Nicklas Karlsson
Assignee: Ales Justin
 Fix For: 1.1.2.Final


 A method that negates the propagation of the cid parameter by the 
 ConversationAwareViewHandler so that a non-transient is not resumed even if 
 there is a cid parameter in the request. Stripping it out on a 
 per-component-basis is tricky.
 Suggested implementation: change the last line in 
 WeldPhaseListener.getConversationId to
 return 
 facesContext.getExternalContext().getRequestParameterMap().containsKey(nocid)
  ? null : cid;

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues


[weld-issues] [JBoss JIRA] Commented: (WELD-919) Conversation propagation token that negates the cid parameter

2011-06-09 Thread Ales Justin (JIRA)

[ 
https://issues.jboss.org/browse/WELD-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12607408#comment-12607408
 ] 

Ales Justin commented on WELD-919:
--

What would be the diff between none and end in this case?


 Conversation propagation token that negates the cid parameter
 ---

 Key: WELD-919
 URL: https://issues.jboss.org/browse/WELD-919
 Project: Weld
  Issue Type: Feature Request
  Components: Conversations
Affects Versions: 1.1.1.Final
Reporter: Nicklas Karlsson
Assignee: Ales Justin
 Fix For: 1.1.2.Final


 A method that negates the propagation of the cid parameter by the 
 ConversationAwareViewHandler so that a non-transient is not resumed even if 
 there is a cid parameter in the request. Stripping it out on a 
 per-component-basis is tricky.
 Suggested implementation: change the last line in 
 WeldPhaseListener.getConversationId to
 return 
 facesContext.getExternalContext().getRequestParameterMap().containsKey(nocid)
  ? null : cid;

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues


[weld-issues] [JBoss JIRA] Commented: (WELD-919) Conversation propagation token that negates the cid parameter

2011-06-09 Thread Ales Justin (JIRA)

[ 
https://issues.jboss.org/browse/WELD-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12607420#comment-12607420
 ] 

Ales Justin commented on WELD-919:
--

Do we really want to push this kind of logic into WeldPhaseListener?


 Conversation propagation token that negates the cid parameter
 ---

 Key: WELD-919
 URL: https://issues.jboss.org/browse/WELD-919
 Project: Weld
  Issue Type: Feature Request
  Components: Conversations
Affects Versions: 1.1.1.Final
Reporter: Nicklas Karlsson
Assignee: Ales Justin
 Fix For: 1.1.2.Final


 A method that negates the propagation of the cid parameter by the 
 ConversationAwareViewHandler so that a non-transient is not resumed even if 
 there is a cid parameter in the request. Stripping it out on a 
 per-component-basis is tricky.
 Suggested implementation: change the last line in 
 WeldPhaseListener.getConversationId to
 return 
 facesContext.getExternalContext().getRequestParameterMap().containsKey(nocid)
  ? null : cid;

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues


[weld-issues] [JBoss JIRA] Commented: (WELD-919) Conversation propagation token that negates the cid parameter

2011-06-09 Thread Pete Muir (JIRA)

[ 
https://issues.jboss.org/browse/WELD-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12607435#comment-12607435
 ] 

Pete Muir commented on WELD-919:


Nik, make sure you add a CDI feature request as well.

 Conversation propagation token that negates the cid parameter
 ---

 Key: WELD-919
 URL: https://issues.jboss.org/browse/WELD-919
 Project: Weld
  Issue Type: Feature Request
  Components: Conversations
Affects Versions: 1.1.1.Final
Reporter: Nicklas Karlsson
Assignee: Ales Justin
 Fix For: 1.1.2.Final


 A method that negates the propagation of the cid parameter by the 
 ConversationAwareViewHandler so that a non-transient is not resumed even if 
 there is a cid parameter in the request. Stripping it out on a 
 per-component-basis is tricky.
 Suggested implementation: change the last line in 
 WeldPhaseListener.getConversationId to
 return 
 facesContext.getExternalContext().getRequestParameterMap().containsKey(nocid)
  ? null : cid;

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


___
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues