[Wengophone-devel] some thoughts on submitting patches
Hi!
After the (first) patchset I've submitted on this list for openwengo
I was looking around for some guidelines on how to submit patches
correctly.
I was not able to find any information about submitting patches
neither in the openwengo-wiki nor in the archives of the
mailling-list. Did I miss something?
If found some guides from other projects:
[1] http://kerneltrap.org/Linux/Email_Clients_and_Patches
[2] http://winmerge.org/Wiki/Submit_Patch
[3] http://www.linuxfromscratch.org/patches/submit.html
[4]
http://sunsite.ualberta.ca/Documentation/Misc/perl-5.6.1/Porting/patching.html
In fact they can be summed up by these questions:
- How to create the patch?
- What should be the filename of the patch?
- How is the patch submitted?
The first question should be easy to answer:
- Use svn diff or create a patch with TortoiseSVN (or even use diff
-u)
The second question is not that easy. My suggestion (if anybody
cares):
- {OrigFilename}_r{svnrevision}_{patchName}-{patchVersion}.diff|patch
The third question is also not as easy as it seems:
As Attachment?
* gzipped?
* zipped?
* text?
Inline?
What should be the subject?
[PATCH] - {OrigFilename}_r{svnrevision}_{patchName}-{patchVersion}
I also like the idea of [3] of adding a patch header on each patch,
but I may be wrong.
What do you maintainer and longtime contributors think? Is that too
much overkill or would you like to stick to some guidelines? I would
love to hear your opinions. Thank you!
Greetings,
- Darsha
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] some thoughts on submitting patches
Hi,
I think it is better to submit is as an attachment because mail programs
has an effect on the file.
Chris
On Jan 31, 2008 1:33 AM, Darshaka Pathirana [EMAIL PROTECTED] wrote:
Hi!
After the (first) patchset I've submitted on this list for openwengo
I was looking around for some guidelines on how to submit patches
correctly.
I was not able to find any information about submitting patches
neither in the openwengo-wiki nor in the archives of the
mailling-list. Did I miss something?
If found some guides from other projects:
[1] http://kerneltrap.org/Linux/Email_Clients_and_Patches
[2] http://winmerge.org/Wiki/Submit_Patch
[3] http://www.linuxfromscratch.org/patches/submit.html
[4]
http://sunsite.ualberta.ca/Documentation/Misc/perl-5.6.1/Porting/patching.html
In fact they can be summed up by these questions:
- How to create the patch?
- What should be the filename of the patch?
- How is the patch submitted?
The first question should be easy to answer:
- Use svn diff or create a patch with TortoiseSVN (or even use diff
-u)
The second question is not that easy. My suggestion (if anybody
cares):
- {OrigFilename}_r{svnrevision}_{patchName}-{patchVersion}.diff|patch
The third question is also not as easy as it seems:
As Attachment?
* gzipped?
* zipped?
* text?
Inline?
What should be the subject?
[PATCH] - {OrigFilename}_r{svnrevision}_{patchName}-{patchVersion}
I also like the idea of [3] of adding a patch header on each patch,
but I may be wrong.
What do you maintainer and longtime contributors think? Is that too
much overkill or would you like to stick to some guidelines? I would
love to hear your opinions. Thank you!
Greetings,
- Darsha
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] some thoughts on submitting patches
Darshaka Pathirana wrote:
Hi!
After the (first) patchset I've submitted on this list for openwengo
I was looking around for some guidelines on how to submit patches
correctly.
I was not able to find any information about submitting patches
neither in the openwengo-wiki nor in the archives of the
mailling-list. Did I miss something?
If found some guides from other projects:
[1] http://kerneltrap.org/Linux/Email_Clients_and_Patches
[2] http://winmerge.org/Wiki/Submit_Patch
[3] http://www.linuxfromscratch.org/patches/submit.html
[4]
http://sunsite.ualberta.ca/Documentation/Misc/perl-5.6.1/Porting/patching.html
In fact they can be summed up by these questions:
- How to create the patch?
- What should be the filename of the patch?
- How is the patch submitted?
The first question should be easy to answer:
- Use svn diff or create a patch with TortoiseSVN (or even use diff
-u)
The second question is not that easy. My suggestion (if anybody
cares):
- {OrigFilename}_r{svnrevision}_{patchName}-{patchVersion}.diff|patch
The third question is also not as easy as it seems:
As Attachment?
* gzipped?
* zipped?
* text?
Inline?
What should be the subject?
[PATCH] - {OrigFilename}_r{svnrevision}_{patchName}-{patchVersion}
I also like the idea of [3] of adding a patch header on each patch,
but I may be wrong.
What do you maintainer and longtime contributors think? Is that too
much overkill or would you like to stick to some guidelines? I would
love to hear your opinions. Thank you!
Greetings,
- Darsha
Folks as we're going to to switch to mercuririal i suggest you read:
http://www.selenic.com/mercurial/wiki/index.cgi/PatchbombExtension
I think it will be the best way to submit the patches for review
Thanks
Vadim
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
Re: [Wengophone-devel] some thoughts on submitting patches
Darshaka Pathirana wrote:
Hi!
Hello,
- How to create the patch?
svn diff file foo.patch
if you fix a bug in N source files of a module use.
svn diff file..fileN foo.patch
Don't submit everything as one big patch.
- What should be the filename of the patch?
I name them after the subject.
fix_gcc43_warnings.patch for example
- How is the patch submitted?
Attach them to a bug or add them as an attachement to an email.
The first question should be easy to answer:
- Use svn diff or create a patch with TortoiseSVN (or even use diff
-u)
The second question is not that easy. My suggestion (if anybody
cares):
- {OrigFilename}_r{svnrevision}_{patchName}-{patchVersion}.diff|patch
The third question is also not as easy as it seems:
As Attachment?
attachement
What should be the subject?
[PATCH] - {OrigFilename}_r{svnrevision}_{patchName}-{patchVersion}
[PATCH] - Subject of the patch
Git has a special approach for commit messages, I think it is the same for hg.
The first line is a summary of the patch, max 60 chars. Then an empty line and
a description of the patch.
I also like the idea of [3] of adding a patch header on each patch,
but I may be wrong.
Yes, this makes it easier for the reviewer. I do that normally. With git you do
git-format-patch origin/master
and you get what you want. I hope hg can do the same.
What do you maintainer and longtime contributors think? Is that too
much overkill or would you like to stick to some guidelines? I would
love to hear your opinions. Thank you!
git does everything which you asked for. Hopefully hg behaves the same. The
important thing is that you write good commit messages.
Greetings,
- Darsha
-- andreas
--
http://www.cynapses.org/ - cybernetic synapses
signature.asc
Description: OpenPGP digital signature
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
