[Wesnoth-bugs] [patch #4596] add a number box widget for numerical input

2014-03-10 Thread Sebastia Kölle 
URL:
  

 Summary: add a number box widget for numerical input
 Project: Battle for Wesnoth
Submitted by: aquileia
Submitted on: Mo 10 Mär 2014 15:17:37 UTC
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

The first of three widgets I hope to implement:
1. number box
2. spinner (number box with increment and decrement buttons)
3. vertical slider

The code isn't tested yet because I have no building environment.



___

File Attachments:


---
Date: Mo 10 Mär 2014 15:17:37 UTC  Name:
0001-add-a-number-box-widget-for-numerical-input.patch  Size: 16kB   By:
aquileia



___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [patch #4596] add a number box widget for numerical input

2014-03-10 Thread Sebastia Kölle 
Additional Item Attachment, patch #4596 (project wesnoth):

File name: 0001-Update-syntax-highlighting-for-vim-and-emacs.patch Size:3 KB


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [patch #4596] add a number box widget for numerical input

2014-03-10 Thread Sebastia Kölle 
Follow-up Comment #1, patch #4596 (project wesnoth):

There is one thing that remains to be tested... if you delete the last digit
so that the box reads "", will it default to 0 or ignore you? I couldn't
figure out by looking at the code of lexical_cast, so testing seems the
easiest way to verify it works.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [patch #4596] add a number box widget for numerical input

2014-03-10 Thread Sebastia Kölle 
Follow-up Comment #2, patch #4596 (project wesnoth):

Next time I'll grep all of Wesnoth, not only src...

I always wondered whether the integer_selector interface allows to
automatically transmit the tag keys - now I know it doesn't and I just didn't
find the code where it's actually done.

(file #20301)
___

Additional Item Attachment:

File name: 0001-num_box-connecting-tag-and-widget.patch Size:4 KB


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [patch #4596] add a number box widget for numerical input

2014-03-11 Thread Sebastia Kölle 
Additional Item Attachment, patch #4596 (project wesnoth):

File name: 0001-fix-num_box-and-its-documentation.patch Size:2 KB


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [patch #4596] add a number box widget for numerical input

2014-03-11 Thread Sebastia Kölle 
Additional Item Attachment, patch #4596 (project wesnoth):

File name: 0001-num-box-add-support-for-up-down-arrows.patch Size:1 KB


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [patch #4596] add a number box widget for numerical input

2014-03-12 Thread Sebastia Kölle 
Follow-up Comment #4, patch #4596 (project wesnoth):

Thanks for testing!

I merged the three tag lists (adding 4 entries to lipk's list) and added
another patch for Vim.

I also added the indentation of some macros in lobby_main that lipk's grep
pointed to. I can easily exclude these changes from the final patch if they
are unwanted.

(file #20310)
___

Additional Item Attachment:

File name: 0001-more-GUI-tags-for-Vim-syntax-highlighting.patch Size:4 KB


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [patch #4596] add a number box widget for numerical input

2014-03-12 Thread Sebastia Kölle 
Follow-up Comment #6, patch #4596 (project wesnoth):

I fixed both num_box and the vim file locally, but I want to get Wesnoth
compiled before uploading a patch (right now the link command needs zlib).
I'll do that on Friday.

Please wait with reviewing for the update.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [patch #4596] add a number box widget for numerical input

2014-03-14 Thread Sebastia Kölle 
Follow-up Comment #7, patch #4596 (project wesnoth):

For paste_selection, I'd need some feedback from mordante... but everything
else should work.

(file #20323, file #20324, file #20325)
___

Additional Item Attachment:

File name: 0001-new-GUI2-widget-num_box.patch Size:20 KB
File name: 0002-add-GUI-tag-list-for-Vim-syntax-highlighting.patch Size:3 KB
File name: 0003-minor-fixes-in-the-wake-of-creating-number_box.patch Size:2 KB


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [patch #4596] add a number box widget for numerical input

2014-03-14 Thread Sebastia Kölle 
Follow-up Comment #8, patch #4596 (project wesnoth):

I made this patch a pull request on GitHub as all issues I know of are
solved.

https://github.com/wesnoth/wesnoth/pull/117

(file #20332, file #20333, file #20334)
___

Additional Item Attachment:

File name: 0005-new-GUI2-widget-num_box.patch Size:13 KB
File name: 0006-register-num_box-for-compilation-syntax.patch Size:7 KB
File name: 0008-Switch-the-order-of-variables-in-num_box.hpp.patch Size:0 KB


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #21915] resolution settings in windowed mode incorrect

2014-04-15 Thread Sebastia Kölle 
URL:
  

 Summary: resolution settings in windowed mode incorrect
 Project: Battle for Wesnoth
Submitted by: aquileia
Submitted on: Mi 16 Apr 2014 00:03:46 UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: User Interface
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 1.13 dev
Operating System: Windows 7

___

Details:

On Windows in windowed mode, the resolution setting via the preferences menu
is faulty: The resulting resolution is decisively smaller than the selected
one.

Examples for this behavior:
1366x768 --> xwindowsize=800, ywindowsize=600
1360x768 --> xwindowsize=640, ywindowsize=480
1280x768 --> preferences file unchanged if reduced, 512x438 if increased
1280x720 --> xwindowsize=640, ywindowsize=400
1280x600 --> xwindowsize=400, ywindowsize=300

A possible cause for this could be commit eef30804a49.




___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #21915] resolution settings in windowed mode incorrect

2014-04-16 Thread Sebastia Kölle 
Follow-up Comment #1, bug #21915 (project wesnoth):

Found the commit that causes this bug by locally reverting it:
04eea8963

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #13248] glitch in preference menu

2014-04-19 Thread Sebastia Kölle 
Follow-up Comment #2, bug #13248 (project wesnoth):

Solved with ellipsis truncate as of version 1.11.9.

Longer entries are displayed on mouse over, which means #19482 is fixed as
well.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #19482] Advanced options field is too wide in russian version

2014-04-19 Thread Sebastia Kölle 
Follow-up Comment #4, bug #19482 (project wesnoth):

Solved with ellipsis truncate as of version 1.11.9.
Longer entries are displayed on mouse over.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #13333] Text Input Crashes Wesnoth

2014-04-19 Thread Sebastia Kölle 
Follow-up Comment #10, bug #1 (project wesnoth):

The only GUI1 textbox I could find (MP Configuration: Name of game) works fine
on Windows.

[text_input] has no overflow issues either.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #17141] the eastern envasion. Evacuation scenario ending bug

2014-04-19 Thread Sebastia Kölle 
Follow-up Comment #5, bug #17141 (project wesnoth):

Fixed in 9a2158cd642ae by zookeeper.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #13248] glitch in preference menu

2014-04-26 Thread Sebastia Kölle 
Follow-up Comment #3, bug #13248 (project wesnoth):

As shadowm pointed out, there remains an issue with wide glyphs: For certain
languages, the truncation won't apply before the end of the listbox leading to
a similar problem where the scrollbar is shifted out of the menu to make place
for the wider glyphs.

(file #20584)
___

Additional Item Attachment:

File name: listbox truncation.png Size:165 KB


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #13248] glitch in preference menu

2014-04-26 Thread Sebastia Kölle 
Follow-up Comment #4, bug #13248 (project wesnoth):

It seems I misunderstood shadowm:

"The issue with Russian isn't caused by wide glyphs, [...] it's caused by wide
strings in the other listbox, the one implementing the pagination menu at the
left.
The pagination menu takes up extra space and the advanced preferences listbox
layout goes wrong as a result of an interaction with the dialog constraints."

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #22265] Game crashes after main menu

2014-07-06 Thread Sebastia Kölle 
Follow-up Comment #3, bug #22265 (project wesnoth):

AI0867 already has a fix for this, but the problem is - if we fix it for
Windows, another platform (Pandora) won't work.

The Windows maintainer offered to use the fix specifically for his builds, but
I forgot to reply to him...

The bug is triggered if the path to Wesnoth (or the userdata directory)
contains non-ASCII characters. To work around that, you have to install e.g.
directly in C:Wesnoth and deselect the option to save userdata in your Games
directory.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #23374] THoT Angarthing inspire level 3 description not used

2015-03-21 Thread Sebastia Kölle 
Update of bug #23374 (project wesnoth):

  Status:Works For Me => Fixed  

___

Follow-up Comment #5:

Help topics are created by name, not by id (which would be the same anyhow).
Fixed in master by rewriting the inspire description to be generic.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #14011] Map Editor cannot browse to a different drive

2015-08-09 Thread Sebastia Kölle 
Update of bug #14011 (project wesnoth):

  Status:   Confirmed => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #2:

Tested on 1.12.1, typing in 'D:\' allows to browse that drive and load maps
from it.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #21769] Windows installer incorrectly forces end-users to accept GPL

2015-08-15 Thread Sebastia Kölle 
Update of bug #21769 (project wesnoth):

  Status:None => Fixed  

___

Follow-up Comment #2:

Removed the "you have to accept [...] to continue" text and changed the button
text to "$(^NextBtn)", which is a NSIS LangString and thus localized.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #21891] [regression] Incorrect save folder on Windows

2015-10-27 Thread Sebastia Kölle 
Update of bug #21891 (project wesnoth):

  Status:None => Wont Fix   

___

Follow-up Comment #7:

As wedge009 commented, the development team decided to continue using 'My
Games'
a) Wesnoth isn't the only game to use that directory, see e.g. Skyrim.
b) displaying a localized name via a hidden desktop.ini file isn't too hard;
however we deemed it could potentially confuse players of aforementioned other
games.

If the 'My Games' folder really is an eyesore to you, you can edit your
Wesnoth shortcut in the start menu and add
--userconfig-dir D:/Users/abeau/Saved Games/Wesnoth1.12

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24519] Windows installer displays wrong version of GPL for some languages

2016-03-21 Thread Sebastia Kölle 
Follow-up Comment #5, bug #24519 (project wesnoth):

Well, Wesnoth is licensed under GPL v2+, that is "version 2 or higher". Back
when I added licence translations, I simply used the right to re-distribute
under version 3 to help the readers of these three languages.

As the GPL doesn't bind the end user anyhow (that's why the button no longer
reads "Agree" but "Next") it's basically irrelevant whether we display v2 or
v3 in the installer.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24568] Travis needs a c++14 build

2016-05-13 Thread Sebastia Kölle 
Update of bug #24568 (project wesnoth):

Category: Bug => Feature Request
  Status:None => Fixed  
 Assigned to:None => aquileia   

___

Follow-up Comment #6:

Implemented as of 23abf97f36.

As the build currently fails due to a conflict between make_reverse_iterator
from std:: and boost::, the build is marked as an allowed failure.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs