windows compile error

2003-09-16 Thread Herold Heiko
Just a quick note, the current cvs code on windows during compile (with
VC++6) stops with

cl /I. /DWINDOWS /D_CONSOLE /DHAVE_CONFIG_H /DSYSTEM_WGETRC=\wgetrc\
/DHAVE_SSL /nologo /MT /W0 /O2 /c utils.c
utils.c
utils.c(1651) : error C2520: conversion from unsigned __int64 to double not
implemented, use signed __int64

The culprit seems to be (in wtimer_sys_diff)

#ifdef WINDOWS
  return (double)(wst1-QuadPart - wst2-QuadPart) / 1;
#endif

But this isn't really my area, anyone ?

Heiko 

-- 
-- PREVINET S.p.A. www.previnet.it
-- Heiko Herold [EMAIL PROTECTED]
-- +39-041-5907073 ph
-- +39-041-5907472 fax


bug in wget 1.8.1/1.8.2

2003-09-16 Thread Dieter Drossmann
Hello,

I use a extra file with a long list of http entries. I included this 
file with the  -i option.
After 154 downloads I got an error message: Segmentation fault.

With wget 1.7.1 everything works well.

Is there a new limit of lines?

Regards,
Dieter Drossmann




Re: windows compile error

2003-09-16 Thread Hrvoje Niksic
Herold Heiko [EMAIL PROTECTED] writes:

 Just a quick note, the current cvs code on windows during compile (with
 VC++6) stops with

 cl /I. /DWINDOWS /D_CONSOLE /DHAVE_CONFIG_H /DSYSTEM_WGETRC=\wgetrc\
 /DHAVE_SSL /nologo /MT /W0 /O2 /c utils.c
 utils.c
 utils.c(1651) : error C2520: conversion from unsigned __int64 to double not
 implemented, use signed __int64

 The culprit seems to be (in wtimer_sys_diff)

 #ifdef WINDOWS
   return (double)(wst1-QuadPart - wst2-QuadPart) / 1;
 #endif

Does this patch help?

2003-09-16  Hrvoje Niksic  [EMAIL PROTECTED]
 
* utils.c (wtimer_sys_diff): Convert the time difference to signed
__int64, then to double.  This works around MS VC++ 6 which can't
convert unsigned __int64 to double directly.

Index: src/utils.c
===
RCS file: /pack/anoncvs/wget/src/utils.c,v
retrieving revision 1.54
diff -u -r1.54 utils.c
--- src/utils.c 2003/09/15 21:14:15 1.54
+++ src/utils.c 2003/09/16 21:01:02
@@ -1648,7 +1648,10 @@
 #endif
 
 #ifdef WINDOWS
-  return (double)(wst1-QuadPart - wst2-QuadPart) / 1;
+  /* VC++ 6 doesn't support direct cast of uint64 to double.  To work
+ around this, we subtract, then convert to signed, then finally to
+ double.  */
+  return (double)(signed __int64)(wst1-QuadPart - wst2-QuadPart) / 1;
 #endif
 }
 



Re: bug in wget 1.8.1/1.8.2

2003-09-16 Thread Hrvoje Niksic
Dieter Drossmann [EMAIL PROTECTED] writes:

 I use a extra file with a long list of http entries. I included this
 file with the -i option.  After 154 downloads I got an error
 message: Segmentation fault.

 With wget 1.7.1 everything works well.

 Is there a new limit of lines?

No, there's no built-in line limit, what you're seeing is a bug.

I cannot see anything wrong inspecting the code, so you'll have to
help by providing a gdb backtrace.  You can get it by doing this:

* Compile Wget with `-g' by running `make CFLAGS=-g' in its source
  directory (after configure, of course.)

* Go to the src/ directory and run that version of Wget the same way
  you normally run it, e.g. ./wget -i FILE.

* When Wget crashes, run `gdb wget core', type `bt' and mail us the
  resulting stack trace.

Thanks for the report.



Re: Incomplete man page on wget

2003-09-16 Thread Mitra
Hi,

Thanks for the response.

 I've never used Info before, except for documentation of emacs and 
very few things are documented there. I suggest it should be presumed 
that people will look at man wget or wget --help and make sure 
the documentation is either the same, or that there is a level of 
indirection to info wget

- Mitra

At 12:39 PM +0200 16/9/03, Hrvoje Niksic wrote:
Mitra [EMAIL PROTECTED] writes:

 The wget man page reports

 --proxy=on/off
 Turn proxy support on or off.  The proxy is on by
 default if the appropriate environmental variable is
 defined.
 Which is of course incomplete as it doesn't say WHAT the appropriate
 environmental variable is!
Thanks for the report.  Note that the real Wget documentation is in
Info format.  The Info manual names the proxy environment variables in
the Proxies node.


--
Mitra Technology Consulting -  www.mitra.biz - [EMAIL PROTECTED]
home 02-6684-8096  mobile 0414-648-722  office 02-6684-6182
Byron Community Knowledge Management Project www.byronkm.com
Life is a Mystery to be Lived, not a Problem to be Solved



Re: Incomplete man page on wget

2003-09-16 Thread Hrvoje Niksic
Mitra [EMAIL PROTECTED] writes:

 Hi,

 Thanks for the response.

   I've never used Info before, except for documentation of emacs and
   very few things are documented there. I suggest it should be
   presumed that people will look at man wget or wget --help and
   make sure the documentation is either the same, or that there is a
   level of indirection to info wget

You are right.  The current man page does not seem to mention that it
is only an excerpt from the entire documentation, and that is a bug.

As for Info, note that Wget is a GNU program, and Info is the
preferred documentation format of the GNU project.



Re: Incomplete man page on wget

2003-09-16 Thread Mitra
Sure - I understand that info is the preferred documentation for GNU, 
no problem there, but this is not going to be widely known to people 
who have grown up on --help and man, so there is a responsibility to 
let it be known IN MOST PEOPLE'S DEFAULT where to get the prefered 
documentation.

I would have a similar response to people who prefer to put the 
documentation online (e.g. php). There needs to be a pointer in the 
obvious places to lead people to the non-obvious places.  You can't 
assume that people know that GNU = Info.

- Mitra

At 12:12 AM +0200 17/9/03, Hrvoje Niksic wrote:
Mitra [EMAIL PROTECTED] writes:

 Hi,

 Thanks for the response.

   I've never used Info before, except for documentation of emacs and
   very few things are documented there. I suggest it should be
   presumed that people will look at man wget or wget --help and
   make sure the documentation is either the same, or that there is a
   level of indirection to info wget
You are right.  The current man page does not seem to mention that it
is only an excerpt from the entire documentation, and that is a bug.
As for Info, note that Wget is a GNU program, and Info is the
preferred documentation format of the GNU project.


--
Mitra Technology Consulting -  www.mitra.biz - [EMAIL PROTECTED]
home 02-6684-8096  mobile 0414-648-722  office 02-6684-6182
Byron Community Knowledge Management Project www.byronkm.com
Life is a Mystery to be Lived, not a Problem to be Solved



Small change to print SSL version

2003-09-16 Thread Christopher G. Lewis
Here's a small change to print out the OpenSSL version with the -V 
--help parameters.


2003-09-16  Christopher G. Lewis [EMAIL PROTECTED]
* main.c (main): Trivial change to show OpenSSL libray version
in
--help and -V


--- wget20030915s/wget.20030915/src/main.c  2003-09-16
12:32:42.0 -0500
+++ wget20030915s_original/wget.20030915/src/main.c 2003-09-15
00:04:14.0 -0500
@@ -131,14 +131,8 @@
 static void
 print_help (void)
 {
-#ifndef HAVE_SSL
   printf (_(GNU Wget %s, a non-interactive network retriever.\n),
 version_string);
-#else
-  printf (_(GNU Wget %s %s, a non-interactive network retriever.\n),
-version_string, SSLeay_version(SSLEAY_VERSION));
-#endif
-
   print_usage ();
   /* Had to split this in parts, so the #@@#%# Ultrix compiler and cpp
  don't bitch.  Also, it makes translation much easier.  */
@@ -510,11 +504,8 @@
 setval (recursive, on);
 break;
   case 'V':
-printf (GNU Wget %s\n, version_string);
-#ifdef HAVE_SSL
-printf(  %s\n,SSLeay_version(SSLEAY_VERSION));
-#endif
-printf (\n%s, _(\
+ printf (GNU Wget %s\n\n, version_string);
+ printf (%s, _(\
 Copyright (C) 1995, 1996, 1997, 1998, 2000, 2001 Free Software
Foundation,
Inc.\n));
 printf (%s, _(\
 This program is distributed in the hope that it will be useful,\n\