Re: Bug in wget: cannot request urls with double-slash in the query string
D Richard Felker III <[EMAIL PROTECTED]> writes: > The following code in url.c makes it impossible to request urls that > contain multiple slashes in a row in their query string: [...] That code is removed in CVS, so multiple slashes now work correctly. > Think of something like http://foo/bar/redirect.cgi?http://... > wget translates this into: [...] Which version of Wget are you using? I think even Wget 1.8.2 didn't collapse multiple slashes in query strings, only in paths. > Removing the offending code fixes the problem, but I'm not sure if > this is the correct solution. I expect it would be more correct to > remove multiple slashes only before the first occurrance of ?, but > not afterwards. That's exactly what should happen. Please give us more details, if possible accompanied by `-d' output.
Re: Bug in wget: cannot request urls with double-slash in the query string
On Mon, Mar 01, 2004 at 03:36:55PM +0100, Hrvoje Niksic wrote: > D Richard Felker III <[EMAIL PROTECTED]> writes: > > > The following code in url.c makes it impossible to request urls that > > contain multiple slashes in a row in their query string: > [...] > > That code is removed in CVS, so multiple slashes now work correctly. > > > Think of something like http://foo/bar/redirect.cgi?http://... > > wget translates this into: [...] > > Which version of Wget are you using? I think even Wget 1.8.2 didn't > collapse multiple slashes in query strings, only in paths. I was using 1.8.2 and noticed the problem, so I upgraded to 1.9.1 and it persisted. > > Removing the offending code fixes the problem, but I'm not sure if > > this is the correct solution. I expect it would be more correct to > > remove multiple slashes only before the first occurrance of ?, but > > not afterwards. > > That's exactly what should happen. Please give us more details, if > possible accompanied by `-d' output. If you'd still like details now that you know the version I was using, let me know and I'll be happy to do some tests. Rich
Re: Bug in wget: cannot request urls with double-slash in the query string
D Richard Felker III <[EMAIL PROTECTED]> writes: >> > Think of something like http://foo/bar/redirect.cgi?http://... >> > wget translates this into: [...] >> >> Which version of Wget are you using? I think even Wget 1.8.2 didn't >> collapse multiple slashes in query strings, only in paths. > > I was using 1.8.2 and noticed the problem, so I upgraded to 1.9.1 > and it persisted. OK. >> > Removing the offending code fixes the problem, but I'm not sure if >> > this is the correct solution. I expect it would be more correct to >> > remove multiple slashes only before the first occurrance of ?, but >> > not afterwards. >> >> That's exactly what should happen. Please give us more details, if >> possible accompanied by `-d' output. > > If you'd still like details now that you know the version I was > using, let me know and I'll be happy to do some tests. Yes please. For example, this is how it works for me: $ /usr/bin/wget -d "http://www.xemacs.org/something?redirect=http://www.cnn.com"; DEBUG output created by Wget 1.8.2 on linux-gnu. --19:23:02-- http://www.xemacs.org/something?redirect=http://www.cnn.com => `something?redirect=http:%2F%2Fwww.cnn.com' Resolving www.xemacs.org... done. Caching www.xemacs.org => 199.184.165.136 Connecting to www.xemacs.org[199.184.165.136]:80... connected. Created socket 3. Releasing 0x8080b40 (new refcount 1). ---request begin--- GET /something?redirect=http://www.cnn.com HTTP/1.0 User-Agent: Wget/1.8.2 Host: www.xemacs.org Accept: */* Connection: Keep-Alive ---request end--- HTTP request sent, awaiting response... ... The request log shows that the slashes are apparently respected.
WEEKLY COMPUTER SPECIAL
415 N 66thSuite 3 | Lincoln, NE | (402) 466-1455 Computer Diagnostics & Maintenance Your computer system contains both mechanical andelectronic components that are extremely delicate, sensitive and in need ofregular care. Many times computer failure can be prolonged oreliminated by implementing a proactive computer maintenance program. Most people do not realize that theircomputer needs to have a Maintenance Checkup done at least every 6 months. 98% of all Floppy Drive,CD-ROM Drive, & Fan Failure is due to the dirt &Dust that is constantly being drawn into your system by the coolingprocess. If a System is not maintained properly andcleaned periodically then serious Damage can occur. During our Maintenance checkup our certifiedtechnicians will spend about 3 to 4 hours going over your system cleaning,defragging, & checking for Viruss & Spyware. Many systems that come in for a maintenancecheck have already begun to experience problems. Our thorough Maintenancecheck can detect and fix many problems before catastrophic damage is done. Services include, but not limited to: Fan checkups, Defragmenting, Computer Cleaning (Inside & Out) Maintaining Virus Software, Checking For Spyware, Hardware Repair, Software Repair, Analysis of Current Technology, Recommendations For Upgrades & Optimizing Network Performance COMPUTER DIAGNOSTICS ONLY $34.95 STORE HOURS: MON-FRI 8-6,SAT 10-3 *See store for details.Prices and specifications subject to change without notice. Limit rightsreserved. Not responsible for typographical errors. No sales on NET terms.No sales to dealers or resellers. Designated trademarks and brands are theproperty of their respective owners. To be removed from this list, send anemail to [EMAIL PROTECTED] with 'REMOVE' in the subject line (no quotes, case sensitive), anyadditional text will cause addresses to not be removed. <><><><>
