RE: Wget 1.9-beta1 is available for testing
Hrvoje, please add this patch: --- wget-1.9-beta1\windows\Makefile.src Sat May 18 02:16:36 2002 +++ wget-1.9-beta1.wip\windows\Makefile.src Thu Sep 25 08:09:26 2003 @@ -63,15 +63,17 @@ RM = del -SRC = cmpt.c safe-ctype.c connect.c host.c http.c netrc.c ftp-basic.c ftp.c \ - ftp-ls.c ftp-opie.c getopt.c hash.c headers.c html-parse.c html-url.c \ - progress.c retr.c recur.c res.c url.c cookies.c init.c utils.c main.c \ - version.c mswindows.c fnmatch.c gen-md5.c gnu-md5.c rbuf.c log.c $(SSLSRC) +SRC = cmpt.c safe-ctype.c convert.c connect.c host.c http.c netrc.c \ + ftp-basic.c ftp.c ftp-ls.c ftp-opie.c getopt.c hash.c headers.c \ + html-parse.c html-url.c progress.c retr.c recur.c res.c url.c cookies.c \ + init.c utils.c main.c version.c mswindows.c fnmatch.c gen-md5.c \ + gnu-md5.c rbuf.c log.c $(SSLSRC) -OBJ = cmpt$o safe-ctype$o connect$o host$o http$o netrc$o ftp-basic$o ftp$o \ - ftp-ls$o ftp-opie$o getopt$o hash$o headers$o html-parse$o html-url$o \ - progress$o retr$o recur$o res$o url$o cookies$o init$o utils$o main$o \ - version$o mswindows$o fnmatch$o gen-md5$o gnu-md5$o rbuf$o log$o $(SSLOBJ) +OBJ = cmpt$o safe-ctype$o convert$o connect$o host$o http$o netrc$o \ + ftp-basic$o ftp$o ftp-ls$o ftp-opie$o getopt$o hash$o headers$o \ + html-parse$o html-url$o progress$o retr$o recur$o res$o url$o cookies$o \ + init$o utils$o main$oversion$o mswindows$o fnmatch$o gen-md5$o gnu-md5$o\ + rbuf$o log$o $(SSLOBJ) .SUFFIXES: .c .obj A windows binary ONLY (sorry I'm in a real hurry these days) for testing available at http://space.tin.it/computer/hherold However the binaries are as usualy at sunsite.dk, and presently anonymous ftp access at sunsite.dk seems to be down. Heiko -- -- PREVINET S.p.A. www.previnet.it -- Heiko Herold [EMAIL PROTECTED] -- +39-041-5907073 ph -- +39-041-5907472 fax -Original Message- From: Hrvoje Niksic [mailto:[EMAIL PROTECTED] Sent: Tuesday, September 23, 2003 11:29 PM To: [EMAIL PROTECTED] Subject: Wget 1.9-beta1 is available for testing After a lot of time of sitting in CVS, a beta of Wget 1.9 is available. To see what's new since 1.8, check the `NEWS' file in the distribution. Get it from: http://fly.srk.fer.hr/~hniksic/wget/wget-1.9-beta1.tar.gz Please test it on as many different platforms as possible and in the places where Wget 1.8.x is currently being used. I expect this release to be extremely stable, but noone can guarantee that without wider testing. I didn't want to call it pre1 or rc1 lest I anger the Gods. One important addition scheduled for 1.9 and *not* featured in this beta are Mauro's IPv6 improvements. When I receive and merge Mauro's changes, I'll release a new beta. As always, thanks for your help.
RE: Wget 1.9-beta1 is available for testing
Unmangled patch attached. Heiko -- -- PREVINET S.p.A. www.previnet.it -- Heiko Herold [EMAIL PROTECTED] -- +39-041-5907073 ph -- +39-041-5907472 fax -Original Message- From: Herold Heiko [mailto:[EMAIL PROTECTED] Sent: Thursday, September 25, 2003 10:45 AM To: 'Hrvoje Niksic'; [EMAIL PROTECTED] Subject: RE: Wget 1.9-beta1 is available for testing Hrvoje, please add this patch: --- wget-1.9-beta1\windows\Makefile.src Sat May 18 02:16:36 2002 +++ wget-1.9-beta1.wip\windows\Makefile.src Thu Sep 25 08:09:26 2003 @@ -63,15 +63,17 @@ RM = del -SRC = cmpt.c safe-ctype.c connect.c host.c http.c netrc.c ftp-basic.c ftp.c \ - ftp-ls.c ftp-opie.c getopt.c hash.c headers.c html-parse.c html-url.c \ - progress.c retr.c recur.c res.c url.c cookies.c init.c utils.c main.c \ - version.c mswindows.c fnmatch.c gen-md5.c gnu-md5.c rbuf.c log.c $(SSLSRC) +SRC = cmpt.c safe-ctype.c convert.c connect.c host.c http.c netrc.c \ + ftp-basic.c ftp.c ftp-ls.c ftp-opie.c getopt.c hash.c headers.c \ + html-parse.c html-url.c progress.c retr.c recur.c res.c url.c cookies.c \ + init.c utils.c main.c version.c mswindows.c fnmatch.c gen-md5.c \ + gnu-md5.c rbuf.c log.c $(SSLSRC) -OBJ = cmpt$o safe-ctype$o connect$o host$o http$o netrc$o ftp-basic$o ftp$o \ - ftp-ls$o ftp-opie$o getopt$o hash$o headers$o html-parse$o html-url$o \ - progress$o retr$o recur$o res$o url$o cookies$o init$o utils$o main$o \ - version$o mswindows$o fnmatch$o gen-md5$o gnu-md5$o rbuf$o log$o $(SSLOBJ) +OBJ = cmpt$o safe-ctype$o convert$o connect$o host$o http$o netrc$o \ + ftp-basic$o ftp$o ftp-ls$o ftp-opie$o getopt$o hash$o headers$o \ + html-parse$o html-url$o progress$o retr$o recur$o res$o url$o cookies$o \ + init$o utils$o main$oversion$o mswindows$o fnmatch$o gen-md5$o gnu-md5$o\ + rbuf$o log$o $(SSLOBJ) .SUFFIXES: .c .obj A windows binary ONLY (sorry I'm in a real hurry these days) for testing available at http://space.tin.it/computer/hherold However the binaries are as usualy at sunsite.dk, and presently anonymous ftp access at sunsite.dk seems to be down. Heiko -- -- PREVINET S.p.A. www.previnet.it -- Heiko Herold [EMAIL PROTECTED] -- +39-041-5907073 ph -- +39-041-5907472 fax -Original Message- From: Hrvoje Niksic [mailto:[EMAIL PROTECTED] Sent: Tuesday, September 23, 2003 11:29 PM To: [EMAIL PROTECTED] Subject: Wget 1.9-beta1 is available for testing After a lot of time of sitting in CVS, a beta of Wget 1.9 is available. To see what's new since 1.8, check the `NEWS' file in the distribution. Get it from: http://fly.srk.fer.hr/~hniksic/wget/wget-1.9-beta1.tar.gz Please test it on as many different platforms as possible and in the places where Wget 1.8.x is currently being used. I expect this release to be extremely stable, but noone can guarantee that without wider testing. I didn't want to call it pre1 or rc1 lest I anger the Gods. One important addition scheduled for 1.9 and *not* featured in this beta are Mauro's IPv6 improvements. When I receive and merge Mauro's changes, I'll release a new beta. As always, thanks for your help. --- wget-1.9-beta1\windows\Makefile.src Sat May 18 02:16:36 2002 +++ wget-1.9-beta1.wip\windows\Makefile.src Thu Sep 25 08:09:26 2003 @@ -63,15 +63,17 @@ RM = del -SRC = cmpt.c safe-ctype.c connect.c host.c http.c netrc.c ftp-basic.c ftp.c \ - ftp-ls.c ftp-opie.c getopt.c hash.c headers.c html-parse.c html-url.c \ - progress.c retr.c recur.c res.c url.c cookies.c init.c utils.c main.c \ - version.c mswindows.c fnmatch.c gen-md5.c gnu-md5.c rbuf.c log.c $(SSLSRC) +SRC = cmpt.c safe-ctype.c convert.c connect.c host.c http.c netrc.c \ + ftp-basic.c ftp.c ftp-ls.c ftp-opie.c getopt.c hash.c headers.c \ + html-parse.c html-url.c progress.c retr.c recur.c res.c url.c cookies.c \ + init.c utils.c main.c version.c mswindows.c fnmatch.c gen-md5.c \ + gnu-md5.c rbuf.c log.c $(SSLSRC) -OBJ = cmpt$o safe-ctype$o connect$o host$o http$o netrc$o ftp-basic$o ftp$o \ - ftp-ls$o ftp-opie$o getopt$o hash$o headers$o html-parse$o html-url$o \ - progress$o retr$o recur$o res$o url$o cookies$o init$o utils$o main$o \ - version$o mswindows$o fnmatch$o gen-md5$o gnu-md5$o rbuf$o log$o $(SSLOBJ) +OBJ = cmpt$o safe-ctype$o convert$o connect$o host$o http$o netrc$o \ + ftp-basic$o ftp$o ftp-ls$o ftp-opie$o getopt$o hash$o headers$o \ + html-parse$o html-url$o progress$o retr$o recur$o res$o url$o cookies$o \ + init$o utils$o main$oversion$o mswindows$o fnmatch$o gen-md5$o gnu-md5$o\ + rbuf$o log$o $(SSLOBJ) .SUFFIXES: .c .obj
Re: Wget 1.9-beta1 is available for testing
Could the person who sent me the patch for Windows compilers support please resend it? Amidst all the viruses, I accidentally deleted the message before I've had a chance to apply it. Sorry about the mistake.
Re: Wget 1.9-beta1 is available for testing
Hi Hrvoje :) * Hrvoje Niksic [EMAIL PROTECTED] dixit: http://fly.srk.fer.hr/~hniksic/wget/wget-1.9-beta1.tar.gz I've got and tested it, and with NO wgetrc (it happens the same with my own wgetrc, but I tested clean just in case), the problem with the quoting still exists: $wget -r -c -nH ftp://user:[EMAIL PROTECTED]/Music/Joe Hisaishi --15:22:53-- ftp://user:[EMAIL PROTECTED]/Music/Joe%20Hisaishi = `Music/.listing' Resolving david... 213.97.199.90 Connecting to david[213.97.199.90]:21... connected. Logging in as user ... Logged in! == SYST ... done.== PWD ... done. == TYPE I ... done. == CWD /Music ... done. == PORT ... done.== LIST ... done. 0K 7.92 KB/s 15:22:55 (7.92 KB/s) - `Music/.listing' saved [347] Removed `Music/.listing'. --15:22:55-- ftp://user:[EMAIL PROTECTED]/Music%2fJoe%20Hisaishi/Joe%20Hisaishi = `Music%2FJoe Hisaishi/.listing' == CWD /Music/Joe Hisaishi ... done. == PORT ... done.== LIST ... done. 0K .10.28 KB/s 15:22:56 (10.28 KB/s) - `Music%2FJoe Hisaishi/.listing' saved [1286] Removed `Music%2FJoe Hisaishi/.listing'. --15:22:56-- ftp://user:[EMAIL PROTECTED]/Music%2fJoe%20Hisaishi%2fBrother/Joe%20Hisaishi = `Music%2FJoe Hisaishi%2FBrother/.listing' == CWD /Music/Joe Hisaishi/Brother ... done. == PORT ... done.== LIST ... done. 0K . 9.59 KB/s 15:22:57 (9.59 KB/s) - `Music%2FJoe Hisaishi%2FBrother/.listing' saved [1200] Removed `Music%2FJoe Hisaishi%2FBrother/.listing'. --15:22:57-- ftp://user:[EMAIL PROTECTED]/Music%2fJoe%20Hisaishi%2fBrother/01%20-%20Drifter%20...%20In%20LAX.mp3 = `Music%2FJoe Hisaishi%2FBrother/01 - Drifter ... In LAX.mp3' == CWD not required. == PORT ... done.== RETR 01 - Drifter ... In LAX.mp3 ... done. Length: 4,200,538 0K .. .. .. .. At this point I have the following directory entries: Music Music%2FJoeHisaishi Music%2FJoeHisaishi%2FBrother Inside the last dir there is the file 01 - Drifter..., correct, without quoting. As you can see, the slash is quoted and this causes the problem. In fact, is worse than before the patch, because before the only damaged part was the 'Joe Hisaishi' one, namely mangled as 'Joe%20Hisaishi'. In fact, all items provided in the command line are quoted, but happens that 'Music' is not quotable (well, it hasn't wrong characters...). Am I doing something wrong? My platform is a do-it-yourself Linux box, running kernel 2.4.21 and libc 2.2.4, and if you need an username and a password for testing yourself I can provide it, just ask. Apart from this, the release seems to be pretty stable. I've tested it against my own ftp server (the one in the example...), turning it down in the middle of a transfer and things like those and it seems to work right. If you want me to test something more for this release, just tell and I'll do. Thanks for wget :)) Raúl Núñez de Arenas Coronado -- Linux Registered User 88736 http://www.pleyades.net http://raul.pleyades.net/
Re: Wget 1.9-beta1 is available for testing
DervishD [EMAIL PROTECTED] writes:
I've got and tested it, and with NO wgetrc (it happens the same
with my own wgetrc, but I tested clean just in case), the problem
with the quoting still exists:
$wget -r -c -nH ftp://user:[EMAIL PROTECTED]/Music/Joe Hisaishi
[...]
--15:22:55-- ftp://user:[EMAIL PROTECTED]/Music%2fJoe%20Hisaishi/Joe%20Hisaishi
= `Music%2FJoe Hisaishi/.listing'
Thanks for the detailed bug report. Although it doesn't look that
way, this problem is nothing but a simple oversight. (A function that
was supposed to URL-encode everything except slashes failed to enforce
the exception.) This patch should fix it:
2003-09-24 Hrvoje Niksic [EMAIL PROTECTED]
* url.c (url_escape_1): Revert unintentional change to lowercase
xdigit escapes.
(url_escape_dir): Document that this function depends on the
output of url_escape_1.
Index: src/url.c
===
RCS file: /pack/anoncvs/wget/src/url.c,v
retrieving revision 1.94
diff -u -r1.94 url.c
--- src/url.c 2003/09/22 12:07:20 1.94
+++ src/url.c 2003/09/24 14:10:48
@@ -198,8 +198,8 @@
{
unsigned char c = *p1++;
*p2++ = '%';
- *p2++ = XNUM_TO_digit (c 4);
- *p2++ = XNUM_TO_digit (c 0xf);
+ *p2++ = XNUM_TO_DIGIT (c 4);
+ *p2++ = XNUM_TO_DIGIT (c 0xf);
}
else
*p2++ = *p1++;
@@ -1130,6 +1130,7 @@
for (; *h; h++, t++)
{
+ /* url_escape_1 having converted '/' to %2F exactly. */
if (*h == '%' h[1] == '2' h[2] == 'F')
{
*t = '/';
Re: Wget 1.9-beta1 is available for testing
Hi Hrvoje :) * Hrvoje Niksic [EMAIL PROTECTED] dixit: Thanks for the detailed bug report. Although it doesn't look that way, this problem is nothing but a simple oversight. OK, patch applied and working! Now it downloads correctly all files, quote appropriately and all works smooth :)) Thanks a lot for the patch. Raúl Núñez de Arenas Coronado -- Linux Registered User 88736 http://www.pleyades.net http://raul.pleyades.net/
