svn commit: r496614 - in /incubator/wicket/branches/wicket-1.x/wicket-spring-annot: .classpath .project .settings/ .settings/org.eclipse.jdt.core.prefs
Author: ehillenius Date: Mon Jan 15 23:24:24 2007 New Revision: 496614 URL: http://svn.apache.org/viewvc?view=rev&rev=496614 Log: try to fix a very annoying 'This project needs to migrate WTP metadata' error message Added: incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.settings/ incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.settings/org.eclipse.jdt.core.prefs Modified: incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.classpath incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.project Modified: incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.classpath URL: http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.classpath?view=diff&rev=496614&r1=496613&r2=496614 == --- incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.classpath (original) +++ incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.classpath Mon Jan 15 23:24:24 2007 @@ -2,14 +2,14 @@ - - + - - + + - + + Modified: incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.project URL: http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.project?view=diff&rev=496614&r1=496613&r2=496614 == --- incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.project (original) +++ incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.project Mon Jan 15 23:24:24 2007 @@ -7,22 +7,8 @@ org.eclipse.jdt.core.javabuilder - - org.eclipse.wst.common.modulecore.ComponentStructuralBuilder - - - - org.eclipse.wst.validation.validationbuilder - - - - org.eclipse.wst.common.modulecore.ComponentStructuralBuilderDependencyResolver - - org.eclipse.jdt.core.javanature -org.eclipse.jem.workbench.JavaEMFNature -org.eclipse.wst.common.modulecore.ModuleCoreNature Added: incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.settings/org.eclipse.jdt.core.prefs URL: http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.settings/org.eclipse.jdt.core.prefs?view=auto&rev=496614 == --- incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.settings/org.eclipse.jdt.core.prefs (added) +++ incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.settings/org.eclipse.jdt.core.prefs Mon Jan 15 23:24:24 2007 @@ -0,0 +1,5 @@ +#Mon Jan 15 23:24:17 PST 2007 +org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5 +eclipse.preferences.version=1 +org.eclipse.jdt.core.compiler.source=1.5 +org.eclipse.jdt.core.compiler.compliance=1.5
svn commit: r496611 - in /incubator/wicket/branches/wicket-1.x/wicket-jmx: .classpath .project .settings/ .settings/org.eclipse.jdt.core.prefs
Author: ehillenius Date: Mon Jan 15 23:22:21 2007 New Revision: 496611 URL: http://svn.apache.org/viewvc?view=rev&rev=496611 Log: try to fix a very annoying 'This project needs to migrate WTP metadata' error message Added: incubator/wicket/branches/wicket-1.x/wicket-jmx/.settings/ incubator/wicket/branches/wicket-1.x/wicket-jmx/.settings/org.eclipse.jdt.core.prefs Modified: incubator/wicket/branches/wicket-1.x/wicket-jmx/.classpath incubator/wicket/branches/wicket-1.x/wicket-jmx/.project Modified: incubator/wicket/branches/wicket-1.x/wicket-jmx/.classpath URL: http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket-jmx/.classpath?view=diff&rev=496611&r1=496610&r2=496611 == --- incubator/wicket/branches/wicket-1.x/wicket-jmx/.classpath (original) +++ incubator/wicket/branches/wicket-1.x/wicket-jmx/.classpath Mon Jan 15 23:22:21 2007 @@ -1,12 +1,13 @@ - - - - - - + + + + + + + Modified: incubator/wicket/branches/wicket-1.x/wicket-jmx/.project URL: http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket-jmx/.project?view=diff&rev=496611&r1=496610&r2=496611 == --- incubator/wicket/branches/wicket-1.x/wicket-jmx/.project (original) +++ incubator/wicket/branches/wicket-1.x/wicket-jmx/.project Mon Jan 15 23:22:21 2007 @@ -1,25 +1,14 @@ - - wicket-jmx - Wicket Authorization Integration Based on roles, metadata and annotations. This project requires Java 5. - - wicket - - - - org.eclipse.jdt.core.javabuilder - - - - - org.eclipse.wst.validation.validationbuilder - - - - - - org.eclipse.jdt.core.javanature - org.eclipse.jem.workbench.JavaEMFNature - org.eclipse.wst.common.modulecore.ModuleCoreNature - - + wicket-jmx + Wicket Java Management Extensions for Wicket 1.x (will be part of the main distro from Wicket 2.0 on) + + + + org.eclipse.jdt.core.javabuilder + + + + +org.eclipse.jdt.core.javanature + + \ No newline at end of file Added: incubator/wicket/branches/wicket-1.x/wicket-jmx/.settings/org.eclipse.jdt.core.prefs URL: http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket-jmx/.settings/org.eclipse.jdt.core.prefs?view=auto&rev=496611 == --- incubator/wicket/branches/wicket-1.x/wicket-jmx/.settings/org.eclipse.jdt.core.prefs (added) +++ incubator/wicket/branches/wicket-1.x/wicket-jmx/.settings/org.eclipse.jdt.core.prefs Mon Jan 15 23:22:21 2007 @@ -0,0 +1,5 @@ +#Mon Jan 15 23:22:03 PST 2007 +org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.5 +eclipse.preferences.version=1 +org.eclipse.jdt.core.compiler.source=1.5 +org.eclipse.jdt.core.compiler.compliance=1.5
svn commit: r496610 - /incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.settings/
Author: ehillenius Date: Mon Jan 15 23:15:43 2007 New Revision: 496610 URL: http://svn.apache.org/viewvc?view=rev&rev=496610 Log: try to fix a very annoying 'This project needs to migrate WTP metadata' error message Removed: incubator/wicket/branches/wicket-1.x/wicket-spring-annot/.settings/
svn commit: r496609 - in /incubator/wicket/branches/wicket-1.x: wicket-auth-roles-examples/.settings/ wicket-jmx/.settings/
Author: ehillenius Date: Mon Jan 15 23:14:28 2007 New Revision: 496609 URL: http://svn.apache.org/viewvc?view=rev&rev=496609 Log: try to fix a very annoying 'This project needs to migrate WTP metadata' error message Removed: incubator/wicket/branches/wicket-1.x/wicket-auth-roles-examples/.settings/ incubator/wicket/branches/wicket-1.x/wicket-jmx/.settings/
svn commit: r496608 - /incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.classpath
Author: ehillenius Date: Mon Jan 15 23:13:04 2007 New Revision: 496608 URL: http://svn.apache.org/viewvc?view=rev&rev=496608 Log: lib -> project Modified: incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.classpath Modified: incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.classpath URL: http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.classpath?view=diff&rev=496608&r1=496607&r2=496608 == --- incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.classpath (original) +++ incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.classpath Mon Jan 15 23:13:04 2007 @@ -1,12 +1,13 @@ + - - - - - - - - - - - \ No newline at end of file + + + + + + + + + + +
svn commit: r496607 - in /incubator/wicket/branches/wicket-1.x/wicket-auth-roles: .amateras .classpath .cvsignore .project .settings/
Author: ehillenius Date: Mon Jan 15 23:08:59 2007 New Revision: 496607 URL: http://svn.apache.org/viewvc?view=rev&rev=496607 Log: try to fix a very annoying 'This project needs to migrate WTP metadata' error message Removed: incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.amateras incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.cvsignore incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.settings/ Modified: incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.classpath incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.project Modified: incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.classpath URL: http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.classpath?view=diff&rev=496607&r1=496606&r2=496607 == --- incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.classpath (original) +++ incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.classpath Mon Jan 15 23:08:59 2007 @@ -1,12 +1,12 @@ - - - - - - - - - - - + + + + + + + + + + + \ No newline at end of file Modified: incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.project URL: http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.project?view=diff&rev=496607&r1=496606&r2=496607 == --- incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.project (original) +++ incubator/wicket/branches/wicket-1.x/wicket-auth-roles/.project Mon Jan 15 23:08:59 2007 @@ -1,35 +1,14 @@ - - wicket-auth-roles - Wicket Authorization Integration Based on roles, metadata and annotations. This project requires Java 5. - - wicket - - - - org.eclipse.jdt.core.javabuilder - - - - - org.eclipse.wst.common.modulecore.ComponentStructuralBuilder - - - - - org.eclipse.wst.validation.validationbuilder - - - - - org.eclipse.wst.common.modulecore.ComponentStructuralBuilderDependencyResolver - - - - - - org.eclipse.jdt.core.javanature - org.eclipse.jem.workbench.JavaEMFNature - org.eclipse.wst.common.modulecore.ModuleCoreNature - - + wicket-auth-roles + Wicket Authorization Integration Based on roles, metadata and annotations. This project requires Java 5. + + + + org.eclipse.jdt.core.javabuilder + + + + +org.eclipse.jdt.core.javanature + + \ No newline at end of file
svn commit: r496577 - in /incubator/wicket/branches/wicket-1.x/wicket-threadtest/.settings: org.eclipse.jdt.core.prefs org.eclipse.jdt.ui.prefs
Author: ehillenius Date: Mon Jan 15 18:56:50 2007 New Revision: 496577 URL: http://svn.apache.org/viewvc?view=rev&rev=496577 Log: ignore rule Modified: incubator/wicket/branches/wicket-1.x/wicket-threadtest/.settings/org.eclipse.jdt.core.prefs incubator/wicket/branches/wicket-1.x/wicket-threadtest/.settings/org.eclipse.jdt.ui.prefs Modified: incubator/wicket/branches/wicket-1.x/wicket-threadtest/.settings/org.eclipse.jdt.core.prefs URL: http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket-threadtest/.settings/org.eclipse.jdt.core.prefs?view=diff&rev=496577&r1=496576&r2=496577 == --- incubator/wicket/branches/wicket-1.x/wicket-threadtest/.settings/org.eclipse.jdt.core.prefs (original) +++ incubator/wicket/branches/wicket-1.x/wicket-threadtest/.settings/org.eclipse.jdt.core.prefs Mon Jan 15 18:56:50 2007 @@ -1,4 +1,4 @@ -#Sun Oct 08 16:56:59 CEST 2006 +#Mon Jan 15 18:57:05 PST 2007 eclipse.preferences.version=1 org.eclipse.jdt.core.codeComplete.argumentPrefixes= org.eclipse.jdt.core.codeComplete.argumentSuffixes= @@ -25,6 +25,7 @@ org.eclipse.jdt.core.compiler.problem.fieldHiding=ignore org.eclipse.jdt.core.compiler.problem.finalParameterBound=ignore org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletingNormally=warning +org.eclipse.jdt.core.compiler.problem.forbiddenReference=warning org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=warning org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore Modified: incubator/wicket/branches/wicket-1.x/wicket-threadtest/.settings/org.eclipse.jdt.ui.prefs URL: http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket-threadtest/.settings/org.eclipse.jdt.ui.prefs?view=diff&rev=496577&r1=496576&r2=496577 == --- incubator/wicket/branches/wicket-1.x/wicket-threadtest/.settings/org.eclipse.jdt.ui.prefs (original) +++ incubator/wicket/branches/wicket-1.x/wicket-threadtest/.settings/org.eclipse.jdt.ui.prefs Mon Jan 15 18:56:50 2007 @@ -1,4 +1,4 @@ -#Sun Oct 08 16:55:18 CEST 2006 +#Mon Jan 15 18:57:05 PST 2007 comment_clear_blank_lines=false comment_format_comments=true comment_format_header=true @@ -12,7 +12,6 @@ eclipse.preferences.version=1 formatter_profile=_TS profile formatter_settings_version=10 -internal.default.compliance=default org.eclipse.jdt.ui.exception.name=e org.eclipse.jdt.ui.gettersetter.use.is=true org.eclipse.jdt.ui.keywordthis=false
svn commit: r496549 - /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/ComponentTest.java
Author: ivaynberg Date: Mon Jan 15 16:32:19 2007 New Revision: 496549 URL: http://svn.apache.org/viewvc?view=rev&rev=496549 Log: test patch Modified: incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/ComponentTest.java Modified: incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/ComponentTest.java URL: http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/ComponentTest.java?view=diff&rev=496549&r1=496548&r2=496549 == --- incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/ComponentTest.java (original) +++ incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/ComponentTest.java Mon Jan 15 16:32:19 2007 @@ -89,15 +89,15 @@ AjaxEventBehavior behavior = page.getAjaxBehavior(); executedBehavior(TestDetachPage.class, behavior, "TestDetachPageAjaxResult.html"); - assertEquals(2, page.getNrComponentDetachModelCalls()); - assertEquals(2, page.getNrComponentDetachModelsCalls()); - assertEquals(2, page.getNrComponentInternalDetachCalls()); - assertEquals(2, page.getNrComponentOnDetachCalls()); - assertEquals(2, page.getNrPageDetachModelCalls()); - assertEquals(2, page.getNrPageDetachModelsCalls()); - assertEquals(2, page.getNrPageInternalDetachCalls()); - assertEquals(2, page.getNrPageOnDetachCalls()); - assertEquals(2, page.getNrModelDetachCalls()); - assertEquals(2, page.getNrAjaxBehaviorDetachModelCalls()); + assertTrue(1
svn commit: r496545 - /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/basic/SimplePageTest.java
Author: ivaynberg
Date: Mon Jan 15 16:07:16 2007
New Revision: 496545
URL: http://svn.apache.org/viewvc?view=rev&rev=496545
Log:
test fix
Modified:
incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/basic/SimplePageTest.java
Modified:
incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/basic/SimplePageTest.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/basic/SimplePageTest.java?view=diff&rev=496545&r1=496544&r2=496545
==
---
incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/basic/SimplePageTest.java
(original)
+++
incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/basic/SimplePageTest.java
Mon Jan 15 16:07:16 2007
@@ -366,6 +366,10 @@
Panel panel =
(Panel)application.getLastRenderedPage().get("myPanel");
assertNotNull(panel);
+ // we need to setup request/response before calling setvisible
+ application.setupRequestAndResponse();
+ application.createRequestCycle();
+
panel.setVisible(true);
application.processRequestCycle(panel);
String document =
application.getServletResponse().getDocument();
svn commit: r496544 - /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/DisabledComponentTest.java
Author: ivaynberg
Date: Mon Jan 15 16:04:35 2007
New Revision: 496544
URL: http://svn.apache.org/viewvc?view=rev&rev=496544
Log:
test fix
Modified:
incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/DisabledComponentTest.java
Modified:
incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/DisabledComponentTest.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/DisabledComponentTest.java?view=diff&rev=496544&r1=496543&r2=496544
==
---
incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/DisabledComponentTest.java
(original)
+++
incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/DisabledComponentTest.java
Mon Jan 15 16:04:35 2007
@@ -50,7 +50,10 @@
{
executeTest(DisabledComponentPage1.class,
"DisabledComponentPage1a_result.html");
Link link =
((DisabledComponentPage1)application.getLastRenderedPage()).link;
- link.setEnabled(false);
+ // we need to setup request/response before calling setenabled
+ application.setupRequestAndResponse();
+ application.createRequestCycle();
+ link.setEnabled(false);
executedListener(DisabledComponentPage1.class, link,
"DisabledComponentPage1b_result.html");
}
[CONF] Apache Wicket: Tomcat (page edited)
Page Edited : WICKET : Tomcat Tomcat has been edited by Erik van Oosten (Jan 15, 2007). (View changes) Content: WW:How to support UTF-8 URIEncoding with Tomcat Powered by Atlassian Confluence (Version: 2.2.9 Build:#527 Sep 07, 2006) - Bug/feature request Unsubscribe or edit your notifications preferences
[CONF] Apache Wicket: Tomcat (page created)
Page Created : WICKET : Tomcat Tomcat has been created by Erik van Oosten (Jan 15, 2007). Content: WW:How to support UTF-8 URIEncoding with Tomcat Powered by Atlassian Confluence (Version: 2.2.9 Build:#527 Sep 07, 2006) - Bug/feature request Unsubscribe or edit your notifications preferences
[jira] Commented: (WICKET-201) refactor storing pages and versions
[ https://issues.apache.org/jira/browse/WICKET-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464833 ] Eelco Hillenius commented on WICKET-201: No, I don't think so. You can't do this currently, because a rollback goes back in versioning, and then increments from that rolled back version on. But, according to other objections, we can't delete those newer files, so they'll exist. So currently you have to overwrite every time as you don't know whether you have a version that is really new or to be overwritten. > refactor storing pages and versions > --- > > Key: WICKET-201 > URL: https://issues.apache.org/jira/browse/WICKET-201 > Project: Wicket > Issue Type: Improvement >Reporter: Eelco Hillenius > Assigned To: Johan Compagner > Fix For: 1.3, 2.0 > > > See http://www.nabble.com/refactor-storing-pages-and-versions-tf2943670.html > for a discussion. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-201) refactor storing pages and versions
[ https://issues.apache.org/jira/browse/WICKET-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464826 ] Johan Compagner commented on WICKET-201: that page will be saved or not is already covered by 2: Only save the page when a new version is created (so version 0 == new or version >0 is in a request later on) Only one exception And that is an ajax request that makes changes to the version (that i implemented last week) because ajax does touch now the version info. But doesn't create a new version but does a merge with the current version. So when that happens it is a version change (only the version number doesn't go up) and that is the only situation i can think of that a page-id:version-id combination needs to be saved again. So normally such a combination is only saved once. > refactor storing pages and versions > --- > > Key: WICKET-201 > URL: https://issues.apache.org/jira/browse/WICKET-201 > Project: Wicket > Issue Type: Improvement >Reporter: Eelco Hillenius > Assigned To: Johan Compagner > Fix For: 1.3, 2.0 > > > See http://www.nabble.com/refactor-storing-pages-and-versions-tf2943670.html > for a discussion. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-201) refactor storing pages and versions
[ https://issues.apache.org/jira/browse/WICKET-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464819 ] Eelco Hillenius commented on WICKET-201: I think I agree with all those arguments. And if 3 from the previous comment is implemented, we can just save the page when there is an actual new version and we don't have to save every time even if we already had a file, right? > refactor storing pages and versions > --- > > Key: WICKET-201 > URL: https://issues.apache.org/jira/browse/WICKET-201 > Project: Wicket > Issue Type: Improvement >Reporter: Eelco Hillenius > Assigned To: Johan Compagner > Fix For: 1.3, 2.0 > > > See http://www.nabble.com/refactor-storing-pages-and-versions-tf2943670.html > for a discussion. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (WICKET-214) Call all behaviors attached to the same event
Call all behaviors attached to the same event - Key: WICKET-214 URL: https://issues.apache.org/jira/browse/WICKET-214 Project: Wicket Issue Type: Improvement Components: wicket Affects Versions: 1.2.4, 1.3, 2.0 Reporter: Erik van Oosten If one adds 2 AjaxFormComponentUpdatingBehaviors with event "onchange" to the same form component, only the behavior that was added last will actually be called. Please make it so that both are called. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-213) NOTICE and LICENSE in jar files
[ https://issues.apache.org/jira/browse/WICKET-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464766 ] Frank Bille Jensen commented on WICKET-213: --- AFAIK we have to put the NOTICE and LICENSE in the META-INF in our released jar files (binary). I couldn't quickly see how to do that with maven, so if someone else knows how to do it, please take a look at this (Martijn? :) > NOTICE and LICENSE in jar files > --- > > Key: WICKET-213 > URL: https://issues.apache.org/jira/browse/WICKET-213 > Project: Wicket > Issue Type: Sub-task >Reporter: Frank Bille Jensen > Assigned To: Martijn Dashorst > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (WICKET-213) NOTICE and LICENSE in jar files
NOTICE and LICENSE in jar files --- Key: WICKET-213 URL: https://issues.apache.org/jira/browse/WICKET-213 Project: Wicket Issue Type: Sub-task Reporter: Frank Bille Jensen Assigned To: Martijn Dashorst -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-201) refactor storing pages and versions
[ https://issues.apache.org/jira/browse/WICKET-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464764 ] Johan Compagner commented on WICKET-201: I thought about it and it will be pretty hard to really change the current behavior i only see one: Reduce the Page version of a page to max 1 (1extra then the current one) why? > Store only changes This can't be done because those changes do have call backs to the page/parent anyway so this will be very, very hard to reliable implement. > Store only pages when the fall out of the pagemap (not the current page > anymore) This is also not possible. A page when created new or a version is created (is also 'new') then the page has to be saved to disc. There is no other way. Else we are to late the next time and we will loose versions of the page. (of course max page versions to 10+ will solve this but that is just what we don't want) So the only optimizations i can think if is: 1> If SecondLevelPageStore is used then the default max page versions is set to 1 (1 extra then the current) 2> save the page to disk when it is newly created or if there is a new version created in the current request. (this is really needed else we are to late the next time!) 3> make sure that the next version of a page is always ++ (and not decreased when a page version is roll backed) By the way, in wicket 2.0 there is code that can make versions of pages by only storing the changed real values (strings and numbers) I did develop that with discussions with igor how to not serialize the page but make a special snapshot of the complete page (hash mapping all the values) This code is now a bit untouched but maybe we could use it. The planning was to create a snapshot map when a request comes in for a page (just before anything happens to it) then compare it in the end and only store the really changed values. Then we have automatic page versioning.. But don't know if that could really work. > refactor storing pages and versions > --- > > Key: WICKET-201 > URL: https://issues.apache.org/jira/browse/WICKET-201 > Project: Wicket > Issue Type: Improvement >Reporter: Eelco Hillenius > Assigned To: Johan Compagner > Fix For: 1.3, 2.0 > > > See http://www.nabble.com/refactor-storing-pages-and-versions-tf2943670.html > for a discussion. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r496265 - /incubator/wicket/trunk/wicket/src/main/java/wicket/markup/parser/XmlPullParser.java
Author: jcompagner
Date: Mon Jan 15 01:48:51 2007
New Revision: 496265
URL: http://svn.apache.org/viewvc?view=rev&rev=496265
Log:
fix nullpointer if xml reader couldn't be constructed in the parse method
Modified:
incubator/wicket/trunk/wicket/src/main/java/wicket/markup/parser/XmlPullParser.java
Modified:
incubator/wicket/trunk/wicket/src/main/java/wicket/markup/parser/XmlPullParser.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/trunk/wicket/src/main/java/wicket/markup/parser/XmlPullParser.java?view=diff&rev=496265&r1=496264&r2=496265
==
---
incubator/wicket/trunk/wicket/src/main/java/wicket/markup/parser/XmlPullParser.java
(original)
+++
incubator/wicket/trunk/wicket/src/main/java/wicket/markup/parser/XmlPullParser.java
Mon Jan 15 01:48:51 2007
@@ -522,7 +522,7 @@
finally
{
inputStream.close();
- this.xmlReader.close();
+ if(this.xmlReader != null) this.xmlReader.close();
}
}
svn commit: r496262 - /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/parser/XmlPullParser.java
Author: jcompagner
Date: Mon Jan 15 01:44:15 2007
New Revision: 496262
URL: http://svn.apache.org/viewvc?view=rev&rev=496262
Log:
fix nullpointer if xml reader couldn't be constructed in the parse method
Modified:
incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/parser/XmlPullParser.java
Modified:
incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/parser/XmlPullParser.java
URL:
http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/parser/XmlPullParser.java?view=diff&rev=496262&r1=496261&r2=496262
==
---
incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/parser/XmlPullParser.java
(original)
+++
incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/parser/XmlPullParser.java
Mon Jan 15 01:44:15 2007
@@ -386,7 +386,7 @@
finally
{
resource.close();
- this.xmlReader.close();
+ if(this.xmlReader != null) this.xmlReader.close();
}
}
