Re: Wiki-Stuff new website memory problem
On 1/16/07, Igor Vaynberg [EMAIL PROTECTED] wrote: http://81.17.46.170/bamboo Do you think I can get some rights on that one? I want to make sure the tests run in maven as in eclipse. Username: frankbille Frank
Re: Wiki-Stuff new website memory problem
mvn test? Martijn On 1/16/07, Frank Bille [EMAIL PROTECTED] wrote: On 1/16/07, Igor Vaynberg [EMAIL PROTECTED] wrote: http://81.17.46.170/bamboo Do you think I can get some rights on that one? I want to make sure the tests run in maven as in eclipse. Username: frankbille Frank -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now! http://wicketframework.org
Re: Fixing ComponentTest in Wicket 1.x
The problem with this assumption is that the components get attached.
This is not (necessarily) so. Models get attached, but don't
participate in the request cycle.
MyPage(Person p) {
setModel(new CompoundPropertyModel(new LoadableDetachableModel(p)));
add(new Label(name).add(new
AjaxSelfUpdatingBehavior(Duration.seconds(1)));
}
This behavior will only touch the label, but attach the model of the
page, if I'm not mistaken.
I'd rather see an extra step in our request processing that detaches
all pages and their child components that have participated in the
request processing, instead of relying on the request targets to do
so.
Martijn
On 1/16/07, Igor Vaynberg [EMAIL PROTECTED] wrote:
seems like we really cant fix this.
what is happening is this:
the behavior url is rqeuested
behaviortarget is resolved and pushed onto the request cycle
behaviortarget pushes ajaxrequesttarget onto the request cycle
request is processed
request cycle cleans up by calling deatch() on all pushed request targets
ajaxrequsttarget detaches the page
behaviortarget detaches the page
thus two detaches
if we truelly want request targets to be independent this is how they have
to work if they make no assumptions
we have a multiple attach/detach guard on the page itself, but that doesnt
work because ajaxrequesttarget only attaches components it needs, so the
page is never marked as attached
(a) a solution i see is to do something similar we did in 2.0 where we force
super() call in internalattach/internaldetach and use flags to only
attach/detach components that have been attached.
(b) have a page.markattached() method - but this is ugly
(c) ignore the problem and allow detach() to be called more then once in 1.x
i think if we had a vote i would go vote for (a)
-igor
On 1/13/07, Jean-Baptiste Quenot [EMAIL PROTECTED] wrote:
Hi,
I'm trying to fix the last test failure in branch 1.x but I need
help. Here is the failure:
---
Test set: wicket.ComponentTest
---
Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.089 sec
FAILURE!
testDetachPageAjaxRequest(wicket.ComponentTest) Time elapsed: 0.046sec
FAILURE!
junit.framework.AssertionFailedError: expected:2 but was:3
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.failNotEquals(Assert.java:282)
at junit.framework.Assert.assertEquals(Assert.java:64)
at junit.framework.Assert.assertEquals(Assert.java:201)
at junit.framework.Assert.assertEquals(Assert.java:207)
at wicket.ComponentTest.testDetachPageAjaxRequest(
ComponentTest.java:92)
Apparently the component is detached 2 times: one time by
BehaviorRequestTarget, and one time by AjaxRequestTarget.
What is the expected process when a behavior is executed via AJAX?
Can you explain a little bit?
Oh and BTW once this test is fixed, IncrementalTableNavigationTest
will need to be updated. They are tied together as the number of
detachs has an impact on the generated behavior URLs apparently.
All the best,
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
--
Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket
Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now!
http://wicketframework.org
Re: Wiki-Stuff new website memory problem
yeah and very strange once like: java.lang.RuntimeException: org.w3c.dom.DOMException: NAMESPACE_ERR: An attempt is made to create or change an object in a way which is incorrect with regard to namespaces. at org.apache.xerces.dom.CoreDocumentImpl.checkDOMNSErr(Unknown Source) at org.apache.xerces.dom.AttrNSImpl.setName(Unknown Source) at org.apache.xerces.dom.AttrNSImpl.init(Unknown Source) at org.apache.xerces.dom.CoreDocumentImpl.createAttributeNS(Unknown Source) at org.apache.xerces.dom.CoreDocumentImpl.importNode(Unknown Source) at org.apache.xerces.dom.CoreDocumentImpl.importNode(Unknown Source) at org.apache.xerces.dom.CoreDocumentImpl.importNode(Unknown Source) On 1/16/07, Frank Bille [EMAIL PROTECTED] wrote: The problem is that if I run it on my machine I get 5 failing tests. On the build machine it's 113 failing tests... Frank On 1/16/07, Martijn Dashorst [EMAIL PROTECTED] wrote: mvn test? Martijn On 1/16/07, Frank Bille [EMAIL PROTECTED] wrote: On 1/16/07, Igor Vaynberg [EMAIL PROTECTED] wrote: http://81.17.46.170/bamboo Do you think I can get some rights on that one? I want to make sure the tests run in maven as in eclipse. Username: frankbille Frank -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now! http://wicketframework.org
Re: Fixing ComponentTest in Wicket 1.x
Maybe something like this: (quick 'pseudo' code)
final MarkupContainer.internalDetach()
{
super.internalDetach();
for each childere()
{
child.internalDetach();
child.hasOnDetachBeCalled(); // throws an excepton when
component.onDetach() is not reached.
}
}
Component.internalDetach() (can't be final because container has to be able
to override it)
{
if(attached)
{
attached = false;
onDetach()
}
}
Component.onDetach()
{
// set the flag that onDetach is called...
model.onDetach()
behaviours.onDetach()
}
Component.onAttach()
{
attached = true;
}
Then maybe win attach we do the same..
johan
On 1/16/07, Igor Vaynberg [EMAIL PROTECTED] wrote:
seems like we really cant fix this.
what is happening is this:
the behavior url is rqeuested
behaviortarget is resolved and pushed onto the request cycle
behaviortarget pushes ajaxrequesttarget onto the request cycle
request is processed
request cycle cleans up by calling deatch() on all pushed request targets
ajaxrequsttarget detaches the page
behaviortarget detaches the page
thus two detaches
if we truelly want request targets to be independent this is how they have
to work if they make no assumptions
we have a multiple attach/detach guard on the page itself, but that doesnt
work because ajaxrequesttarget only attaches components it needs, so the
page is never marked as attached
(a) a solution i see is to do something similar we did in 2.0 where we
force
super() call in internalattach/internaldetach and use flags to only
attach/detach components that have been attached.
(b) have a page.markattached() method - but this is ugly
(c) ignore the problem and allow detach() to be called more then once in
1.x
i think if we had a vote i would go vote for (a)
-igor
On 1/13/07, Jean-Baptiste Quenot [EMAIL PROTECTED] wrote:
Hi,
I'm trying to fix the last test failure in branch 1.x but I need
help. Here is the failure:
---
Test set: wicket.ComponentTest
---
Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.089sec
FAILURE!
testDetachPageAjaxRequest(wicket.ComponentTest) Time elapsed: 0.046sec
FAILURE!
junit.framework.AssertionFailedError: expected:2 but was:3
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.failNotEquals(Assert.java:282)
at junit.framework.Assert.assertEquals(Assert.java:64)
at junit.framework.Assert.assertEquals(Assert.java:201)
at junit.framework.Assert.assertEquals(Assert.java:207)
at wicket.ComponentTest.testDetachPageAjaxRequest(
ComponentTest.java:92)
Apparently the component is detached 2 times: one time by
BehaviorRequestTarget, and one time by AjaxRequestTarget.
What is the expected process when a behavior is executed via AJAX?
Can you explain a little bit?
Oh and BTW once this test is fixed, IncrementalTableNavigationTest
will need to be updated. They are tied together as the number of
detachs has an impact on the generated behavior URLs apparently.
All the best,
--
Jean-Baptiste Quenot
aka John Banana Qwerty
http://caraldi.com/jbq/
Re: Wiki-Stuff new website memory problem
On 1/16/07, Igor Vaynberg [EMAIL PROTECTED] wrote: confluence should be back up http://81.17.46.170/confluence/ notice we lost the port Thank you Igor. As you probably have seen I've ported some of the contents of the old site in the new one. I hope to finish by the end of this week (so we can move to do more insteresting stuff) BTW... are you going to install Jira as well? -- Filippo Diotalevi [EMAIL PROTECTED] http://www.diotalevi.com/weblog http://www.jugmilano.it
Re: Wiki-Stuff new website memory problem
done, let me know when you create an account -igor On 1/16/07, Filippo Diotalevi [EMAIL PROTECTED] wrote: On 1/16/07, Igor Vaynberg [EMAIL PROTECTED] wrote: confluence should be back up http://81.17.46.170/confluence/ notice we lost the port Thank you Igor. As you probably have seen I've ported some of the contents of the old site in the new one. I hope to finish by the end of this week (so we can move to do more insteresting stuff) BTW... are you going to install Jira as well? -- Filippo Diotalevi [EMAIL PROTECTED] http://www.diotalevi.com/weblog http://www.jugmilano.it
Re: Wiki-Stuff new website memory problem
On 1/16/07, Igor Vaynberg [EMAIL PROTECTED] wrote: done, let me know when you create an account Igor, my jira account is: fdiotalevi thanks -- filippo
Re: Wiki-Stuff new website memory problem
you are all set -igor On 1/16/07, Filippo Diotalevi [EMAIL PROTECTED] wrote: On 1/16/07, Igor Vaynberg [EMAIL PROTECTED] wrote: done, let me know when you create an account Igor, my jira account is: fdiotalevi thanks -- filippo
Re: Render a javascript in header via ajaxTarget
Matej Knopp a écrit :
I just tried it, 1.x and firefox. Works like charm for me :)
Are you sure you have caching turned of? The javascripts are cached
quite aggressively.
Ok, sorry to disturb you. I will check my sources.
Thanks
-Matej
Vincent Demay wrote:
Matej Knopp wrote:
That should work. I see no reason why ajax header contribution
should fail adding function. Do you use lastest wicket (any branch).
If so, can you please provide a quickstart app, so that I can look
at it?
Just try to put an alert('foo'); in a header contributor re-rendered
by ajax. When ajax response is evaluate no alert come out.
I work with lastest branch 1.X under Firefox
thanks
Re: Render a javascript in header via ajaxTarget
That's all right. Javascript header contribution is a very tricky thing
and while it's considered stable now, there still might be bugs in it,
so please, if the problem persists, id would be great if you provided a
quick start that can reproduce it.
-Matej
Vincent Demay wrote:
Matej Knopp a écrit :
I just tried it, 1.x and firefox. Works like charm for me :)
Are you sure you have caching turned of? The javascripts are cached
quite aggressively.
Ok, sorry to disturb you. I will check my sources.
Thanks
-Matej
Vincent Demay wrote:
Matej Knopp wrote:
That should work. I see no reason why ajax header contribution
should fail adding function. Do you use lastest wicket (any branch).
If so, can you please provide a quickstart app, so that I can look
at it?
Just try to put an alert('foo'); in a header contributor re-rendered
by ajax. When ajax response is evaluate no alert come out.
I work with lastest branch 1.X under Firefox
thanks
Re: Wiki-Stuff new website memory problem
i think bamboo counts each method as a test instead of each class -igor On 1/16/07, Frank Bille [EMAIL PROTECTED] wrote: The problem is that if I run it on my machine I get 5 failing tests. On the build machine it's 113 failing tests... Frank On 1/16/07, Martijn Dashorst [EMAIL PROTECTED] wrote: mvn test? Martijn On 1/16/07, Frank Bille [EMAIL PROTECTED] wrote: On 1/16/07, Igor Vaynberg [EMAIL PROTECTED] wrote: http://81.17.46.170/bamboo Do you think I can get some rights on that one? I want to make sure the tests run in maven as in eclipse. Username: frankbille Frank -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket 1.2.4 is as easy as 1-2-4. Download Wicket now! http://wicketframework.org
