Re: RequestCycle, max steps
Yes, that works for me. On 6/19/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: Ok. I set it to 100. Is that reasonable? Eelco On 6/19/07, Sean Sullivan <[EMAIL PROTECTED]> wrote: > Short.MAX_VALUE is definitely too high. > > I'd love to see a lower value. > > Sean > > On 6/18/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > > > > max int is actually a pretty rediculous default in itself. How about > > setting it to 1,000 or even 100 or such? > > > > Eelco > > > > On 6/18/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > > > Why would you want to do that? Sure, we can put a setter in there, but > > > it is really only meant to detect cycles. > > > > > > Eelco > > > > > > > > > On 6/18/07, Sean Sullivan <[EMAIL PROTECTED]> wrote: > > > > In RequestCycle.java, the steps() method has this code: > > > > > > > > * final* *int* maxSteps = Short.MAX_VALUE; > > > > > > > > Is there any way for me to override the maxSteps value? > > > > > > > > Would it be reasonable to have getter/setter methods? > > > > > > > > protected void setMaxSteps(int value) > > > > > > > > protected int getMaxSteps() > > > > > > > > > > > > Cheers, > > > > > > > > Sean > > > > > > > > > >
Re: RequestCycle, max steps
Ok. I set it to 100. Is that reasonable? Eelco On 6/19/07, Sean Sullivan <[EMAIL PROTECTED]> wrote: Short.MAX_VALUE is definitely too high. I'd love to see a lower value. Sean On 6/18/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > > max int is actually a pretty rediculous default in itself. How about > setting it to 1,000 or even 100 or such? > > Eelco > > On 6/18/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > > Why would you want to do that? Sure, we can put a setter in there, but > > it is really only meant to detect cycles. > > > > Eelco > > > > > > On 6/18/07, Sean Sullivan <[EMAIL PROTECTED]> wrote: > > > In RequestCycle.java, the steps() method has this code: > > > > > > * final* *int* maxSteps = Short.MAX_VALUE; > > > > > > Is there any way for me to override the maxSteps value? > > > > > > Would it be reasonable to have getter/setter methods? > > > > > > protected void setMaxSteps(int value) > > > > > > protected int getMaxSteps() > > > > > > > > > Cheers, > > > > > > Sean > > > > > >
Re: RequestCycle, max steps
Short.MAX_VALUE is definitely too high. I'd love to see a lower value. Sean On 6/18/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: max int is actually a pretty rediculous default in itself. How about setting it to 1,000 or even 100 or such? Eelco On 6/18/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > Why would you want to do that? Sure, we can put a setter in there, but > it is really only meant to detect cycles. > > Eelco > > > On 6/18/07, Sean Sullivan <[EMAIL PROTECTED]> wrote: > > In RequestCycle.java, the steps() method has this code: > > > > * final* *int* maxSteps = Short.MAX_VALUE; > > > > Is there any way for me to override the maxSteps value? > > > > Would it be reasonable to have getter/setter methods? > > > > protected void setMaxSteps(int value) > > > > protected int getMaxSteps() > > > > > > Cheers, > > > > Sean > > >
Re: RequestCycle, max steps
fine by me -igor On 6/18/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: max int is actually a pretty rediculous default in itself. How about setting it to 1,000 or even 100 or such? Eelco On 6/18/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > Why would you want to do that? Sure, we can put a setter in there, but > it is really only meant to detect cycles. > > Eelco > > > On 6/18/07, Sean Sullivan <[EMAIL PROTECTED]> wrote: > > In RequestCycle.java, the steps() method has this code: > > > > * final* *int* maxSteps = Short.MAX_VALUE; > > > > Is there any way for me to override the maxSteps value? > > > > Would it be reasonable to have getter/setter methods? > > > > protected void setMaxSteps(int value) > > > > protected int getMaxSteps() > > > > > > Cheers, > > > > Sean > > >
Re: RequestCycle, max steps
max int is actually a pretty rediculous default in itself. How about setting it to 1,000 or even 100 or such? Eelco On 6/18/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: Why would you want to do that? Sure, we can put a setter in there, but it is really only meant to detect cycles. Eelco On 6/18/07, Sean Sullivan <[EMAIL PROTECTED]> wrote: > In RequestCycle.java, the steps() method has this code: > > * final* *int* maxSteps = Short.MAX_VALUE; > > Is there any way for me to override the maxSteps value? > > Would it be reasonable to have getter/setter methods? > > protected void setMaxSteps(int value) > > protected int getMaxSteps() > > > Cheers, > > Sean >
Re: RequestCycle, max steps
Why would you want to do that? Sure, we can put a setter in there, but it is really only meant to detect cycles. Eelco On 6/18/07, Sean Sullivan <[EMAIL PROTECTED]> wrote: In RequestCycle.java, the steps() method has this code: * final* *int* maxSteps = Short.MAX_VALUE; Is there any way for me to override the maxSteps value? Would it be reasonable to have getter/setter methods? protected void setMaxSteps(int value) protected int getMaxSteps() Cheers, Sean
Re: RequestCycle, max steps
why would you want to do that? that is there only to detect run away loops. -igor On 6/18/07, Sean Sullivan <[EMAIL PROTECTED]> wrote: In RequestCycle.java, the steps() method has this code: * final* *int* maxSteps = Short.MAX_VALUE; Is there any way for me to override the maxSteps value? Would it be reasonable to have getter/setter methods? protected void setMaxSteps(int value) protected int getMaxSteps() Cheers, Sean
