Re: VOTE accept fix to WICKET-432 into 1.2.x

2007-03-31 Thread Martijn Dashorst 

How does this affect people that have overridden Page.onAttach() but
don't call super()?

Martijn

Re: VOTE accept fix to WICKET-432 into 1.2.x

2007-03-31 Thread Martijn Dashorst 

On 3/31/07, Martijn Dashorst [EMAIL PROTECTED] wrote:

How does this affect people that have overridden Page.onAttach() but
don't call super()?


I saw that you fixed that first commit. +1

Martijn

--
Learn Wicket at ApacheCon Europe: http://apachecon.com
Join the wicket community at irc.freenode.net: ##wicket
Wicket 1.2.5 will keep your server alive. Download Wicket now!
http://wicketframework.org

Re: VOTE accept fix to WICKET-432 into 1.2.x

2007-03-31 Thread Gwyn Evans 

+1
/Gwyn

On 31/03/07, Igor Vaynberg [EMAIL PROTECTED] wrote:

the subject says it all.

i kinda jumped the gun on this one and committed already by mistake :( my
appologies.

if the vote doesnt pass i will revert it.

-igor




--
Download Wicket 1.2.5 now! - http://wicketframework.org

Re: VOTE accept fix to WICKET-432 into 1.2.x

2007-03-30 Thread Igor Vaynberg 

+1

-igor


On 3/30/07, Igor Vaynberg [EMAIL PROTECTED] wrote:


the subject says it all.

i kinda jumped the gun on this one and committed already by mistake :( my
appologies.

if the vote doesnt pass i will revert it.

-igor