[Wicket-user] [wicket 1.2.4] JIRA issue? Ampersand char problem in "wicket.markup.html.link.ExternalLink.java"
Hi all,
i experienced a problem with "href" attribute of rendered ExternalLink.
In our application, i needed to parse rendered html in a SaxParser
implementation. But i couldnt! When i looked in source codes of
ExternalLink and Link, i saw the problematic line is that, in ExternalLink
there is no escaping for & signs.
line 159:
tag.put("href", url);
should be as below
tag.put("href", Strings.*replaceAll*(url, "&", "&")); (which
was already in the Link.java file)
Regards
Kadir
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] [wicket 1.2.4] JIRA issue? Ampersand char problem in "wicket.markup.html.link.ExternalLink.java"
Fixed, see http://issues.apache.org/jira/browse/WICKET-251
Eelco
On 1/23/07, Kadir Sener GUMUS <[EMAIL PROTECTED]> wrote:
> Hi all,
> i experienced a problem with "href" attribute of rendered ExternalLink.
> In our application, i needed to parse rendered html in a SaxParser
> implementation. But i couldnt! When i looked in source codes of
> ExternalLink and Link, i saw the problematic line is that, in ExternalLink
> there is no escaping for & signs.
>
> line 159:
> tag.put("href", url);
> should be as below
> tag.put("href" , Strings.replaceAll(url, "&", "&")); (which
> was already in the Link.java file)
>
>
> Regards
> Kadir
> -
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
>
> ___
> Wicket-user mailing list
> Wicket-user@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wicket-user
>
>
>
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] [wicket 1.2.4] JIRA issue? Ampersand char problem in "wicket.markup.html.link.ExternalLink.java"
this has to be fixed different later on.
Because this is horrible. Everywhere we have those special url encoding char
replacing
of urls. That should go into one place (at moment of constructing and
rendering the url)
johan
On 2/2/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
Fixed, see http://issues.apache.org/jira/browse/WICKET-251
Eelco
On 1/23/07, Kadir Sener GUMUS <[EMAIL PROTECTED]> wrote:
> Hi all,
> i experienced a problem with "href" attribute of rendered ExternalLink.
> In our application, i needed to parse rendered html in a SaxParser
> implementation. But i couldnt! When i looked in source codes of
> ExternalLink and Link, i saw the problematic line is that, in
ExternalLink
> there is no escaping for & signs.
>
> line 159:
> tag.put("href", url);
> should be as below
> tag.put("href" , Strings.replaceAll(url, "&", "&"));
(which
> was already in the Link.java file)
>
>
> Regards
> Kadir
>
-
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share
your
> opinions on IT & business topics through brief surveys - and earn cash
>
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
>
> ___
> Wicket-user mailing list
> Wicket-user@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wicket-user
>
>
>
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job
easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] [wicket 1.2.4] JIRA issue? Ampersand char problem in "wicket.markup.html.link.ExternalLink.java"
On 2/4/07, Johan Compagner <[EMAIL PROTECTED]> wrote: > this has to be fixed different later on. > Because this is horrible. Everywhere we have those special url encoding char > replacing > of urls. That should go into one place (at moment of constructing and > rendering the url) If that is possible, that is great. However, if I remember correctly that is what we had more than a year ago, and that didn't work in some occasions (javascript I think). Anyone if free to fix (and test!) of course, but until that time, this solved a real problem for a real user. Eelco - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
