[Widelands-dev] [Merge] lp:~hjd/widelands/section-initialization into lp:widelands

[Hans Joachim Desserud]

Hans Joachim Desserud has proposed merging 
lp:~hjd/widelands/section-initialization into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~hjd/widelands/section-initialization/+merge/242577

Found by scan-build.
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~hjd/widelands/section-initialization into lp:widelands.
=== modified file 'src/ui_fsmenu/options.cc'
--- src/ui_fsmenu/options.cc	2014-11-22 10:18:20 +
+++ src/ui_fsmenu/options.cc	2014-11-22 22:12:59 +
@@ -53,10 +53,8 @@
 };
 
 void add_languages_to_list(UI::Listselect* list, const std::string& language) {
-	Section* s = &g_options.pull_section("global");
-
 	Profile ln("txts/languages");
-	s = &ln.pull_section("languages");
+	Section* s = &ln.pull_section("languages");
 	bool own_selected = "" == language || "en" == language;
 
 	// Add translation directories to the list.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

[GunChleoc]

Running clang-format is good :) Doesn't work on my system though :(
-- 
https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/seafaring-ai into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/save_minimap into lp:widelands

[noreply]

The proposal to merge lp:~widelands-dev/widelands/save_minimap into 
lp:widelands has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/save_minimap/+merge/242567
-- 
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/save_minimap.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/save_minimap into lp:widelands

[GunChleoc]

Review: Approve

LGTM, will merge
-- 
https://code.launchpad.net/~widelands-dev/widelands/save_minimap/+merge/242567
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/save_minimap.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/save_minimap into lp:widelands

[SirVer]

SirVer has proposed merging lp:~widelands-dev/widelands/save_minimap into 
lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/save_minimap/+merge/242567

Saves a minimap into the folder of the map. This is a step towards removing the 
software renderer.
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/save_minimap into lp:widelands.
=== added file 'maps/Atoll.wmf/minimap.png'
Binary files maps/Atoll.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Atoll.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Calvisson.wmf/minimap.png'
Binary files maps/Calvisson.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Calvisson.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Checkmate.wmf/minimap.png'
Binary files maps/Checkmate.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Checkmate.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Comet Island.wmf/minimap.png'
Binary files maps/Comet Island.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Comet Island.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Crater.wmf/minimap.png'
Binary files maps/Crater.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Crater.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Crossing the horizon.wmf/minimap.png'
Binary files maps/Crossing the horizon.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Crossing the horizon.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Desert Tournament.wmf/minimap.png'
Binary files maps/Desert Tournament.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Desert Tournament.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Dry Riverbed.wmf/minimap.png'
Binary files maps/Dry Riverbed.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Dry Riverbed.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Elven Forests.wmf/minimap.png'
Binary files maps/Elven Forests.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Elven Forests.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Fellowships.wmf/minimap.png'
Binary files maps/Fellowships.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Fellowships.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Finlakes.wmf/minimap.png'
Binary files maps/Finlakes.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Finlakes.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Firegames.wmf/minimap.png'
Binary files maps/Firegames.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Firegames.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Four Castles.wmf/minimap.png'
Binary files maps/Four Castles.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Four Castles.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Four Mountains.wmf/minimap.png'
Binary files maps/Four Mountains.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Four Mountains.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Glacier Lake.wmf/minimap.png'
Binary files maps/Glacier Lake.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Glacier Lake.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Golden Peninsula.wmf/minimap.png'
Binary files maps/Golden Peninsula.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Golden Peninsula.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Ice wars.wmf/minimap.png'
Binary files maps/Ice wars.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Ice wars.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Impact.wmf/minimap.png'
Binary files maps/Impact.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Impact.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Islands at war.wmf/minimap.png'
Binary files maps/Islands at war.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Islands at war.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Kings and Queens.wmf/minimap.png'
Binary files maps/Kings and Queens.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Kings and Queens.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Lake of tranquility.wmf/minimap.png'
Binary files maps/Lake of tranquility.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Lake of tranquility.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Last Bastion.wmf/minimap.png'
Binary files maps/Last Bastion.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Last Bastion.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/Long, long way.wmf/minimap.png'
Binary files maps/Long, long way.wmf/minimap.png	1970-01-01 00:00:00 + and maps/Long, long way.wmf/minimap.png	2014-11-22 15:40:05 + differ
=== added file 'maps/MP Sce

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

[TiborB]

next time just put a comment into diff here whenever you see someting that 
needs fixing - it will be easier for me to get what you mean
-- 
https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/seafaring-ai into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

[TiborB]

@GunChleoc - yes, there was one error left unfixed in defaultai.cc - fixed

cosmetic changes happened on files out of ai directory (like ship.cc) that I 
had not touched before. And were caused by clang-format. Next time somebody 
will work on them and run clang-format on them, there will be no cosmetic 
changes, of course.
-- 
https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/seafaring-ai into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ui_fixes into lp:widelands

[GunChleoc]

Filed a bug report for the Alt problem: 
https://bugs.launchpad.net/widelands/+bug/1395322
-- 
https://code.launchpad.net/~widelands-dev/widelands/ui_fixes/+merge/242561
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/ui_fixes into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ui_fixes into lp:widelands

[noreply]

The proposal to merge lp:~widelands-dev/widelands/ui_fixes into lp:widelands 
has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ui_fixes/+merge/242561
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/ui_fixes into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ui_fixes into lp:widelands

[SirVer]

1. remerged trunk and fixed all conflicts. 
2. that is probably an issue with the window manager. It works for me. I think 
we should rethink the alternate tools (maybe left/right mouse buttons).

going to merge.
-- 
https://code.launchpad.net/~widelands-dev/widelands/ui_fixes/+merge/242561
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/ui_fixes into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_alt_panning_of_window into lp:widelands

[SirVer]

valid comment, however we have to deal with this in another fashion anyways. 
Tablets do not have an ALT key.
-- 
https://code.launchpad.net/~widelands-dev/widelands/remove_alt_panning_of_window/+merge/242560
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/remove_alt_panning_of_window into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_alt_panning_of_window into lp:widelands

[Gabriel Margiani]

didn't realise this is already merged, uncomitting isn't worth it.
-- 
https://code.launchpad.net/~widelands-dev/widelands/remove_alt_panning_of_window/+merge/242560
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/remove_alt_panning_of_window into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_alt_panning_of_window into lp:widelands

[Gabriel Margiani]

On very big maps using really low resolution, the minimap can get bigger than 
the screen, so you wont be able to move it without alt dragging (on 800x600, 
you need to the minimap of a 512x512 map to trigger the problem). But I am not 
sure if we should really care about it, such low-resolution screens are quite 
rare today on devices where Widelands runs on. 
-- 
https://code.launchpad.net/~widelands-dev/widelands/remove_alt_panning_of_window/+merge/242560
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/remove_alt_panning_of_window into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ui_fixes into lp:widelands

[GunChleoc]

The proposal to merge lp:~widelands-dev/widelands/ui_fixes into lp:widelands 
has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ui_fixes/+merge/242561
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/ui_fixes into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ui_fixes into lp:widelands

[GunChleoc]

LGTM. 2 issues though:

1. Don't forget to remove the text conflict in src/ui_basic/panel.h

2. Alt switches the tool, but clicking doesn't do anything. I assume it's the 
Ubuntu window manager getting in the way.
-- 
https://code.launchpad.net/~widelands-dev/widelands/ui_fixes/+merge/242561
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/ui_fixes into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

[GunChleoc]

I will have to look at this in detail later, my brain's not working properly 
today.

Codecheck still comes up with an error, could you please always run codecheck 
over the complete code base before submitting a merge request? This way, we 
won't have cosmetic changes in the diff in the future.

I also saw that there are commented out lines of code in the diff, they should 
go before a merge.
-- 
https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/seafaring-ai into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ui_fixes into lp:widelands

[SirVer]

SirVer has proposed merging lp:~widelands-dev/widelands/ui_fixes into 
lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ui_fixes/+merge/242561

- Uses SDLK_ (logical keycodes) instead of SDL_SCANCODE (physical keycodes) for
  hotkeys.
- A panel that handles textinput should also handle all key inputs so that they
  do not propagate.
- Removes a bunch of unneeded ifs and other save code changes.
- Renames set_think() to set_thinks().

-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/ui_fixes into lp:widelands.
=== modified file 'src/editor/editorinteractive.cc'
--- src/editor/editorinteractive.cc	2014-11-13 18:48:57 +
+++ src/editor/editorinteractive.cc	2014-11-22 12:01:09 +
@@ -394,16 +394,16 @@
 			handled = true;
 			break;
 
-		case SDL_SCANCODE_LSHIFT:
-		case SDL_SCANCODE_RSHIFT:
+		case SDLK_LSHIFT:
+		case SDLK_RSHIFT:
 			if (tools.use_tool == EditorTool::First)
 select_tool(tools.current(), EditorTool::Second);
 			handled = true;
 			break;
 
-		case SDL_SCANCODE_LALT:
-		case SDL_SCANCODE_RALT:
-		case SDL_SCANCODE_MODE:
+		case SDLK_LALT:
+		case SDLK_RALT:
+		case SDLK_MODE:
 			if (tools.use_tool == EditorTool::First)
 select_tool(tools.current(), EditorTool::Third);
 			handled = true;
@@ -470,6 +470,7 @@
 m_history.undo_action(egbase().world());
 			handled = true;
 			break;
+
 		case SDLK_y:
 			if (code.mod & (KMOD_LCTRL | KMOD_RCTRL))
 m_history.redo_action(egbase().world());
@@ -477,16 +478,15 @@
 			break;
 		default:
 			break;
-
 		}
 	} else {
 		// key up events
 		switch (code.sym) {
-		case SDL_SCANCODE_LSHIFT:
-		case SDL_SCANCODE_RSHIFT:
-		case SDL_SCANCODE_LALT:
-		case SDL_SCANCODE_RALT:
-		case SDL_SCANCODE_MODE:
+		case SDLK_LSHIFT:
+		case SDLK_RSHIFT:
+		case SDLK_LALT:
+		case SDLK_RALT:
+		case SDLK_MODE:
 			if (tools.use_tool != EditorTool::First)
 select_tool(tools.current(), EditorTool::First);
 			handled = true;

=== modified file 'src/editor/ui_menus/editor_player_menu.cc'
--- src/editor/ui_menus/editor_player_menu.cc	2014-10-27 10:14:10 +
+++ src/editor/ui_menus/editor_player_menu.cc	2014-11-22 12:01:09 +
@@ -90,8 +90,7 @@
 	}
 	update();
 
-	set_think(true);
-
+	set_thinks(true);
 }
 
 /**

=== modified file 'src/graphic/graphic.cc'
--- src/graphic/graphic.cc	2014-11-13 06:45:36 +
+++ src/graphic/graphic.cc	2014-11-22 12:01:09 +
@@ -295,7 +295,6 @@
 */
 void Graphic::toggle_fullscreen()
 {
-	log("Try SDL_WM_ToggleFullScreen...\n");
 	// TODO(unknown): implement proper fullscreening here. The way it can work is to
 	// recreate SurfaceCache but keeping ImageCache around. Then exiting and
 	// reinitalizing the SDL Video Mode should just work: all surface are

=== modified file 'src/ui_basic/button.cc'
--- src/ui_basic/button.cc	2014-11-22 10:35:14 +
+++ src/ui_basic/button.cc	2014-11-22 12:01:09 +
@@ -58,10 +58,9 @@
 	m_clr_down  (229, 161, 2),
 	m_draw_caret(false)
 {
-	set_think(false);
+	set_thinks(false);
 }
 
-
 Button::Button //  for pictorial buttons
 	(Panel * const parent,
 	 const std::string & name,
@@ -87,7 +86,7 @@
 	m_clr_down  (229, 161, 2),
 	m_draw_caret(false)
 {
-	set_think(false);
+	set_thinks(false);
 }
 
 
@@ -142,7 +141,7 @@
 	else {
 		if (m_pressed) {
 			m_pressed = false;
-			set_think(false);
+			set_thinks(false);
 			grab_mouse(false);
 		}
 		m_enabled = false;
@@ -307,7 +306,7 @@
 		if (m_repeating) {
 			m_time_nextact =
 WLApplication::get()->get_time() + MOUSE_BUTTON_AUTOREPEAT_DELAY;
-			set_think(true);
+			set_thinks(true);
 		}
 	}
 	update();
@@ -320,7 +319,7 @@
 
 	if (m_pressed) {
 		m_pressed = false;
-		set_think(false);
+		set_thinks(false);
 		grab_mouse(false);
 		update();
 		if (m_highlighted && m_enabled) {

=== modified file 'src/ui_basic/editbox.cc'
--- src/ui_basic/editbox.cc	2014-11-22 10:23:33 +
+++ src/ui_basic/editbox.cc	2014-11-22 12:01:09 +
@@ -23,6 +23,7 @@
 
 #include 
 
+#include "base/log.h"
 #include "graphic/font.h"
 #include "graphic/font_handler.h"
 #include "graphic/rendertarget.h"
@@ -71,7 +72,7 @@
 	m_history_active(false),
 	m_history_position(-1)
 {
-	set_think(false);
+	set_thinks(false);
 
 	m->background = background;
 	m->fontname = UI_FONT_NAME;
@@ -86,7 +87,7 @@
 
 	set_handle_mouse(true);
 	set_can_focus(true);
-	set_handle_textinput(true);
+	set_handle_textinput();
 
 	// Initialize history as empty string
 	for (uint8_t i = 0; i < CHAT_HISTORY_SIZE; ++i)
@@ -232,7 +233,7 @@
 			//let the panel handle the tab key
 			return false;
 
-		case SDL_SCANCODE_KP_ENTER:
+		case SDLK_KP_ENTER:
 		case SDLK_RETURN:
 			// Save history if active and text is not empty
 			if (m_history_active) {
@@ -246,7 +247,7 @@
 			ok();
 			return true;
 
-		case SDL_SCANCODE_KP_PERIOD:
+		case SDLK_KP_PERIOD:
 			if (code.mod & KMOD_NUM) {
 break;
 			}
@@ -269,12

[Widelands-dev] [Merge] lp:~hjd/widelands/debian-reduce-paths into lp:~widelands-dev/widelands/debian

[noreply]

The proposal to merge lp:~hjd/widelands/debian-reduce-paths into 
lp:~widelands-dev/widelands/debian has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~hjd/widelands/debian-reduce-paths/+merge/239646
-- 
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/debian.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_alt_panning_of_window into lp:widelands

[noreply]

The proposal to merge lp:~widelands-dev/widelands/remove_alt_panning_of_window 
into lp:widelands has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/remove_alt_panning_of_window/+merge/242560
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/remove_alt_panning_of_window into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_caching_in_ui into lp:widelands

[GunChleoc]

The proposal to merge lp:~widelands-dev/widelands/remove_caching_in_ui into 
lp:widelands has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/remove_caching_in_ui/+merge/242559
-- 
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/remove_caching_in_ui.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_caching_in_ui into lp:widelands

[GunChleoc]

Review: Approve

LGTM, will merge.
-- 
https://code.launchpad.net/~widelands-dev/widelands/remove_caching_in_ui/+merge/242559
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/remove_caching_in_ui.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-977980 into lp:widelands

[SirVer]

Review: Needs Fixing

That is not a proper fix. Assume this order of action:

- you set 10 fish on water.
- you switch the terrain to be greenland. Now you have 10 fish on greenland and 
the map is broken.
- you now click the reduce resource tool -> you now have 9 fish on water, but 
that is still wrong.

Also, your fix should then also be applied to the set resources tool. 

I left a comment on the bug on how I believe this should be fixed.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-977980/+merge/242410
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-977980.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_alt_panning_of_window into lp:widelands

[SirVer]

SirVer has proposed merging 
lp:~widelands-dev/widelands/remove_alt_panning_of_window into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/remove_alt_panning_of_window/+merge/242560

Removes alt dragging of windows since it never worked properly in the editor.
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/remove_alt_panning_of_window into lp:widelands.
=== modified file 'src/ui_basic/panel.cc'
--- src/ui_basic/panel.cc	2014-10-28 12:53:29 +
+++ src/ui_basic/panel.cc	2014-11-22 10:52:38 +
@@ -735,18 +735,6 @@
 	return draw_tooltip(rt, tooltip());
 }
 
-
-/**
- * Called whenever the user presses a mouse button in the panel while pressing the alt-key.
- * This function is called first on the parent panels.
- * It should be only overwritten by the UI::Window class.
- * \return true if the click was processed, false otherwise
- */
-bool Panel::handle_alt_drag(int32_t /* x */, int32_t /* y */)
-{
-	return false;
-}
-
 /**
  * Enable/Disable mouse handling by this panel
  * Default is enabled. Note that when mouse handling is disabled, child panels
@@ -1025,17 +1013,6 @@
 	if (_flags & pf_top_on_click)
 		move_to_top();
 
-	//  TODO(unknown): This code is erroneous. It checks the current key state. What it
-	//  needs is the key state at the time the mouse was clicked. See the
-	//  usage comment for get_key_state.
-	//  Some window managers use alt-drag, so we can't only use the alt keys
-	if
-		((!_g_mousegrab) && (btn == SDL_BUTTON_LEFT) &&
-		 ((get_key_state(SDL_SCANCODE_LALT) | get_key_state(SDL_SCANCODE_RALT) |
-			get_key_state(SDL_SCANCODE_MODE) | get_key_state(SDL_SCANCODE_LSHIFT
-		if (handle_alt_drag(x, y))
-			return true;
-
 	if (_g_mousegrab != this)
 		for
 			(Panel * child = _fchild;

=== modified file 'src/ui_basic/panel.h'
--- src/ui_basic/panel.h	2014-10-27 08:37:54 +
+++ src/ui_basic/panel.h	2014-11-22 10:52:38 +
@@ -191,7 +191,6 @@
 	virtual bool handle_mousewheel(uint32_t which, int32_t x, int32_t y);
 	virtual bool handle_key(bool down, SDL_Keysym);
 	virtual bool handle_textinput(const char* text);
-	virtual bool handle_alt_drag(int32_t x, int32_t y);
 	virtual bool handle_tooltip();
 
 	/// \returns whether a certain given is currently down.

=== modified file 'src/ui_basic/window.cc'
--- src/ui_basic/window.cc	2014-11-02 20:31:40 +
+++ src/ui_basic/window.cc	2014-11-22 10:52:38 +
@@ -464,17 +464,6 @@
 	return true;
 }
 
-bool Window::handle_alt_drag(int32_t mx, int32_t my)
-{
-	_dragging = true;
-	_drag_start_win_x = get_x();
-	_drag_start_win_y = get_y();
-	_drag_start_mouse_x = get_x() + get_lborder() + mx;
-	_drag_start_mouse_y = get_y() + get_tborder() + my;
-	grab_mouse(true);
-	return true;
-}
-
 // Always consume the tooltip event to prevent tooltips from
 // our parent to be rendered
 bool Window::handle_tooltip()

=== modified file 'src/ui_basic/window.h'
--- src/ui_basic/window.h	2014-07-26 10:43:23 +
+++ src/ui_basic/window.h	2014-11-22 10:52:38 +
@@ -86,7 +86,6 @@
 	bool handle_mouserelease(uint8_t btn, int32_t mx, int32_t my) override;
 	bool handle_mousemove
 		(uint8_t state, int32_t mx, int32_t my, int32_t xdiff, int32_t ydiff) override;
-	bool handle_alt_drag (int32_t mx, int32_t my) override;
 	bool handle_tooltip() override;
 
 protected:

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_caching_in_ui into lp:widelands

[SirVer]

SirVer has proposed merging lp:~widelands-dev/widelands/remove_caching_in_ui 
into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/remove_caching_in_ui/+merge/242559

In preparation of removing the software rendering: Removes caching from the UI 
implementation. It was not used often (only for complete windows) and will 
likely be slower on OpenGL anyways.
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/remove_caching_in_ui into lp:widelands.
=== modified file 'src/ui_basic/CMakeLists.txt'
--- src/ui_basic/CMakeLists.txt	2014-11-22 10:23:33 +
+++ src/ui_basic/CMakeLists.txt	2014-11-22 10:39:42 +
@@ -60,7 +60,6 @@
 graphic
 graphic_color
 graphic_image
-graphic_surface
 helper
 io_filesystem
 # TODO(sirver): should not depend on logic

=== modified file 'src/ui_basic/button.cc'
--- src/ui_basic/button.cc	2014-11-02 20:31:40 +
+++ src/ui_basic/button.cc	2014-11-22 10:39:42 +
@@ -59,9 +59,6 @@
 	m_draw_caret(false)
 {
 	set_think(false);
-
-	if (m_pic_background)
-		set_cache(true);
 }
 
 
@@ -91,9 +88,6 @@
 	m_draw_caret(false)
 {
 	set_think(false);
-
-	if (m_pic_background)
-		set_cache(true);
 }
 
 

=== modified file 'src/ui_basic/panel.cc'
--- src/ui_basic/panel.cc	2014-10-28 12:53:29 +
+++ src/ui_basic/panel.cc	2014-11-22 10:39:42 +
@@ -19,13 +19,12 @@
 
 #include "ui_basic/panel.h"
 
+// NOCOM(#sirver): check includes
 #include "base/log.h"
 #include "graphic/font_handler.h"
 #include "graphic/font_handler1.h"
 #include "graphic/graphic.h"
 #include "graphic/rendertarget.h"
-#include "graphic/surface.h"
-#include "graphic/surface_cache.h"
 #include "helper.h"
 #include "profile/profile.h"
 #include "sound/sound_handler.h"
@@ -38,40 +37,6 @@
 
 namespace UI {
 
-// Caches the image of the inner of a panel. Will redraw the Panel on cache misses.
-class Panel::CacheImage : public Image {
-public:
-	CacheImage(Panel* const panel, uint16_t w, uint16_t h) :
-		width_(w),
-		height_(h),
-		panel_(panel),
-		hash_("cache_image_" + random_string("0123456789ABCDEFGH", 32)) {}
-	virtual ~CacheImage() {}
-
-	// Implements Image.
-	uint16_t width() const override {return width_;}
-	uint16_t height() const override {return height_;}
-	const string& hash() const override {return hash_;}
-	Surface* surface() const override {
-		Surface* rv = g_gr->surfaces().get(hash_);
-		if (rv)
-			return rv;
-
-		rv = g_gr->surfaces().insert(hash_, Surface::create(width_, height_), true);
-
-		// Cache miss! We have to redraw our panel onto our surface.
-		RenderTarget inner(rv);
-		panel_->do_draw_inner(inner);
-
-		return rv;
-	}
-
-private:
-	const int16_t width_, height_;
-	Panel* const panel_;  // not owned.
-	const string hash_;
-};
-
 Panel * Panel::_modal   = nullptr;
 Panel * Panel::_g_mousegrab = nullptr;
 Panel * Panel::_g_mousein   = nullptr;
@@ -93,7 +58,6 @@
 	:
 	_parent(nparent), _fchild(nullptr), _lchild(nullptr), _mousein(nullptr), _focus(nullptr),
 	_flags(pf_handle_mouse|pf_think|pf_visible),
-	_needdraw(false),
 	_x(nx), _y(ny), _w(nw), _h(nh),
 	_lborder(0), _rborder(0), _tborder(0), _bborder(0),
 	_border_snap_distance(0), _panel_snap_distance(0),
@@ -308,12 +272,10 @@
  * Move the panel. Panel's position is relative to the parent.
  */
 void Panel::set_pos(const Point n) {
-	bool nd = _needdraw;
 	update(0, 0, _w, _h);
 	_x = n.x;
 	_y = n.y;
 	update(0, 0, _w, _h);
-	_needdraw = nd;
 }
 
 /**
@@ -510,8 +472,6 @@
 		 y >= static_cast(_h) || y + h <= 0)
 		return;
 
-	_needdraw = true;
-
 	if (_parent) {
 		_parent->update_inner(x + _x, y + _y, w, h);
 	} else {
@@ -558,24 +518,6 @@
 }
 
 /**
- * Enable/Disable the drawing cache.
- * When the drawing cache is enabled, draw() is only called after an update()
- * has been called explicitly. Otherwise, the contents of the panel are copied
- * from an \ref Surface containing the cached image.
- *
- * \note Caching only works properly for solid panels that have no transparency.
- */
-void Panel::set_cache(bool cache)
-{
-	if (cache) {
-		_flags |= pf_cache;
-	} else {
-		_flags &= ~pf_cache;
-		_cache.reset();
-	}
-}
-
-/**
  * Called once per event loop pass, unless set_think(false) has
  * been called. It is intended to be used for animations and game logic.
  */
@@ -934,31 +876,12 @@
 
 	draw_border(dst);
 
-	if (_flags & pf_cache) {
-		uint32_t innerw = _w - (_lborder + _rborder);
-		uint32_t innerh = _h - (_tborder + _bborder);
-
-	if (!_cache || _cache->width() != innerw || _cache->height() != innerh) {
-			_cache.reset(new CacheImage(this, innerw, innerh));
-			_needdraw = true;
-		}
-
-		if (_needdraw) {
-			RenderTarget inner(_cache->surface());
-			do_draw_inner(inner);
-
-			_needdraw = false;
-		}
-
-		dst.blit(Point(_lborder, _tborder), _cache.get(), CM_Copy);
-	} else {
-		Rect innerwindow
-			(Point(_lborder, _tborder),
-

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-768826 into lp:widelands

[GunChleoc]

Review: Needs Fixing

draw_overlay needs to know if it's drawing for the editor or for a game/replay. 
I don't know how the control flow is here and what is accessible from the 
function; you might need to add a function parameter.

Some more comments in the diff.

Diff comments:

> === modified file 'src/wui/interactive_base.cc'
> --- src/wui/interactive_base.cc   2014-11-13 08:25:45 +
> +++ src/wui/interactive_base.cc   2014-11-21 21:28:04 +
> @@ -403,15 +403,18 @@
>  */
>  void InteractiveBase::draw_overlay(RenderTarget& dst) {
>  
> + const Map & map = egbase().map();
> +
>   // Blit node information when in debug mode.
>   if (get_display_flag(dfDebug) || !dynamic_cast(&egbase())) 
> {
>   const std::string 
> gametime(gametimestring(egbase().get_gametime()));
>   const std::string gametime_text = as_uifont(gametime, 
> UI_FONT_SIZE_SMALL);
> - dst.blit(Point(5, 5), UI::g_fh1->render(gametime_text), 
> CM_UseAlpha, UI::Align_TopLeft);

This has disappeared from the game screen as well.

> - static boost::format node_format("(%i, %i)");
> + static boost::format node_format("(%3i, %3i; %2i)");

I think (%3i, %3i, %2i) would look better.

> + 
> + const int32_t height=map[m_sel.pos.node].get_height();
>  
>   const std::string node_text = as_uifont
> - ((node_format % m_sel.pos.node.x % 
> m_sel.pos.node.y).str(), UI_FONT_SIZE_SMALL);
> + ((node_format % m_sel.pos.node.x % m_sel.pos.node.y % 
> height).str(), UI_FONT_SIZE_SMALL);

Don't show the third coordinate on the game screen; this should be an editor 
only function.

>   dst.blit(
>   Point(get_w() - 5, get_h() - 5),
>   UI::g_fh1->render(node_text),
> 


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-768826/+merge/242544
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-768826.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] *** GMX Spamverdacht *** Re: Editor -> Resources -> 'Set Value' unused?

[Holger Rapp]

the problem is that we load the editor to fast these days 8). 

We used to have ‘hints’ there, but they can hardly be read anymore. We could 
something like “tipps of the week” when opening the editor, but they usually 
are obnoxious. Best we finally get the help system underway.

On 21.11.2014, at 22:17, Tibor Bamhor  wrote:

> This sound like very useful feature, it is pity that there is no hint/tooltip
> 
> 
> 2014-11-21 17:53 GMT+01:00 wl-zocker :
> The option should be activated when Alt is pressed.
> While the increase/decrease option adds/subtracts the indicated value to the 
> current amount, the set option simply overwrites it. That is very useful when 
> you want to create a mountain that does not contain the maximum resources. 
> Change the set value to 30 and then place coal. There will be 30 coal. With 
> the normal increase tool, you have to be careful because if you click twice 
> on a field, the value is not 30 anymore.
> Furthermore, the resource type can be changed overwritten. There is no need 
> to decrease it to 0 first. (The increase/decrease tool cannot change other 
> resources than the currently selected one.)
> Btw, "set height" works the same way.
> 
> That is at least what it did in build 18. The alternative tools are broken in 
> the current trunk.
> 
> It took me some time to find out how that works and how this tool is 
> activated, so a tooltip would be a good idea.
> 
> 
> -Ursprüngliche Nachricht- From: Fòram na Gàidhlig
> Sent: Friday, November 21, 2014 12:14 PM
> To: widelands-dev@lists.launchpad.net
> Subject: Re: [Widelands-dev] Editor -> Resources -> 'Set Value' unused?
> 
> I sort of wondered about that while I was testing the tool. Since I'm
> not an editor user, I don't understand what the intended usage of these
> 2 settings is here.
> 
> If it is indeed supposed to be unused, +1 for removing. If not, we have
> a bug or need to explain this to the user somewhere, e.g. with a tooltip.
> 
> 
> 21/11/2014 08:13, sgrìobh Tibor Bamhor:
> Hi,
> 
> it seems to me that 'Set Value' in window for resources
> increasing/decreasing has no effect at all. Am I right?
> 
> Then, can it be removed?
> 
> Tibor
> 
> 
> ___
> Mailing list: https://launchpad.net/~widelands-dev
> Post to : widelands-dev@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~widelands-dev
> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> No virus found in this message.
> Checked by AVG - www.avg.com 
> Version: 2015.0.5577 / Virus Database: 4213/8604 - Release Date: 11/21/14
> 
> 
> ___
> Mailing list: https://launchpad.net/~widelands-dev
> Post to : widelands-dev@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~widelands-dev
> More help   : https://help.launchpad.net/ListHelp 
> 
> ___
> Mailing list: https://launchpad.net/~widelands-dev
> Post to : widelands-dev@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~widelands-dev
> More help   : https://help.launchpad.net/ListHelp
> 
> ___
> Mailing list: https://launchpad.net/~widelands-dev
> Post to : widelands-dev@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~widelands-dev
> More help   : https://help.launchpad.net/ListHelp



smime.p7s
Description: S/MIME cryptographic signature
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Build #6588249] i386 build of widelands 1:18-ppa0-bzr7265-201411220801~ubuntu14.10.1 in ubuntu utopic RELEASE [~widelands-dev/ubuntu/widelands-daily]

[Launchpad Buildd System]

 * Source Package: widelands
 * Version: 1:18-ppa0-bzr7265-201411220801~ubuntu14.10.1
 * Architecture: i386
 * Archive: ~widelands-dev/ubuntu/widelands-daily
 * Component: main
 * State: Failed to build
 * Duration: 16 minutes
 * Build Log: 
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/6588249/+files/buildlog_ubuntu-utopic-i386.widelands_1%3A18-ppa0-bzr7265-201411220801%7Eubuntu14.10.1_FAILEDTOBUILD.txt.gz
 * Builder: https://launchpad.net/builders/lgw01-24
 * Source: not available



If you want further information about this situation, feel free to
contact a member of the Launchpad Buildd Administrators team.

--
i386 build of widelands 1:18-ppa0-bzr7265-201411220801~ubuntu14.10.1 in ubuntu 
utopic RELEASE
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/6588249

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Build #6588251] i386 build of widelands 1:18-ppa0-bzr7265-201411220801~ubuntu15.04.1 in ubuntu vivid RELEASE [~widelands-dev/ubuntu/widelands-daily]

[Launchpad Buildd System]

 * Source Package: widelands
 * Version: 1:18-ppa0-bzr7265-201411220801~ubuntu15.04.1
 * Architecture: i386
 * Archive: ~widelands-dev/ubuntu/widelands-daily
 * Component: main
 * State: Failed to build
 * Duration: 15 minutes
 * Build Log: 
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/6588251/+files/buildlog_ubuntu-vivid-i386.widelands_1%3A18-ppa0-bzr7265-201411220801%7Eubuntu15.04.1_FAILEDTOBUILD.txt.gz
 * Builder: https://launchpad.net/builders/lgw01-05
 * Source: not available



If you want further information about this situation, feel free to
contact a member of the Launchpad Buildd Administrators team.

--
i386 build of widelands 1:18-ppa0-bzr7265-201411220801~ubuntu15.04.1 in ubuntu 
vivid RELEASE
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/6588251

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Build #6588250] amd64 build of widelands 1:18-ppa0-bzr7265-201411220801~ubuntu15.04.1 in ubuntu vivid RELEASE [~widelands-dev/ubuntu/widelands-daily]

[Launchpad Buildd System]

 * Source Package: widelands
 * Version: 1:18-ppa0-bzr7265-201411220801~ubuntu15.04.1
 * Architecture: amd64
 * Archive: ~widelands-dev/ubuntu/widelands-daily
 * Component: main
 * State: Failed to build
 * Duration: 14 minutes
 * Build Log: 
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/6588250/+files/buildlog_ubuntu-vivid-amd64.widelands_1%3A18-ppa0-bzr7265-201411220801%7Eubuntu15.04.1_FAILEDTOBUILD.txt.gz
 * Builder: https://launchpad.net/builders/lgw01-02
 * Source: not available



If you want further information about this situation, feel free to
contact a member of the Launchpad Buildd Administrators team.

--
amd64 build of widelands 1:18-ppa0-bzr7265-201411220801~ubuntu15.04.1 in ubuntu 
vivid RELEASE
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/6588250

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Build #6588248] amd64 build of widelands 1:18-ppa0-bzr7265-201411220801~ubuntu14.10.1 in ubuntu utopic RELEASE [~widelands-dev/ubuntu/widelands-daily]

[Launchpad Buildd System]

 * Source Package: widelands
 * Version: 1:18-ppa0-bzr7265-201411220801~ubuntu14.10.1
 * Architecture: amd64
 * Archive: ~widelands-dev/ubuntu/widelands-daily
 * Component: main
 * State: Failed to build
 * Duration: 14 minutes
 * Build Log: 
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/6588248/+files/buildlog_ubuntu-utopic-amd64.widelands_1%3A18-ppa0-bzr7265-201411220801%7Eubuntu14.10.1_FAILEDTOBUILD.txt.gz
 * Builder: https://launchpad.net/builders/lgw01-12
 * Source: not available



If you want further information about this situation, feel free to
contact a member of the Launchpad Buildd Administrators team.

--
amd64 build of widelands 1:18-ppa0-bzr7265-201411220801~ubuntu14.10.1 in ubuntu 
utopic RELEASE
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/6588248

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Build #6588240] amd64 build of widelands 1:18-ppa0-bzr7265-201411220801~ubuntu14.04.1 in ubuntu trusty RELEASE [~widelands-dev/ubuntu/widelands-daily]

[Launchpad Buildd System]

 * Source Package: widelands
 * Version: 1:18-ppa0-bzr7265-201411220801~ubuntu14.04.1
 * Architecture: amd64
 * Archive: ~widelands-dev/ubuntu/widelands-daily
 * Component: main
 * State: Failed to build
 * Duration: 12 minutes
 * Build Log: 
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/6588240/+files/buildlog_ubuntu-trusty-amd64.widelands_1%3A18-ppa0-bzr7265-201411220801%7Eubuntu14.04.1_FAILEDTOBUILD.txt.gz
 * Builder: https://launchpad.net/builders/lgw01-07
 * Source: not available



If you want further information about this situation, feel free to
contact a member of the Launchpad Buildd Administrators team.

--
amd64 build of widelands 1:18-ppa0-bzr7265-201411220801~ubuntu14.04.1 in ubuntu 
trusty RELEASE
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/6588240

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Build #6588241] i386 build of widelands 1:18-ppa0-bzr7265-201411220801~ubuntu14.04.1 in ubuntu trusty RELEASE [~widelands-dev/ubuntu/widelands-daily]

[Launchpad Buildd System]

 * Source Package: widelands
 * Version: 1:18-ppa0-bzr7265-201411220801~ubuntu14.04.1
 * Architecture: i386
 * Archive: ~widelands-dev/ubuntu/widelands-daily
 * Component: main
 * State: Failed to build
 * Duration: 12 minutes
 * Build Log: 
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/6588241/+files/buildlog_ubuntu-trusty-i386.widelands_1%3A18-ppa0-bzr7265-201411220801%7Eubuntu14.04.1_FAILEDTOBUILD.txt.gz
 * Builder: https://launchpad.net/builders/lgw01-18
 * Source: not available



If you want further information about this situation, feel free to
contact a member of the Launchpad Buildd Administrators team.

--
i386 build of widelands 1:18-ppa0-bzr7265-201411220801~ubuntu14.04.1 in ubuntu 
trusty RELEASE
https://launchpad.net/~widelands-dev/+archive/ubuntu/widelands-daily/+build/6588241

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp