Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/align-align into lp:widelands
The alinment of the chatbox in the Mutiplayerlobby is now right, must check the code for MultilineTextarea again. -- https://code.launchpad.net/~widelands-dev/widelands/align-align/+merge/317871 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/align-align. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/align-align into lp:widelands
Continuous integration builds have changed state: Travis build 1976. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/204153616. Appveyor build 1811. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_align_align-1811. -- https://code.launchpad.net/~widelands-dev/widelands/align-align/+merge/317871 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/align-align. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/cleanup-networking-messages into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/cleanup-networking-messages into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/cleanup-networking-messages/+merge/316974 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/cleanup-networking-messages. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cleanup-networking-messages into lp:widelands
Bunnybot only posts here when Travis has a status change. Since it never failed, no new messages. The best way to trigger Travis again is to merge trunk, but it's not necessary in this branch - we haven't merged anything within the week that would touch this part of the code. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/cleanup-networking-messages/+merge/316974 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/cleanup-networking-messages. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1663490-ship-windows into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/bug-1663490-ship-windows into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1663490-ship-windows/+merge/317051 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1663490-ship-windows. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/align-align into lp:widelands
Checked all you comments now, most are related to Textarea, WordWrap or RenderTarget. Change two others as you suggested. -- https://code.launchpad.net/~widelands-dev/widelands/align-align/+merge/317871 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/align-align. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1663490-ship-windows into lp:widelands
Review: Approve LGTM - I'd say that the status popping up is actually wanted behaviour. If it gets annoying, we can change it in the win condition - we should send less status updates at the beginning of the game anyway. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1663490-ship-windows/+merge/317051 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1663490-ship-windows. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/align-align into lp:widelands
Review: Resubmit Gun: are you sure about changing alignement of Textarea, WordWrap and RenderTarget to HAlign only? void Textarea::draw() uses H and VAlignent, so text _can_ be centered vertically. Same for WordWrap:draw() and RenderTarget::blit(). Doing this will introduce a semantic change we should adress in a seperate branch. Can we go with my changes now and adress your wishes later? I am not done checking all your comments, but lets check if Travis and Appveyor are happy now. -- https://code.launchpad.net/~widelands-dev/widelands/align-align/+merge/317871 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/align-align. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
