Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_buildingwindows into lp:widelands
Duh, I confused the coords with the pos. I have removed it now. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/notifications_buildingwindows/+merge/317264 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/notifications_buildingwindows. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_buildingwindows into lp:widelands
Regarding the segfault, it has to do with the destructor code in UI::Panel - if a panel gets destroyed, it also removes its children and is deleted from its parent's list of children. It seems like the reference from the buildingwindow to its parent was broken before it tried to access it for deleting the workarea overlay. -- https://code.launchpad.net/~widelands-dev/widelands/notifications_buildingwindows/+merge/317264 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/notifications_buildingwindows. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands has been updated. Commit Message changed to: Fixed assertion failure in int UI::Panel::get_inner_h(): - Fixed bug with automatic column sizing for tables where the columns were already being resized before all of them were added. - Allow getting inner width/height for panels that have their borders set but w/h == 0. Added assertions and fallbacks to set_size and set_desired_size to make sure that width/height will never be negative. - Explicitly initialize all variables in ui_basic. - Only layout spinbox if it has size. For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1653460-panel-init-width. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands
Review: Resubmit The spinbox now only layouts itself if it has size, so that should fix it. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1653460-panel-init-width. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/gcc63 into lp:widelands
Review: Approve LGTM - let's get this in but leave the bug open, so we can have a real fix later. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/gcc63/+merge/318374 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/gcc63. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/gcc63 into lp:widelands
Continuous integration builds have changed state: Travis build 2012. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/206110677. Appveyor build 1848. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_gcc63-1848. -- https://code.launchpad.net/~widelands-dev/widelands/gcc63/+merge/318374 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/gcc63. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/gcc63 into lp:widelands
Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways. Travis build 2012. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/206110677. -- https://code.launchpad.net/~widelands-dev/widelands/gcc63/+merge/318374 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/gcc63. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/wlwebsite_docker into lp:widelands-website
I got a failure on make init: django.core.exceptions.ImproperlyConfigured: settings.DATABASES is improperly configured. Please supply the ENGINE value. Check settings documentation for more details. make: *** [Makefile:32: init] Fehler 1 I am unsure about the benefits: > 1) get rid of installing dependencies (like the python modules) > on dev machines. Instead one has to install other things (docker itself, docker-files). > 2) make sure all devs have always the exactly same set of python > modules and python version, Good point. On the other side: If one is using a more up to date version we are able to find a trap early, before deploying. > 3) dev workflows can use external tools (like wl_map_info) also > on their dev machine, i.e. less differences between production and dev, Also a good point. On the other side a website dev should have current trunk from widelands somewhere on his disk, to develop the encyclopedia or the documentation. So it should be possible to give also access to wl_map_info. > 4) quicker setup for new devs. I don't know. The whole setup relies on docker which basics have to be understood. From my point of view having our README is much clearer and cleaner than reading and executing the docker example. Using docker will hide some of the installation process to a new dev which could lead into other questions. Also running docker means each docker-file has some access to the root file system. The 'make init' command produce *.pyc files owned by the root user here. Regarding mysql, and database in general: The main Problem for a new dev is that he has no data. All the forum and wiki is empty. For testing purposes a dev has to spend some time to get such data. I had worked on a text file regarding setting up and maintain a mysql database containing some hints on using utf8, collation, backup and so on. Maybe this is the better way to go? All this installations takes round about 2 GB of disk space. Can't say why, but i don't like that... I think this proposal is meant to get more developers for the webpage, but i don't believe it would help here because the process is as 'complicated' as using the README. Maybe i am wrong... -- https://code.launchpad.net/~widelands-dev/widelands-website/wlwebsite_docker/+merge/317036 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/wlwebsite_docker into lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands
Review: Needs Fixing Crash when accessing "About Widelands": This is Widelands Version bzr8310[bug-1653460-panel-init-width] (Debug) [...] widelands: /home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/panel.cc:243: void UI::Panel::set_size(int, int): Assertion `nw >= 0' failed. Thread 1 "widelands" received signal SIGABRT, Aborted. 0x7513b04f in raise () from /usr/lib/libc.so.6 (gdb) backtrace #0 0x7513b04f in raise () from /usr/lib/libc.so.6 #1 0x7513c47a in abort () from /usr/lib/libc.so.6 #2 0x75133ea7 in __assert_fail_base () from /usr/lib/libc.so.6 #3 0x75133f52 in __assert_fail () from /usr/lib/libc.so.6 #4 0x00edafe4 in UI::Panel::set_size (this=0x1d47c20, nw=-10, nh=-49) at /home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/panel.cc:243 #5 0x00ecb775 in UI::FileViewPanel::update_tab_size (this=0x7fffce00, index=0) at /home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/fileview_panel.cc:68 #6 0x00ecb8c6 in UI::FileViewPanel::layout (this=0x7fffce00) at /home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/fileview_panel.cc:83 #7 0x00ef656b in UI::TabPanel::update_desired_size (this=0x7fffce00) at /home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/tabpanel.cc:158 #8 0x00ef6971 in UI::TabPanel::add_tab (this=0x7fffce00, width=74, name="about_0", title="Readme", pic=0x21ed330, tooltip_text="", panel=0x1d59920) at /home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/tabpanel.cc:207 #9 0x00ef6660 in UI::TabPanel::add (this=0x7fffce00, name="about_0", title="Readme", panel=0x1d59920, tooltip_text="") at /home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/tabpanel.cc:170 #10 0x00ecb41f in UI::FileViewPanel::add_tab (this=0x7fffce00, lua_script="txts/README.lua") at /home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/fileview_panel.cc:59 #11 0x00f019e8 in FullscreenMenuAbout::FullscreenMenuAbout (this=0x7fffca80) at /home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_fsmenu/about.cc:39 #12 0x00c3138f in WLApplication::mainmenu (this=0x1960b10) at /home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/wlapplication.cc:1017 #13 0x00c2de4c in WLApplication::run (this=0x1960b10) at /home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/wlapplication.cc:444 #14 0x00c2c4c1 in main (argc=1, argv=0x7fffe5b8) at /home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/main.cc:49 -- https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1653460-panel-init-width. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_buildingwindows into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/notifications_buildingwindows into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/notifications_buildingwindows/+merge/317264 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/notifications_buildingwindows. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands
Similar crash happens in game if a building wants to be dismantled. Backtrace then: https://bugs.launchpad.net/widelands/+bug/1653460/+attachment/4828491/+files/backtrace -- https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1653460-panel-init-width. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_buildingwindows into lp:widelands
Makes sense, thanks. -- https://code.launchpad.net/~widelands-dev/widelands/notifications_buildingwindows/+merge/317264 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/notifications_buildingwindows. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1653460-panel-init-width into lp:widelands
Thanks for these. I'll have a look if we can get rid of the failures - we might have some underlying bugs here that nobody noticed. If not, I'll remove the new assertions. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1653460-panel-init-width. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/gcc63 into lp:widelands
That was an error, not a fail. @bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/gcc63/+merge/318374 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/gcc63. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/gcc63 into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/gcc63 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/gcc63/+merge/318374 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/gcc63. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
