[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1805508-burning-military-sites into lp:widelands
Continuous integration builds have changed state: Travis build 4618. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/508632426. Appveyor build 4405. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1805508_burning_military_sites-4405. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1805508-burning-military-sites/+merge/364665 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1805508-burning-military-sites. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1805508-burning-military-sites into lp:widelands
Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways. Travis build 4618. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/508632426. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1805508-burning-military-sites/+merge/364665 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1805508-burning-military-sites. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands
Continuous integration builds have changed state: Travis build 4616. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/508307520. Appveyor build 4403. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ferry-4403. -- https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ferry into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bridges into lp:widelands
Continuous integration builds have changed state: Travis build 4615. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/508306031. Appveyor build 4402. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bridges-4402. -- https://code.launchpad.net/~widelands-dev/widelands/bridges/+merge/364318 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bridges into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/more_latest_posts into lp:widelands-website
Done with stringfixes, also applied the change to the label of days as you suggested. Will apply the needed changes to have the ordering/grouping you mentioned. This may take some time so i shut down alpha again. -- https://code.launchpad.net/~widelands-dev/widelands-website/more_latest_posts/+merge/364706 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/more_latest_posts into lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands
Continuous integration builds have changed state: Travis build 4613. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/508113746. Appveyor build 4400. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1809838_document_mill-4400. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1809838-document-mill/+merge/364704 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1805508-burning-military-sites into lp:widelands
Review: Approve -- https://code.launchpad.net/~widelands-dev/widelands/bug-1805508-burning-military-sites/+merge/364665 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1805508-burning-military-sites. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1820036-map-saving-prompt into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/bug-1820036-map-saving-prompt into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1820036-map-saving-prompt/+merge/364705 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1820036-map-saving-prompt. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1820036-map-saving-prompt into lp:widelands
Continuous integration builds have changed state: Travis build 4612. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/508113297. Appveyor build 4399. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1820036_map_saving_prompt-4399. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1820036-map-saving-prompt/+merge/364705 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1820036-map-saving-prompt. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bridges into lp:widelands
you need to merge trunk to make appveyor happy and working -- https://code.launchpad.net/~widelands-dev/widelands/bridges/+merge/364318 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bridges into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1820036-map-saving-prompt into lp:widelands
Review: Approve Looks good for me @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1820036-map-saving-prompt/+merge/364705 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1820036-map-saving-prompt. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1805508-burning-military-sites into lp:widelands
another try @bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/bug-1805508-burning-military-sites/+merge/364665 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1805508-burning-military-sites into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/more_latest_posts into lp:widelands-website
The change you mention is exactly what I would expect. Sorted by topics' last
post date rather than each individual post's date.
The only reason we need this long list really is that we can't link to the
first unread post.
Diff comments:
>
> === modified file 'pybb/forms.py'
> --- pybb/forms.py 2018-12-21 11:26:08 +
> +++ pybb/forms.py 2019-03-18 21:30:36 +
> @@ -87,3 +87,17 @@
> post.updated = datetime.now()
> post.save(*args, **kwargs)
> return post
> +
> +
> +class LastPostsDayForm(forms.Form):
> +days = forms.IntegerField(
> +max_value = 1000,
> +min_value = 5,
> +label = 'Show posts created these days before today:'
Is it possible to do it like this with Django?
Show posts created up to n days ago
I have had a look at phpBB and that's how they do it in their advanced search:
Limit results to previous: n days
vBulletin has a date range with 2 date pickers in their advanced search, but I
think that's a bit overkill for our context here.
> +)
> +
> +sort_by = forms.ChoiceField(
> +#widget = forms.RadioSelect,
> +choices = [('forum','Forum'),('topic', 'Topic'),],
> +label = 'Sort by:',
> +)
--
https://code.launchpad.net/~widelands-dev/widelands-website/more_latest_posts/+merge/364706
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands-website/more_latest_posts into lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/more_latest_posts into lp:widelands-website
Thanks. I have replied to one of your inline comments below.
About grouping: I agree that this can be confusing. Currently the list is
always sorted by the posts dates, so grouping lead into this situation were
some topics appear double. Say we have:
post1 created 12.3.2019 in topic foo
post2 created 11.3.2019 in topic bar
post3 created 10.3.2019 in topic baz
post4 created 1.1.2019 in topic foo
Will lead to:
topic foo:
post1 (12.3.2019)
topic bar:
post2 (11.3.1019)
topic baz:
post3 (10.3.2019)
topic foo:
post4 (1.1.2019)
If we change this to something like:
topic foo:
post1 (12.3.2019)
post4 (1.1.2019)
topic bar:
post2 (11.3.1019)
topic baz:
post3 (10.3.2019)
The posts are not sorted by date anymore: A post created yesterday may appear
at the bottom of the page then, after several other old posts.
I am unsure about a good grouping. Maybe this should be tested in production to
have real time data? Or adding a third option 'no grouping' which shows the
posts by date descending and change the grouping by topic/forum to have no
double entries?
Diff comments:
>
> === modified file 'pybb/forms.py'
> --- pybb/forms.py 2018-12-21 11:26:08 +
> +++ pybb/forms.py 2019-03-18 21:30:36 +
> @@ -87,3 +87,17 @@
> post.updated = datetime.now()
> post.save(*args, **kwargs)
> return post
> +
> +
> +class LastPostsDayForm(forms.Form):
> +days = forms.IntegerField(
> +max_value = 1000,
> +min_value = 5,
> +label = 'Show posts created these days before today:'
Can't we have a sentence ending with ? The reason to have it like this is
accessibility. See the red marked paragraph here:
https://wiki.selfhtml.org/wiki/HTML/Formulare/label
> +)
> +
> +sort_by = forms.ChoiceField(
> +#widget = forms.RadioSelect,
> +choices = [('forum','Forum'),('topic', 'Topic'),],
> +label = 'Sort by:',
> +)
--
https://code.launchpad.net/~widelands-dev/widelands-website/more_latest_posts/+merge/364706
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands-website/more_latest_posts into lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
