[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands
travis failure is transient. (apt-get failed) @bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands
Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways. Travis build 4535. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/499382080. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands
Continuous integration builds have changed state: Travis build 4535. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/499382080. Appveyor build 4322. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1817686_SDL_pixel_format-4322. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands
> built-in Intel graphics card I should had bet for this :-D There were several problems with this graphics card in the past. Glad it's working for you now. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands
Thanks for the review and testing @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands
Review: Approve It´s a perfectly normal built-in Intel graphics card (VGA compatible controller, Atom Processor Z36xxx/Z37xxx Series Graphics & Display) with default drivers – no reason why it should behave like that, especially in such a random way. It always worked before… The code looks good to me; and if the SDL is messed up, that´s a problem with the graphics driver or possibly the SDL, but not in widelands. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands
I guess the driver is too messed up to even display the message box then. I have now made the log message identical to the dialog message and removed the assert. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands
Tested it. The log says »ERROR: Wrong SDL_BYTESPERPIXEL, expected 4 but got 1« as expected. But no message box appears, the program exits immediately. By the way, the assert could be removed now, right? Since the triggering failure is now caught beforehand. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands. Commit message: Fail with SDL messagebox if SDL_BYTESPERPIXEL != 4 Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1817686 in widelands: "Assert fail in Graphic::initialize" https://bugs.launchpad.net/widelands/+bug/1817686 For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1817686-SDL-pixel-format/+merge/363729 -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1817686-SDL-pixel-format into lp:widelands. === modified file 'src/graphic/graphic.cc' --- src/graphic/graphic.cc 2019-02-23 11:00:49 + +++ src/graphic/graphic.cc 2019-02-27 14:22:14 + @@ -114,6 +114,15 @@ " size %d %d\n" " END GRAPHICS REPORT \n", SDL_GetCurrentVideoDriver(), disp_mode.format, disp_mode.w, disp_mode.h); + const int bytes_per_pixel = SDL_BYTESPERPIXEL(disp_mode.format); + if (bytes_per_pixel != 4) { + log("ERROR: Wrong SDL_BYTESPERPIXEL, expected 4 but got %d\n", bytes_per_pixel); + SDL_ShowSimpleMessageBox(SDL_MESSAGEBOX_ERROR, "Video Error", + (boost::format("SDL should report 4 bytes per pixel, but %d were reported instead.\n\nPlease check that everything's OK with your graphics driver.") % bytes_per_pixel).str().c_str(), + nullptr); + exit(1); + + } assert(SDL_BYTESPERPIXEL(disp_mode.format) == 4); } ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp