[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/fri-portraits into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fri-portraits. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
If I may be so bold – I have added the missing dev-credit entry for myself here, and as there are two approves: @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fri-portraits. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
@Klaus: I don´t think using real portraits would work. There are very few portraits of Frisians. Aldgisl is about as close as we can get, and he was a Western Frisian duke (so he´d fit to Reebaud, who seems more Western than Northern frisian anyway), but there are few others. In the middle ages, it was mainly rich kings, dukes and the like that had themselves painted. But Northern Frisian society knew no distinction between higher and lower classes – nearly everyone was a peasant, even the (Ratsherren) and (Deichgrafen). Also, as far as I know most frisians who were rich enough to have themselves painted lived on Strand and other places the sea since reclaimed, so those portraits were destroyed by the flood of 1634. That´s why only few older paintings of (northern) Frisians exist. And I don´t want to edit real photographs for Widelands; I tried that but couldn´t produce anything useful. @GunChleoc: This branch doesn´t need to wait for b21, right? Since it´s a graphics-only change. -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fri-portraits. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
Continuous integration builds have changed state: Travis build 4109. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/439709708. Appveyor build 3904. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fri_portraits-3904. -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fri-portraits. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
Review: Approve At least the style is consistent now. I think the difference to the frisians is good for the player to distinguish between them easily. Thanks a lot -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fri-portraits. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
Portrait for Murilius is uploaded. He looks a bit different to the Frisian people though ;) -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fri-portraits. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
Yes, the empire workers are also in the repo. It´ll still look somewhat different though due to different modelling style. I´ll make the image this evening :) -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fri-portraits. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
the portraits are better now with the canvas texture they don't look that bad anymore. Do you have the blender files for the romans as well to create a Screenshot also for Murilius? That would give us some consistency over the Frisian campaign -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fri-portraits. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
I have given the portraits (including Murilius) some editing in GIMP now to give them a painting-like look and a playercolored frame. How about these? -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fri-portraits. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
I think the new pictures do not fit in the context of the other Scenarios where portraits are used. This will especially evident in the 2nd Frisian scenario so my personal taste would be to keep the false portraits as they are currently rather than having these screenshots. If the new pictures shall be taken we should add the same kind of image for Murilius at least to have the same artwork over all Frisian scenarios -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fri-portraits. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
Furthermore they could be enriched with the playercolor in the scenario. (e.g. blue for Hauke and Rebaud) -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fri-portraits. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
Review: Approve OK, the portraits work as designed. But as we already have a real Islnad could we have some +/- real Perons portrait, too? Like https://de.wikipedia.org/wiki/Aldgisl Or from here: https://www.youtube.com/watch?v=cVZjSD6_WIQ Or from some local Museum? Fell free to merge, though. Can add better pictures later, -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fri-portraits. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
Continuous integration builds have changed state: Travis build 4099. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/437958798. Appveyor build 3895. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fri_portraits-3895. -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/fri-portraits into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
Looks like my youtube video reminded you of something ;-) Will check this now. -- https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/fri-portraits into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fri-portraits into lp:widelands
Benedikt Straub has proposed merging lp:~widelands-dev/widelands/fri-portraits into lp:widelands. Commit message: New portraits for the characters in the frisian campaign Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221 I want to get rid of those placeholder images, so I shot some "photographs" in Blender similar to the ones for the widelands.org/wiki/Artwork page. These should be fine for b20 imho, but we should definitely make completely new images when we have someone who can draw portraits. -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/fri-portraits into lp:widelands. === modified file 'data/campaigns/fri01.wmf/pics/hauke.png' Binary files data/campaigns/fri01.wmf/pics/hauke.png 2018-02-10 13:02:13 + and data/campaigns/fri01.wmf/pics/hauke.png 2018-10-06 08:54:59 + differ === modified file 'data/campaigns/fri01.wmf/pics/maukor.png' Binary files data/campaigns/fri01.wmf/pics/maukor.png 2018-02-10 13:02:13 + and data/campaigns/fri01.wmf/pics/maukor.png 2018-10-06 08:54:59 + differ === modified file 'data/campaigns/fri01.wmf/pics/reebaud.png' Binary files data/campaigns/fri01.wmf/pics/reebaud.png 2018-02-10 13:02:13 + and data/campaigns/fri01.wmf/pics/reebaud.png 2018-10-06 08:54:59 + differ === modified file 'data/campaigns/fri02.wmf/pics/hauke.png' Binary files data/campaigns/fri02.wmf/pics/hauke.png 2018-02-10 13:02:13 + and data/campaigns/fri02.wmf/pics/hauke.png 2018-10-06 08:54:59 + differ === modified file 'data/campaigns/fri02.wmf/pics/reebaud.png' Binary files data/campaigns/fri02.wmf/pics/reebaud.png 2018-02-10 13:02:13 + and data/campaigns/fri02.wmf/pics/reebaud.png 2018-10-06 08:54:59 + differ ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp