[Widelands-dev] [Merge] lp:~widelands-dev/widelands/oars_appdata into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/oars_appdata into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309624 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/oars_appdata. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/oars_appdata into lp:widelands
Thanks - that error message was confusing me! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309624 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/oars_appdata. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/oars_appdata into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/oars_appdata into lp:widelands has been updated. Commit Message changed to: Added age ratings to Appdata https://odrs.gnome.org/oars and validator call to utils/uppdate_appdata.py. Fixed localization format for long description. Fixed id tag. For more details, see: https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309624 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/oars_appdata. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/oars_appdata into lp:widelands
Review: Needs Fixing One more things: The specification you mentioned is for the *.desktop files not *.appdata.xml files. The appdata specification does not mention the type property so I think we can trust the validator and remove it. -- https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309624 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/oars_appdata. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/oars_appdata into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/oars_appdata into lp:widelands has been updated. Commit Message changed to: Added age ratings to Appdata https://odrs.gnome.org/oars and validator call to utils/uppdate_appdata.py. Fixed localization format for long description. For more details, see: https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309624 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/oars_appdata. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/oars_appdata into lp:widelands
Review: Needs Fixing LBTM. This is invalid XML, you have multiple root tags. The has to be a child of . You can use the appstream package of your distribution to validate appstream files. E.g: appstreamcli validate debian/widelands.appdata.xml It throws a lot of errors, even before your change but you can still use it to see if new validation errors where introduced. -- https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309624 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/oars_appdata. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/oars_appdata into lp:widelands
GunChleoc has proposed merging lp:~widelands-dev/widelands/oars_appdata into lp:widelands. Commit message: Added age ratings to Appdata https://odrs.gnome.org/oars Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309624 -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/oars_appdata into lp:widelands. === modified file 'debian/widelands.appdata.xml' --- debian/widelands.appdata.xml 2016-10-17 22:05:02 + +++ debian/widelands.appdata.xml 2016-10-29 06:39:26 + @@ -236,3 +236,25 @@ https://wl.widelands.org/wiki/Game%20Manual/ The Widelands Development Team + + moderate + none + none + none + none + mild + none + none + none + none + none + none + none + intense + none + none + none + none + none + none + === modified file 'debian/widelands.appdata.xml.stub' --- debian/widelands.appdata.xml.stub 2016-09-19 07:01:19 + +++ debian/widelands.appdata.xml.stub 2016-10-29 06:39:26 + @@ -56,3 +56,25 @@ https://wl.widelands.org/wiki/Game%20Manual/ The Widelands Development Team + + moderate + none + none + none + none + mild + none + none + none + none + none + none + none + intense + none + none + none + none + none + none + ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/oars_appdata into lp:widelands/build19
You're right. I can't change the target, so I'll delete this proposal and create a new one. -- https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309600 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/oars_appdata into lp:widelands/build19. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/oars_appdata into lp:widelands/build19
Continuous integration builds have changed state: Travis build 1529. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/171459465. Appveyor build 1371. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_oars_appdata-1371. -- https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309600 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/oars_appdata into lp:widelands/build19. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/oars_appdata into lp:widelands/build19
The diff shows much more changes than the appdata... i guess this is not the one that should go into build19? -- https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309600 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/oars_appdata into lp:widelands/build19. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
