[Widelands-dev] [Merge] lp:~widelands-dev/widelands/relax-ai-asserts into lp:widelands

2019-09-07 Thread noreply 
The proposal to merge lp:~widelands-dev/widelands/relax-ai-asserts into 
lp:widelands has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/relax-ai-asserts/+merge/372400
-- 
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/relax-ai-asserts.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/relax-ai-asserts into lp:widelands

2019-09-07 Thread GunChleoc 
Thanks for the review :)

@bunnybot merge
-- 
https://code.launchpad.net/~widelands-dev/widelands/relax-ai-asserts/+merge/372400
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/relax-ai-asserts.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/relax-ai-asserts into lp:widelands

2019-09-07 Thread bunnybot 
Continuous integration builds have changed state:

Travis build 5404. State: passed. Details: 
https://travis-ci.org/widelands/widelands/builds/581765188.
Appveyor build 5174. State: success. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_relax_ai_asserts-5174.
-- 
https://code.launchpad.net/~widelands-dev/widelands/relax-ai-asserts/+merge/372400
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/relax-ai-asserts.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/relax-ai-asserts into lp:widelands

2019-09-06 Thread GunChleoc 
The proposal to merge lp:~widelands-dev/widelands/relax-ai-asserts into 
lp:widelands has been updated.

Commit message changed to:

Some improvements around AI asserts

- Relax AI requirement for hunters
- Be more informative when building is missing the
  "collects_ware_from_map" AI hint

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/relax-ai-asserts/+merge/372400
-- 
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/relax-ai-asserts.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/relax-ai-asserts into lp:widelands

2019-09-06 Thread GunChleoc 
GunChleoc has proposed merging lp:~widelands-dev/widelands/relax-ai-asserts 
into lp:widelands.

Commit message:
Relax AI requirement for hunters.

Requested reviews:
  TiborB (tiborb95)

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/relax-ai-asserts/+merge/372400
-- 
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/relax-ai-asserts.
=== modified file 'src/ai/defaultai.cc'
--- src/ai/defaultai.cc	2019-09-05 19:57:55 +
+++ src/ai/defaultai.cc	2019-09-06 08:29:52 +
@@ -898,7 +898,8 @@
 	assert(count_buildings_with_attribute(BuildingAttribute::kRanger) == 1);
 	assert(count_buildings_with_attribute(BuildingAttribute::kWell) == 1);
 	assert(count_buildings_with_attribute(BuildingAttribute::kLumberjack) == 1);
-	assert(count_buildings_with_attribute(BuildingAttribute::kHunter) == 1);
+	assert((count_buildings_with_attribute(BuildingAttribute::kHunter) == 1) ||
+		   (count_buildings_with_attribute(BuildingAttribute::kHunter) == 0));
 	assert(count_buildings_with_attribute(BuildingAttribute::kIronMine) >= 1);
 	assert(count_buildings_with_attribute(BuildingAttribute::kFisher) == 1);
 	// If there will be a tribe with more than 3 mines of the same type, just increase the number

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp