[Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-skip-translations-in-debug-builds into lp:widelands
GunChleoc has proposed merging lp:~widelands-dev/widelands/travis-skip-translations-in-debug-builds into lp:widelands. Commit message: On Travis, build translations and documentation only on release builds in order to help with job execution time. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/travis-skip-translations-in-debug-builds/+merge/359347 -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/travis-skip-translations-in-debug-builds into lp:widelands. === modified file '.travis.sh' --- .travis.sh 2018-09-24 10:19:41 + +++ .travis.sh 2018-11-24 07:22:12 + @@ -25,22 +25,10 @@ # Configure the build mkdir build cd build -cmake .. -DCMAKE_BUILD_TYPE:STRING="$BUILD_TYPE" -DOPTION_ASAN="OFF" if [ "$BUILD_TYPE" == "Debug" ]; then - - # Build the documentation. Any warning is an error. - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then - sudo pip install sphinx - fi - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then - pip2 install sphinx - fi - pushd ../doc/sphinx - mkdir source/_static - ./extract_rst.py - sphinx-build -W -b json -d build/doctrees source build/json - popd + # We test translations only on release builds, in order to help with job timeouts + cmake .. -DCMAKE_BUILD_TYPE:STRING="$BUILD_TYPE" -DOPTION_BUILD_TRANSLATIONS="OFF" -DOPTION_ASAN="OFF" # Run the codecheck test suite. pushd ../cmake/codecheck @@ -54,6 +42,22 @@ echo "You have codecheck warnings (see above) Please fix." exit 1 # CodeCheck warnings. fi +else + cmake .. -DCMAKE_BUILD_TYPE:STRING="$BUILD_TYPE" -DOPTION_BUILD_TRANSLATIONS="ON" -DOPTION_ASAN="OFF" + + # We test the documentation on release builds to make timeouts for debug builds less likely. + # Any warning is an error. + if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then + sudo pip install sphinx + fi + if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then + pip2 install sphinx + fi + pushd ../doc/sphinx + mkdir source/_static + ./extract_rst.py + sphinx-build -W -b json -d build/doctrees source build/json + popd fi # Do the actual build. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-skip-translations-in-debug-builds into lp:widelands
Continuous integration builds have changed state: Travis build 4281. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/459060026. Appveyor build 4075. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_travis_skip_translations_in_debug_builds-4075. -- https://code.launchpad.net/~widelands-dev/widelands/travis-skip-translations-in-debug-builds/+merge/359347 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/travis-skip-translations-in-debug-builds into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-skip-translations-in-debug-builds into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/travis-skip-translations-in-debug-builds into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/travis-skip-translations-in-debug-builds/+merge/359347 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/travis-skip-translations-in-debug-builds. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-skip-translations-in-debug-builds into lp:widelands
Review: Approve Diff is looking good and based on the Travis output it seems to work as intented. -- https://code.launchpad.net/~widelands-dev/widelands/travis-skip-translations-in-debug-builds/+merge/359347 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/travis-skip-translations-in-debug-builds. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-skip-translations-in-debug-builds into lp:widelands
Thanks! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/travis-skip-translations-in-debug-builds/+merge/359347 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/travis-skip-translations-in-debug-builds. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp