[Bug 47431] JSON extension dependency has a non-free component: JSON_parser.c

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47431

Ori Livneh  changed:

   What|Removed |Added

 CC||o...@wikimedia.org

--- Comment #15 from Ori Livneh  ---
(In reply to comment #14)
> From Remi's comment on the PHP bug, I understand that Debian will configure
> PHP with --disable-json, and distribute jsonc separately. So if MW is going
> to run out of the box on a plain Debian PHP package, we will need a pure-PHP
> implementation.

Why not have MediaWiki depend on php5-json? My understanding is that php5-json
is both properly free and packaged for all versions of Debian that will
configure PHP without JSON support.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 47431] JSON extension dependency has a non-free component: JSON_parser.c

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47431

Tim Starling  changed:

   What|Removed |Added

 CC||tstarl...@wikimedia.org

--- Comment #14 from Tim Starling  ---
From Remi's comment on the PHP bug, I understand that Debian will configure PHP
with --disable-json, and distribute jsonc separately. So if MW is going to run
out of the box on a plain Debian PHP package, we will need a pure-PHP
implementation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54677] Do account creation checks when creating users

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54677

T. Gries  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54677] Do account creation checks when creating users

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54677

--- Comment #1 from T. Gries  ---
Thanks for reporting and giving starting points. I will try to fix this as soon
as possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 46377] MeetBot for #wikimedia-office

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=46377

--- Comment #8 from Antoine "hashar" Musso  ---
The Multimedia team held a daily checkin yesterday:

IRC log:
http://integration-meetbot.instance-proxy.wmflabs.org/wikimedia-meetbot/2013/wikimedia-meetbot.2013-09-26-16.59.log.html

Report:
http://integration-meetbot.instance-proxy.wmflabs.org/wikimedia-meetbot/2013/wikimedia-meetbot.2013-09-26-16.59.html

Mark Holqmist sent a report on the engineering mailing list:



I just dragged the Multimedia team into that channel to test it out at
our daily scrum meeting, with qualified success.

* We needed to use #info and other things more (lesson for other teams)
* Running a standup with it could be more automated - maybe e3bot could
  be told how to run a standup meeting? (ori-l? spage?)
* The logs [0] are specific to our meeting, so we don't have to dig for
  them. Awesome!
* The #meetingname command [1] had nil effect - it would be nice to
  implement it in the filenamePattern config for our instance if we
  move forward with this.
* The logs maybe highlight /^\S*:/ as a highlighting action. This seems
  unnecessary and, clearly in this case, inaccurate. At least something
  to be aware of. (see where Bryan and I said "Yesterday: ")

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54671] VisualEditor opt-in preference disappears

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54671

--- Comment #1 from Antoine "hashar" Musso  ---
The Selenium_user on enwiki has the following preferences right now:

["visualeditor-enable"]=> int(0)
["visualeditor-enable-experimental"]=>  int(1)
["visualeditor-betatempdisable"]=> int(0)

So VE is actually disabled.

Maybe some test is disabling the option while other set it?   Tests relying on
VE should probably set the user preference through the API before the test run.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 24671] "Previous" revision link on oldest version of wiki article points to a *newer* revision

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=24671

PleaseStand  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||pleasest...@live.com
 Resolution|--- |DUPLICATE

--- Comment #3 from PleaseStand  ---
Correct me if I'm wrong.

*** This bug has been marked as a duplicate of bug 2930 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 2930] Edit history is based on timestamp while diff prev/next links are based on revision id

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=2930

PleaseStand  changed:

   What|Removed |Added

 CC||fp...@web.de

--- Comment #26 from PleaseStand  ---
*** Bug 24671 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 38781] Messages needing PLURAL support (tracking)

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=38781

Siddhartha Ghai  changed:

   What|Removed |Added

 Depends on||54679

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54679] New: PLURAL support for Coll-load local book

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54679

   Web browser: ---
Bug ID: 54679
   Summary: PLURAL support for Coll-load local book
   Product: MediaWiki extensions
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: Collection
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: siddhartha.g...@gmail.com
CC: developm...@pediapress.com, marcin.cies...@gmail.com
Classification: Unclassified
   Mobile Platform: ---

Reporting this bug per an old translatewiki thread[1], the message
[[:w:MediaWiki:Coll-load local book]] doesn't support plural. It needs to
support plural over the %NUMPAGES% parameter. This is needed for proper hindi
translation of the sentence. Its probably also needed for other languages.

Hindi translation won't require support for plural over %TITLE% but I can't say
if other languages may need this support.

[1]:
http://translatewiki.net/wiki/Thread:Support/PLURAL_support_for_Coll-load_local_book

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54679] PLURAL support for Coll-load local book

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54679

Siddhartha Ghai  changed:

   What|Removed |Added

 CC||siddhartha.g...@gmail.com
 Blocks||38781

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54678] uselang=en on an RTL wiki leaves mw-input-wpUsername in RTL input mode

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54678

Mark A. Hershberger  changed:

   What|Removed |Added

   Keywords||i18n

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54678] New: uselang=en on an RTL wiki leaves mw-input-wpUsername in RTL input mode

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54678

   Web browser: ---
Bug ID: 54678
   Summary: uselang=en on an RTL wiki leaves mw-input-wpUsername
in RTL input mode
   Product: MediaWiki
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: User login and signup
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: m...@everybody.org
CC: swall...@wikimedia.org
Classification: Unclassified
   Mobile Platform: ---

This is unexpected on the "Reset password" page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54677] New: Do account creation checks when creating users

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54677

   Web browser: ---
Bug ID: 54677
   Summary: Do account creation checks when creating users
   Product: MediaWiki extensions
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: OpenID
  Assignee: m...@tgries.de
  Reporter: cste...@wikimedia.org
Classification: Unclassified
   Mobile Platform: ---

It doesn't look like SpecialOpenIDLogin.body.php is doing the same checks that
MediaWiki core is doing on account creation. I'm not sure if vandals could
abuse this, but it would be good to check.

Specific checks that need to happen (apologies if I've missed these somewhere
else):

* Username needs to valid against the 'creatable' checks, so some thing like
$u = User::newFromName( $name, 'creatable' );
if ( !is_object( $u ) ) {
return null;

* The AbortNewAccount hook should be run

* IP throttle needs to be checked

* Make sure the email passes Sanitizer::validateEmail()

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54676] #timel:t returns wrong number of days

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54676

--- Comment #1 from lucasbill...@gmail.com ---
sorry, that 3rd example is:

{{#timel:t|2013-02-01}} ▷ 31

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54676] New: #timel:t returns wrong number of days

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54676

   Web browser: ---
Bug ID: 54676
   Summary: #timel:t returns wrong number of days
   Product: MediaWiki
   Version: 1.21.2
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: Parser
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: lucasbill...@gmail.com
Classification: Unclassified
   Mobile Platform: ---

After an upgrade from 1.18.1 to 1.21.2 noticed some of my templates were
broken. In troubleshooting them, discovered weird behaviour of timel:t where it
wouldn't return the right number of days in a month if the date argument was
the first day of a month with 30 or 28 days in it. #time: showed no such
behaviour. Maybe something I'm doing wrong. Couldn't find a bug like it. 

example output:

{{#timel:t|2013-01-01}} ▷ 31
{{#timel:t|2013-02-10}} ▷ 28
{{#timel:t|2013-02-01}} ▷ 
{{#timel:t|2013-Feb}} ▷ 31

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54195] CentralAuth not caching Special:CentralAutoLogin/start

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195

Brad Jorsch  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |NEW

--- Comment #11 from Brad Jorsch  ---
(In reply to comment #10)
> Ah, thanks. Could we build the correct returnto and update the link in the
> javascript that we return from /setCookies?

Probably. Although my gut reaction is "this #p-personal thing keeps getting
more and more hacky".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54195] CentralAuth not caching Special:CentralAutoLogin/start

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195

--- Comment #10 from Chris Steipp  ---
(In reply to comment #8)
> (In reply to comment #6)
> > Brad, do remember why we add returnto and returntoquery in
> > centralautologin.js
> > for non-login pages? It's not used except when we get to the /setCookies
> > phase,
> > and there, it only adds a window.location if the request had a 'return'
> > parameter, which I don't ever see set. So it seems like we're passing it
> > around
> > without actually using it.. but am I missing something?
> 
> git blame would point you to Gerrit change #83007. The returnto gets used in
> SkinTemplate.php in core, when it generates the #p-personal replacement.

Ah, thanks. Could we build the correct returnto and update the link in the
javascript that we return from /setCookies?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54195] CentralAuth not caching Special:CentralAutoLogin/start

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195

--- Comment #9 from Gerrit Notification Bot  ---
Change 86207 abandoned by CSteipp:
Remove returnto for basic login test

Reason:
We'll find a better solution

https://gerrit.wikimedia.org/r/86207

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54335] VisualEditor: Surface isn't updated properly for Language annotations

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54335

Roan Kattouw  changed:

   What|Removed |Added

 Depends on||54675

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54675] VisualEditor: Render lock when changing selection prevents inspectors' changes from rendering

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54675

Roan Kattouw  changed:

   What|Removed |Added

 CC||roan.katt...@gmail.com
 Blocks||54335

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54636] wikitech.wikimedia.org needs to have VE enabled

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54636

Roan Kattouw  changed:

   What|Removed |Added

 CC||roan.katt...@gmail.com

--- Comment #3 from Roan Kattouw  ---
(In reply to comment #2)
> So there was ' Enable VisualEditor (only in the main and user namespaces)'
> and
> ' Temporarily disable VisualEditor while it is in beta' in preferences, and
> they were both unchecked.
Hah, I wasn't aware it was possible to have both preferences visible at once.
That's probably a bug. Either way, you need to both have the "enable" box
checked and have the "disable" box unchecked.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54636] wikitech.wikimedia.org needs to have VE enabled

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54636

--- Comment #2 from Yuvi Panda  ---
So there was ' Enable VisualEditor (only in the main and user namespaces)' and
' Temporarily disable VisualEditor while it is in beta' in preferences, and
they were both unchecked.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54655] "Cannot determine host VirtualBox version." running update-guest-additions in "vagrant ssh"

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54655

--- Comment #6 from Ori Livneh  ---
Yes, I suspect the most recent version of Vagrant sets a custom LD_LIBRARY_PATH
or LIBRARY_PATH to get its embedded Ruby interpreter to work. (You know your
language's package management facilities suck when people resort to bundling
the entire runtime. WTF.)

The patch above uses Vagrant's internal API to get the version number. I was
able to get it to work after a lot of trial-and-error and poking around in
Vagrant's code. I'm not sure yet if it's a good approach, or if the APIs that
it is using are stable.

I think that at minimum I'd like to have 'upgrade-guest-additions' take an
optional command-line argument that lets you specify a VirtualBox version, as a
fallback for this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54655] "Cannot determine host VirtualBox version." running update-guest-additions in "vagrant ssh"

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54655

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54655] "Cannot determine host VirtualBox version." running update-guest-additions in "vagrant ssh"

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54655

--- Comment #5 from Gerrit Notification Bot  ---
Change 86212 had a related patch set uploaded by Ori.livneh:
Use interval Vagrant hook to determine VirtualBox version

https://gerrit.wikimedia.org/r/86212

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54662] wfArrayDiff2_cmp noisy

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54662

--- Comment #4 from Sam Reed (reedy)  ---
Except that won't put the info anywhere useful. Bed time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54662] wfArrayDiff2_cmp noisy

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54662

--- Comment #3 from Sam Reed (reedy)  ---
reedy@tin:/a/common/php-1.22wmf19/includes$ git diff
diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index 414c822..23e75ff 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -123,6 +123,10 @@ function wfArrayDiff2( $a, $b ) {
  * @return int
  */
 function wfArrayDiff2_cmp( $a, $b ) {
+   if( is_array( $a ) || is_array( $b ) ) {
+   var_dump( $a, $b );
+   debug_print_backtrace();
+   }
if ( !is_array( $a ) ) {
return strcmp( $a, $b );
} elseif ( count( $a ) !== count( $b ) ) {

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54662] wfArrayDiff2_cmp noisy

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54662

Sam Reed (reedy)  changed:

   What|Removed |Added

   Priority|Unprioritized   |High
   Assignee|wikibugs-l@lists.wikimedia. |s...@reedyboy.net
   |org |

--- Comment #2 from Sam Reed (reedy)  ---
Assigning to me as a TODO for post sleep. This is very noisy on just the "test"
wikis, so cluster wide it's going to be awful.

Need to hack in some debugging to get a stack trace and find out where it's
coming from...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54674] Fatal error renaming file

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54674

--- Comment #2 from Sam Reed (reedy)  ---
2013-09-27 00:27:28 mw1049 enwiki: [770efea1]
/w/index.php?title=Special:MovePage&action=submit   Exception from line 1053 of
/usr/local/apache/common-local/php-1.22wmf18/includes/filebackend/SwiftFileBackend.php:
Got InvalidResponseException exception.
#0
/usr/local/apache/common-local/php-1.22wmf18/includes/filebackend/SwiftFileBackend.php(1701):
SwiftFileBackend->getFileListPageInternal('wikipedia-en-lo...',
'2/28/Kufuor.JPG', NULL, 9000, Array)
#1
/usr/local/apache/common-local/php-1.22wmf18/includes/filebackend/SwiftFileBackend.php(1635):
SwiftFileBackendFileList->pageFromList('wikipedia-en-lo...', '2/28/Kufuor.JPG',
NULL, 9000, Array)
#2
/usr/local/apache/common-local/php-1.22wmf18/includes/filerepo/file/LocalFile.php(792):
SwiftFileBackendList->rewind()
#3
/usr/local/apache/common-local/php-1.22wmf18/includes/filerepo/file/LocalFile.php(880):
LocalFile->getThumbnails()
#4
/usr/local/apache/common-local/php-1.22wmf18/includes/filerepo/file/LocalFile.php(837):
LocalFile->purgeThumbnails(Array)
#5
/usr/local/apache/common-local/php-1.22wmf18/includes/filerepo/file/File.php(1079):
LocalFile->purgeCache()
#6
/usr/local/apache/common-local/php-1.22wmf18/includes/filerepo/file/LocalFile.php(1508):
File->purgeEverything()
#7 /usr/local/apache/common-local/php-1.22wmf18/includes/Title.php(3631):
LocalFile->move(Object(Title))
#8
/usr/local/apache/common-local/php-1.22wmf18/includes/specials/SpecialMovepage.php(518):
Title->moveTo(Object(Title), true, '', true)
#9
/usr/local/apache/common-local/php-1.22wmf18/includes/specials/SpecialMovepage.php(100):
MovePageForm->doSubmit()
#10 /usr/local/apache/common-local/php-1.22wmf18/includes/SpecialPage.php(631):
MovePageForm->execute(NULL)
#11
/usr/local/apache/common-local/php-1.22wmf18/includes/SpecialPageFactory.php(489):
SpecialPage->run(NULL)
#12 /usr/local/apache/common-local/php-1.22wmf18/includes/Wiki.php(291):
SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#13 /usr/local/apache/common-local/php-1.22wmf18/includes/Wiki.php(590):
MediaWiki->performRequest()
#14 /usr/local/apache/common-local/php-1.22wmf18/includes/Wiki.php(459):
MediaWiki->main()
#15 /usr/local/apache/common-local/php-1.22wmf18/index.php(55):
MediaWiki->run()
#16 /usr/local/apache/common-local/w/index.php(3):
require('/usr/local/apac...')
#17 {main}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54482] a new key for faster search mw.title.new()

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54482

Brad Jorsch  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #3 from Brad Jorsch  ---
(In reply to comment #2)
> Sorry, the function mw.title.new( id ) is "expensive" in the Lua manual.

Yes, that's because we don't want people doing thousands of database lookups to
load (or check the existence of) thousands of title objects. Adding CRCs isn't
going to change that, because it's the thousands of database round-trips we're
wanting to avoid.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54195] CentralAuth not caching Special:CentralAutoLogin/start

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195

--- Comment #8 from Brad Jorsch  ---
(In reply to comment #6)
> Brad, do remember why we add returnto and returntoquery in
> centralautologin.js
> for non-login pages? It's not used except when we get to the /setCookies
> phase,
> and there, it only adds a window.location if the request had a 'return'
> parameter, which I don't ever see set. So it seems like we're passing it
> around
> without actually using it.. but am I missing something?

git blame would point you to Gerrit change 83007. The returnto gets used in
SkinTemplate.php in core, when it generates the #p-personal replacement.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54675] New: VisualEditor: Render lock when changing selection prevents inspectors' changes from rendering

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54675

   Web browser: ---
Bug ID: 54675
   Summary: VisualEditor: Render lock when changing selection
prevents inspectors' changes from rendering
   Product: VisualEditor
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: ContentEditable
  Assignee: i...@wikia-inc.com
  Reporter: roan.katt...@gmail.com
CC: da...@sheetmusic.org.uk, i...@wikia-inc.com,
jforres...@wikimedia.org, krinklem...@gmail.com,
or...@framezero.com, tpars...@wikimedia.org
Classification: Unclassified
   Mobile Platform: ---

This is the root cause of bug 54335. Basically, you open the language inspector
(or the link inspector, for that matter), make a change, then close the
inspector by clicking elsewhere into the document (as opposed to by using the
arrow or by pressing enter or escape in the link inspector's text input).

Narrated call stack:
* A mouseup event fires on the document
* ve.ce.Surface.onDocumentMouseUp() starts the observer and polls
* The observer notices that the selection has changed and emits a
selectionChange event, which ends up invoking ve.ce.Surface.onSelectionChange
* onSelectionChange sets a render lock and changes the model selection
* ve.dm.Surface.change() emits a change event
* ve.ui.Context.onChange() notices that the selection changed while an
inspector was visible, so it closes the inspector
* ve.ui.AnnotationInspector.onClose() saves the changes the user made to the
model, by indirectly calling ve.dm.Surface.change()
* (at this point, we have a change() call stack frame nested inside another
change() frame, which is always a bad sign)
* The transaction processed by onClose() annotates text, which causes an update
event to be emitted
* ve.ce.ContentBranchNode.onChildUpdate() responds to this event and calls
renderContents()
* renderContents() checks to see if the surface is locked for rendering; it is,
so it bails and doesn't render the change

When I briefly talked to Trevor about this issue, he said something about
emitting an event asynchronously. I dismissed it at the time, because it would
just move both problems (having to lock to prevent the model normalizing the
selection / event storms, but having to not lock to allow inspector changes to
render), but now I think about it I think it has merit. We could have
ve.ui.Context.onChange() asynchronously close the inspector, from a
setTimeout(). That would avoid the nested change() thing, and it would allow
the render lock to be lifted before the inspector is closed.

Alternatively, onSelectionChange could only lock against selection changes and
still allow transactions. But the nested change() seems like a code smell
anyway, the order of event handlers might get messed up for instance, and the
caller would observe multiple changes from calling change() once (that's the
root of the problem here).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54580] [Experimental] Query string disappears after page is loaded

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54580

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|ASSIGNED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54580] [Experimental] Query string disappears after page is loaded

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54580

--- Comment #3 from Gerrit Notification Bot  ---
Change 86211 had a related patch set uploaded by Jdlrobson:
Ajax Page Loads: Don't drop the query string

https://gerrit.wikimedia.org/r/86211

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54580] [Experimental] Query string disappears after page is loaded

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54580

Jon  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|wikibugs-l@lists.wikimedia. |jrob...@wikimedia.org
   |org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54674] Fatal error renaming file

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54674

Bartosz Dziewoński  changed:

   What|Removed |Added

 CC||matma@gmail.com
   Severity|normal  |critical

--- Comment #1 from Bartosz Dziewoński  ---
(Data loss → critical.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54674] New: Fatal error renaming file

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54674

   Web browser: ---
Bug ID: 54674
   Summary: Fatal error renaming file
   Product: MediaWiki
   Version: 1.22-git
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: File management
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: bda...@wikimedia.org
CC: bawolff...@gmail.com, bryan.tongm...@gmail.com,
fflo...@wikimedia.org, mtrac...@member.fsf.org
Classification: Unclassified
   Mobile Platform: ---

Reported on #wikimedia-tech by Dragonfly6-7:

6:28Dragonfly6-7I just killed an image while trying to rename it
6:29Dragonfly6-7the system told me "Fatal error (numbers that I didn't
copy in time)", and then I tried to rename it again, and now it's gone gone
gone
6:32Dragonfly6-7originally it was [[File:Kufuor.JPG]] (on en.wiki)
6:34Dragonfly6-7and I tried moving it to [[File:John Agyekum Kufuor
(June 28, 2001).jpg]]

MaxSem looked in server logs and found:

6:41MaxSem2013-09-27 00:27:28 mw1049 enwiki: [770efea1]
/w/index.php?title=Special:MovePage&action=submit   Exception from line 1053 of
/usr/local/apache/common-l
6:41MaxSemocal/php-1.22wmf18/includes/filebackend/SwiftFileBackend.php:
Got InvalidResponseException exception.

This seems to be a semi-expected error condition in SwiftFileBackend.
SwiftFileBackend::handleException() looks specifically for
InvalidResponseException and forces a re-connect and re-auth.

The loss of the image from enwiki is the troubling part. It seems like the move
operation should have been rolled back. Instead the move took place but the
media file is not found at the new expected location.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 46377] MeetBot for #wikimedia-office

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=46377

--- Comment #7 from Quim Gil  ---
(In reply to comment #6)
> GIVE IT A TRY !!

BIG THANK YOU!

The Engineering Community Team will give it a try soon and we will report back.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54597] Remove $wgBlockOpenProxies (or move to an extension)

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54597

--- Comment #1 from Chris Steipp  ---
I think this is a good idea, if anyone is up for doing the work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54597] Remove $wgBlockOpenProxies (or move to an extension)

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54597

Bartosz Dziewoński  changed:

   What|Removed |Added

 CC||matma@gmail.com

--- Comment #2 from Bartosz Dziewoński  ---
Can we just remove it? I'm up for removing. :P

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 48915] VisualEditor: Respect Parsoid's

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=48915

--- Comment #14 from Roan Kattouw  ---
(In reply to comment #13)
> Change 86065 had a related patch set uploaded by Catrope:
> Resolve rendered URLs according to the provided 
> 
> https://gerrit.wikimedia.org/r/86065
This addresses the most common symptoms of this bug. It fixes rendering of link
targets for internal links (at least on initial rendering; the href attribute
doesn't update correctly when the link is edited), and it fixes href and src
attributes of things inside of generated content nodes (templates, mostly).

While the change in Gerrit fixes href/src attribute rendering for uneditable
href/src attributes, we still have to do something for models that manage their
own href/src and edit it, or generate it from another editable attribute.

ve.dm.LinkAnnotation, ve.dm.MWExternalLinkAnnotation: href attribute is edited
directly; in practice MWExternalLinkAnnotation is a full URL and LinkAnnotation
isn't used in the MW integration, but we should still fix them.

ve.dm.MWInternalLinkAnnotation: Generates href based on title attribute, which
can be edited. Links that came directly from Parsoid now render correctly due
to a hack (see bug 51487), but edited links don't render correctly.

ve.dm.ImageNode, ve.dm.MWInlineImageNode, ve.dm.MWBlockImageNode: src attribute
is edited directly; in practice, the MW ones use full URLs (the user doesn't
edit the src directly, and the UI widget gets full URLs from the API) and
ImageNode isn't used in the MW integration, but we should still fix them.

ve.dm.MWCategoryMetaItem, ve.dm.MWLanguageMetaItem: these manage hrefs that can
be edited, but they're never rendered and always absolute, so we don't really
care

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 48915] VisualEditor: Respect Parsoid's

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=48915

Roan Kattouw  changed:

   What|Removed |Added

 Blocks||51487

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 51487] VisualEditor: Get rid of dmRendering stuff in ce.MWInternalLinkAnnotation

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=51487

Roan Kattouw  changed:

   What|Removed |Added

 Depends on||48915

--- Comment #3 from Roan Kattouw  ---
(In reply to comment #2)
> (In reply to comment #1)
> > Change 86065 had a related patch set uploaded by Catrope:
> > Resolve rendered URLs according to the provided 
> > 
> > https://gerrit.wikimedia.org/r/86065
> This change tried to just get rid of href computation, but that's not good
> enough. It does need to actually be computed.

The most recent version of this change actually makes the hack worse, in order
to partly fix bug 48915. Once that bug is fixed properly, this hack can be
removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54673] LESS compiler should preserve the position of CSSMin / CSSJanus annotations

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54673

Bartosz Dziewoński  changed:

   What|Removed |Added

 CC||krinklem...@gmail.com,
   ||tpars...@wikimedia.org
  Component|General/Unknown |ResourceLoader
   Target Milestone|--- |1.22.0 release

--- Comment #1 from Bartosz Dziewoński  ---
(Marking with 1.22 milestone – we really should find a way to make embedding
and flipping work with LESS before the release, with this or otherwise.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54458] Accounts with ipb_user = 0

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54458

--- Comment #3 from とある白い猫  ---
I'd request investigating the reason and fixing the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 51487] VisualEditor: Get rid of dmRendering stuff in ce.MWInternalLinkAnnotation

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=51487

--- Comment #2 from Roan Kattouw  ---
(In reply to comment #1)
> Change 86065 had a related patch set uploaded by Catrope:
> Resolve rendered URLs according to the provided 
> 
> https://gerrit.wikimedia.org/r/86065
This change tried to just get rid of href computation, but that's not good
enough. It does need to actually be computed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 51487] VisualEditor: Get rid of dmRendering stuff in ce.MWInternalLinkAnnotation

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=51487

Roan Kattouw  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |NEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 44613] Editor Engagement Experiments public data sets

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=44613

Matthew Flaschen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Matthew Flaschen  ---
Marking fixed.

If there are issues with Wikimetrics, they can be filed at
https://bugzilla.wikimedia.org/enter_bug.cgi?product=Analytics&component=Wikimetrics
.  People can also discuss these issues on the
https://lists.wikimedia.org/mailman/listinfo/analytics list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54673] New: LESS compiler should preserve the position of CSSMin / CSSJanus annotations

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54673

   Web browser: ---
Bug ID: 54673
   Summary: LESS compiler should preserve the position of CSSMin /
CSSJanus annotations
   Product: MediaWiki
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: General/Unknown
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: o...@wikimedia.org
CC: br...@wikimedia.org, matma@gmail.com,
roan.katt...@gmail.com
Classification: Unclassified
   Mobile Platform: ---

We have some fancy ideas for handling image embedding and flipping in LESS, but
until they are realized, LESS should preserve CSS @embed and @noflip
annotations.

The problematic bits in lessc.inc.php that need to be modified are in lines
280-286:

protected function compileProps($block, $out) {
foreach ($this->sortProps($block->props) as $prop) {
$this->compileProp($prop, $block, $out);
}

$out->lines = array_values(array_unique($out->lines));
}


Required changes:
* Call to array_unique() should be replaced with something that exempts
comments, because it is valid to have multiple /* @embed */ annotations in a
single block. (Maybe we can just get rid of 'array_unique' -- it could be a
nonstandard performance optimization.)
* sortProps should preserve the position of @annotations relative to the rules
below them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54195] CentralAuth not caching Special:CentralAutoLogin/start

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|REOPENED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54195] CentralAuth not caching Special:CentralAutoLogin/start

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195

--- Comment #7 from Gerrit Notification Bot  ---
Change 86207 had a related patch set uploaded by CSteipp:
Remove returnto for basic login test

https://gerrit.wikimedia.org/r/86207

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54276] RTL for Notification Tool: ? should be ؟ icon

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54276

bs...@wikimedia.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from bs...@wikimedia.org ---


*** This bug has been marked as a duplicate of bug 54252 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54195] CentralAuth not caching Special:CentralAutoLogin/start

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54195

Chris Steipp  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #6 from Chris Steipp  ---
Thanks Faidon. In the majority case, the ping to check if the anon user is
logged in, we shouldn't need the returnto.. so if that's being added, I think
we can fix that.

Brad, do remember why we add returnto and returntoquery in centralautologin.js
for non-login pages? It's not used except when we get to the /setCookies phase,
and there, it only adds a window.location if the request had a 'return'
parameter, which I don't ever see set. So it seems like we're passing it around
without actually using it.. but am I missing something?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 745] RTL/bidirectional issues (tracking)

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=745

Bug 745 depends on bug 54276, which changed state.

Bug 54276 Summary: RTL for Notification Tool: ? should be ؟ icon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54276

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54252] some images need to be reversed for RTL languages

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54252

bs...@wikimedia.org changed:

   What|Removed |Added

 CC||reza.ene...@gmail.com

--- Comment #4 from bs...@wikimedia.org ---
*** Bug 54276 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54613] numbers are not formatted on Special:Nearby

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54613

Jon  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54613] numbers are not formatted on Special:Nearby

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54613

--- Comment #2 from Gerrit Notification Bot  ---
Change 86027 merged by jenkins-bot:
Add convertNumber to localize the distance

https://gerrit.wikimedia.org/r/86027

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54655] "Cannot determine host VirtualBox version." running update-guest-additions in "vagrant ssh"

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54655

--- Comment #4 from Brion Vibber  ---
So the problem seems to be that VBoxManage is actually crapping out with a
low-level error:

sh: line 1:  2322 Trace/BPT trap: 5   VBoxManage -v 2> /dev/null

^ so we get an empty string as output.

I can find some general references to this 'Trace/BPT trap: 5' thing happening
in VBox, Postgres, and a couple other things on OS X and FreeBSD... not really
sure what it actually means.

It's possible that something in the Vagrant or Puppet environment is causing
libraries or config files not to load, or something, and it's crashing the
program. Weeird! I haven't figured out how to repro it directly, but it
happens quite consistently when rerunning 'vagrant provision'.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54672] New: ApiQueryMessageGroups should complete in 5 seconds

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54672

   Web browser: ---
Bug ID: 54672
   Summary: ApiQueryMessageGroups should complete in 5 seconds
   Product: MediaWiki extensions
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: Translate
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: niklas.laxst...@gmail.com
CC: alolita.sha...@gmail.com, asha...@wikimedia.org,
kartik.mis...@gmail.com, niklas.laxst...@gmail.com,
run...@gmail.com, s.mazel...@xs4all.nl,
santhosh.thottin...@gmail.com
Classification: Unclassified
   Mobile Platform: ---

We had to extra delay in https://gerrit.wikimedia.org/r/86199

The list of groups should load under 5 seconds of opening the group selector.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53635] div.navbar-inner obscures content on Internet Explorer 10

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53635

Quim Gil  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 CC||a...@bitergia.com,
   ||christ...@quelltextlich.at
  Component|(other) |Tech community metrics
Product|Wikimedia Labs  |Analytics

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53719] Only 30 repos listed in tech community metrics

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53719

Quim Gil  changed:

   What|Removed |Added

   Priority|High|Normal
   Severity|major   |normal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54469] Bugzilla data scanned for tech metrics must be aligned with repos scanned

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54469

Quim Gil  changed:

   What|Removed |Added

   Priority|High|Normal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54655] "Cannot determine host VirtualBox version." running update-guest-additions in "vagrant ssh"

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54655

--- Comment #3 from Brion Vibber  ---
Just checking some of the code from the functions in
lib/mediawiki-vagrant/helpers.rb manually:

>> RbConfig::CONFIG['host_os'] =~ /mswin|msys|mingw32|windows/i
=> nil

(so it shouldn't be accidentally thinking it's Windows)

>> `VBoxManage -v 2>/dev/null`[/[\d\.]+/] rescue nil
=> "4.2.18"

(so it seems to return a sane value...)


and from puppet/modules/virtualbox/manifests/init.pp:

>> "4.2.18" =~ /[\d.]+/
=> 0

(so it should create /etc/virtualbox-version) Apparently 0 evaluates to "true"
in Ruby. Nice. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 47191] [Regression] Installer: MySQL Fatal Error "1283: Column 'si_title' cannot be part of FULLTEXT index" for collation set to "binary"

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=47191

--- Comment #12 from Gerrit Notification Bot  ---
Change 86075 merged by jenkins-bot:
Use utf8 charset for searchindex MySQL table

https://gerrit.wikimedia.org/r/86075

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54646] Signs by numerical keypad

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54646

--- Comment #3 from benningh...@ekir.de ---
The bug is reproducable on all de.wikipedia.org-pages, but not on other
wikimedia-sites like commons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53635] div.navbar-inner obscures content on Internet Explorer 10

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53635

--- Comment #3 from Jack Phoenix  ---
The offending CSS property seems to be the height: auto; on the img element in
http://korma.wmflabs.org/browser/VizGrimoireJS/vizgrimoire.css. After removing
the img styles provided by
http://korma.wmflabs.org/browser/VizGrimoireJS/bootstrap/css/bootstrap.css (via
IE's built-in developer tools), only the three styles defined in
vizgrimoire.css apply and removing the height: auto; provided by that file
fixes this issue and makes the WMF logo display as it does on MatmaRex's
screenshot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54642] VisualEditor: Right half of toolbar disappears when image caption on first line contains "page " followed by any string

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54642

Chris McKenna  changed:

   What|Removed |Added

 CC||cmcke...@sucs.org
   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=53312,
   ||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=54379

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54379] VisualEditor: Right half of toolbar disappears when or appears in image on first line of page

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54379

Chris McKenna  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=54642

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53312] Image captions containing "page " anywhere are parsed as page option

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53312

Chris McKenna  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=54642

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54671] New: VisualEditor opt-in preference disappears

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54671

   Web browser: ---
Bug ID: 54671
   Summary: VisualEditor opt-in preference disappears
   Product: Wikimedia Labs
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: Unprioritized
 Component: deployment-prep (beta)
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: cmcma...@wikimedia.org
CC: benap...@gmail.com, cmcma...@wikimedia.org,
fai...@wikimedia.org, has...@free.fr,
mhershber...@wikimedia.org, platoni...@gmail.com
Classification: Unclassified
   Mobile Platform: ---

As user Selenium_user on beta labs enwiki, I have set my preference to opt-in
to VisualEditor several times, but the preference then gets reset to default
(opt-in not set) after a period of some hours.  

This causes failures in the browser tests and I wonder if it is a risk in the
production environment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54346] Rename / forward E3 list emails to new Growth list

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54346

Steven Walling  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Steven Walling  ---
(In reply to comment #3)
> Great. I've created the list and done some basic set up (confirm and approve
> subscription, private archives and terse phrase) and sent you an email with
> the
> password.

Thank you so much!

> 
> CC'ing Daniel in here - Daniel please could you add an email alias (on exim I
> think?) to forward all emails sent to e3-t...@lists.wikimedia.org to
> growth-t...@lists.wikimedia.org (but don't set up a web redirect as Steven
> would still like to view the archives of the old list)?

On second thought, I am not sure we need to do this. Now that we have the new
list, I unsub'd everyone, added relevant folks to the new list, and can set an
auto-reply for the e3 list that points to the new list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54233] notes.html missing in tech metrics

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54233

Quim Gil  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54232] Bots showing up as contributors in tech metrics

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54232

Quim Gil  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53719] Only 30 repos listed in tech community metrics

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53719

Quim Gil  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |ASSIGNED

--- Comment #6 from Quim Gil  ---
(Removing Patch to Review since we use it only when there is an actual patch to
review in Gerrit)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53719] Only 30 repos listed in tech community metrics

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53719

Quim Gil  changed:

   What|Removed |Added

   Priority|Highest |High

--- Comment #5 from Quim Gil  ---
Looking at http://korma.wmflabs.org/browser/scm-repos.html

This UI is realy confusing... It took me a while to see the ">"... 

If we have >200 repositories in practice is impractical to click Next maybe 20
times to find your project... Is there a quick way to search/find the data of a
specific project?

The current design might be enough for up to 10 repos but beyond that things
start getting really ugly (e.g. the column graphs are almost meaningless when
they show only the 10 repos listed in that page).

Do you agree with this problem?

One possibility would be to have a text-only table/list with all reports,
sorted alphabetically, specifying the basic metrics of every repo and a link to
go to the specific page of the repo.

But... maybe it's better to sketch before coding? Currently is not even clear
what UI are you after.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54670] Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54670

--- Comment #1 from Sam Reed (reedy)  ---
[26-Sep-2013 22:10:19] Fatal error: Call to a member function setFragment() on
a non-object at
/usr/local/apache/common-local/php-1.22wmf19/extensions/LiquidThreads/pages/ThreadPermalinkView.php
on line 168
Server: mw1212
Method: GET
URL:
http://www.mediawiki.org/wiki/Thread:Talk:MediaWiki_1.19/Broken_redirects_and_sidebar_display_after_upgrade_from_MW_1.12_to_MW_1.19/reply_(2)
Backtrace:
#0
/usr/local/apache/common-local/php-1.22wmf19/extensions/LiquidThreads/pages/ThreadPermalinkView.php(168):
ThreadPermalinkView::getSubtitle()
#1
/usr/local/apache/common-local/php-1.22wmf19/extensions/LiquidThreads/pages/ThreadPermalinkView.php(231):
ThreadPermalinkView->getSubtitle()
#2
/usr/local/apache/common-local/php-1.22wmf19/extensions/LiquidThreads/classes/Dispatch.php(100):
ThreadPermalinkView->show()
#3
/usr/local/apache/common-local/php-1.22wmf19/extensions/LiquidThreads/classes/Dispatch.php(220):
LqtDispatch::threadPermalinkMain(Object(OutputPage), Object(Article),
Object(Title), Object(User), Object(WebRequest))
#4 [internal function]: LqtDispatch::tryPage(Object(OutputPage),
Object(Article), Object(Title), Object(User), Object(WebRequest),
Object(MediaWiki))
#5 /usr/local/apache/common-local/php-1.22wmf19/includes/Hooks.php(199):
call_user_func_array('LqtDispatch::tr...', Array)
#6
/usr/local/apache/common-local/php-1.22wmf19/includes/GlobalFunctions.php(3898):
Hooks::run('MediaWikiPerfor...', Array)
#7 /usr/local/apache/common-local/php-1.22wmf19/includes/Wiki.php(423):
wfRunHooks('MediaWikiPerfor...', Array)
#8 /usr/local/apache/common-local/php-1.22wmf19/includes/Wiki.php(305):
MediaWiki->performAction(Object(Article), Object(Title))
#9 /usr/local/apache/common-local/php-1.22wmf19/includes/Wiki.php(591):
MediaWiki->performRequest()
#10 /usr/local/apache/common-local/php-1.22wmf19/includes/Wiki.php(460):
MediaWiki->main()
#11 /usr/local/apache/common-local/php-1.22wmf19/index.php(55):
MediaWiki->run()
#12 /usr/local/apache/common-local/w/index.php(3):
require('/usr/local/apac...')
#13 {main}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54626] forceHTTPS session cookie placed even with HTTPS opt-out set

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54626

--- Comment #3 from Gerrit Notification Bot  ---
Change 86101 merged by jenkins-bot:
Explicitly clear forceHTTPS cookie when insecure

https://gerrit.wikimedia.org/r/86101

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54670] New: Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54670

   Web browser: ---
Bug ID: 54670
   Summary: Fatal error:  Call to a member function setFragment()
on a non-object in ThreadPermalinkView.php on line 168
   Product: MediaWiki extensions
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: LiquidThreads
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: s...@reedyboy.net
CC: agarr...@wikimedia.org, jforres...@wikimedia.org
Blocks: 17553
Classification: Unclassified
   Mobile Platform: ---

Fatal error:  Call to a member function setFragment() on a non-object in
/usr/local/apache/common-local/php-1.22wmf19/extensions/LiquidThreads/pages/ThreadPermalinkView.php
on line 168

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 17553] LQT Call to a member function ... on a non-object at different places

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=17553

Sam Reed (reedy)  changed:

   What|Removed |Added

 Depends on||54670

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54512] Ex:OpenID needs to work with $wgSecureLogin

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54512

Chris Steipp  changed:

   What|Removed |Added

Summary|Ex:OpenID needs to work |Ex:OpenID needs to work
   |with wgServerLogin  |with $wgSecureLogin

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 10887] API JSON formatter returns [] as an empty return value - inconsistent with {} for non-empty values

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=10887

--- Comment #9 from Brion Vibber  ---
(In reply to comment #6)
> Resolving as LATER. [] is legal syntax, but inconsistent. If Python can't
> handle [], that's a problem in their JSON interpreter. We could fix this in
> theory, but it's so much hassle that it's only practical to do if the
> formatting code as a whole is revised.

Just to clarify on this old bug -- the Python JSON interpreter can handle []
just fine, but it creates a *list* (equivalent to JS *array*) instead of a
*dict* (equivalent to JS *object*).

This can cause problems if you do some kind of operation on what you expected
would be a dict/object/map/hash/associative array.

This is not Python-specific, but could also cause problems in Java,
Objective-C, C++, and ... basically anything but PHP  especially for those
with strong typing, you might even throw an error when simply assigning an
extracted object to a variable of what turns out to be the wrong type.


A few possible ways to resolve this, should we care to:

a) use objects instead of associative arrays in the PHP code in the first place

b) use a special array key value that the JSON formatter knows to drop from the
output, that forces an otherwise empty array to be treated as an associative
array

c) create a special object type that wraps associative arrays in the API
output, that the JSON formatter knows how to deal with

Under PHP 5.4, option c) can be combined with the JsonSerializable interface to
ensure that a wrapped associative array outputs the way we want it even if
people use json_encode() directly, so this could be used outside the API as
well.

Combine that with the array-like object interface, and the array wrapper also
becomes transparent to array-like uses in PHP. I think this is my favorite
method...

  $data['pages'] = $someArray;
  // ...
  echo json_encode( $data ); // {"pages":[]} OOPS!

fix to:

  // wrap an array that might be empty
  $data['pages'] = new JsonAssociativeArray( $someArray );
  // ...
  echo json_encode( $data ); // {"pages":{}}

or

  // start with an empty array
  $foo = new JsonAssociativeArray();
  if ( $condition ) {
$foo["bar"] = "baz";
  }
  $data['pages'] = $foo;
  // ...
  echo json_encode( $data ); // {"pages":{}}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53485] Key performance indicator: analyze who contributes code

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53485

Quim Gil  changed:

   What|Removed |Added

   Priority|Highest |High

--- Comment #4 from Quim Gil  ---
There are a couple of highest issues that we want to fix before tackling this
one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54230] Tech metrics missing IRC channels

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54230

Quim Gil  changed:

   What|Removed |Added

   Priority|Highest |Normal

--- Comment #4 from Quim Gil  ---
IRC channels are not that critical. Normal priority.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54512] Ex:OpenID needs to work with wgServerLogin

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54512

Chris Steipp  changed:

   What|Removed |Added

Summary|Does not work with  |Ex:OpenID needs to work
   |$wgCanonicalServer as   |with wgServerLogin
   |http:// and forceHTTPS  |
   |cookie  |

--- Comment #1 from Chris Steipp  ---
This is a problem with the id provider has $wgSecureLogin enabled. Since the
WMF is running $wgSecureLogin, we need the extension to work with this in order
to deploy it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54584] VisualEditor: MWExtensionNode/GeneratedContentNode should avoid emitting 'rerender' twice when rendering s

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54584

Roan Kattouw  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Roan Kattouw  ---
https://gerrit.wikimedia.org/r/#/c/86167/ fixes this

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54669] New: search by string

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54669

   Web browser: ---
Bug ID: 54669
   Summary: search by string
   Product: MediaWiki extensions
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Unprioritized
 Component: CirrusSearch
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: massimo.palmie...@libero.it
CC: innocentkil...@gmail.com,
neverett+bugzi...@wikimedia.org
Classification: Unclassified
   Mobile Platform: ---

when I serach for string PO:BAR:AZU I wish retrieve only the string
"PO:BAR:AZU", not string "PO:BAR" close to string "AZU". Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54623] Wrapping guider title leads to misplaced close action

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54623

Steven Walling  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Steven Walling  ---
Deployed and working.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54668] New: Parsoid problem with the tag, wrong navigation links

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54668

   Web browser: ---
Bug ID: 54668
   Summary: Parsoid problem with the  tag, wrong navigation
links
   Product: Parsoid
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: General
  Assignee: gwi...@wikimedia.org
  Reporter: kel...@kiwix.org
CC: ssas...@wikimedia.org
Classification: Unclassified
   Mobile Platform: ---

With Parsoid, the HTML generated from a  tag is partially wrong, the url
to go back to the precedent chapter points to the same current chapter.

In this example, it points to "CHAPITRE IX", although the reader is already at
this chapter:
http://parsoid.wmflabs.org/frwikisource/De%20la%20litt%C3%A9rature%20des%20n%C3%A8gres/9

In comparison, on Wikisource, this points correctly to "CHAPITRE VIII":
http://fr.wikisource.org/wiki/De_la_litt%C3%A9rature_des_n%C3%A8gres/9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54667] New: MediaWiki logging us out a lot

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54667

   Web browser: ---
Bug ID: 54667
   Summary: MediaWiki logging us out a lot
   Product: MediaWiki
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: General/Unknown
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: sarahstie...@gmail.com
Classification: Unclassified
   Mobile Platform: ---

Hi everyone. 

Myself and my co-worker Jaime (who works on the Program Evaluation team) have
noticed that we get logged off of MetaWiki every time we refresh a page, or if
we close the tab and go back to check our watchlist or make an edit it logs me
off. 

We both click remember me and it still stops working. 

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54667] MediaWiki logging us out a lot

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54667

Sarah Stierch  changed:

   What|Removed |Added

   Hardware|All |Macintosh
Web browser|--- |Google Chrome
 OS|All |Mac OS X 10.8

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53636] text input history/autocomplete doesn't work in IE + https

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53636

Paine Ellsworth  changed:

   What|Removed |Added

 CC||pain...@aol.com

--- Comment #5 from Paine Ellsworth  ---
I'm going to track this closely because I just asked this question at the
pump...
https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#AutoComplete_.E2.80.93_forms
and my buddy, Jimbo, assured me it would be fixed soon.  Well, that last part's
not entirely true, but I do make a lot of edits that require the same edit
summary, so this is a huge time bottleneck for me, and probably other
contributors, as well.  Please fix this soon, especially since bug 54626 has
not yet been resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 53378] ApiMobileView::getData: PoolCounter didn't return parser output

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=53378

--- Comment #3 from Gerrit Notification Bot  ---
Change 85980 merged by jenkins-bot:
Check latest revision in mobileview

https://gerrit.wikimedia.org/r/85980

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54666] New: FormSpecialPage's onSubmit() signature omits $form parameter

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54666

   Web browser: ---
Bug ID: 54666
   Summary: FormSpecialPage's onSubmit() signature omits $form
parameter
   Product: MediaWiki
   Version: 1.22-git
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: Special pages
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: sp...@wikimedia.org
Classification: Unclassified
   Mobile Platform: ---

HTMLForm's trySubmit() calls the client-supplied onSubmit() callback:
call_user_func( $callback, $data, $this );

so the second parameter to the callback is the HTMLForm object. This doesn't
seem to be documented anywhere.

But when you subclass FormSpecialPage, it declares the form handler as
abstract public function onSubmit( array $data );

so you can't access this second parameter.  I need access to the form for a
demo program because some of the controls on the form affect its display.

If I change the function declaration in SpecialPage.php to
abstract public function onSubmit( array $data, $form );

then my program can access the form object, but this breaks all the other pages
that subclass FormSpecialPage.

I dunno if there's some PHP foo to let children inspect the hidden second
parameter, or some way not to break the API.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54482] a new key for faster search mw.title.new()

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54482

--- Comment #2 from Rical  ---
Sorry, the function mw.title.new( id ) is "expensive" in the Lua manual.

Perhaps the cost is due to the search of the page by comparing full page names
with others. In this case, to accelerate this comparing we could compare short
int64 keys rather than full names. These keys could be computed like CRC
polynoms from the full names.

Such keys change the sorting of pages, but this no matter because the goal is
only "exists-or-no".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 52102] VisualEditor: Write newFromDocumentReplace so editing document slices is simple

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=52102

James Forrester  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 33105] VisualEditor: Preserve rich text formatting when pasting from internal or external sources (tracking)

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=33105

Bug 33105 depends on bug 52102, which changed state.

Bug 52102 Summary: VisualEditor: Write newFromDocumentReplace so editing 
document slices is simple
https://bugzilla.wikimedia.org/show_bug.cgi?id=52102

   What|Removed |Added

 Status|PATCH_TO_REVIEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 43436] Implement Twitter Cards

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=43436

Quim Gil  changed:

   What|Removed |Added

 CC||q...@wikimedia.org

--- Comment #17 from Quim Gil  ---
fwiw https://www.mediawiki.org/wiki/Extension:TwitterCards also exists (it's
the same project that Harsh started).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 54665] New: Jenkins job for verifying LESS files

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=54665

   Web browser: ---
Bug ID: 54665
   Summary: Jenkins job for verifying LESS files
   Product: Wikimedia
   Version: wmf-deployment
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: Continuous integration
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: jgon...@wikimedia.org
CC: has...@free.fr, innocentkil...@gmail.com,
krinklem...@gmail.com
Classification: Unclassified
   Mobile Platform: ---

We have LESS support in core now. Since it is a language that compiles to CSS,
we should have a Jenkins job verifying that all the LESS files compile without
errors.

Ori suggested that the job should go over all the registered ResourceLoader
modules, fetch LESS files from them and run the compiler on each of them to see
if there are any errors.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 43436] Implement Twitter Cards

2013-09-26 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=43436

Quim Gil  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=49859

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


  1   2   3   4   5   >