date:20131009

[Bug 55541] Segfault when getting EXIF data of some tif images

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55541

Chad H.  changed:

   What|Removed |Added

 CC||innocentkil...@gmail.com

--- Comment #10 from Chad H.  ---
Possibly needs reporting in hhvm as well, as most of the exif code is lifted
straight from zend.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40694] Translatable page header is at the bottom of the page

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=40694

Siebrand Mazeland  changed:

   What|Removed |Added

 CC||s.mazel...@xs4all.nl

--- Comment #12 from Siebrand Mazeland  ---
(In reply to comment #11)
> See also https://bugzilla.wikimedia.org/show_bug.cgi?id=53872

This comment is not relevant to this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55541] Segfault when getting EXIF data of some tif images

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55541

--- Comment #9 from Tim Starling  ---
Reported at https://bugs.php.net/bug.php?id=65873

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 53241] Use Map and Set instead of plain objects / ES6 shim cleanup

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=53241

--- Comment #19 from Arlo Breault  ---
Subbu, here's a comparison as requested in d),
https://gist.github.com/arlolra/6913667

So it's clear, in this case:

master is before that merge that just went in, so
ec485737eaa10f5336578e5a9f54fe944de9fc23

no-es6 is master with, git revert 560c79e9a1ee8d01bc9cc4b862f280fa6752a610

and es6regress is what just went in dea9cbfa8ff4a6aea12930ca13c2d0f3491d8477

Still seeing a regression so taking one of Cscott's solutions is probably best.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55530] Duplicated targets on Flow events in recent changes

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55530

--- Comment #1 from sp...@wikimedia.org ---
Prioritization and scheduling of this bug is tracked on Mingle card
https://mingle.corp.wikimedia.org/projects/flow/cards/310

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55541] Segfault when getting EXIF data of some tif images

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55541

Tim Starling  changed:

   What|Removed |Added

 CC||tstarl...@wikimedia.org

--- Comment #8 from Tim Starling  ---
I have the file. It is an interesting bug. The pointer offset_base is
deliberately assigned a value before the start of its associated buffer. It is
a kind of virtual start-of-file pointer -- when you add a file offset to
offset_base, you get a pointer to the memory that holds the file data at that
offset.

The bug occurs when the IFD offset is larger than the heap address for the file
buffer. This only happens when both the heap address is small (e.g. if it is
allocated from brk()) and the IFD offset is large. In this case, offset_base
wraps around past the start of the address space and becomes a large positive
pointer. This is mostly harmless, except for when a tag value is located so far
before the start of the IFD that its virtual pointer also wraps around to a
large positive value. Then in exif_process_IFD_TAG():

if (byte_count > IFDlength || offset_val > IFDlength-byte_count || value_ptr <
dir_entry) {

The "value_ptr < dir_entry" condition should be true, because the value is
before the IFD in the file, but because value_ptr has wrapped around and
dir_entry hasn't, it is false. So this code incorrectly assumes that value_ptr
is inside the already-loaded buffer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55518] on beta labs/master: IP recorded for logged-in-user, not username

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55518

--- Comment #2 from sp...@wikimedia.org ---
Prioritization and scheduling of this bug is tracked on Mingle card
https://mingle.corp.wikimedia.org/projects/flow/cards/309

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 53241] Use Map and Set instead of plain objects / ES6 shim cleanup

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=53241

--- Comment #18 from Arlo Breault  ---
For a), this seems to be the largest culprit:
https://gerrit.wikimedia.org/r/88927

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55334] ResourceLoader didn't invalidate cached CSS correctly for Extension:CategoryTree change

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55334

--- Comment #5 from Liangent  ---
I was logged in, and based on the time I don't think I was seeing that just
within 5 minutes after deployment, so, it's:

In the first 30 days, after the first 5 minutes: logged-in users see the new
i18n icon with (expected) the new css / (actual) the old css.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55546] Restore copy and paste function

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55546

Robert Myers  changed:

   What|Removed |Added

Mobile Platform|--- |iOS 7.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55547] New: tools: Disable the default no-op output buffer

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55547

   Web browser: ---
Bug ID: 55547
   Summary: tools: Disable the default no-op output buffer
   Product: Wikimedia Labs
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: tools
  Assignee: m...@uberbox.org
  Reporter: krinklem...@gmail.com
CC: benap...@gmail.com, t...@tim-landscheidt.de
Classification: Unclassified
   Mobile Platform: ---

// http://php.net/ob_get_level
> ob_get_level()
int(1)

http://php.net/ob_get_status
> ob_get_status()
array(5) {
  ["level"]=>
  int(1)
  ["type"]=>
  int(1)
  ["status"]=>
  int(0)
  ["name"]=>
  string(22) "default output handler"
  ["del"]=>
  bool(true)
}

According to phpinfo(), zlib.output_compression = Off and output_handler = ''.
That's good. But output_buffering = 4096 (silly PHP does this by default, it
has an output buffer that you can't enable but doesn't do anything either).

When using MediaWiki (or any other PHP app that tries to do the same) to send
pages gzipped, it gives up because there is an ob level already, and of a type
(internal php) that it claims it can't remove.

I ran into the same issue on my localhost, solved by setting:

 output_buffering = Off

in php.ini

Please do the same on tools.wmflabs.org so that we can actually send out
gzipped responses (especially important for tools that get called from popular
gadgets with cross-domain JSON-P requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55546] New: Restore copy and paste function

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55546

   Web browser: ---
Bug ID: 55546
   Summary: Restore copy and paste function
   Product: Commons App
   Version: unspecified
  Hardware: Smartphone
OS: All
Status: NEW
  Severity: trivial
  Priority: Unprioritized
 Component: iOS (iPhone or iPad)
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: bidgee-w...@virginbroadband.com.au
CC: br...@wikimedia.org, mh...@wikimedia.org
Classification: Unclassified
   Mobile Platform: ---

With the latest beta version (1.0.9), the copy and paste function is no longer
functional (removed or disabled) in the Commons app for the iPhone/iPad using
iOS 7.0.0.2. The function is handy to have, since I do my titles and
description on the iPhone's Notepad app, which can save time if you have
photographs that are similar or from the same event.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 52719] Requesting adding AdorshoLipi font for Bangla

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=52719

--- Comment #10 from Runa Bhattacharjee  ---
Tanvir, Nasir, Jayanta,

Can you please confirm that there is a community consensus for this font to be
made available for use? A link to a discussion or a discussion on this bug will
be fine.

We are done with the testing (you are welcome to test some more) and can push
it into the repo once we get a nod that the Bangla user community will not
object to having another font. Thanks.

Runa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 52719] Requesting adding AdorshoLipi font for Bangla

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=52719

--- Comment #9 from Runa Bhattacharjee  ---
Patch tested. Works well with Firefox and Chrome.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55545] New: Auto login from CentralAuth shows unstyled Echo markup

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55545

   Web browser: ---
Bug ID: 55545
   Summary: Auto login from CentralAuth shows unstyled Echo markup
   Product: Wikimedia
   Version: wmf-deployment
  Hardware: All
OS: All
Status: NEW
  Keywords: design
  Severity: normal
  Priority: Unprioritized
 Component: General/Unknown
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: krinklem...@gmail.com
Classification: Unclassified
   Mobile Platform: ---

Created attachment 13469
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=13469&action=edit
Screenshot of auto login (top), and regular (bottom)

When CentralAuth does an autologin and transition the personal portlet to a
logged-in state, it also gets markup from ULS and Echo.

ULS's stylsheets are loaded for anonymous users as well, so those look fine.
Not so much for Echo.

Either CentralAuth needs to account for this (e.g. a hook to build a list of
module names to pass to mw.loader.using before showing the new links), or Echo
needs to have the HTML fallback better so that it doesn't look like an
out-of-place number.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55544] Does not parse interwiki link (to MediaWiki.org)

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55544

Matthew Flaschen  changed:

   What|Removed |Added

Mobile Platform|--- |Android 4.2.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55544] Does not parse interwiki link (to MediaWiki.org)

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55544

--- Comment #2 from Matthew Flaschen  ---
I forgot to mention.  This is with the latest, Android 1.0beta12.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55544] Does not parse interwiki link (to MediaWiki.org)

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55544

--- Comment #1 from Matthew Flaschen  ---
Created attachment 13468
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=13468&action=edit
Screenshot showing unparsed link

It also doesn't seem to want to load the PDF, but I think that's separate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55544] New: Does not parse interwiki link (to MediaWiki.org)

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55544

   Web browser: ---
Bug ID: 55544
   Summary: Does not parse interwiki link (to MediaWiki.org)
   Product: Commons App
   Version: unspecified
  Hardware: Smartphone
OS: Linux
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: Android
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: mflasc...@wikimedia.org
CC: br...@wikimedia.org, yuvipa...@gmail.com
Classification: Unclassified
   Mobile Platform: ---

The interwiki link at
https://commons.wikimedia.org/wiki/File:Wikimania_GuidedTour.pdf is not parsed
when displayed in the "My Uploads" view.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55507] Emulate site group for special wikis

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55507

Sam Reed (reedy)  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55513] Define DataType for quantities

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55513

Sam Reed (reedy)  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55512] Implement QuantityValue

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55512

Sam Reed (reedy)  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55511] Implement DecimalValue

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55511

Sam Reed (reedy)  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55533] VisualEditor: MWSyntaxHighlight* is badly broken

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55533

James Forrester  changed:

   What|Removed |Added

   Priority|Unprioritized   |High
 CC||rm...@wikimedia.org
  Component|General |Editing Tools
   Assignee|jforres...@wikimedia.org|tpars...@wikimedia.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55453] VisualEditor: Bug in Converter throws "Uncaught NotFoundError: An attempt was made to reference a Node in a context where it does not exist."

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55453

James Forrester  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |ASSIGNED

--- Comment #9 from James Forrester  ---
Patch to disable SyntaxHighlight is now merged, so this problem will be
suppressed with the production push tomorrow morning; restoring to "ASSIGNED".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55533] VisualEditor: MWSyntaxHighlight* is badly broken

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55533

James Forrester  changed:

   What|Removed |Added

 Status|PATCH_TO_REVIEW |ASSIGNED

--- Comment #3 from James Forrester  ---
Patch to disable SyntaxHighlight is now merged, so this problem will be
suppressed with the production push tomorrow morning; restoring to "ASSIGNED".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 51932] Pages with chess diagrams seem to have their layout messed up in certain cases

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=51932

James Forrester  changed:

   What|Removed |Added

   See Also|https://bugzilla.wikimedia. |
   |org/show_bug.cgi?id=23401   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 23401] adding extension to wikipedia to allow display of chess games

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=23401

James Forrester  changed:

   What|Removed |Added

 CC||jforres...@wikimedia.org
   See Also|https://bugzilla.wikimedia. |
   |org/show_bug.cgi?id=51932   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55535] Add icon support for mediawiki.ui buttons

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55535

Sam Reed (reedy)  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55534] Add mediawiki.ui dialogs

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55534

Sam Reed (reedy)  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55536] Give Bugzilla's "Save Changes" button some style.

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55536

Sam Reed (reedy)  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55541] Segfault when getting EXIF data of some tif images

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55541

--- Comment #7 from Tim Starling  ---
Can you give a link to the TIFF file so that I can reproduce this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55541] Segfault when getting EXIF data of some tif images

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55541

Sam Reed (reedy)  changed:

   What|Removed |Added

 Blocks||48205

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 48205] Server-side upload of large number of files to Commons

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=48205

Sam Reed (reedy)  changed:

   What|Removed |Added

 Depends on||55541

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54716] Button on MWOAuthManageMyGrants/manage should be text instead

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=54716

--- Comment #7 from MZMcBride  ---
Created attachment 13467
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=13467&action=edit
Screenshot of [[mw:Special:MWOAuthManageMyGrants/manage/34]]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54716] Button on MWOAuthManageMyGrants/manage should be text instead

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=54716

--- Comment #6 from MZMcBride  ---
I'm looking at
 and
the two grey buttons side by side aren't great. I'll upload a screenshot in a
moment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 40926] HipHop/HHVM issues (tracking)

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=40926

Chad H.  changed:

   What|Removed |Added

 Depends on||55543

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55543] New: Upload test for file with no extension failing under hhvm

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55543

   Web browser: ---
Bug ID: 55543
   Summary: Upload test for file with no extension failing under
hhvm
   Product: MediaWiki
   Version: 1.22-git
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: Uploading
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: innocentkil...@gmail.com
CC: bawolff...@gmail.com, bryan.tongm...@gmail.com,
fflo...@wikimedia.org, mtrac...@member.fsf.org
Blocks: 40926
Classification: Unclassified
   Mobile Platform: ---

We're getting FILETYPE_BADTYPE when we should be getting FILETYPE_MISSING.

$ hhvm phpunit.php includes/upload/UploadBaseTest.php
PHPUnit 3.7.23 by Sebastian Bergmann.

Configuration read from /www/mediawiki/core/tests/phpunit/suite.xml

.F..

Time: 194 ms, Memory: 11.67Mb

There was 1 failure:

1) UploadBaseTest::testTitleValidation with data set #5 ('A', NULL, 8, 'upload
title without extension')
upload title without extension code
Failed asserting that 9 matches expected 8.

/www/mediawiki/core/tests/phpunit/includes/upload/UploadBaseTest.php:38
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55541] Segfault when getting EXIF data of some tif images

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55541

Sam Reed (reedy)  changed:

   What|Removed |Added

   Keywords||upstream
   Priority|Unprioritized   |Low

--- Comment #6 from Sam Reed (reedy)  ---
Very much outside MediaWiki. Need to (I will) file an upstream bug with PHP for
this issue

 If you can't you should file a bug about it
 Or just stuff it in a github public repo with a test script to
reproduce.
 I think `$data = exif_read_data( $this->file, 0, true );` in your
minimum test case if I understand the trace Faidon gave.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 46428] mwscript.php/mctest.php does not know about memcache in both datacenters

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=46428

Tim Starling  changed:

   What|Removed |Added

 CC||tstarl...@wikimedia.org

--- Comment #19 from Tim Starling  ---
I don't understand why you would want a concept of per-DC memcached clusters in
MediaWiki, when there is no replication. We're not planning on solving the
split-brain problem at the application level. As far as I'm concerned, every
actual bug was fixed in I5d64cec2 and Ib327d713 and so this can be closed.

(In reply to comment #9)
> I think that in a multidatacenter environment (which even if we don't really
> have it, we should strive to have all our code pretending that we do), the
> location where you run a script should be unimportant (since we all know
> someone will mess up somehow) and the script should either have the knowledge
> of the location or prompt for the input of location (or just clear from all
> locations).

Since I5d64cec2/Ib327d713, it doesn't matter where you run a script. So this is
fixed, isn't it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55532] BitmapMetadataHandlerTest::testIPTCDatesInvalid() failing under hhvm

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55532

--- Comment #1 from Chad H.  ---
I'm pretty sure this be an +upstream bug, but the ext/exif code is kind of hard
to follow :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 20097] TitleKey should drop special characters, like diacritics

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=20097

Rbirmann <_bugzi...@ricardobirmann.com> changed:

   What|Removed |Added

 CC||_bugzi...@ricardobirmann.co
   ||m

--- Comment #3 from Rbirmann <_bugzi...@ricardobirmann.com> ---
Some discussion regarding this issue here: 

https://www.mediawiki.org/wiki/Thread:Extension_talk:TitleKey/Accent_and_special_characters_independent_search

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55534] Add mediawiki.ui dialogs

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55534

--- Comment #9 from Matthew Flaschen  ---
(In reply to comment #8)
> As for centring, the iframes don't particularly help there but I do know that
> in VE we have a satisfying way of centring the dialog
> vertically/horizontally.
> 
> The centring of dialogs is generally a solved problem in web development
> afaik.
> There's different ways to go about it, but there's at least 1 commonly used
> way that works.

I have a working solution, but it doesn't work in IE 6 or 7 (bug 55487).  If
you have a recommendation, I'd be glad to look at it.

> On the subject, oo.ui dialogs do have an interesting aspect that is worth
> mentioning. They don't require a fixed width/height. CSS min-height /
> max-height is dynamically honoured (it can shrink/grow, and overflow:auto
> will show scrollbars if needed), and browser resizing as well.

Unfortunately, that's an example of a compatibility issue which we're going to
have to grapple with.  IE6 apparently can't support both min-height and
max-height on the same element
(http://stackoverflow.com/questions/1467664/how-to-implement-cross-browser-min-height-and-max-height-at-the-same-time)

> As for the CSS, that's going to be the area that'll need most manual testing
> and fixing. I think most browser bugs we account for date back pretty far (we
> tend to IE8, Opera 12 and recent Firefox/Chrome).
> 
> Though IE6, IE7 and Firefox 4 (which would be the main browsers missing
> between
> VE requirements and MW requirements) do have a ton of specific quirks, afaik
> those are all bugs that can be worked around, not actual missing CSS features
> that would be blockers (aside from CSS3 enhancements, which will be absent
> but
> those degrade gracefully).

Yeah, I primarily meant CSS and rendering.  I agree some have relatively simple
workarounds.  However, others are a bit more complicated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 30876] WikiHiero: rendering bug in Opera when embedded into some infoboxes

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=30876

Max Semenik  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #4 from Max Semenik  ---
RIP Presto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 28481] hhvm: ext/mysql throws needless notices on query failures

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=28481

Chad H.  changed:

   What|Removed |Added

   Keywords||upstream

--- Comment #7 from Chad H.  ---
(In reply to comment #1)
> You should file it upstream if it can't be disabled. MediaWiki has its own
> logging system for query errors we actually care about, we don't need
> HipHop's.

I should've listened to Tim a long time ago.

Should be handled in master soon:
https://github.com/facebook/hiphop-php/pull/1140

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 28419] Replace MD5 password hashing with WHIRLPOOL

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=28419

--- Comment #87 from Daniel Friesen  ---
(In reply to comment #86)
> Daniel, do you mind if I put a sqashed version of your branch, rebased on
> master, into gerrit? I'd like to have a couple of people comment on it.

Sure. Though you should probably -2 it, there's no PasswordLayerType yet.

Also a properly revived branch is going to need to update
$wgRedactedFunctionArguments.

Btw, here's the encryption based pepper I was playing with to figure out what I
need for a password layer type.
https://github.com/dantman/mediawiki-core/commit/d73f956076c2a169c47de497b70782991ef46503

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55541] Segfault when getting EXIF data of some tif images

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55541

--- Comment #5 from Sam Reed (reedy)  ---
Amusingly, it completes under valgrind

root@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core# valgrind php
maintenance/importImages.php --comment-ext=txt --user=Reedy /tmp/uploads
==22771== Memcheck, a memory error detector
==22771== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al.
==22771== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info
==22771== Command: php maintenance/importImages.php --comment-ext=txt
--user=Reedy /tmp/uploads
==22771==
Import Images

Importing
Pressbilder_till_Ars_11,_reprofotografi_av_bild_från_resealbum_-_Hallwylska_museet_-_87785.tif...

done.

Found: 1
Added: 1
==22771==
==22771== HEAP SUMMARY:
==22771== in use at exit: 148,542 bytes in 1,646 blocks
==22771==   total heap usage: 421,034 allocs, 419,388 frees, 122,387,624 bytes
allocated
==22771==
==22771== LEAK SUMMARY:
==22771==definitely lost: 410 bytes in 7 blocks
==22771==indirectly lost: 3,640 bytes in 5 blocks
==22771==  possibly lost: 0 bytes in 0 blocks
==22771==still reachable: 144,492 bytes in 1,634 blocks
==22771== suppressed: 0 bytes in 0 blocks
==22771== Rerun with --leak-check=full to see details of leaked memory
==22771==
==22771== For counts of detected and suppressed errors, rerun with: -v
==22771== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 2 from 2)
root@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core#
root@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core# php
maintenance/importImages.php --comment-ext=txt --user=Reedy /tmp/uploads
Import Images

Pressbilder_till_Ars_11,_reprofotografi_av_bild_från_resealbum_-_Hallwylska_museet_-_87785.tif
exists, skipping

Found: 1
Skipped: 1
root@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core# php
maintenance/importImages.php --comment-ext=txt --user=Reedy /tmp/uploads
--overwrite
Import Images

Pressbilder_till_Ars_11,_reprofotografi_av_bild_från_resealbum_-_Hallwylska_museet_-_87785.tif
exists, overwriting...Segmentation fault
root@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core#

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55541] Segfault when getting EXIF data of some tif images

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55541

--- Comment #4 from Sam Reed (reedy)  ---
Slightly different with PagedTiffHandler installed

php_ifd_get16u (value=0xfa152920, motorola_intel=0) at
/build/buildd/php5-5.4.9/ext/exif/exif.c:1095
1095/build/buildd/php5-5.4.9/ext/exif/exif.c: No such file or directory.
(gdb) zbacktrace
[0x77fa8d00]
exif_read_data("/tmp/uploads/Pressbilder_till_Ars_11,_reprofotografi_av_bild_fr\303\3777645n_resealbum_-_Hallwylska_museet_-_87785.tif",
"0", true) /var/www/wiki/mediawiki/core/includes/media/Exif.php:302
[0x77fa88b8]
Exif->__construct("/tmp/uploads/Pressbilder_till_Ars_11,_reprofotografi_av_bild_fr\303\3777645n_resealbum_-_Hallwylska_museet_-_87785.tif",
"LE") /var/www/wiki/mediawiki/core/includes/media/BitmapMetadataHandler.php:268
[0x77fa7428]
BitmapMetadataHandler::Tiff("/tmp/uploads/Pressbilder_till_Ars_11,_reprofotografi_av_bild_fr\303\3777645n_resealbum_-_Hallwylska_museet_-_87785.tif")
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler.image.php:174
[0x77fa7190] PagedTiffImage->retrieveMetaData()
/var/www/wiki/mediawiki/extensions/PagedTiffHandler/PagedTiffHandler_body.php:514
[0x77fa6628] PagedTiffHandler->getMetadata(object[0x143bd50],
"/tmp/uploads/Pressbilder_till_Ars_11,_reprofotografi_av_bild_fr\303\3777645n_resealbum_-_Hallwylska_museet_-_87785.tif")
/var/www/wiki/mediawiki/core/includes/filebackend/FSFile.php:136
[0x77fa6498] FSFile->getProps(true)
/var/www/wiki/mediawiki/core/includes/filebackend/FSFile.php:241
[0x77fa4060]
FSFile::getPropsFromPath("/tmp/uploads/Pressbilder_till_Ars_11,_reprofotografi_av_bild_fr\303\3777645n_resealbum_-_Hallwylska_museet_-_87785.tif")
/var/www/wiki/mediawiki/core/maintenance/importImages.php:231

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55542] Possible double-counting of 'hide' logging

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55542

--- Comment #1 from Steven Walling  ---
This comes from examining the counts of event actions on the last tour step,
for tour "firstedit". Like so: 

SELECT COUNT(*),event_action FROM GuidedTour_5222838 WHERE event_tourname =
"firstedit" AND wiki = "enwiki" AND timestamp >= 2013100900 AND event_step
= 4 GROUP BY event_action;

This produces the following results:

175button-click
285complete
442hide
286impression

Some other steps in the tour also produce this discrepancy, for example the
step 2 results:

173button-click
345hide
242impression

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55542] New: Possible double-counting of 'hide' logging

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55542

   Web browser: ---
Bug ID: 55542
   Summary: Possible double-counting of 'hide' logging
   Product: MediaWiki extensions
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: GuidedTour
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: mflasc...@wikimedia.org
CC: mflasc...@wikimedia.org, swall...@wikimedia.org,
tc...@wikimedia.org
Classification: Unclassified
   Mobile Platform: ---

There seems to be an excessive number of 'hide' events on the firstedit tour. 
It's possible there's somehow double-counting.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55534] Add mediawiki.ui dialogs

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55534

--- Comment #8 from Krinkle  ---
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #4)
> > oo.ui is about two years ahead of mw.ui in development time, but we built
> > things as we needed them in VisualEditor so there might be certain kinds of
> > widgets that mw.ui has that aren't in oo.ui yet. Things like dialog support,
> > though, have existed in oo.ui for a long time. oo.ui also fully supports
> > running all of its widgets in iframes (which is how dialogs are done as
> > well).
> 
> I don't really know much about the advantages of iframes for this kind of
> thing.  However, I did have some issues (e.g. full horizontal and modal
> centering), so if it solves that, that would be nice.


iframes are mostly to allow text selection, focus and other complicated and
cross-browser unstable states to remain while the dialog is up.

As for centring, the iframes don't particularly help there but I do know that
in VE we have a satisfying way of centring the dialog vertically/horizontally.

The centring of dialogs is generally a solved problem in web development afaik.
There's different ways to go about it, but there's at least 1 commonly used way
that works.

On the subject, oo.ui dialogs do have an interesting aspect that is worth
mentioning. They don't require a fixed width/height. CSS min-height /
max-height is dynamically honoured (it can shrink/grow, and overflow:auto will
show scrollbars if needed), and browser resizing as well.

(In reply to comment #7)
> 
> We'll be supporting more browsers than VE does, so oo.ui will need to do the
> same if we take that approach.

As far as javascript code itself, we currently require the browser to support
most ES5 features (IE8 is missing some ES5 features, but we haven't needed
those yet, and we keep an eye out for those with feature tests).

At this point we only use ES5 features that have established polyfills
(Array#filter, Function#bind, Object#create, String#trim, JSON.stringify etc.,
full list at[1]). We don't polyfill them right now because we don't have to,
but we can easily bring in an es5shim if we have to.

As for the CSS, that's going to be the area that'll need most manual testing
and fixing. I think most browser bugs we account for date back pretty far (we
tend to IE8, Opera 12 and recent Firefox/Chrome).

Though IE6, IE7 and Firefox 4 (which would be the main browsers missing between
VE requirements and MW requirements) do have a ton of specific quirks, afaik
those are all bugs that can be worked around, not actual missing CSS features
that would be blockers (aside from CSS3 enhancements, which will be absent but
those degrade gracefully).


[1]
https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/4da68b71d11f15b10e2e1f418025b438954e7da5/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js#L68-L85

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55536] Give Bugzilla's "Save Changes" button some style.

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55536

Andre Klapper  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal

--- Comment #3 from Andre Klapper  ---
If you would like to turn this into a Gerrit patch, the code is at
https://git.wikimedia.org/tree/wikimedia%2Fbugzilla%2Fmodifications.git/HEAD/skins%2Fcontrib%2FWikimedia

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 28419] Replace MD5 password hashing with WHIRLPOOL

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=28419

--- Comment #86 from Chris Steipp  ---
Daniel, do you mind if I put a sqashed version of your branch, rebased on
master, into gerrit? I'd like to have a couple of people comment on it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 20234] Clickable tabs overlap for small screen resolutions

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=20234

Andre Klapper  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=54919

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54919] Tabs (Read / View Source / Search) wrap to next line and cover content if screen width < ~700px

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=54919

Andre Klapper  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=20234

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55541] Segfault when getting EXIF data of some tif images

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55541

--- Comment #3 from Sam Reed (reedy)  ---
root@ubuntu64-web-esxi:/tmp# gdb php
GNU gdb (GDB) 7.5.91.20130417-cvs-ubuntu
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
For bug reporting instructions, please see:
...
Reading symbols from /usr/bin/php5...Reading symbols from
/usr/lib/debug/usr/bin/php5...^[[Adone.
done.
(gdb)
(gdb) directory /tmp/php5-5.4.9/
Source directories searched: /tmp/php5-5.4.9:$cdir:$cwd
(gdb) source /tmp/php5-5.4.9/.gdbinit
Redefine command "set_ts"? (y or n) [answered Y; input not from terminal]
Redefine command "executor_globals"? (y or n) [answered Y; input not from
terminal]
Redefine command "print_cvs"? (y or n) [answered Y; input not from terminal]
Redefine command "dump_bt"? (y or n) [answered Y; input not from terminal]
Redefine command "printzv"? (y or n) [answered Y; input not from terminal]
Redefine command "printzv_contents"? (y or n) [answered Y; input not from
terminal]
Redefine command "printzv"? (y or n) [answered Y; input not from terminal]
Redefine command "print_const_table"? (y or n) [answered Y; input not from
terminal]
Redefine command "print_const_table"? (y or n) [answered Y; input not from
terminal]
Redefine command "print_ht"? (y or n) [answered Y; input not from terminal]
Redefine command "print_ht"? (y or n) [answered Y; input not from terminal]
Redefine command "print_htptr"? (y or n) [answered Y; input not from terminal]
Redefine command "print_htstr"? (y or n) [answered Y; input not from terminal]
Redefine command "print_ft"? (y or n) [answered Y; input not from terminal]
Redefine command "print_ft"? (y or n) [answered Y; input not from terminal]
Redefine command "print_inh_class"? (y or n) [answered Y; input not from
terminal]
Redefine command "print_inh_iface"? (y or n) [answered Y; input not from
terminal]
Redefine command "print_inh"? (y or n) [answered Y; input not from terminal]
Redefine command "print_pi"? (y or n) [answered Y; input not from terminal]
Redefine command "print_str"? (y or n) [answered Y; input not from
terminal]
Redefine command "printzn"? (y or n) [answered Y; input not from terminal]
Redefine command "printzops"? (y or n) [answered Y; input not from terminal]
Redefine command "zbacktrace"? (y or n) [answered Y; input not from terminal]
Redefine command "zmemcheck"? (y or n) [answered Y; input not from terminal]
(gdb) run /var/www/wiki/mediawiki/core/maintenance/importImages.php
--comment-ext=txt --user=Reedy /tmp/uploads --overwrite
Starting program: /usr/bin/php5
/var/www/wiki/mediawiki/core/maintenance/importImages.php --comment-ext=txt
--user=Reedy /tmp/uploads --overwrite
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
warning: the debug information found in
"/usr/lib/debug//usr/lib/php5/20100525/mysql.so" does not match
"/usr/lib/php5/20100525/mysql.so" (CRC mismatch).

warning: the debug information found in
"/usr/lib/debug/usr/lib/php5/20100525/mysql.so" does not match
"/usr/lib/php5/20100525/mysql.so" (CRC mismatch).

warning: the debug information found in
"/usr/lib/debug//usr/lib/php5/20100525/mysqli.so" does not match
"/usr/lib/php5/20100525/mysqli.so" (CRC mismatch).

warning: the debug information found in
"/usr/lib/debug/usr/lib/php5/20100525/mysqli.so" does not match
"/usr/lib/php5/20100525/mysqli.so" (CRC mismatch).

warning: the debug information found in
"/usr/lib/debug//usr/lib/php5/20100525/pdo_mysql.so" does not match
"/usr/lib/php5/20100525/pdo_mysql.so" (CRC mismatch).

warning: the debug information found in
"/usr/lib/debug/usr/lib/php5/20100525/pdo_mysql.so" does not match
"/usr/lib/php5/20100525/pdo_mysql.so" (CRC mismatch).

[New Thread 0x7fffe975b700 (LWP 23078)]
[Thread 0x7fffe975b700 (LWP 23078) exited]
Import Images

Pressbilder_till_Ars_11,_reprofotografi_av_bild_från_resealbum_-_Hallwylska_museet_-_87785.tif
exists, overwriting...
Program received signal SIGSEGV, Segmentation fault.
php_ifd_get16u (value=0xfa3fb318, motorola_intel=0) at
/build/buildd/php5-5.4.9/ext/exif/exif.c:1095
1095/build/buildd/php5-5.4.9/ext/exif/exif.c: No such file or directory.
(gdb) zbacktrace
[0x77fa7928]
exif_read_data("/tmp/uploads/Pressbilder_till_Ars_11,_reprofotografi_av_bild_fr\303\3777645n_resealbum_-_Hallwylska_museet_-_87785.tif",
"0", true) /var/www/wiki/mediawiki/core/includes/media/Exif.php:302
[0x77fa74e0]
Exif->__construct("/tmp/uploads/Pressbilder_till_Ars_11,_reprofotografi_av_bild_fr\303\3777645n_resealbum_-_Hallwylska_museet_-_87785.tif",
"LE") /var/www/wiki/med

[Bug 55499] Support some form of "AutoSettings.php" like our "mw-config/overrides.php" to hook in after DefaultSettings but before LocalSettings.

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55499

Andre Klapper  changed:

   What|Removed |Added

   Priority|Unprioritized   |Low
Version|unspecified |1.22-git

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55532] BitmapMetadataHandlerTest::testIPTCDatesInvalid() failing under hhvm

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55532

Andre Klapper  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55349] Version doesn't exists if author of revision is hidden (FlaggedRevs conflicts with revision deletion)

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55349

Andre Klapper  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal
 CC||aschulz4...@gmail.com
  Component|Patrolling  |Revision deletion
Summary|Version doesn't exists if   |Version doesn't exists if
   |author of revision is   |author of revision is
   |hidden  |hidden (FlaggedRevs
   ||conflicts with revision
   ||deletion)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55473] [REGRESSION] License select fallback broken at Commons

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55473

--- Comment #3 from Andre Klapper  ---
(In reply to comment #2)
> No need to do so. Unfortunately there is no means connecting your Wikimedia
> Commons/Wikipedia account with Bugzilla

For the records, that's bug 14487 and we'll take a look in the next months.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55528] Please collect statistics for the Vietnamese Wikivoyage

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55528

Andre Klapper  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55535] Add icon support for mediawiki.ui buttons

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55535

Andre Klapper  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55523] Add hard drop shadow to echo badge label to increase readability

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55523

Andre Klapper  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55534] Add mediawiki.ui dialogs

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55534

Andre Klapper  changed:

   What|Removed |Added

   Priority|Unprioritized   |Normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55541] Segfault when getting EXIF data of some tif images

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55541

--- Comment #2 from Sam Reed (reedy)  ---
https://github.com/php/php-src/blob/PHP-5.4.9/ext/exif/exif.c#L1095


(gdb) bt
#0  php_ifd_get16u (value=0xf9e7b278, motorola_intel=0) at
/build/buildd/php5-5.4.9/ext/exif/exif.c:1095
#1  0x0049d5fe in exif_iif_add_value (image_info=0x7fff9d30,
section_index=0, name=0x0, tag=-102256004, format=0, length=3,
value=0x49d7cf , motorola_intel=-102256008) at
/build/buildd/php5-5.4.9/ext/exif/exif.c:1753
#2  0x0049d7cf in exif_process_IFD_TAG (ImageInfo=0x7fff9d30,
dir_entry=0x0, offset_base=0x22fc ,
IFDlength=13927872,
displacement=4192710974, section_index=764, ReadNextIFD=4846524,
tag_table=0x65c2d4 ) at
/build/buildd/php5-5.4.9/ext/exif/exif.c:1803
#3  0x0049f3bc in exif_process_IFD_in_TIFF (ImageInfo=0x7fff9d30,
dir_offset=6771448, section_index=0) at
/build/buildd/php5-5.4.9/ext/exif/exif.c:3703
#4  0x0049f863 in exif_read_file.constprop.13
(ImageInfo=0x7fff9d30,
FileName=0x7fffe89e3138
"/tmp/uploads/Pressbilder_till_Ars_11,_reprofotografi_av_bild_från_resealbum_-_Hallwylska_museet_-_87785.tif",
read_thumbnail=0)
at /build/buildd/php5-5.4.9/ext/exif/exif.c:3797
#5  0x004a01a9 in zif_exif_read_data (ht=-102256008,
return_value=0x7fff, return_value_ptr=0x778c04, this_ptr=0x1,
return_value_used=23832424)
at /build/buildd/php5-5.4.9/ext/exif/exif.c:3959
#6  0x74dab5de in xdebug_execute_internal
(current_execute_data=0x77fa7928, return_value_used=1) at
/build/buildd/xdebug-2.2.1/build-php5/xdebug.c:1483
#7  0x0075f17e in zend_do_fcall_common_helper_SPEC
(execute_data=0x77fa7928) at
/build/buildd/php5-5.4.9/Zend/zend_vm_execute.h:644
#8  0x00718c17 in execute (op_array=0x16a5098) at
/build/buildd/php5-5.4.9/Zend/zend_vm_execute.h:410
#9  0x74dab168 in xdebug_execute (op_array=0x16a5098) at
/build/buildd/xdebug-2.2.1/build-php5/xdebug.c:1391
#10 0x0075f499 in zend_do_fcall_common_helper_SPEC
(execute_data=0x77fa74e0) at
/build/buildd/php5-5.4.9/Zend/zend_vm_execute.h:669
#11 0x00718c17 in execute (op_array=0x169e990) at
/build/buildd/php5-5.4.9/Zend/zend_vm_execute.h:410
#12 0x74dab168 in xdebug_execute (op_array=0x169e990) at
/build/buildd/xdebug-2.2.1/build-php5/xdebug.c:1391
#13 0x0075f499 in zend_do_fcall_common_helper_SPEC
(execute_data=0x77fa7190) at
/build/buildd/php5-5.4.9/Zend/zend_vm_execute.h:669
#14 0x00718c17 in execute (op_array=0x167dbb0) at
/build/buildd/php5-5.4.9/Zend/zend_vm_execute.h:410
#15 0x74dab168 in xdebug_execute (op_array=0x167dbb0) at
/build/buildd/xdebug-2.2.1/build-php5/xdebug.c:1391
#16 0x0075f499 in zend_do_fcall_common_helper_SPEC
(execute_data=0x77fa6628) at
/build/buildd/php5-5.4.9/Zend/zend_vm_execute.h:669
#17 0x00718c17 in execute (op_array=0x161d588) at
/build/buildd/php5-5.4.9/Zend/zend_vm_execute.h:410
#18 0x74dab168 in xdebug_execute (op_array=0x161d588) at
/build/buildd/xdebug-2.2.1/build-php5/xdebug.c:1391
#19 0x0075f499 in zend_do_fcall_common_helper_SPEC
(execute_data=0x77fa6498) at
/build/buildd/php5-5.4.9/Zend/zend_vm_execute.h:669
#20 0x00718c17 in execute (op_array=0x1621b78) at
/build/buildd/php5-5.4.9/Zend/zend_vm_execute.h:410
#21 0x74dab168 in xdebug_execute (op_array=0x1621b78) at
/build/buildd/xdebug-2.2.1/build-php5/xdebug.c:1391
#22 0x0075f499 in zend_do_fcall_common_helper_SPEC
(execute_data=0x77fa4060) at
/build/buildd/php5-5.4.9/Zend/zend_vm_execute.h:669
#23 0x00718c17 in execute (op_array=0x77fd78f8) at
/build/buildd/php5-5.4.9/Zend/zend_vm_execute.h:410
#24 0x74dab168 in xdebug_execute (op_array=0x77fd78f8) at
/build/buildd/xdebug-2.2.1/build-php5/xdebug.c:1391
#25 0x006b8a8c in zend_execute_scripts (type=-134383448,
retval=0x30008, file_count=32767) at
/build/buildd/php5-5.4.9/Zend/zend.c:1309
#26 0x00658733 in php_execute_script (primary_file=0x7fff9d30) at
/build/buildd/php5-5.4.9/main/main.c:2482
#27 0x00761943 in do_cli (argc=0, argv=0x7fffe874) at
/build/buildd/php5-5.4.9/sapi/cli/php_cli.c:988
#28 0x0042c8d0 in main (argc=32767, argv=0xdfd210) at
/build/buildd/php5-5.4.9/sapi/cli/php_cli.c:1364

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 53968] Serialize HTML DOM according to polyglot markup spec so that it can be parsed with HTML and XML parsers

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=53968

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 53968] Serialize HTML DOM according to polyglot markup spec so that it can be parsed with HTML and XML parsers

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=53968

--- Comment #2 from Gerrit Notification Bot  ---
Change 88904 had a related patch set uploaded by GWicke:
Bug 53968: Add XMLSerializer and use it to produce XHTML

https://gerrit.wikimedia.org/r/88904

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55541] Segfault when getting EXIF data of some tif images

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55541

--- Comment #1 from Sam Reed (reedy)  ---
Also noting it's an issue in multiple versions of php:

PHP 5.3.10-1ubuntu3.6+wmf1 with Suhosin-Patch (cli) (built: May 15 2013
23:19:18)
PHP 5.4.9-4ubuntu2.3 (cli) (built: Sep  4 2013 19:32:25)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 23401] adding extension to wikipedia to allow display of chess games

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=23401

John Mark Vandenberg  changed:

   What|Removed |Added

 CC||jay...@gmail.com
   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=51932

--- Comment #3 from John Mark Vandenberg  ---
The code has moved to https://sourceforge.net/projects/mwec/

And the documentation now exists at

http://code.google.com/p/pgn4web/wiki/User_Notes_mediawiki

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 51932] Pages with chess diagrams seem to have their layout messed up in certain cases

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=51932

John Mark Vandenberg  changed:

   What|Removed |Added

   See Also||https://bugzilla.wikimedia.
   ||org/show_bug.cgi?id=23401

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 53687] LinksDeletionUpdate skipped, causing revisions to disappear on undelete

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=53687

--- Comment #21 from Gerrit Notification Bot  ---
Change 88761 merged by jenkins-bot:
Fixed trx isolation bug that could cause text not to be found

https://gerrit.wikimedia.org/r/88761

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55514] Claim guid case difference in ChangeOpClaim means duplicate claims are created when editing

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55514

--- Comment #4 from Andre Klapper  ---
Patch has been merged in master (and I wonder why the Gerrit bot did not update
this ticket). 

Addshore: Any reason you set the Version field from "master" to "REL1_21
branch"?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55541] New: Segfault when getting EXIF data of some tif images

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55541

   Web browser: ---
Bug ID: 55541
   Summary: Segfault when getting EXIF data of some tif images
   Product: MediaWiki
   Version: 1.22-git
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: File management
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: s...@reedyboy.net
CC: bawolff...@gmail.com, bryan.tongm...@gmail.com,
fflo...@wikimedia.org, mtrac...@member.fsf.org
Classification: Unclassified
   Mobile Platform: ---

reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core$ php
maintenance/importImages.php --comment-ext=txt --user=Reedy /tmp/uploads
--overwrite
Import Images

Pressbilder_till_Ars_11,_reprofotografi_av_bild_från_resealbum_-_Hallwylska_museet_-_87785.tif
exists, overwriting...Segmentation fault
reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core$


Initial stuff from gdb

Import Images

Pressbilder_till_Ars_11,_reprofotografi_av_bild_från_resealbum_-_Hallwylska_museet_-_87785.tif
exists, overwriting...
Program received signal SIGSEGV, Segmentation fault.
php_ifd_get16u (value=0xf9f44320, motorola_intel=0) at
/build/buildd/php5-5.4.9/ext/exif/exif.c:1095
1095/build/buildd/php5-5.4.9/ext/exif/exif.c: No such file or directory.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55535] Add icon support for mediawiki.ui buttons

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55535

--- Comment #6 from Jared Zimmerman (WMF)  ---
Sorry if i was unclear, just questioning whether the help text need to be IN
the button

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55535] Add icon support for mediawiki.ui buttons

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55535

--- Comment #5 from Steven Walling  ---
(In reply to comment #4)
> If this is the only place this is used I would ask the PM on the feature to
> decide if its absolutely required, as you mentioned its not used anywhere
> else.
> I can certainly see the need for a CTA button with image, i'm not questioning
> that. but the multi-line button seems like it might be either so specialized
> that it doesn't belong in Agora Controls or it isn't the right design to
> begin
> with if we want to drive consistency. 
> 
> I'm going to start a page on wiki that starts to cover what control types we
> have and add a place for requests. eventually we can turn this into the
> living
> spec that is our end goal

We'll have hard data in about a week, but so far usability testing has strongly
suggested that the second line explanation on the CTA is very useful for users.
One person even suggested they probably would not have accepted the CTA without
the additional assurance that help would be provided.[1]

1.
https://www.mediawiki.org/wiki/Onboarding_new_Wikipedians/user_testing#Testing_scenario_four

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55534] Add mediawiki.ui dialogs

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55534

--- Comment #7 from Matthew Flaschen  ---
(In reply to comment #6)
> (In reply to comment #4)
> > Are you planning to put oo.ui in core?  If so, are you going to merge it 
> > with
> > mediawiki.ui?
> oo.ui is going to be a standalone library, but we're planning for MW core to
> depend on it and bundle it, same as with e.g. jQuery.

Makes sense.

> I personally would like to make mw.ui an extension of oo.ui, making
> MW-specific things in mw.ui extensions of generic things in oo.ui, and moving 
> any generic functionality from mw.ui into oo.ui if oo.ui doesn't already have 
> it.

That seems reasonable, though it might take some practice drawing that line.

> oo.ui is about two years ahead of mw.ui in development time, but we built
> things as we needed them in VisualEditor so there might be certain kinds of
> widgets that mw.ui has that aren't in oo.ui yet. Things like dialog support,
> though, have existed in oo.ui for a long time. oo.ui also fully supports
> running all of its widgets in iframes (which is how dialogs are done as
> well).

I don't really know much about the advantages of iframes for this kind of
thing.  However, I did have some issues (e.g. full horizontal and modal
centering), so if it solves that, that would be nice.

We'll be supporting more browsers than VE does, so oo.ui will need to do the
same if we take that approach.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55535] Add icon support for mediawiki.ui buttons

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55535

--- Comment #4 from Jared Zimmerman (WMF)  ---
If this is the only place this is used I would ask the PM on the feature to
decide if its absolutely required, as you mentioned its not used anywhere else.
I can certainly see the need for a CTA button with image, i'm not questioning
that. but the multi-line button seems like it might be either so specialized
that it doesn't belong in Agora Controls or it isn't the right design to begin
with if we want to drive consistency. 

I'm going to start a page on wiki that starts to cover what control types we
have and add a place for requests. eventually we can turn this into the living
spec that is our end goal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55453] VisualEditor: Bug in Converter throws "Uncaught NotFoundError: An attempt was made to reference a Node in a context where it does not exist."

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55453

--- Comment #8 from Gerrit Notification Bot  ---
Change 88901 merged by jenkins-bot:
Remove SyntaxHighlight from the experimental set

https://gerrit.wikimedia.org/r/88901

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55533] VisualEditor: MWSyntaxHighlight* is badly broken

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55533

--- Comment #2 from Gerrit Notification Bot  ---
Change 88901 merged by jenkins-bot:
Remove SyntaxHighlight from the experimental set

https://gerrit.wikimedia.org/r/88901

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55529] geowiki counts edits on any page in the main namespace, not just on countable ones

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55529

--- Comment #4 from Dario Taraborelli  ---
We do have a concept of a "content namespace" that varies across wikis.

http://www.mediawiki.org/wiki/Analytics/Metric_definitions#Content_namespaces

My opinion is that both "countable pages" and "content namespaces" are
MediaWiki artifacts that we cannot and shouldn't include in our KPI definitions
going forward.

1) They make historical analysis pointless (as individual communities can
change these definitions over time)
2) They make cross-project comparisons pointless (different projects use
different definitions of "countable" and "content")
3) They make feature-level -> project-level projections impossible

I recommend that: 
• we start using a stricter definition of active limited to ns0 and including
all pages, not just countable ones.
• we discuss on an ad-hoc basis how to accommodate special projects like
Commons or Wikidata
• we re-evaluate the pros and cons of this approach after a few months

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55540] New: Broken link creation workflow

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55540

   Web browser: ---
Bug ID: 55540
   Summary: Broken link creation workflow
   Product: VisualEditor
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: Data Model
  Assignee: esand...@wikimedia.org
  Reporter: jrob...@wikimedia.org
CC: jforres...@wikimedia.org, roan.katt...@gmail.com,
tpars...@wikimedia.org
Classification: Unclassified
   Mobile Platform: ---

I'm not sure exactly how I cause this bug but I've seen it twice now.

Works somewhat like this:
Click anywhere in the textarea and ensure there is whitespace before the cursor
and nothing highlighted.

Click the link button
enter text, save it.

The link doesn't get added anywhere and now clicking the link button to create
a new link has no effect.

I get JavaScript exception:
Uncaught Error: Offset could not be translated to a DOM element and offset:
6306

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55533] VisualEditor: MWSyntaxHighlight* is badly broken

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55533

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|NEW |PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55453] VisualEditor: Bug in Converter throws "Uncaught NotFoundError: An attempt was made to reference a Node in a context where it does not exist."

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55453

--- Comment #7 from Gerrit Notification Bot  ---
Change 88901 had a related patch set uploaded by Catrope:
Remove SyntaxHighlight from the experimental set

https://gerrit.wikimedia.org/r/88901

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55453] VisualEditor: Bug in Converter throws "Uncaught NotFoundError: An attempt was made to reference a Node in a context where it does not exist."

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55453

Gerrit Notification Bot  changed:

   What|Removed |Added

 Status|ASSIGNED|PATCH_TO_REVIEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55533] VisualEditor: MWSyntaxHighlight* is badly broken

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55533

--- Comment #1 from Gerrit Notification Bot  ---
Change 88901 had a related patch set uploaded by Catrope:
Remove SyntaxHighlight from the experimental set

https://gerrit.wikimedia.org/r/88901

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55360] FlaggedRevs conflicts with revision deletion

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55360

Nathan Larson  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Nathan Larson  ---


*** This bug has been marked as a duplicate of bug 55349 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55349] Version doesn't exists if author of revision is hidden

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55349

Nathan Larson  changed:

   What|Removed |Added

 CC||nathanlarson3...@gmail.com

--- Comment #4 from Nathan Larson  ---
*** Bug 55360 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55539] New: Make cucumber doesn't work

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55539

   Web browser: ---
Bug ID: 55539
   Summary: Make cucumber doesn't work
   Product: MediaWiki extensions
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: MobileFrontend
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: jrob...@wikimedia.org
CC: aricha...@wikimedia.org, jgon...@wikimedia.org,
jrob...@wikimedia.org, kw...@wikimedia.org,
maxsem.w...@gmail.com, mgro...@wikimedia.org,
mpinc...@wikimedia.org, rkald...@wikimedia.org,
tf...@wikimedia.org
Classification: Unclassified
   Mobile Platform: ---

The Makefile is there to make development easy.
So far it is a pain to run QA tests as for some reason this happens:

keegoing x ~/Sites/w/extensions/MobileFrontend $ make cucumber
Running Cucumber tests...
Please ensure you have a user account for User:Selenium_user
Could not find data_magic-0.15.1 in any of the sources
Run `bundle install` to install missing gems.
make: *** [cucumber] Error 7

Deleting the Gemfile.lock solves this problem but not clear why.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55539] Make cucumber doesn't work

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55539

--- Comment #1 from Bingle  ---
Prioritization and scheduling of this bug is tracked on Mingle card
https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1300

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55538] New: Creating a page via the API doesn't add it to the searchindex table

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55538

   Web browser: ---
Bug ID: 55538
   Summary: Creating a page via the API doesn't add it to the
searchindex table
   Product: MediaWiki
   Version: 1.21.1
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: API
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: tekmo...@neoseeker.com
CC: bjor...@wikimedia.org, bryan.tongm...@gmail.com,
roan.katt...@gmail.com, s...@reedyboy.net
Classification: Unclassified
   Mobile Platform: ---

When creating a page with the API using the params:
action=edit
title=
summary=
text=
token=

The page gets created but no entry for it is added to the searchindex table. If
you go through the front end the proper entry to the page will be added.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 53343] Translated page should be reset when translation unit subpage is deleted

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=53343

Krinkle  changed:

   What|Removed |Added

 CC||krinklem...@gmail.com

--- Comment #1 from Krinkle  ---
On mediawiki.org a user made the following edit:

https://www.mediawiki.org/w/index.php?title=How_to_contribute%2Fbrh&diff=798308&oldid=783714

The edit also triggered a page creation (Translations:How_to_contribute/24/brh)
which has been deleted by an admin.

However the edit remains and is still the last revision, and undo/edit doesn't
work (forwards to the Translate interface), and inside the Translate interface
it still looks like before the vandal edit was made.

https://www.mediawiki.org/w/index.php?title=Special:Translate&group=page-How+to+contribute&action=page&filter=&language=brh

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55537] User profile looks strange when a user has never uploaded an image

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55537

--- Comment #2 from Bingle  ---
Prioritization and scheduling of this bug is tracked on Mingle card
https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1299

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55534] Add mediawiki.ui dialogs

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55534

--- Comment #6 from Roan Kattouw  ---
(In reply to comment #4)
> Are you planning to put oo.ui in core?  If so, are you going to merge it with
> mediawiki.ui?
oo.ui is going to be a standalone library, but we're planning for MW core to
depend on it and bundle it, same as with e.g. jQuery.

I personally would like to make mw.ui an extension of oo.ui, making MW-specific
things in mw.ui extensions of generic things in oo.ui, and moving any generic
functionality from mw.ui into oo.ui if oo.ui doesn't already have it.

oo.ui is about two years ahead of mw.ui in development time, but we built
things as we needed them in VisualEditor so there might be certain kinds of
widgets that mw.ui has that aren't in oo.ui yet. Things like dialog support,
though, have existed in oo.ui for a long time. oo.ui also fully supports
running all of its widgets in iframes (which is how dialogs are done as well).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55537] User profile looks strange when a user has never uploaded an image

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55537

--- Comment #1 from Jon  ---
See
http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:UserProfile/Testken?mobileaction=beta
for example

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55537] New: User profile looks strange when a user has never uploaded an image

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55537

   Web browser: ---
Bug ID: 55537
   Summary: User profile looks strange when a user has never
uploaded an image
   Product: MediaWiki extensions
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: Unprioritized
 Component: MobileFrontend (Beta)
  Assignee: wikibugs-l@lists.wikimedia.org
  Reporter: jrob...@wikimedia.org
CC: jgon...@wikimedia.org, jrob...@wikimedia.org,
kw...@wikimedia.org, maxsem.w...@gmail.com,
mgro...@wikimedia.org, mpinc...@wikimedia.org,
rkald...@wikimedia.org
Classification: Unclassified
   Mobile Platform: ---

When a user has never uploaded an image there is no spacing between

section-end class should be added to the div with class section
section-activity in this situation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55535] Add icon support for mediawiki.ui buttons

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55535

--- Comment #3 from Matthew Flaschen  ---
I think that's open to discussion.  We should also make sure we actually want
this.  I note it's not in the spec.  I realize that spec isn't final, but we
should bear in mind everything we add has a cost in maintenance, and
potentially offers multiple ways to do the same thing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55534] Add mediawiki.ui dialogs

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55534

Matthew Flaschen  changed:

   What|Removed |Added

 Blocks||54360

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 2007] Tracking bug (tracking)

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=2007

Matthew Flaschen  changed:

   What|Removed |Added

 Depends on||54360

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 54360] implement new Agora spec in mediawiki.ui

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=54360

Matthew Flaschen  changed:

   What|Removed |Added

   Keywords||tracking
 Blocks||2007
 Depends on||55534

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

[Bug 55536] Give Bugzilla's "Save Changes" button some style.

2013-10-09 Thread bugzilla-daemon

https://bugzilla.wikimedia.org/show_bug.cgi?id=55536

--- Comment #2 from Daniel Friesen  ---
Created attachment 13466
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=13466&action=edit
Button style with modified mw.ui css

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

1 2 3 4 5 6 >

1 - 100 of 588 matches

Mail list logo